summaryrefslogtreecommitdiffstats
path: root/src/core
Commit message (Collapse)AuthorAgeFilesLines
...
* Advertise correct security levelAllan Sandfeld Jensen2022-04-061-1/+1
| | | | | | | | | | Otherwise it will look like we are still vulnerable to the critical CVEs Change-Id: I205e4b5cb72021f56621772d36a27f9fa5dc340c Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 00e4a2ac3f694b5ec1999af3518f1c550b662057) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove dead ozone codeAllan Sandfeld Jensen2022-03-272-12/+1
| | | | | | | | | This code does nothing now Change-Id: Ic4fca6c89a8ae42a5bb2264eb8d946f878449556 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 453694e2b73f7d5249ce193d068b8e83cdfa7eda) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Find GIO with QtBase 6.2Allan Sandfeld Jensen2022-03-261-1/+4
| | | | | | | | | | GLIB2 doesn't find GIO with Qt 6.2, so try adding a fallback. Task-number: QTBUG-100435 Change-Id: Ic98a7aea07b726dc4f6e76a65669ca92b1916b5c Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit 7c112f5c613cfc8a93ca3d85ccdab7a38b82a3c3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix include guardAllan Sandfeld Jensen2022-03-251-2/+2
| | | | | | | Change-Id: Iedb95f6c7128834a701e4c5549dd0fec44b0ee8f Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit 038c86c6d8c85e0a101b8d2b7fc35a995c8d1d40) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix qrc sources for QWebEngineScriptAllan Sandfeld Jensen2022-03-191-4/+3
| | | | | | | | Fixes: QTBUG-96525 Change-Id: I39d6247c0dd0e55e4fb91b176f34e676eeabbcdd Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit ce2d6a94ce99f8d6f82fbcbf45603f8eb7a92957) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix wrong assumption about focus in/out event deliveryMichal Klocek2022-03-181-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In 2947d79d assumption was made that we never get focus in event for popup reason. Unfortunately this is not true as simply creating window menu and switching between webengineview will trigger the issue. Moreover, focus in and out events with popup reason do not mean change of focus, as in qtbase: if (QWidget *fw = active_window->focusWidget()) { if (fw != QApplication::focusWidget()) { fw->setFocus(Qt::PopupFocusReason) } else { QFocusEvent e(QEvent::FocusIn, Qt::PopupFocusReason); QCoreApplication::sendEvent(fw, &e); } } Therefore it is safe to ignore focus in/out events with popup reason. Note that the fact that ASSERT got not triggered for context menu is due to another race condition issue in qquick event stack delivery. This commit amends 2947d79d8210a7ae4ce2bc02e058628e66011be3. Fixes: QTBUG-101706 Pick-to: dev 6.2 Change-Id: I3e761fe5d8054aed72461eba7981c69755877d1b Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* QWebEngineLoadingInfo: Fix include conventionFriedemann Kleint2022-03-151-1/+1
| | | | | | | | | Amends da019632bfc0227e2d0d0cc676a80a352fc27a62. Change-Id: I22dce54dca802d96aec2f4cca68df0330d10fede Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit d4927a526dfd992ac5ffe053d9e63e8581c2a8eb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Improve glType detectionMichal Klocek2022-03-141-51/+56
| | | | | | | | | | | | | Clean up the glType detection and do not set extra gl related command parameters in case command line arguments have already '--disable-gpu'. Task-number: QTBUG-100713 Change-Id: I5662a8c8fc64b38d483ed8349265f29f7ae0c5e4 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 97c1a232e6dd689b6149b3c9aae000138add755b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add test for blocking of remote contentAllan Sandfeld Jensen2022-03-091-2/+1
| | | | | | | | Task-number: QTBUG-50686 Change-Id: Ie176bece1a44a6df608646e91171d02ceeea7e8f Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit b8603c148c6cd53bdd82d0b712971cfc1b747780) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update documented Chromium versionsAllan Sandfeld Jensen2022-03-081-1/+1
| | | | | | | | Fixes: QTBUG-100911 Change-Id: If669b46634bf31f419a1cf41e24c0ddfdae5aab6 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 697b3777345a2087f31155c550f32aaedefaea0b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Correct documentationAllan Sandfeld Jensen2022-03-071-2/+2
| | | | | | | | | WebEngine was first in 6.2 Change-Id: Id8e6e438e5f4cfd7b28ed8f821f503125033ae62 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit bb3d7e528b27282727aba2de68d8630a24b2856b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update build documentationAllan Sandfeld Jensen2022-03-041-13/+8
| | | | | | | Change-Id: I2c6dffbd8683ed909ff985f672de1914be83422a Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit d706d7ceb91507c71d779463cfc25982acaa36b1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Split accessibility object between Chromium and Qt interfacesAllan Sandfeld Jensen2022-03-044-282/+332
| | | | | | | | | | | They have different life-times and needs to be able to be deleted independently. Fixes: QTBUG-100996 Change-Id: I812381c22699f9408e0c5d3edc489e51040a6491 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 1bdb43a4da6d0bbb36309dc12128c180b4d9c12b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumMichael Brüning2022-03-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 2aad1f40..7dba564e: > Revert "[Backport] CVE-2022-0297: Use after free in Vulkan" > [Backport] CVE-2022-0297: Use after free in Vulkan > [Backport] Security bug 1292537 > [Backport] Security bug 1289394 > [Backport] Security bug 1289384 > [Backport] CVE-2022-0610: Inappropriate implementation in Gamepad API > [Backport] CVE-2022-0609: Use after free in Animation > [Backport] CVE-2022-0608: Integer overflow in Mojo > [Backport] CVE-2022-0607: Use after free in GPU > [Backport] CVE-2022-0606: Use after free in ANGLE > [Backport] CVE-2022-0303: Race in GPU Watchdog > [Backport] CVE-2021-4056: Type Confusion in loader > [Backport] CVE-2022-0466: Inappropriate implementation in Extensions Platform (4/4) > [Backport] CVE-2022-0466: Inappropriate implementation in Extensions Platform (3/4) > [Backport] CVE-2022-0466: Inappropriate implementation in Extensions Platform (2/4) > [Backport] CVE-2022-0466: Inappropriate implementation in Extensions Platform (1/4) > [Backport] CVE-2021-4066: Integer underflow in ANGLE > [Backport] Security bug 1268448 > [Backport] Security bug 1265570 > [Backport] Security bug 1252562 > [Backport] Security bug 1274113 > [Backport] CVE-2022-0470: Out of bounds memory access in V8 > [Backport] CVE-2022-0457: Type Confusion in V8 > [Backport] CVE-2022-0456: Use after free in Web Search > [Backport] CVE-2022-0453: Use after free in Reader Mode > [Backport] CVE-2022-0464: Use after free in Accessibility > [Backport] Security bug 1261415 > [Backport] CVE-2021-4053: Use after free in UI > [Backport] Security bug 1271747 > [Backport] CVE-2022-0468: Use after free in Payments (2/2) > [Backport] CVE-2022-0468: Use after free in Payments (1/2) > [Backport] CVE-2022-0461: Policy bypass in COOP > [Backport] CVE-2022-0460: Use after free in Window Dialog > [Backport] CVE-2022-0459: Use after free in Screen Capture > [Backport] CVE-2022-0306: Heap buffer overflow in PDFium > FIXUP: Keep the close button when "undocked", as we can dock differently > Fix more windows build errors on build without jumbo > FIXUP: Add missing include for Supplement Change-Id: I82671c60c00c940c4943a0df4234ac7286e9c0dd Task-number: QTBUG-101051 Task-number: QTBUG-99099 Task-number: QTBUG-99720 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Check for loaded opengl library in case-insensitive mannerMichal Klocek2022-02-281-1/+1
| | | | | | | | | | | | | | After a14f2d59141e in qtbase library returned by GetModuleFileName can be "opengl32sw.dll" or as in ci "opengl32sw.DLL" as file extension is filled now by the winapi function. Make comparison case insensitive. Fixes: QTBUG-101084 Change-Id: I0816bbef21be40a786246ae9d43f031c5487a4f9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1a50992c2bb56825ab085b8d8343e1effc8a3e8d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Use a specific \ingroup name for qt_add_webengine_dictionaryTopi Reinio2022-02-221-2/+2
| | | | | | | | | | | | | CMake manual uses module-specific group names when listing CMake commands. Also, change a \target to a \keyword as it fits this purpose better. Task-number: QTBUG-100210 Change-Id: If9d075356c616ff5528f9a04e2d66bfb72e7a51a Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit abe0ddf07852f1629128f4d5f389941c633b051a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Minor. Fix context logMichal Klocek2022-02-171-2/+2
| | | | | | | | | | Log context before initialization as it can fail/crash and we do not see what failed. Change-Id: Ib47906c25bf8fb55c6c043ba5fadce9b354a87fc Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 3ddc6f951120fcbde903e650245849bde554b455) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add charset parsing to custom scheme handler's content typeAllan Sandfeld Jensen2022-02-172-13/+17
| | | | | | | | | | | This was already assumed by test in tst_qwebengineprofile. [ChangeLog][QWebEngineUrlRequestJob] Charset is now explicitly parsed from provided contentType Change-Id: I9bfb1f94cf523fbe0f9796654b4114e61e904c92 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit c3ae834aaad8bc78d4e534d1b1346fcdba475a03) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add html5lib to platform notesMichal Klocek2022-02-151-1/+1
| | | | | | | Change-Id: If414e4e8669032ebc8b7a11c8f7db2e67f269503 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 78819cdfc6738d1411e79b827c2d67b0739f4d3b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: State Qt versions for when CMake commands etc. were introducedJoerg Bornemann2022-02-141-0/+2
| | | | | | | | Task-number: QTBUG-100212 Change-Id: I03f5c83f5a745bb9f14c06d571333f074aec7f6c Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit c5d2168730e6f715f7965fe41933c8df62ec27b8) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* CMake: Adjust qt_add_webengine_dictionary APIAlexandru Croitor2022-02-122-9/+11
| | | | | | | | | | | | | | | | | | Rename the webengine_dictionaries custom target to qtwebengine_dictionaries. We don't name it qt_webengine_dictionaries for it to be consistent with the name of the directory where WebEngine looks up the binary dictionaries. Also fix the docs to mention the correct location of the dictionary output directory. Task-number: QTBUG-100210 Change-Id: I0232fa17d904ff602a09a70d21ad3d94c145b4c7 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 20b6674dc44bb808903fca94a85d40aea44ce81c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix using system libxsltAllan Sandfeld Jensen2022-02-121-0/+4
| | | | | | | | | | | The webengine-libxml settings should set both use_system_libxslt and use_system_libxml Fixes: QTBUG-100500 Change-Id: I1c731530a56e0ca9a49b91e1d6e095d8b416dd8d Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 18523483945756e786f5d6e82cb00be2defd302d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix crash on WebEngine(View|Profile).userScripts.collection getKirill Burtsev2022-02-101-0/+1
| | | | | | | | | | | | | | | | To create a javascript list on 'collection' method qml engine is needed for a qml scope, but it's only available for objects, which are created by the QML Engine itself. The only object in hierarchy of classes is an actual WebEngineView, so get it from there on collection init. Also implement delayed initialization of scripts collection for the usage of default profile through WebEngine singleton, and for the reason that it's not really needed until really asked by user code. Fixes: QTBUG-96597 Change-Id: I61e76652a5d0fd5609070fd541816503908f2dc8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit f5fbc34fc16fc9c6e7f7e8bbbf60f5b343b9466d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix accumulation of compositor-observer bindings for skia-on-glKirill Burtsev2022-02-083-9/+2
| | | | | | | | | | | | | | One of Compositor's derived classes, DisplaySkiaOutputDevice, was missing call to 'unbind' from its observer, leading to not releasing binding from global cache on destroy. Since unbind is done on destroy, remove all explicit calls to unbind from derived classes, and just do them in their base implementations. Ammends b117909825. Change-Id: I75c909eaa22ca1946ad67aa5093a8ee268c3562b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 16b2976e2c983cabe6011cd732e3ec46e3402d22) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Introduce gn complete static lib target for qtpdfMichal Klocek2022-02-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | With 6.x we have gn-cmake integration which allows now in case of static builds to switch gn target output to static_library with 'complete static' option instead of shared_library. This way we can avoid installing dependencies in form of internal static Chromium archives as it was done in 5.15 in case of static builds. Unfortunately 'complete static' option can not be used with QtWebEngineCore build as it will exceed 4Gb static archive limitation on Windows, however it will work fine with QtPdf. Note the qtbase 3rdparty static libs have to be still installed in case of qt static build, this patch only eliminates need for Chromium specific ones. Task-number: QTBUG-88614 Change-Id: I6fc4ce48c79a1631b013d0b29c190c62280f7304 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 8e549e6e0ccd6078b3bd2e38b87337fd367dec55) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Detect GSSAPI on Linux and pass it onAllan Sandfeld Jensen2022-02-032-0/+8
| | | | | | | | Fixes: QTBUG-100291 Change-Id: Iba9a9b41938e6ff9270bb8f98393c31d30663859 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit a4b28af742592284208a078cee26b20239b72c3e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Do not list native spellchecker feature on LinuxAllan Sandfeld Jensen2022-02-021-2/+5
| | | | | | | | | | | And make the condition more general as it is available on both macOS and Windows. Fixes: QTBUG-100293 Change-Id: If430eaa219f910bc686dc0859178b52a0d0c3fb3 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit a44849f7298de667dd0254f4a19546ffa40552be) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Improve local scheme access rulesAllan Sandfeld Jensen2022-01-286-43/+57
| | | | | | | | Task-number: QTBUG-96849 Change-Id: Ieb24da12a61e5e37b29ccf2d1a11b7bd863b842e Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 3071de1e07be28d763164a037d946281146bf31d) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use IsSameDocument() rather than IsLoadingToDifferentDocument()Benjamin Terrier2022-01-271-1/+1
| | | | | | | | | | | | | | For certain types of redirect navigations (for example, with a non-default useragent set) 'IsLoadingToDifferentDocument()' can be unexpectedly false. In such cases 'navigation_handle->IsSameDocument()' also returns false. Fixes: QTBUG-94924 Change-Id: Ie2c17127e1a00ffc515829526320ba2f71d45af5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit 8b5e3a46f253cd82dc48bc20c4233f1bf79fcb87) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Widgets: Add FileSelectionMode::FileSelectSaveSzabolcs David2022-01-203-0/+4
| | | | | | | | | | Now we have an example to trigger this type of dialog, we can expose this as public API. Change-Id: If0964d07a532daaff5e798dac63dc02ec7781d4d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 99b46c0959ec6280ee51c0d9ef8df432fd96a5bc) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add xkbfile to pkgconfigAllan Sandfeld Jensen2022-01-201-4/+3
| | | | | | | | | | To get the correct includes if they are less standard Fixes: QTBUG-99890 Change-Id: Ibd751d46dce7e00e4ce8433549e778d4814dae30 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 52f0ca90445c633c68694fde84b4630a13c3c14e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Find GIO like qtbase doesAllan Sandfeld Jensen2022-01-191-2/+2
| | | | | | | | | | | | Otherwise it can conflict and cause issue on reconfigure Change-Id: I3e7756b4720bc5a1e82ef0f327b8c9dbc76667ec Fixes: QTBUG-99669 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> (cherry picked from commit 0b6310bf48cfe9772be6ca2b51c685acce3f4ba6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Do not override signal handlersAllan Sandfeld Jensen2022-01-151-0/+1
| | | | | | | | | | We used to have this, but it got dropped at some point in an adaptions. Fixes: QTBUG-99263 Change-Id: I3bf86a1b42edca0cd792723c85d7dcb7877fea37 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit fbaab46becbf5ea063a8b4a01abf8cd1d4a1725d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix printing PDF filesSzabolcs David2022-01-143-10/+37
| | | | | | | | | | | | Delegate printing task down to the guest WebContents if any is present. Also update PrintWebViewHelperDelegateQt to find the plugin element properly for printing. Task-number: QTBUG-98941 Change-Id: I81004a2275e0870a17565af527b1450472afb24b Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 455efe7ef204c6cd8de72b9b1f922f1681f58589) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add objectName to webengine accessibility objectsAllan Sandfeld Jensen2022-01-084-19/+42
| | | | | | | | | | This requires adding a QObject to represent the backing node. Fixes: QTBUG-99485 Change-Id: I4d8c722a0dfb1f374995f3feab23b93ed5d8752a Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit d95f6a6b23e3052c39a32f50d6e604cf17e698e3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix inspector overlayAllan Sandfeld Jensen2022-01-061-0/+2
| | | | | | | | | | Was missing resources that had moved Fixes: QTBUG-99526 Change-Id: I68b05b9de3dbd6c6460e5495a939e2599623a047 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6617cb8edb51bce85861e44035948d8f634c985b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Always generate printing buildflagsAllan Sandfeld Jensen2022-01-051-3/+1
| | | | | | | | | | We include them unconditionally Fixes: QTBUG-99511 Change-Id: I4d9ebbf5777099ade38740ceb41532f0088df4c0 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 7720aa45fa8419da4c90ffed9954fbf7502d062e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update SG backend codeAllan Sandfeld Jensen2022-01-051-53/+21
| | | | | | | | | Correct the debug output and remove references to dead code like ANGLE. Change-Id: I261ecf23a200c4328ea79514f7f75fce991960f5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 3d0b32c93c0d45bf61a77e76ef9ab54efd2b2eeb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Cleanup code and clang build warningsKirill Burtsev2022-01-0316-62/+18
| | | | | | | | | | Fix build noise as reported by clang for issues like api deprecation, unused variables, sign/unsigned mismatch and other non critical issues. Change-Id: I4fba25406eea8170e3283c42e908ae86bd512e3a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 02d58a067fb5f0db32c254e783170f9f283aeb9d) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix crash on meet.google.comSzabolcs David2021-12-301-1/+7
| | | | | | | | | | | Hangout Services extension has a background WebContents. Do not try to access its delegate and settings. Task-number: QTBUG-99119 Change-Id: Ib46867ba98644e14af6263253daa253ef2e6b12a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1552ad5d3e66460bbbb5bbd71ca2083fb9d17d3f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix headers in GN sourcesAllan Sandfeld Jensen2021-12-241-4/+2
| | | | | | | Change-Id: Ib2faa3e0242799e1088d4ec7c610fa89a4d15bbb Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 540b1cadb1888a9adde8cf338fcdbd8630423c0b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* FIXUP: Add onTouchSelectionMenuRequested QML handlerBalazs Egedi2021-12-231-1/+1
| | | | | | | | | Fixed CodeChecker warnings, added missing documentation. Change-Id: I723ea2b0952ded52f513a3cd53ac443b727f1e58 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 56005ae3d52568b469db32498afebd9c52e4881b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Replace GeolocationSystemPermissionManager with GeolocationManager after 94 ↵Peter Varga2021-12-084-17/+19
| | | | | | | | | | | | | adaptations This is necessary to fix crash with disabled geolocation on macOS. The change in upstream is: Use GeolocationManager in CoreLocationProvider https://chromium-review.googlesource.com/c/chromium/src/+/2779636 Change-Id: I97143886bc3c98ad880c3cfc739ef08e5bfa3e73 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash with disabled geolocation on macOSPeter Varga2021-12-084-2/+60
| | | | | | | | | | | | | | | | | QtWebEngine uses custom LocationProvider for geolocation. If geolocation is disabled, Chromium fallbacks to NetworkLocationProvider. NetworkLocationProvider uses GeolocationSystemPermissionManager and tThere is no nullptr check for the manager instance so QtWebEngine has to provide it. This fix implements a FakeSystemGeolocationPermissionManager what is meant to be used only on macOS if geolocation is disabled. LocationSystemPermissionStatus is always set to denied by the fake manager. Pick-to: 6.2 Change-Id: I25d51c9ce8911b95ff69cc72bc6aae7023e7edbe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update documentationAllan Sandfeld Jensen2021-12-071-2/+0
| | | | | | | | | The signal is updated much faster for paused media now. Pick-to: 6.2 5.15 Fixes: QTBUG-98918 Change-Id: Ifa3b54e212436a7c93e101dc244d7edcbf473b63 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Check if qt_internal_return_unless_building_tools presentMichal Klocek2021-12-061-2/+3
| | | | | | | | Fixes dev build with 6.2.2 Fixes: QTBUG-97944 Change-Id: I027a473bc7cf239610d2162abb697cf10a557f4a Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix race condition on layout (take2)Michal Klocek2021-12-062-26/+10
| | | | | | | | | | | | | | | | | | | | | Even if layout is 'meaningful' it can still require update before toPlainTextSync call can proceed. Simply wait for frame being loaded in stead of tracking layout update. Depending on DidLoadFinish will brake default toHtml call for empty not loaded page, therefore return expected value if there is no load. This fixes crashes/asserts on certificateError (stacktrace in bug report). Remove blacklist on certificateError as bad certificate is back on line and toPlainTextSync works without issues. Fixes: QTBUG-97414 Pick-to: 6.2 Change-Id: Ib702bbe813f6061eef446e2d87d7e9e455d715c5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Allow surface factory with no backendAllan Sandfeld Jensen2021-12-021-3/+6
| | | | | Change-Id: I5fef92c4cb0110e413a7af2d35f2e9cf02a5b16b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 94Allan Sandfeld Jensen2021-12-0262-384/+466
| | | | | Change-Id: I9fb8998a3a7762b0aea70993ca231f0bbf4f7761 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 92Allan Sandfeld Jensen2021-12-0265-320/+363
| | | | | Change-Id: I1849c130ca75615802744275f6e4212a755c39b4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>