| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When text is selected inside a QWebEngineView, the selection is stored
in a RenderWidgetHostViewBase instance. When QWebEngineView::setHtml is
called, the stored selection is not cleared, and thus requesting for
the selected text will return stale data that is not present in the
page anymore.
Fix consists in calling WebContentsImpl::Unselect() after the new
html is loaded and focused in WebContentsAdapter::setContent().
Change-Id: Idd0f3187f324863b9a805af6a288dccfcbd5566f
Task-number: QTBUG-53033
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Qt versions < 5.6.1 the constructor of QCoreApplication directly
calls QCoreApplication::init and QtWebEngineCore::initialize() in turn.
That means that qobject_cast<QGuiApplication*> cannot work, because the
object is not fully constructed yet.
This was fixed for Qt 5.6.1 in commit qtbase/1b441c39.
This patch turns off the fix for QTBUG-51789 when building QtWebEngine
against Qt versions older than 5.6.1.
Task-number: QTBUG-51789
Change-Id: I092fb559ea4449bd443737d5962b4b87dee88cdd
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On windows, calling QtWebEngine::initialize from DllMain may crash,
depending on what QPA backend is used.
We make sure to only add a qAddPreRoutine initializing QtWebEngine
if there is no instance of QCoreApplication.
By doing so, we support linking to QtWebEngineWidget from a plugin,
while still initializing the WebEngine automatically when linked to
the main application binary.
Task-number: QTBUG-46720
Reviewed-by: Jocelyn Turcotte (Woboq GmbH) <jturcotte@woboq.com>
(cherry picked from commit 6a8d99ab00ace2084820547572dc05ac8ad2bc5a)
Change-Id: Id3b2c1e21e01808cef124f8ece6b247b1ba613cb
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a tool which converts hunspell 'dic' dictionaries
to binary 'bdic' format, which is required by spellchecker
in chromium. Tool is compiled as a qt console application.
It reuses linking information produced by gyp.
This tool cannot be used in cross-builds due to limitations
of the gyp-based build system.
Change-Id: Ibee8cbc6048b522c0e4fe22b21c91c649c8515bc
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using default value in kSpellCheckDictionary ends up in
migrating preferences from single-language to multi-language
schema. Default values can be set on application start.
Change-Id: I59e3667bcf57a859f1b18f389c1c44c81fc82651
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Current logic of setting resource paths will
always complain about missing dictionaries
see QTBUG-52682. Remove warnings so now
only SpellcheckService warns about missing
or corrupted dictionary on lazy load.
Use only one global and one local search path.
Task-number: QTBUG-52506
Change-Id: I33b613ea8c0a7533f51742e6c155c6ee2c8ceda1
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We never shipped a debug version of the QtWebEngineProcess executable.
This is problematic in debug_and_release builds when a debug application
starts the release version of QtWebEngineProcess. The Qt libraries will
then be loaded twice, in debug and release.
Also, in development setups where only the debug libraries are deployed,
the release version of QtWebEngineProcess cannot be loaded.
Task-number: QTBUG-49493
Change-Id: I2f7bfb9c7cf8e869dc91007f4e967a713f438065
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For the Widget API the QIcon returned by QWebEnginePage::icon() function
contains all the candidate icons for the current page.
For the Quick API the QQuickWebEngineFaviconProvider provides the best
quality icon for the requested size from the candidates.
Task-number: QTBUG-51179
Change-Id: I42b8427f957e2f2fc745dd0111bedcc71b577216
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This method is broken, since SpellcheckerService
is lazily initialized and dictionaries might
be not loaded yet. Moreover there is a missing
implementation on mac. Instead log warning
when SpellcheckService can not load dictionary.
Change-Id: Ifa2e769d83307543fa6cdf529475e9ab980022f0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Chromium 51 WebAudio will be always on, and can not be runtime
enabled or disabled. We should avoid introducing a setting we can
not even support in the next version.
Change-Id: I42f7d4f3f7f952f38361ef73dfe7b318ea1a4cf5
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| | |
We don't use extensions and can disable them.
Change-Id: I2f1ff2a177cf60d229b599e8dffc4ee55b46b920
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adds copyright and origins to files in src/core based on Chrome sources.
Change-Id: I842ce4c170bfeabe06d92fb67fef3d8f9a202ddc
Task-number: QTBUG-53048
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adds original copyright where it was missing and add origin sources, so
we can better find and compare with the original.
Change-Id: Id74da177325a55d98ac4487ff596f9b383012ea4
Task-number: QTBUG-53048
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This API is needed to support Netflix.
Change-Id: I413a0e29e6be12fa5c70879c7127618665fc859c
Task-number: QTBUG-52100
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Chrome usually installs the widevine plugin into the
/Library/Application Support/Google/Chrome/WidevineCDM directory.
Try and load it from that location, so it doesn't have to be specified
on the command line.
Change-Id: Idb14ae677112f16c853bdc5d1ae700a75a735ebf
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
|\|
| |
| |
| | |
Change-Id: I329397621f19ba3890be5daf44a6bb2d668ad2d8
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Only update installed custom url scheme handlers, and leave the rest of
the job factory untouched, so we don't delete the protocol handlers and
request interceptors Chromium passed us, and that are now owned by the
job-factory.
Change-Id: I640527487dda053463f8fa9986ceb47941593f2b
Task-number: QTBUG-52790
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add comments to parts of URLRequestContextGetterQt that are subtle and
I already forgot once.
Also adds another update atomic to match the rest.
Change-Id: I8193247ce76435ac0d169b740a4543099b3ffac2
Task-number: QTBUG-52790
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Switches HttpUserAgentSettingsQt to reading local string that lives on
the IO thread, instead of accessing a pointer that may be deleted.
Also adds a test and fixes updating accept-language of already
initialized WebContents.
Change-Id: Iff4e3bd1ac40482a92bed50c3f703ed8b974b0ad
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Release CookieStore in URLRequestContextGetterQt destructor,
this will eventually delete CookieMonsterDelegateQt and
trigger commit of cookies in cookie store backend.
Task-bumber: QTBUG-52121
Change-Id: Ic83c7ee3ece1c64ac9e47cba5dcf40e084d9c3dc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The SkBitmap to QImage conversion in ClipboardQt::WriteBitmap was
hardcoding the image format to ARGB32. This failed whenever the format
of the SkBitmap provided by Chromium was different.
This change backports 1cf9175e from 5.7.
Task-number: QTBUG-52715
Change-Id: Icf27b97bc421a2201c307a4514928dcf384d9ba6
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It turns out that using the temporary zoom factor is meant to set
the zoom factor for one certain view, and this is actually what we
want.
Also added auto tests for this.
Task-number: QTBUG-51851
Task-number: QTBUG-51969
Change-Id: I8912cbc25637d3c1681026380a2ab3068a964868
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Remove the non-const reference access to customUrlSchemeHandlers, and
replace the last remaining use-case with clearCustomUrlSchemeHandlers.
Change-Id: If9077e3900593d7f9520fb9bbcef2f1aa3307eac
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Avoids accessing the QWebEngineUrlSchemeHandler from any other thread
than the UI thread, since it may be deleted at any time on the UI
thread.
Change-Id: Icb4331b3c36f6f619a9fd975d155a9fd608dc5e9
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ic3504db1b55e1ff4375efacb450a96ce32a119ee
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adds test for user-agent override and fixes the override so that it
also works when loading with content instead of URLs.
Change-Id: I3f61b1d91b7b0908e35216722054168d1c514a87
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
BrowserContextAdapter is not a form of shared data, and using
QExplicitSharedDataPointer on it as always been a misuse of the class.
Instead we should switch it to QSharedPointer, which also allows us to
use QWeakPointer.
Change-Id: I8eb489b4a12d3fdddcde55821be294814a156a9d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| | |
Assert and thereby also document thread assumptions.
Change-Id: I44cd8b015ed8a6e38b9328f334f55d9d2f72b50d
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Call logging::InitLogging so arguments such as --v and --vmodule are parsed
and used to configure chromium logging levels.
Change-Id: I44f8ed6b0ca9db4d606ced383c269566218383ad
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The new QQuickImageProvider subclass is used to access downloaded icons
from the FaviconManager via the Quick API.
Change-Id: I6a52d3c737b2260cf480167764a931915cd99cab
Task-number: QTBUG-51179
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-51808
Change-Id: Ie612410b95cc13363bfca0b412deac3a7e65f687
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* marks new properties in QQuickWebEngineProfile as FINAL
* removes QT_NO_SPELLCHECK from API headers
* renames spellCheckLanguages() to availableDictionaries()
* removes "togle spellcheck" methods and actions
* use WEBENGINE_CONFIG instead of CONFIG for disable the feature at
compile time: WEBENGINE_CONFIG+=no_spellcheck
Done-With: Peter Varga <pvarga@inf.u-szeged.hu>
Task-number: QTBUG-52371
Change-Id: I8c8eff497b9e7afe0cec2edc97dec248151487f2
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\|
| |
| |
| | |
Change-Id: I490e0ee46d3ff040ca26426feb7e4d6ef7098f94
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ICU .dat file and .pak files were already copied to
the developer build directory in core_module.pro. Let's
do the same for translations, and remove the logic
handling this in resources.gyp.
Change-Id: I4926cd6012f2664feed27aa042eb3ceb282a93d9
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Get rid of dangling pointer on storage removal in
URLRequestContextGetterQt. This is accessed later
in generateHttpCache.
Task-number: QTBUG-52468
Change-Id: I03c0b3186b01046e17258af838bf5f9adc435da0
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I could not reproduce the issue, nor the CI. Anyhow, it doesn't hurt to
include the header explicitly, instead of relying on indirect includes.
Task-number: QTBUG-52460
Change-Id: I78d04f3af853aa5951cdfc066089f06f71f72988
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
While it is better to use the global shared OpenGL context, we can
fall back to using the module type which is usually correct.
Change-Id: I441bfdc38db593abfd10cb08ba90af09dcd31a2a
Task-number: QTBUG-51379
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a URL interceptor changes the request but doesn't block it, we
currently do not send the navigation requested signal to the API layer.
Instead continue as normal when not blocking.
Change-Id: Ida6aad5767fcaef58093c50aa3932092334f499c
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
We already set sysroot to empty for all none cross_compile builds in
the 5.7 branch.
Change-Id: I99626694983c776f46d0e5daa9b1e39614266cb6
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
|\|
| |
| |
| | |
Change-Id: I53645ee5405b1c43807123fd3c196e314cfd1ce9
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is needed to let local content access the qrc resources by making them
part of the same security origin. This is stated in the docs as the default
behavior.
This also backports change f7d343000d77c80f34a115fe9c78f101929292b1
from 5.7, which fixed some race condition with the qrc registration.
Task-number: QTBUG-52085
Change-Id: Ia704fa6dbce8529f82695ab543244020cb9f8b8a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes access of label of MediaStream tracks
Also fixes the logged error:
WebContentsDelegate::CheckMediaAccessPermission: Not supported.
Change-Id: I3fee9ccd9e8b2e5cbd6b707336cc61425a44ba31
Task-number: QTBUG-52216
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I9e1acaa0dbd31978730dae33ebb517f467f8df49
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The qputenv() call inside gl_surface_qt.cpp, which is executed on a
GpuChildThread, can reallocate the process environment structure,
and it is possible that at the same time the main thread calls getenv,
which will dereference a pointer to the freed environment structure,
essentially causing a use-after-free crash.
Make sure the qputenv() call happens before Chromium initialization
starts, so no thread-race can occur.
Change-Id: I4ecbdc8bf2abbe45f7d6c5d2633dc9fe27f51e66
Task-number: QTBUG-52124
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
(cherry picked from commit 76c61aa1400ef2def204c3732e30e08e40631e8d)
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Compiling against NSS 3.23 fails with current Chromium. Also, with NSS
3.21 there are failures connecting to e.g. google.com.
Fix this by adapting the setup endorsed by upstream Chromium: BoringSSL
is always used for cryptography, and NSS only for certificate handlng.
Patches included in 3rdparty update:
0a385bb [backport] Call EnsureNSSHttpIOInit in the chimera build.
0472123 Fix build against newer NSS
90c62c4 <third_party/libpng> [Backport] update to libpng 1.2.56
34857b8 <third_party/libpng> [Backport] Stop large iCCP chunks causing delays and "Aw Snap!"
Task-number: QTBUG-52193
Task-number: QTBUG-51890
Task-number: QTBUG-52068
Change-Id: If8aaed9b9a09475c5ed0dfec64d31f45ce9670f5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Chromium usually clears the pending entry when it fails,
so that an arbitrary URL is not left visible above a committed page.
However, it does preserve the pending entry in some cases,
such as on the initial navigation of an unmodified blank tab.
So in other cases Chromium clears the pending entry
(if the navigation is not in progress), and it does force the UI (URL bar)
to refresh.
In our case we allow failed URLs to stick around in the URL bar
but only when alternate error pages are used.
Change-Id: I26e81e7a99415aa184880dcb647a06d977584119
Task-number: QTBUG-48995
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
moc.prf contains magic (translation: weird heuristics) to determine if
the moc command line would exceed the command line length limit on
Windows. If such an excess is detected a response file is created in
MOC_DIR. As our build directory is not qmake's default one, moc calls
will not find the response file.
Set MOC_DIR accordingly to generate the reponse file in the right
location.
Task-number: QTBUG-51847
Change-Id: Id0695451a986cd9514a7c965c6d33c5c3ef800cd
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Chromium insists on getting the command line via the system call
GetCommandLineW. QCoreApplication already did that, and we want to pass
the already split argument vector to init CommandLine.
This way, the user can pass custom arguments to QGuiApplication, and
Chromium will pick those up correctly.
Task-number: QTBUG-51971
Change-Id: I85b2071fcd8e5781b13ec8d22dc00b1a0c71601b
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently on OSX, two Info.plist files are generated and copied to the
QtWebEngineCore framework, one into Contents/Info.plist and another
into Resources/Info.plist. The first one is generated by
core_headers.pro and the second by core_module.pro.
OS X frameworks only use the plist found in the Resources directory,
and the Contents one was generated by qmake erroneously, assuming
that core_headers is an application, rather than a framework.
When macdeployqt is used with -always-overwrite option, it copies
Contents/Info.plist (which contained an incorrect bundle id) over to
Resources/Info.plist, and afterwards when an application is executed,
it cannot find the plist file because it contains the the wrong
CFBundleIdentifier, thus not being able to find the QtWebEngineProcess.
Fix consists in making sure code_headers.pro does not generate an
Info.plist, and just use the one generated by core_module.pro.
Change-Id: I6295bde3b1d1771ed45f3a2fdff9fc60577f2ab6
Task-number: QTBUG-51939
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove misleading "singleton, if one has been set" from the accessor's
documentation. Also link to the accessor's from the class documentation,
and remove mentioning of cookie store as something that can be accessed
for an individual page.
Finally, mark QWebEngineProfile::cookieStore as new in Qt 5.6.
Change-Id: Ia20ca0ef45a9a15de0052f7ceb7f59d454c70fdc
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
|