summaryrefslogtreecommitdiffstats
path: root/src/core
Commit message (Collapse)AuthorAgeFilesLines
* Fix rsp linking on windowsMichal Klocek2017-02-101-9/+8
| | | | | | | | | Rsp file format is not correct currently on windows, as a workaround use selfmade rsp file. Task-number: QTBUG-58710 Change-Id: I0cd6f3f5e29285330b1abbb30177bbd56f064e0d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.8' into 5.9Allan Sandfeld Jensen2017-02-083-6/+28
|\ | | | | | | Change-Id: I0c3654ad097809fe10bcc6a15827a0af3006c4e6
| * Do not create directories for overridden pathsJoerg Bornemann2017-02-071-4/+18
| | | | | | | | | | | | | | | | | | When overriding Chromium's default paths do not create non-existent directories anymore. Just print a diagnostic message. Task-number: QTBUG-54258 Change-Id: Ie642a630ad5b4aebc4e80e3eace7db7489a82907 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Provisional Fix for Navigation-Breakage on right-click in Flash appletViktor Engelmann2017-02-021-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When one right-clicks into a flash applet, chromium believes that a context menu was open (even though PepperRendererHostFactoryQt::CreateResourceHost returns NULL, which only causes an ASSERT on chromiums side). Because of this, the navigation is disabled, although no context menu is displayed. This fix just sends a message to chromium, telling it that "the context menu" is now "closed", which causes another ASSERT, but re-enables the navigation. Task-number: QTBUG-57924 Change-Id: Id6d8150a7d4944162bab81362153f8621d35bb4c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Avoid crash in desktop linux with --disable-gpuAllan Sandfeld Jensen2017-02-011-1/+1
| | | | | | | | | | | | | | Don't try to access null OpenGL contexts. Change-Id: I7d0e607e8d29d3cfba8d6e98cd142b951c960281 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Fix running qmake recursivelyMichal Klocek2017-02-071-1/+8
| | | | | | | | | | | | | | Move gn run call form make step to qmake step. Change-Id: I01913aef9dff505df3319755ae7009144919accf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Refactor release and debug handlingMichal Klocek2017-02-063-23/+8
| | | | | | | | | | | | | | | | | | | | Fix release and debug builds. Refactor ninja and gn builds as a sub projects, these are only build as release. Call core_generator and gn_run separately for debug and release builds. Change-Id: I638023214cdc98a5101d190486452cc4a1229486 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix escaping of double-quotesAllan Sandfeld Jensen2017-02-031-1/+1
| | | | | | | | | | | | | | | | We are using double-quoted strings and should therefore be escaping double-quotation marks and not single-quotation ones. Change-Id: I0ae3bb45365843647b38c88a22379f89843dff54 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Switch linux desktop builds to gnMichal Klocek2017-02-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates chromium: 1fd9f11 Remove linking with libatomic fa90180 Fix missing dependency on libffi b5a3338 Fix broken unit test for gn 70ea2bc Fix gn compilation for rhel6.6, rhel7.2 f408e89 Improve .pri output 492b20a Remove gtk2 dependency in tests 42e3484 Allow Service Workers without HTTP headers 7a1be30 Do not require gnome-keyring 11e5c2d Revert "Add mus and catapult project files" 891fb3a Remove various test and telemetry dependencies ddd6053 Do not use last_commit_position for gn build e85719e Windows and macOS GN integration 8fda2ae Make more features configurable 93db377 [Backport] Don't schedule wholeSubtreeInvalid sets [ChangeLog] Switch linux desktop builds to gn Change-Id: I0f766b9ee9ea65a2f92d9818ea5fb34a2e65c52d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge dev into 5.9Oswald Buddenhagen2017-02-0124-131/+684
|\ \ | | | | | | | | | Change-Id: Id919bfd67d9d435fd5a05a892151a12ae5bcd3c0
| * | Assert WindowOpenDisposition enum valuesAllan Sandfeld Jensen2017-02-011-0/+11
| | | | | | | | | | | | | | | | | | | | | We are depending on them matching but were not asserting it. Change-Id: I86e9a9a2f516e8a149d82077884bf08b4d8aee51 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * | Make WebRTC support configurableAllan Sandfeld Jensen2017-01-312-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | WebRTC is a big feature that Chromium has left configurable for a long time, we can forward that configurability to our users to allow them control it directly instead of just enabling it on desktop and disabling it on embedded. Change-Id: I4445e2189112205ddf1368bd5e197bab2df92092 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * | Fix build with 5.8 and make embedded configurableAllan Sandfeld Jensen2017-01-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid checking features only available in 5.9 directly. This also changes the embedded-build configuration to being a feature that can be set at configure time. Change-Id: I9b42dcf696734a83e5c8d6e1cc07562cbeb3f993 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * | Merge remote-tracking branch 'origin/5.8' into devLiang Qi2017-01-305-37/+101
| |\| | | | | | | | | | Change-Id: Ic36a80502730d404ab96dfa11ff1eb0ac6eb302d
| | * Forward mouse buttons and keyboard modifiers while draggingJoerg Bornemann2017-01-261-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | Until now we always pretended that the left mouse button was used and no modifier key was pressed. Change-Id: I0f4b84ed87e7c94289c14c13a6cd12c3beda671a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Fix canceling drag and drop actionsJoerg Bornemann2017-01-262-15/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RenderViewHost::DragSourceEndedAt must be called after dropping and after canceling a drag. Otherwise scripts running on the web page do not get properly notified. Task-number: QTBUG-58037 Change-Id: Ia245131c59f03f3331158bea6cc2f53bce50f989 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Fix confirming IME composition and newline insertionPeter Varga2017-01-253-21/+48
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-55766 Change-Id: I3be3b224dfef9ecc1ce39f4f20ec5c1d13c0fa69 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | macOS GN integrationAlexandru Croitor2017-01-278-76/+128
| | | | | | | | | | | | | | | Change-Id: I89850d43c8f11ec54b3a47318ef0b3f083ae3dee Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | GN configuration cleanup and preparationAllan Sandfeld Jensen2017-01-263-14/+49
| | | | | | | | | | | | | | | | | | | | | | | | Reintroduces the shared linux.pri configuration and moves configuration shared by all architectures to common.pri Change-Id: Iff4d1e6e3d98280223cce0c2c0b74d71ef99df5f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * | Merge "Merge remote-tracking branch 'origin/5.8' into dev" into refs/staging/devLiang Qi2017-01-257-21/+32
| |\ \
| | * | Merge remote-tracking branch 'origin/5.8' into devLiang Qi2017-01-257-21/+32
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/3rdparty tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp Change-Id: I070173576fc4be53689ce0dd9e1fd4133f5814da
| | | * Fix handling of empty input method eventsPeter Varga2017-01-221-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-55766 Change-Id: I4e6ade8f000f66ff1bb28f3b856ae140834292f1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | | * Make input method hints available via RWHV delegate widgetPeter Varga2017-01-202-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moreover, set ImHiddenText hint for password fields and add back the corresponding widget auto test. Task-number: QTBUG-55766 Change-Id: I3f76e19c8c33e11f3d9f515b6dc7d6e998c3c9a4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | | * Disable Q_ASSERTs for a release buildKai Koehne2017-01-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Qt WebEngine uses the core_gyp_generator.pro and the gyp_generator.prf files to extract defines set by Qt. Anyhow, only one core_generated.gyp file is written for debug and release builds, which hence misses the QT_NO_DEBUG define specific to debug builds. Work around this by explicitly adding back the define. Task-number: QTBUG-58103 Change-Id: I8684aa08417efc93878d70817211e9f66623c78c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | | * Fix conversion from blink::WebDragOperation to Qt::DropActionJoerg Bornemann2017-01-184-19/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | blink::WebDragOperation is a bit field, even if it is not used in its blink::WebDragOperationsMask incarnation. In particular, WebDragOperationGeneric can be set in addition to other operations. This fixes situations where UpdateDragCursor is called with multiple bits set in its WebDragOperationArgument and the drag action will be spuriously ignored. Also directly pass the WebDragOperation we get from UpdateDragCursor to chromium's API without converting to QDropAction and then converting it back. Task-number: QTBUG-58037 Change-Id: I5c85699de534771f84db69abf7b98e779872a0f7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | | Add gn build of qtwebengine for linuxMichal Klocek2017-01-259-96/+468
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit uses gn instead of gyp to build on desktop linux. Use WEBENGINE_CONFIG+=use_gn to use gn during the build instead of gyp. Change-Id: Ifd3d8d0835b47c323a8d39c320eb55e5e1024dee Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* / / Add SUBDIRS in dependency orderSamuli Piippo2017-01-311-7/+8
|/ / | | | | | | | | | | | | | | | | Once more, fix the order of SUBDIRS, since recursive qmake call does not handle .depends Task-number: QTBUG-45706 Change-Id: Ibe578a9f5e80079d1ba917915f169e0e0bc4203e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge remote-tracking branch 'origin/5.8' into devAllan Sandfeld Jensen2017-01-186-10/+30
|\| | | | | | | Change-Id: If16bfc6f0fbfd0040e13a8a3cbaa113fda10f387
| * QWebEngineDownloadItem::path() should not be percentage encodedAllan Sandfeld Jensen2017-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the name of the download item is derived from the URL, we currently end up reporting a partially percentage encoded name. This is problematic if our users try to undo the the percentage encoding and opens them out to download-folder escaping files that can install hooks in the user's home directory. [ChangeLog][DownloadItem] (QWebEngine)DownloadItem::path() was previously incorrectly returning percentage encoded file-names when the suggested path was based on URL. This has been corrected. Note percentage decoding the path generally before is not just incorrect when the path is not based on URL, but also dangerous as it can lead to downloads that escape the download folder. Task-number: QTBUG-58155 Change-Id: Ie23a4ff5d4e4c353df72e617bb2b00e1935cd6c1 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
| * Avoid overriding new and deleteAllan Sandfeld Jensen2017-01-061-1/+3
| | | | | | | | | | | | | | | | As a minimum this produces valgrind warnings of mismatched new and delete. No runtime issues have been observed outside of valgrind though. Change-Id: I5ebb6b380f25f117434633e55dd7fdf04260f0bc Reviewed-by: David Faure <david.faure@kdab.com>
| * Replace ASSERT in FaviconManager::setIcon by returnViktor Engelmann2017-01-051-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | The ASSERT in FaviconManager::setIcon can be triggered by what seems to be a race condition. Apparently the old request can be gone (so m_inProgressRequests.contains(id) is false), but m_inProgressRequests can still be non-empty, because of a new request to the same URL, so this case is not covered by checking m_inProgressRequests.isEmpty() before. Task-number: QTBUG-57900 Change-Id: I2f26c05e5c97e4bd8d1cea03e8005cf61f2b0c98 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Check RWHV for NULL before dereferencing itViktor Engelmann2017-01-031-2/+5
| | | | | | | | | | | | | | | | | | | | | | Under exotic circumstances, the RenderWidgetHostView pointer returned by m_webContents->GetRenderWidgetHostView() can be NULL. Therefore, it must be tested for NULL, before its SetBackgroundColor method is called. Task-number: QTBUG-57826 Change-Id: I30e0d2174e80d7971f4e2b6f315a771dc1577814 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Prevent accessing d when view closed during DnD operationViktor Engelmann2017-01-021-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When a WebEngineView is closed while a Drag-n-Drop operation is in progress, the this pointer and its d-pointer become invalid, so the accesses after drag->exec must be prevented from being executed. To achieve this, a lambda function is connected to dragSources &QObject::destroyed signal, which invalidates a bool on the stack (and cancels the Drag-n-Drop operation). Task-number: QTBUG-57713 Change-Id: I9cbb5e6aba99e307d62773bc18f4fec5f79cf703 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
| * Enable viewport-meta setting againAllan Sandfeld Jensen2016-12-291-0/+5
| | | | | | | | | | | | | | | | | | | | We enabled this using a command-line argument in 5.6, but that argument is no longer available in 5.7, so instead set it to match viewport enabled. Task-number: QTBUG-57206 Change-Id: Ibef9e93bc96f74429870fdb340d6ea0c0030159c Reviewed-by: Jocelyn Turcotte (Woboq GmbH) <jturcotte@woboq.com>
* | Add pepper-plugins feature to new configure systemMichal Klocek2017-01-166-17/+25
| | | | | | | | | | | | | | | | Task-number: QTBUG-57731 Task-number: QTBUG-58108 Change-Id: I253dab52361afd411dcf545fab752836c19ee3c7 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add print and pdf feature to new configure systemMichal Klocek2017-01-168-31/+36
| | | | | | | | | | | | | | | | | | | | | | | | Currently printing and pdf are bounded together. Make compilation optional by adding it as a feature. Fix formatting of embedded_linux.pri Task-number: QTBUG-57731 Task-number: QTBUG-58108 Change-Id: I53a2baea656df0a5b6139365ed06385c9ebc5830 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add methods for textual description of DownloadInterruptReasonViktor Engelmann2017-01-124-38/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A method was added to get a textual description of a Q(Quick)WebEngineDownloadItem::DownloadInterruptReason. Basically returns the same description from the QDoc entry, but shortened where that was to long. Also moved the ASSERT_ENUMS_MATCHes from download_manager_delegate_qt.cpp to the newly created browser_context_adapter_client.cpp. Task-number: QTBUG-56839 Change-Id: I17c68987b7f12fcaeb71fd27f7ebb35c0ac87bac Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add methods to issue various types of HTTP requestsViktor Engelmann2017-01-115-6/+575
| | | | | | | | | | | | | | | | | | | | | | | | | | Added class QWebEngineHttpRequest, which describes a GET or POST HTTP Request. Also added overloads of method "load" to QWebEngineView, QWebEnginePage and WebContentsAdapter, which issue such a request. These can be used for example to simulate form-submissions. Task-number: QTBUG-53314 Task-number: QTBUG-53372 Change-Id: I85ac8cdd3d1557905b35e3172b922aba356d1c41 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Optimize scene graph rendering by reusing old nodes if possibleMichael Brüning2017-01-113-98/+438
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, Qt WebEngine always dropped all existing scene graph nodes that were created for previous frames and built up a whole new tree. The main reason for this was that the render pass structure is not guaranteed to remain the same across two frames. This resulted in a full repaint of every new frame, even if only a small area had changed. We now check first if the structure of the frame data has changed across two sequential frames. We only discard the old nodes if there actually has been a change. Otherwise, we reuse the scene graph nodes and only update the nodes that have changed. A general exception to this at the moment is video. In case any streaming video or yuv video nodes are found in the render pass, all nodes get recreated. Task-number: QTBUG-57720 Change-Id: I8998577af48a163d54144f205c316ee427ed0307 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Emit a new signal when printing to a PDF file finishesMichael Brüning2017-01-104-29/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ChangeLog][Important Changes] Printing to a PDF file will now emit signal the signal pdfPrintingFinished in both QQuickWebEngineView and QWebEnginePage. The boolean passed with the signal to indicate if the printing and saving of the PDF was successful. The path of the created file is also passed to enable the user to map the signal to a print request. Task-number: QTBUG-56677 Change-Id: Ifab5a20b048f33a8cd872165bd4d453b01708037 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | Merge branch '5.8' into devAllan Sandfeld Jensen2016-12-216-13/+49
|\| | | | | | | | | | | | | Conflicts: configure.json Change-Id: I658a02de96b45b382f0f6c383964501b794b5eb6
| * Warn on wayland if compiled with x11 support, however no xwaylandMichal Klocek2016-12-201-0/+7
| | | | | | | | | | | | | | | | Add a warning message for builds with aura and x11, when run on wayland wihout xwayland support. This will be fixed properly in 55-based. Change-Id: I7482c7989087b5702634aff5d43409ae8728cd94 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix compilation, add getApplicationLocale() method implementationMichal Klocek2016-12-201-1/+9
| | | | | | | | | | | | | | | | This is workaround to not include web_engine_library_info.h for qtwebengine_sources. Change-Id: Idbc86e8e5281a514199ebcd80af045e11f554362 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Merge remote-tracking branch 'origin/5.8.0' into 5.8Liang Qi2016-12-154-12/+33
| |\ | | | | | | | | | Change-Id: I1f2068d52104764a1ac75354cbe7d90f6293ec7d
| | * Fix Linux audio library detectionAllan Sandfeld Jensen2016-12-151-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | The configure checks where moved to QtMultimedia which we do not depend on, therefore we need to now duplicate the checks ourselves. Task-number: QTBUG-57620 Change-Id: I6f7319c7e91e3f51baf012c669121389cd6e1360 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Use surfaceless context if necessaryAkihiko Odaki2016-12-081-8/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The support for surfaceless context was disabled in commit 9cc97f0c63049a8076476acc89c875c9e240abfb, which says: > Using surfaceless EGL surface on imx6 embedded device crashes webengine > with backtrace in gpu driver. It was added in commit bfcbdc3ab42880dc37ffa7174af96928ccf25f03, which says: > This patch is a port of commit 4b0cac9dfeebb73f21a11e10e6a2bc7bddbe889b > in Chromium for Qt WebEngine. > The based commit says: > (snip) > > the creation of a dummy offscreen surface. This would also enable > > support for offscreen rendering on platforms (i.e Ozone-Wayland) which > > donot support pbuffer surfaces. > > Some platforms supported by QPA, such as Mesa 3D DRI2 with drm and > wayland backend also don't support pbuffer surfaces. Considering those cases, this change enables surfaceless context only if pseudo surfaceless context made of surface context is not available. Change-Id: I015421ebbbc357d48313e09d4f7a0369bb956521 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Avoiding accessing null QMimeData from missing clipboardsAllan Sandfeld Jensen2016-12-071-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | Not every Linux QPA has the selection clipboard, and will return a null QMimeData when one is requested for Selection. Task-number: QTBUG-57425 Change-Id: Ib63a0c3589df299ce4a2a5e30cbe6efb0727b5f1 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Merge remote-tracking branch 'origin/5.7.1' into 5.8.0Liang Qi2016-12-071-2/+3
| | |\ | | | | | | | | | | | | Change-Id: I4f73844c730d52b00194ab6ff4abe35c59f7ef68
| | | * Disable surfaceless context supportv5.7.1Michal Klocek2016-12-011-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using surfaceless EGL surface on imx6 embedded device crashes webengine with backtrace in gpu driver. Since this feature requires a bit more testing on embedded platforms disable support for the 5.7.1 release. Task-number: QTBUG-57290 Change-Id: I3ed5b6fc173d184486316a2c3d899a88d4b1de76 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * | Do not disable thumb instructions on ARMv7+Allan Sandfeld Jensen2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromium in particular the bundled FFMPEG does not build on ARMV7 with thumb disabled. Since thumb should always be available on ARMv7 just ignore possible -marm in QMAKE_CFLAGS in that case. Task-number: QTBUG-57037 Change-Id: I09380839dddb97f64fb35ed749e5af0d002fa5fa Reviewed-by: Michal Klocek <michal.klocek@qt.io>