| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Make sure the HTTP referer is properly placed on a request when it's set
via the QWebEngineUrlRequestInterceptor.
Added test case to catch future incidents.
Fixes: QTBUG-60203
Change-Id: Ida2f713a7352c3199fc9f8e15b5d8350d50afdda
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Disallow installing handler for "about" and everything in kStandardURLSchemes of
url/url_util.cc. Except for "gopher" which is used in tests. Suppress warning
about custom schemes for "gopher" since it's not a custom scheme.
Also lowercase the scheme in urlSchemeHandler() and removeUrlSchemeHandler().
Change-Id: I72b06d4fa6433882019405a0d600a593c8971bf1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
This amends 26ac59af2306
Fixes: QTBUG-75465
Change-Id: I22df5dc851f80724a44c028310269289548dacc5
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
| |
Change-Id: I05ef67b81d9b871d38fcc51639b742b2a7b8a387
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-75212
Change-Id: I1d1a99d9a5b6684d23e51cf55d384e7dfee6ef2a
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
QPageLayout::pageSize() is always defined in portrait orientation.
Removing margins without considering the actual orientation was incorrent.
Use QPageLayout::paintRect() instead.
Task-number: QTBUG-75092
Change-Id: I34c19d3f0587ae21da2d985e3107b6ec673f53d0
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
Delegate assumed to be owned and released by BrowserContext instance
Change-Id: I1b5dc3ad2ace6f5c40b9f56e7ed7eb6b23b60925
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes regression, introduced by the fix for QTBUG-66011, where setting
JavascriptEnabled to false stops all scripts from running instead of only
MainWorld scripts (as documented). Only the DocumentCreation injection point is
affected.
The original change which introduced the regression consisted of moving the
DocumentCreation injection point from
ContentRendererClient::RunScriptsAtDocumentStart
to
RenderFrameObserver::DidClearWindowObject.
The problem of scripts not working on view-source URLs was fixed by this move,
but it turns out that the call to DidClearWindowObject happens to be conditional
on Document::CanExecuteScripts and this is, of course, false if JS is disabled.
Hence the regression.
This new patch moves the injection point again to a task launched from
RenderFrameObserver::DidCommitProvisionalLoad.
DidCommitProvisionalLoad and DidClearWindowObject are both indirectly called
from DocumentLoader::InstallNewDocument, however the former is called before the
Document is opened and is therefore too early for script execution. As such, the
execution is delayed by posting a task which, in theory, should be scheduled
very soon after the normal call to DidClearWindowObject.
Fixes: QTBUG-74304
Change-Id: Iac8714bcc5651c287b73181811af26996d955af5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
refs/staging/5.12
|
| |\
| | |
| | |
| | | |
Change-Id: I8a087fefcb9f0f1c750747d29819e53c11984b41
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Also fixes the fact that WebEngine was passing POST data to Chromium
even if the request was not a POST request. This triggered an assert
in the backported code.
3aaf2ca833c [Backport] Security bug 906739
e4e10461659 [Backport] Security bug 906437
0a717e1dbe9 [Backport] Security bug 913212
c7fa9a16957 [Backport] CVE-2019-5803
ebe1e7068ca [Backport] Dependency for CVE-2019-5802 (1/5)
597dae52a3b [Backport] CVE-2019-5802 (1/5)
64d3770e5e9 [Backport] CVE-2019-5802 (2/5)
a34d2fb5dd1 [Backport] CVE-2019-5802 (3/5)
62f25b2d83f [Backport] CVE-2019-5802 (4/5)
a63d51633ab [Backport] Dependency for CVE-2019-5802 (5/5)
c6d0023bc59 [Backport] CVE-2019-5802 (5/5)
f7fcbe53871 [Backport] Security bug 905509 (1/13)
94f1317917f [Backport] Security bug 905509 (2/13)
812a9e68a2c [Backport] Security bug 905509 (3/13)
36c2c5e8b27 [Backport] Security bug 905509 (4/13)
8b01fa3780a [Backport] Security bug 905509 (5/13)
69b772f1e9a [Backport] Security bug 905509 (6/13)
f2dfd87785a [Backport] Security bug 905509 (7/13)
ec503eae3ed [Backport] Security bug 905509 (8/13)
f5a4144a132 [Backport] Security bug 905509 (9/13)
03d8580cf59 [Backport] Security bug 905509 (10/13)
03c4a4ffb98 [Backport] Security bug 905509 (11/13)
700a4af1fb5 [Backport] Security bug 905509 (12/13)
03be3aa656a [Backport] Security bug 917707
269d53ceabd [Backport] Security bug 905509 (13/13)
d720564a5ba [Backport] Security bug 938251
85136fedbde [Backport] Security Bug 929088
037efcfdba3 [Backport] Security Bug 931640 1/2
bea83ccee0f [Backport] Security Bug 931640 2/2
dd18af1614f [Backport] Security Bug 924905
e54c1076009 [Backport] Security Bug 919572
258feedf8e1 [Backport] Security Bug 919340
f4f1e852df5 [Backport] CVE-2019-5789
8566ec6cc21 FIXUP: [Backport] Security bug 905509 (3/13)
3d59c5717de FIXUP: [Backport] Security bug 906739
dd6863f4aea FIXUP: [Backport] Security bug 905509
43c92056fab FIXUP: [Backport] CVE-2019-5802
d6d21a17c5a FIXUP: [Backport] Security bug 913212
a4a129005d8 FIXUP: [Backport] Security bug 905509
38a6ae037ee FIXUP: [Backport] Security Bug 924905
d147ad350da FIXUP: [Backport] Security bug 905509 (3/13)
Task-number: QTBUG-74445
Change-Id: Ic8d750bc89950c0e020eb43881dbf03328108940
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-74698
Task-number: QTBUG-74251
Change-Id: I4358feb7fb28b226edb24ed10611e797fcd3c326
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/
|
|
|
|
|
|
|
|
| |
Remove the previous workaround (internal \externalpage command) that
was used for this purpose, and replace it with a \QWE macro that
expands to the string 'Qt \WebEngine'. The backslash in the expanded
string instructs QDoc not to attempt auto-linking the word.
Change-Id: If4e1c95423fa07479b1af055e4760a890c0ac667
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
| |
Based on https://chromium-review.googlesource.com/c/chromium/src/+/1432882
Task-number: QTBUG-74764
Change-Id: I74b4711f5146d2d2261487f13ccac702b9aa969e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
The modern media controls in 69-based were not completely ready, so
stay with the legacy media controls until 5.13.
Fixes: QTBUG-74484
Change-Id: I06de16d8210341443a10d8c984f1978d373de0d9
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Some things controlled by the OFFICIAL_BUILD defined are commented as
unsafe to ship in production, so we need that as well.
Note that GOOGLE_CHROME and OFFICIAL_BUILD are two different settings,
so this just denotes the build as one shipped in production.
Change-Id: I1fdcfec7f5c5142dd2bdc5f1d1f9a296a60e5708
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
This logic was incorrectly stripped out in adaptations
for Chromium 68, but is still needed.
Fixes: QTBUG-74519
Change-Id: Iefe7aba352bd43148898c1abeea34f4afe354d72
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
| |
Follow the other implementation and pass TakeFocus to WebContents
Delegate, and hook to our UI from there. Also fixes use of Blur instead
of LostFocus, which means we now render unfocused more correctly.
Change-Id: I34a1882489bc68b9ff36ed5139af0ee8a3a95b79
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
| |
Fixes false navigation type on http-equiv refresh, and javascript
redirects.
Task-number: QTBUG-74490
Change-Id: Ie6fa5c94ae9642a7e9c689198a4977747f4101ce
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-74311
Change-Id: If912564ecd29e4f11a613905f2b9169326207ec2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Add the source files within a "lupdate_run" scope.
Task-number: QTBUG-74152
Change-Id: Idb7b5f58d6f7964b8ed67f34bd9f485bb7bba7b8
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently users might forget to delete webcontent client before
profile adapter. This might be nasty if users are not aware of default
profile. Instead of asserting badly in chromium, clean up and release
chromium resources.
This avoids the crash, but might leak memory if users never deletes
page.
Task-number: QTBUG-74021
Change-Id: I66f466f169d12f7ee08866d505260dca47800bb0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Issue takes place when QQmlApplicationEngine is a child of qApp.
In case WebEngineContext gets destructed do not try to get default
profile, which is anyway already gone.
Task-number: QTBUG-74116
Change-Id: I24ea87baf677360a420d444b4c964feb722ab317
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adapt DownloadManagerDelegateQt::m_currentId to
https://chromium-review.googlesource.com/1144311
Update Chromium:
09516a434b [Backport] Allow DownloadManagerImpl to get InProgressDownloadManager from DownloadManagerService
b3edbf2a84 [Backport] Make DownloadManagerImpl to generate download IDs for in-progress DB
Task-number: QTBUG-70702
Change-Id: I1224643398a2084fcd5d70d2c04b105ed69c1f3d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Installing an event filter on QApplication which uses dynamic_cast will crash
the application since QtWebEngine is sending QTimerEvents to classes without
RTTI information.
Fix by
1. Moving the QObject part of MessagePumpForUIQt into api/ as a private class.
2. Using QTimer directly in WebEngineSettings, without subclassing.
Fixes: QTBUG-73833
Change-Id: Ida73006a4fef76637c964f8f05468adcc4a190ce
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Store the icon type in a bitfield because the same icon URL might be
used for various types on same page. This way webengine won't ignore to
download a default icon what is also set as a touch icon when touch
icons are disabled.
Moreover, do not store the icon types from the previous page because
a subsequent page might use the same icon URL but with different type.
With this change the type of the cached icons are updated after each
page load.
Fixes: QTBUG-70081
Change-Id: I8031a740b07b0c6a8e5759a994f386b13ce87be2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Make sure all \brief descriptions start with an upper-case letter and end with a .
Also start descriptions of \class with the name of the class or struct.
Change-Id: Ifd2656201f9c1dff092085508a5423ce516e2d3f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test tst_Spellchecking::spellcheck crashes when run with
QT_LOGGING_RULES=qt.accessibility.cache.debug=true
which triggers debug output from
QAccessible::registerAccessibleInterface and
QAccessible::deleteAccessibleInterface
These functions are called during the construction/destruction of
BrowserAccessibilityQt. The problem is that BrowserAccessibilityQt is not
necessarily in a valid state at these times: BrowserAccessibilityQt relies on
it's manager to be *fully* initialized yet BrowserAccessibilityQt may be
constructed/destructed *during* the managers construction/destruction.
The solution is to override QAccessibleInterface::isValid to return true only if
the manager is in a valid state too. This disables the debug output and avoids
the crash.
Fixes: QTBUG-72878
Change-Id: Icffe4e503145133c24535fb094bbcb606568e57c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Shut down the ProxyResolutionService before regenerating storage,
it may have pending URLRequests.
Change-Id: If79efc0bc942762dc48a50a12d74593ff1ee3989
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Add warnings for late registration and invalid configuration.
Fixes: QTBUG-72842
Change-Id: I2c103c3b3581112cc885c3a1b4f42c011c3510ab
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: Ibaaa64ace3bff9fe630d9448864587bac8f7b128
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Lost in the transition to Chromium 69 as the function we were using
no longer exists. Reimplemented by how it is now done in NetworkContext.
Change-Id: I05c986f2941c7d5f2b8641adc8c619ec3f75e0b1
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|\
| |
| |
| | |
Change-Id: I4315127d8a329bcb65e6853d4f3625b6dbc55560
|
| |
| |
| |
| |
| |
| |
| | |
Reland fix 04337275e4 after adaptations d5bffb5125
Change-Id: Ieca40fd2ac3d245f760c9b24e2d42d21855b836a
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As more things gets mojofy and become services,
we can not simply delete parts of storage context.
Therefore regenerate whole storage in case of cookie
store, cache, agent settings updates. URLRequestContextStorage
guards correct order of destruction.
This change aims to fix some crashes during cookie store and
http cache recreation when ChannelIDService gets deleted.
Depending on timing this ends with different stacktraces like
in cookie store manager or during ssl handshake.
We still keep network delegate outside of storage context to
prevent crashes when url requests end their life due
to (forced) request cancellation in cancelAllUrlRequests().
Please note this is just band-aid patch, and introduction of
'profile builder' will be a proper fix.
Fixes: QTBUG-71895
Change-Id: If33a7af3ebba2632ea33f32d913e1c21a4534817
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Amend change for clipboard permission f2bdf9af58
Change-Id: I151766a3fc00c105b656bfb646c565a175691139
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Wire page settings into clipboard permissions and add some auto test.
Task-number: QTBUG-72714
Change-Id: If921c65cdff7f55a48340d90fc593071febc6ebe
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
We depended on another header including qopenglcontext_p.h
Fixes: QTBUG-73224
Change-Id: Ifbd7e17cd62b08466ebbe4d2091c92e4091fc8a3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Shutting down the browser runner in single process mode
requires the browser context to be present. Moreover
single mode does not support multi browser context.
For single mode move profile destruction to PostMainMessageLoopRun.
Fixes: QTBUG-45722
Change-Id: I15b5aa17061b4dd7898d0ff9427fada44d2eff74
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were never removing internal download item.
[ChangeLog][Behavioral Changes] Deleting a download item will
now also cancel it if it is still in progress.
Change-Id: I2fab497d7acf7ca6ca17f4a61e106b1c18bfb333
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|/
|
|
|
|
|
|
|
|
| |
We only enable the GLX backends when we have all the X11 dependencies,
but try to build the corresponding sources files even when we don't.
And additional xrandr is no longer a dependency.
Change-Id: I35c97c34c6d121bd6544344a73653900bf406be3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: Ia86459503be86eb9b0d97affe94b7ce82d5e29f1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium's expected timestamp base is the time when the system was
started. QInputEvent::timestamp() returns a timestamp for the actual
platform that may differ from the Chromium's standard.
Use base::TimeTicks::Now() at the input conversion instead. This may
provide less precise but valid timestamp for all cases.
Fixes: QTBUG-72654
Change-Id: I2235344a629072c15f7b16c033e13260093de958
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue was introduced by this Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/1025772/
Add new auto tests for first party url.
Depends on Chromium change:
d2f5d6869f Add net::URLRequest::first_party_url()
Task-number: QTBUG-70790
Change-Id: Ib43bde69990e7fb1d495cc32ac2f6860a613f185
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes setRequestInterceptor take effect atomically, so it's always safe to
delete the interceptor after unsetting it from the profile. On the other hand,
we run into a deadlock if the user code tries to wait for a profile operation on
the UI thread to finish. It seems quite unlikely though that user code would do
that and it would probably still be easier for users to understand and debug
than the current non-deterministic use-after-free problems.
Task-number: QTBUG-72260
Change-Id: I1784a9d9f00029d440508f0bb076d1081a326758
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
1. Extend Qt::Key to ui::DomKey conversion to handle most Qt::Key_Dead_* keys.
2. Supplement Qt::Key to windows key code conversion with a fall back to
DomCodeToUsLayoutKeyboardCode.
Fixes: QTBUG-72655
Change-Id: I9ab8dc5f931065c4dc381adc5a1690ee288b8244
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The QFileInfo::baseName() can’t be used to split the filename
when it contains a dot what is not for extension.
Moreover, use timestamps after 100 numerically deduplicated
filenames as chrome do:
https://chromium-review.googlesource.com/c/1278137
Task-number: QTBUG-66262
Change-Id: Ice548ba2824bd43cf7ad00509b598853087274af
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change improves the documentation of QWebEngineUrlSchemeHandler to
notify the requirement of registering a custom scheme before installing
a custom scheme handler.
Also start showing warnings when
QWebEngineProfile::installUrlSchemeHandler() is called before a scheme
is registered. Also show warnings when installing the handler using
QML.
Task-number: QTBUG-72079
Change-Id: If249592ea43fe2f9ad587a6ff4e8c9dedcc5d3d3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
The xkbcommon configure logic was refactored in
qtbase/c3a963da1f9e7b1d37e63eedded61da4fbdaaf9a.
For more details see the relevant commit.
Fixes: QTBUG-72448
Change-Id: I04a5c7f7d0d64eb6a278560f439a585fba259cb4
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium implements its own ones and we don't want to conflict with them.
This disables the QtVirtualKeyboard's selection handle what is not
functional with QtWebEngine.
Task-number: QTBUG-59999
Change-Id: I6a615a04d5eac1ce2d0392d63ba0fc9039583914
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|