summaryrefslogtreecommitdiffstats
path: root/src/core
Commit message (Collapse)AuthorAgeFilesLines
* Fix compile time warning in profile_qt.cppSzabolcs David2019-03-141-0/+2
| | | | | | | | profile_qt.cpp:210:1: warning: no return statement in function returning non-void [-Wreturn-type] Change-Id: Icdd5355a503b3bdbc8b1073e26f5b3b230fff7e0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-02-157-107/+135
|\ | | | | | | Change-Id: I0822fb8a10945a252cfd1aacaf0b6d9902cc8831
| * Shutdown ProxyResolutionSerivceMichal Klocek2019-02-111-0/+3
| | | | | | | | | | | | | | | | Shut down the ProxyResolutionService before regenerating storage, it may have pending URLRequests. Change-Id: If79efc0bc942762dc48a50a12d74593ff1ee3989 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Better error reporting for QWebEngineUrlSchemeJüri Valdmann2019-02-113-6/+46
| | | | | | | | | | | | | | | | Add warnings for late registration and invalid configuration. Fixes: QTBUG-72842 Change-Id: I2c103c3b3581112cc885c3a1b4f42c011c3510ab Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * macOS: Look for the widevine plugin in the possible new locationsAndy Shaw2019-02-041-2/+12
| | | | | | | | | | Change-Id: Ibaaa64ace3bff9fe630d9448864587bac8f7b128 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Reinstate CT verification using known logsAllan Sandfeld Jensen2019-02-041-2/+11
| | | | | | | | | | | | | | | | Lost in the transition to Chromium 69 as the function we were using no longer exists. Reimplemented by how it is now done in NetworkContext. Change-Id: I05c986f2941c7d5f2b8641adc8c619ec3f75e0b1 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * Merge remote-tracking branch 'origin/5.12.1' into 5.12Qt Forward Merge Bot2019-02-013-92/+58
| |\ | | | | | | | | | Change-Id: I4315127d8a329bcb65e6853d4f3625b6dbc55560
| | * Fix incorrect GLX pbuffer attributes terminatorKirill Burtsev2019-01-091-1/+1
| | | | | | | | | | | | | | | | | | | | | Reland fix 04337275e4 after adaptations d5bffb5125 Change-Id: Ieca40fd2ac3d245f760c9b24e2d42d21855b836a Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Fix recreation of cookie store and channel id serviceMichal Klocek2019-01-092-91/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As more things gets mojofy and become services, we can not simply delete parts of storage context. Therefore regenerate whole storage in case of cookie store, cache, agent settings updates. URLRequestContextStorage guards correct order of destruction. This change aims to fix some crashes during cookie store and http cache recreation when ChannelIDService gets deleted. Depending on timing this ends with different stacktraces like in cookie store manager or during ssl handshake. We still keep network delegate outside of storage context to prevent crashes when url requests end their life due to (forced) request cancellation in cancelAllUrlRequests(). Please note this is just band-aid patch, and introduction of 'profile builder' will be a proper fix. Fixes: QTBUG-71895 Change-Id: If33a7af3ebba2632ea33f32d913e1c21a4534817 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Support offscreen plugin with glx backendMichal Klocek2019-02-152-4/+5
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-63346 Change-Id: Id475c6c88f79af8cf82610a40d07eaa3f6588d7d Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix crash on removing certificates from local storeAllan Sandfeld Jensen2019-02-141-2/+1
| | | | | | | | | | | | | | | | | | | | | I shouldn't cache end when operating on a changing list. Change-Id: I09a69e238675600fde7a7d9bc75dffe1fb22c4eb Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix incrementing download IDTamas Zakor2019-02-141-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | Adapt DownloadManagerDelegateQt::m_currentId to https://chromium-review.googlesource.com/1144311 Change-Id: I74d0165b096d5d02261290a7f84fda420a2b146c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Simplify visual properties handling in RenderWidgetHostViewQtJüri Valdmann2019-02-138-167/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | Replace separate notifications from delegate with one combined notification and change detection. Store view rect, window rect and screen info in RWHVQ to ensure the properties are in a consistent state. Change-Id: Icef8a17e72882f56db249f5553b6cf554e1f91dc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Do not create the native client cert store on every requestAllan Sandfeld Jensen2019-02-112-17/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | Create it once and keep it around. Also contains drive-by coding style fixes. Change-Id: I8b159ae332080b31ed64fab99ad6bb3d8b4d5e3b Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Add link with lld supportMichal Klocek2019-02-111-0/+3
| | | | | | | | | | | | | | | Change-Id: If81ac9311c44160aac28929d37da7a9e6d946a73 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Fix use_gold gn argumentMichal Klocek2019-02-112-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We add already use_gold in toolchain setup, however for default toolchain toolchain_args are ignored, Therefore use_gold has to be set explicilty in linux.pri. Task-number: QTBUG-73216 Change-Id: If1c8f9df998719d88184d0e5eee525b871d682df Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* | | Cleanup client cert store filesAllan Sandfeld Jensen2019-02-1112-215/+307
| | | | | | | | | | | | | | | | | | | | | | | | The files were not in the right places and wasn't split correctly in domains. Change-Id: Ia0d3b1c8f9bc6082f338a09cb64c4bb4b1aa16ad Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix -Wreorder warning in ProfileAdapterJüri Valdmann2019-02-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | .../profile_adapter.h: In constructor 'QtWebEngineCore::ProfileAdapter::ProfileAdapter(const QString&)': .../profile_adapter.h:229:9: warning: 'QtWebEngineCore::ProfileAdapter::m_pageRequestInterceptors' will be initialized after [-Wreorder] .../profile_adapter.h:219:13: warning: 'QString QtWebEngineCore::ProfileAdapter::m_downloadPath' [-Wreorder] .../profile_adapter.cpp:79:1: warning: when initialized here [-Wreorder] Change-Id: I3aff0462769abc484845ac0233ad892a4ec9bb0d Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Quiet -Wmismatched-tag warningv5.13.0-alpha1Allan Sandfeld Jensen2019-02-081-1/+2
| | | | | | | | | | | | | | | | | | | | | Change CompositorResource to class to match forward declaration. Change-Id: I603038b99e567a8da2096e48b5b33ec8874594ad Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Only allocate a post data block when postingAllan Sandfeld Jensen2019-02-081-4/+3
| | | | | | | | | | | | | | | Change-Id: Ia50b6689bdb182888aba44faf549d17747624833 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Fix incorrect include of pref_names.hMichal Klocek2019-02-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | kShowInternalAccessibilityTree is not spellchecker related feature. Task-number: QTBUG-73562 Change-Id: Iac2b0d235aae93bcffebe923bfde036d67293074 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Web Notifications APIKirill Burtsev2019-02-0619-5/+1074
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements API for end-user notifications. Co-authored by Allan Sandfeld Jensen [ChangeLog][Profile] Support for Web Notifications API for end-user notifications through QWebEngineNotification Task-number: QTBUG-50995 Fixes: QTBUG-51191 Change-Id: Icebaaa05275a713e801f1f8ecdaaec725fa264c8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Merge remote-tracking branch 'origin/dev' into 5.13Michael Brüning2019-02-0567-92/+4475
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/core/content_browser_client_qt.cpp src/core/content_browser_client_qt.h Change-Id: I3da791a82dab56fd7535ba1e4c0ab1d9ca74f547
| * | | Delete WebContentsAdapter::dpiScaleChanged()Jüri Valdmann2019-02-012-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Unused method. Change-Id: Iebdd2d0e2391b0aa897674c009a26110fbb51131 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | | Delete WebContentsAdapterClient::dpiScale()Jüri Valdmann2019-02-016-58/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's always 1. Change-Id: I1c3d5bc3080da90379f03b6d0819c5656334751e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | | Add extension system and PDF viewer to Qt WebEngineMichael Brüning2019-02-0160-23/+4439
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the Chromium extensiuon system to Qt WebEngine. Currently, it only exposes internal APIs to the internal PDF viewer extension. To load a PDF, simply navigate to it. This feature can be configured via the webengine-extensions flag and is turned on by default. Needs patch in Chromium 71-based to build. Adaptations to 71-based from 69-based include: * Flag out update installation, add crx file dependency * Move PostTask over to 71-based implementation * Move extensions API providers to 71-based implementaion * Don't use custom guest view and mime handler view delegates * Adapt the URLRequestResourceBundleJob to match new interface * Move extension system initialization to end of profile constructor Change-Id: I4fa5149057291bb5847f048534c11820cd7ff58c Fixes: QTBUG-50556 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Move QWebEngineUrlRequestInterceptor::intercept to ui threadMichal Klocek2019-02-047-42/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently interceptor sufferers thread safety issues, when custom profiles are deleted, interceptor is set to be nullptr, however it can be still referenced in IO thread. Since profile was split to ui and io part, where io part can outlive the ui part, this can boost thread safety issues. Since QWebEngineUrlRequestInterceptor is living on ui thread simplify the logic move intercept call to ui thread. This fixes the issue of referencing interceptor in io thread. Add new method to install interceptor setUrlRequestInterceptor, and deprecate old one. Update interceptor install method name on page to match the profile one. Task-number: QTBUG-69844 Change-Id: I5dd2b6b734fd91906cccc6c1408ffbe7b1b4250c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Move url_request_notification to own unitMichal Klocek2019-02-044-135/+257
| | | | | | | | | | | | | | | | | | | | Change-Id: I37a0a7194e339136d73e9c8f7faebb8c97ee2c97 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Add proxy switches handlingMichal Klocek2019-02-0410-27/+219
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds switches for proxy: https://www.chromium.org/developers/design-documents/network-settings [ChangeLog] Uses proxy switches for initial proxy configuration Fixes: QTBUG-71229 Change-Id: I1bc02f20c20d737234c650a18f0e0f7c1c63a464 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Disable error page isolationPeter Varga2019-02-042-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With enabled error page isolation it is not possible to change language of error messages among views because error pages would be rendered in the same dedicated process. The error page isolation is enabled since Chromium 71: https://chromium-review.googlesource.com/1115203 Change-Id: Icc100531596dc8fc1caa927d401f923f1151aa02 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-02-012-8/+43
|\ \ \ \ | |/ / / |/| / / | |/ / Change-Id: I2889e49fe9f71bfc996689feb0f350e09569f611
| * | Fix permission type conversionKirill Burtsev2019-01-311-0/+1
| | | | | | | | | | | | | | | | | | | | | Amend change for clipboard permission f2bdf9af58 Change-Id: I151766a3fc00c105b656bfb646c565a175691139 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | Answer permission checks for clipboard permissionsSzabolcs David2019-01-302-8/+42
| | | | | | | | | | | | | | | | | | | | | | | | Wire page settings into clipboard permissions and add some auto test. Task-number: QTBUG-72714 Change-Id: If921c65cdff7f55a48340d90fc593071febc6ebe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Delete RenderWidgetHostViewQt::m_localSurfaceIdJüri Valdmann2019-01-312-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | Not needed due to m_localSurfaceIdAllocator.GetCurrentLocalSurfaceId(). Change-Id: I004a75a4abb8785fd202266d6a2c96137529dd04 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Delete RenderWidgetHostViewQt::m_latestCaptureSequenceNumberJüri Valdmann2019-01-312-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | It's only used by layout tests, i.e. never. Change-Id: I50c5fdcefa87c6b5077b706599a667d9160a931d Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Implement touch text selection for QQuickWebEngineViewPeter Varga2019-01-3112-5/+1119
| | | | | | | | | | | | | | | | | | | | | | | | Touch handle and touch selection menu are not implemented for widget. Task-number: QTBUG-59999 Change-Id: Ia492e58b83d3ad38cdf6877d468724c399f34367 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add HTTP request headers to custom URL schemes (reland)Allan Sandfeld Jensen2019-01-307-7/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it possible to read extra headers added to the request. This reverts commit 9cbe64c54dee8451794e29f4357ccfac6d883e6b. Task-number: QTBUG-69844 Change-Id: I5c5e0c06655d5f764227fdc97fdb0c2a189f532d Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Fix -no-ssl buildPeter Varga2019-01-302-0/+10
| | | | | | | | | | | | | | | Change-Id: I20ca768b2ca5be0992d62c4ce4a32f572169b5bd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add API to set default download pathTamas Zakor2019-01-303-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add functions and property to set the default download location in QWebEngineProfile and QQuickWebEngineProfile. Also add new test for check uniquifying download filename. Update plugins.qmltypes to 1.9 [ChangeLog][Profile][QtWebEngine][QtWebEngineWidgets] Add functions and property to set the default download location in QWebEngineProfile and QQuickWebEngineProfile. Task-number: QTBUG-66262 Task-number: QTBUG-72176 Change-Id: I7fa93b66c326766b176aec24d453dd75602b91de Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Adaptations for Chromium 71Allan Sandfeld Jensen2019-01-2856-302/+388
| | | | | | | | | | | | | | | | | | | | | Change-Id: Ib650113b05dfd4771240804f94e33c07aa317bf2 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix Sandbox V2 to work on macOSAlexandru Croitor2019-01-283-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The renderer process crashed on macOS because sandboxing was not enabled. The patch does two things to fix that: 1) Initializes the Seatbelt Sandbox in processMain(). 2) Exposes a content::getQtPrefix() function that will be used by SetupCommonSandboxParameters in sandbox_parameters_mac.mm to pass the Qt Prefix path to the sandbox rules in chromium/services/service_manager/sandbox/mac/common_v2.sb The path will be used to allow file read access (required to read ICU data files and other resource files). To check which resources are denied access, start any QtWebEngine app with the "--enable-sandbox-logging" flag, and use Console.app to see the denied requests. Change-Id: I61c0a2d20d5e96c7cc9562fd203fd606dd25d36c Fixes: QTBUG-73089 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | | Adaptations for Chromium 70Allan Sandfeld Jensen2019-01-2840-158/+191
| | | | | | | | | | | | | | | | | | | | | Change-Id: I8bb77784dbc8a0b9debd96a4c49421bd34e6a0df Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Merge "Merge remote-tracking branch 'origin/5.12' into dev" into ↵Liang Qi2019-01-252-9/+31
|\ \ \ | | | | | | | | | | | | refs/staging/dev
| * | | Merge remote-tracking branch 'origin/5.12' into devAllan Sandfeld Jensen2019-01-242-9/+31
| |\| | | | | | | | | | | | | | Change-Id: I040db21f90766827c84c48dc0ed2d2d623dc011a
| | * | Fix build after qtdeclarative change - 9e3c46961aAllan Sandfeld Jensen2019-01-241-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We depended on another header including qopenglcontext_p.h Fixes: QTBUG-73224 Change-Id: Ifbd7e17cd62b08466ebbe4d2091c92e4091fc8a3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * | Fix crash on exit with single processMichal Klocek2019-01-231-9/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Shutting down the browser runner in single process mode requires the browser context to be present. Moreover single mode does not support multi browser context. For single mode move profile destruction to PostMainMessageLoopRun. Fixes: QTBUG-45722 Change-Id: I15b5aa17061b4dd7898d0ff9427fada44d2eff74 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* | | | Add support for client-certificate selection to QMLAllan Sandfeld Jensen2019-01-242-5/+31
|/ / / | | | | | | | | | | | | | | | Task-number: QTBUG-69363 Change-Id: I54d1df17d82bf2297f43762b0ba86a080bafee23 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add in-memory client cert store implementationVijith Kini2019-01-239-23/+620
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Qt applications using webengine can now use a specific client certificate without affecting(or using) the native certificate store. It sounds useful for consumer applications where the application wants to identify itself to the server as the application and not as a specific user. Change-Id: Ib4fcdfd48e00051e3215f90be8701978902b1fbf Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Merge remote-tracking branch 'origin/5.12' into devQt Forward Merge Bot2019-01-224-10/+28
|\| | | | | | | | | | | Change-Id: Ib374079ded76e43d4b72f725bbf16fe353ef827e
| * | Remove download items internally when API objects are deletedAllan Sandfeld Jensen2019-01-214-10/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were never removing internal download item. [ChangeLog][Behavioral Changes] Deleting a download item will now also cancel it if it is still in progress. Change-Id: I2fab497d7acf7ca6ca17f4a61e106b1c18bfb333 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>