summaryrefslogtreecommitdiffstats
path: root/src/core
Commit message (Collapse)AuthorAgeFilesLines
* Doc: Add dependency to the CMake manualTopi Reinio2021-11-191-0/+1
| | | | | | | Fixes (qdoc) warning: Can't link to 'Versionless commands' Change-Id: Ia2940a3b244df57cdefe386734bdac0df18cd039 Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
* Add cmake api for 'bdict' dictionary conversionMichal Klocek2021-11-172-0/+132
| | | | | | | | | Fix spellchecker example and test to use new api. Note we should not use qt6 prefix in cmake api in examples. Change-Id: Ib800bf2b7bd83e10060fa01ccd8d4a262752e09b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Use new x11 native interface to query xdisplayMichal Klocek2021-11-171-3/+5
| | | | | | | | | | | | | | | | | | | | | The call to nativeResourceForScreen can return egl native display handle if called with "display", since it gets mapped to XLibDisplay but egl device intergration can return EGLDisplay. This is not the case for nativeResourceForIntegration. Use new native QX11Application interface to query for display, note there is not need to use nativeResourceForScreen for "display" anyway since qt does not support multiple x connections to different displays. This fixes places where code queries "display" and bails out if it is null. Fixes: QTBUG-97472 Pick-to: 6.2 6.2.2 Change-Id: Ibc5f8f96e612389bfa24a81268202c9e47a7580b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash in Quick file system access dialogsSzabolcs David2021-11-171-1/+1
| | | | | | | | | | | | In Quick examples, providing any answer to ui::SelectFileDialog::Listener results immediate destruction of FilePickerController and its m_isHandled flag remains false before the controller is destroyed. An "unhandled" controller calls reject() in destructor, so the controller will be answered twice. Pick-to: 6.2 Change-Id: Iaff5b0f4f54b0b11a447ac624f5652e592a88e6e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Do not access accessibility from qt post routinesMichal Klocek2021-11-164-2/+18
| | | | | | | | | | | | | | | | | | | It seems accessing accessibility from qt post routines ends badly since caches are gone already. Add closingDown() function to web context, which is similar to QCoreApplication::closingDown(), however return true on post routine. Guard delete accessibility calls. Note the widget part is not necessary, but added for completeness, since only qml can release profiles due to garbage collection. Fixes: QTBUG-90904 Pick-to: 6.2 6.2.2 5.15 Change-Id: Ic0e7115cd17eb58f3d58f70fefbc197dfb7a6493 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Doc: Fix qdoc warnings and enable zero warning limitVenugopal Shivashankar2021-11-152-5/+9
| | | | | Change-Id: Ifa2914e7bca9c224670a1891785d0ba8262cd61b Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Do not force off DoH upgradeAllan Sandfeld Jensen2021-11-151-2/+0
| | | | | | | | This should enable use of system DoH settings on macOS and Windows Task-number: QTBUG-98284 Change-Id: Iab019e46341f55146224df6830bc7902db85ff40 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Add CF_HTML clipboard format handlingPeter Varga2021-11-133-0/+189
| | | | | | | Fixes: QTBUG-92539 Pick-to: 6.2 Change-Id: Iece974e7b045bd793ceb8870f370803bf2524c33 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Re-enable network-service-in-processAllan Sandfeld Jensen2021-11-111-0/+1
| | | | | | | | | | The network-service isn't sandboxed anyway, so there is no added security by the process separation. Pick-to: 6.2 5.15 Fixes: QTBUG-84105 Change-Id: Ie3fbda26f0cf8f31166b37a8537b7e1b6d11b560 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Check if xkb extension is presentMichal Klocek2021-11-101-0/+6
| | | | | | | | | | | | | According to docs: "You must call XkbQueryExtension or XkbOpenDisplay before using any other Xkb library interfaces" Task-number: QTBUG-97472 Pick-to: 6.2 Change-Id: I84c1bc49b077224a93d9f8d7a9ac29fe089de13e Reviewed-by: Liang Qi <liang.qi@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Add qmake profile naming changes to docsMichal Klocek2021-11-101-0/+7
| | | | | | | Pick-to: 6.2 Task-number: QTBUG-97836 Change-Id: If32e78144695cefd5ff6092bfd3b845c04891dd7 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Fix proprietary codes feature referring to qmakeMichal Klocek2021-11-101-3/+4
| | | | | | | Fixes: QTBUG-97926 Pick-to: 6.2 Change-Id: I2abba9044d64765fca48d987c70494792529f6ca Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix some issues with icu for dict toolMichal Klocek2021-10-283-5/+21
| | | | | | | | | | | | | | | | The dict tool can be run during the build, therefore copy just in case icu data file to tool application path, so it does not require installation and can run no matter if it is a prefix non prefix build. Guard for webengine_system_icu since there is no icu file in that case. Remove awesome looking genex from examples. Pick-to: 6.2 Change-Id: I2fd5ecf6c99ae1d003a1ac1c7bce2bb61a05f73f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix setup for 'no-prefix' buildsMichal Klocek2021-10-281-21/+14
| | | | | | | | | | | | | | | | | | | QT_SUPERBUILD is never cached and user can run only qtbase as super build and compile any other module as separate module build, moreover this can be also 'no prefix' build. Fix missing checks to support that case and clean up install of resources. For mac framework builds copy bundle to right place in case of 'no-prefix' builds. Fixes: QTBUG-94604 Task-number: QTBUG-96375 Pick-to: 6.2 Change-Id: I4ab7d4fed2c2be93f2a048a510419849361883ba Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add onTouchSelectionMenuRequested QML handlerBalazs Egedi2021-10-262-14/+28
| | | | | | Task-number: QTBUG-85043 Change-Id: Iecd2f5ae20fcf031937a1d44cc154f2e2a3ff52f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Do not open screencast in DevTools by defaultSzabolcs David2021-10-251-0/+6
| | | | | | | | | | If screencastEnabled preference is not found, ScreencastApp.ts defaults it to true. This happens at the first start of a browser application. Task-number: QTBUG-96942 Pick-to: 6.2 Change-Id: I15788737640cfe07c0016b31fc471906452aad1b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix rendering deadlock for software compositingKirill Burtsev2021-10-201-3/+6
| | | | | | | | | | With software compositing render thread of Qt's scene graph and Viz's thread may hit the same mutex inside output surface during frame update. Pick-to: 6.2 Fixes: QTBUG-97598 Change-Id: Ic02e161f7b16b22c9099b93f2b1a91e78347975f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Get rid of TODOs in WebChannel GIN codeAllan Sandfeld Jensen2021-10-141-14/+9
| | | | | | | | | The nodiscard values can be Check()ed. Pick-to: 6.2 Change-Id: I9ee38ca3404c4013c6cda6d3d0833529c2b59105 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Add Chromium attributions targetMichal Klocek2021-10-143-0/+26
| | | | | | Pick-to: 6.2 Change-Id: I4e659dffa119a8c9f41a266cd71e9afb9c36362e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove the rest of qmake based configurationMichal Klocek2021-10-1414-894/+0
| | | | | | | | | | The only not cover part in cmake port are: * ios builds for qtpdf * qt static dependecies for qpdf Pick-to: 6.2 Change-Id: Iefe624c35d847b4a9c3cd970192487340b1657f9 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Workaround for downloading file into the root directory on WindowsPeter Varga2021-10-121-0/+8
| | | | | | | | | | | | | A bug in QtBase breaks downloading files into a root directory on Windows (eg. C:\): QTBUG-85997 Check if the "non-existent" directory is an existing drive and do not cancel the download in this case. Fixes: QTBUG-96855 Pick-to: 6.2 Change-Id: Icf0e472df723fc4f6ad36f4560509aafa69e3582 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix pinch gesturePeter Varga2021-10-122-1/+8
| | | | | | | | | | | | | | | Pinch gesture on a touchpad is expected to zoom-in and zoom-out. It has been broken since the pinch gestures are routed because for routing the event target has to be found. The event target is only tried to be found on a pinch begin gesture. As a fix, handle Qt::BeginNativeGesture and Qt::EndNativeGesture events too. Fixes: QTBUG-96930 Pick-to: 6.2 5.15 Change-Id: Ic8fe5bee933b5e0fbc8f5ba6234363a0a625648d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Block CORS from local URLs when remote access is not enabledAllan Sandfeld Jensen2021-10-122-7/+43
| | | | | | | Pick-to: 6.2 5.15 Task-number: QTBUG-96849 Change-Id: I0e0a1530b8b31341c632a1fd00abd339b5152da0 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Skip unnecessary commands when cross-building toolsJoerg Bornemann2021-10-111-0/+1
| | | | | | | | | | Call qt_internal_return_unless_building_tools() directly after qt_internal_add_tool() to avoid having to special-case code for when this function only creates imported targets in cross-builds. Task-number: QTBUG-85084 Change-Id: If43de0acd45b53032cae25ce0062c390e3f7abf2 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Do not wait on weak_pointer for termination errorsAllan Sandfeld Jensen2021-10-061-2/+2
| | | | | | | | | | We invalidate the weak pointer factory before waiting on the error callback, meaning it will never come. Pick-to: 6.2 5.15 Task-number: QTBUG-96928 Change-Id: Ia5091f7398e79f835ce34dfd48f3c36859382b53 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix leak of properties after XkbRF_GetNamesPropKirill Burtsev2021-10-051-1/+11
| | | | | | | | | | | | Struct _XkbRF_VarDefs for XkbRF_GetNamesProp needs special cleanup logic, but it's currently missing from API: https://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/issues/6 Workaround it with manual deinitialization. Pick-to: 6.2 Change-Id: I3ebe20f58199277521b31b2cd8034c92fd1f2b7f Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix leak on getDefaultScreeenIdKirill Burtsev2021-10-051-0/+1
| | | | | | | | | XRRMonitorInfo struct is supposed to be cleaned-up after getMonitors with a separate call to freeMonitors. Pick-to: 6.2 5.15 Change-Id: Iacc296d1f5e434a1d52798fe09d57833660b7952 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix theoretical use after moveAllan Sandfeld Jensen2021-10-021-8/+5
| | | | | | | We can't recover from a failure to post Change-Id: I6a5addf7346e36112e16878e3173048cf85fb7b5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix use after delete with self assignmentAllan Sandfeld Jensen2021-09-301-1/+4
| | | | | | | | Not sure this is actually used. Discovered in static analyzer Pick-to: 6.2 Change-Id: I1c143002e5da1ec809887626e348ea08a74b3715 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix move of moved valueAllan Sandfeld Jensen2021-09-301-1/+1
| | | | | | | | Do not call the copy to selection with the unique data source pointer. Pick-to: 6.2 Change-Id: Ie2c60e3efd2eb4e634bf95f8bdbe1ba8f1f89301 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix seeking on null QIODevice in pathological corner caseAllan Sandfeld Jensen2021-09-301-1/+1
| | | | | | Pick-to: 6.2 Change-Id: I5b242bc27f27a844d9d2fe0725e2a1f48e50b25b Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix WebChannel when JavaScript is disabledSzabolcs David2021-09-272-9/+9
| | | | | | | | | | | | | WebChannel was not working in ApplicationWorld with JavaScript disabled in MainWorld, because WebChannelIPCTransport::DidClearWindowObject() is called only when the window object was cleared in the main world. Moving the WebChannelTransport installation logic to DidCreateScriptContext() works in other worlds, so fixes the problem. Task-number: QTBUG-88875 Pick-to: 6.2 Change-Id: Ia75613b66a1e049f617f0664684b153b6875e9de Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix no webrtc buildsMichal Klocek2021-09-261-2/+6
| | | | | | | | | | | In case of ozone x11 backend we need x11, which is pulled by use_webrtc_x11, however in case of no webrtc build we lack x11 dependency. Add missing dependency. Change-Id: I19eada846115073251cdf85ce1fabd4d1d2baf2e Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 630062f1189b95689e28e40c5c76d95d3214d123)
* Doc: Fix QDoc warnings for licensing documentationTopi Reinio2021-09-241-0/+16
| | | | | | | | | | | | | | licenses.py takes the value of the URL attribute directly from Chromium's license attribution files, and uses it as a link target for QDoc's \l command. Some of the URLs are not valid, however. Add \externalpage entries for the invalid ones to either direct to the correct URL or to expand to an empty '#' link. Pick-to: 6.2 Change-Id: I06e9c54bceb5465c89de115cb8cd8aa0e75e9c51 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Remove our handling of IME hidden text supportAllan Sandfeld Jensen2021-09-224-22/+4
| | | | | | | | | | QtBase should be disabling it now, if not supported. Pick-to: 6.2 Change-Id: I79bae11764d3cbaba1ae1e0987bf0a472eee3325 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Add run-time getter of patch levelAllan Sandfeld Jensen2021-09-222-0/+13
| | | | | | | | Unfortunately it requires manual updating, unless we agree on a separate place to store it. Change-Id: Ib150afec05005b05b254ef5aeb143f5187ea969d Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Make example consistent with documentationAllan Sandfeld Jensen2021-09-211-2/+2
| | | | | | | Pick-to: 6.2 Fixes: QTBUG-96002 Change-Id: Ib7434b568ffa0ad7998eaf66a8d989fc3cd2aa1d Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix build when xcb only over egl/es2Michal Klocek2021-09-181-2/+3
| | | | | | | | | | | Qt's xcb can be compiled without the glx support, do not use Chromium flag to check that. Fixes: QTBUG-96398 Change-Id: Ie7f1fe74699cd83aee1f9e5aff59760d4d7a70bf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 0fba07e0238a9ff0a1b496eae60ad92257ea76af) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Rename Quick examples' folder from webengine to webenginequickBalazs Egedi2021-09-132-2/+2
| | | | | | | | Fix webengine directory path in project files and comments Pick-to: 6.2 6.2.0 Change-Id: I06ed9ee41111e7135fa9feb152ad2a5eb2262b76 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove check for profile directory from favicon service factoryKirill Burtsev2021-09-111-3/+0
| | | | | | | | | | | | | Since the directory itself in initialized asynchronously this check may lead to desynchronization with how profile is considered to be off the record and what it really is. Subsequently, with a possible wrong initialization of a favicon service with invalid history service for non-otr profile. Pick-to: 6.2 6.2.0 Fixes: QTBUG-95580 Change-Id: I66fbb7914a303650490e1577989beee5cd883037 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix drag and drop againAllan Sandfeld Jensen2021-09-101-2/+2
| | | | | | | | | | Return the right QObjects Fixes: QTBUG-96308 Change-Id: If04be10fe19db6b8c0552c7df588961c711c1250 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit e85e4ab275fb0a0c072f19ed3d5c5b5b46de8321) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Stop listing Adobe Flash as a featureAllan Sandfeld Jensen2021-09-091-47/+1
| | | | | | | | This has been removed Pick-to: 6.2 6.2.0 Change-Id: I9f4be83d584427935bccfff3f23419a49c1664a4 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update ChromiumMichael Brüning2021-09-091-0/+5
| | | | | | | | | | | | | | | | | | Submodule src/3rdparty f8a944bb..202e3447: > [Backport] CVE-2021-30566: Stack buffer overflow in Printing > [Backport] CVE-2021-30618: Inappropriate implementation in DevTools > [Backport] CVE-2021-30616: Use after free in Media. > [Backport] Security bug 1227228 > [Backport] Security bug 1239116 > [Backport] Security bug 1216595 > [Backport] Security bug 1206289 > [Backport] CVE-2021-30613: Use after free in Base internals Pick-to: 6.2 6.2.0 Change-Id: I52c611ae7029baafcc182a6d66890f4bfff81d34 Fixes: QTBUG-96209 Task-number: QTBUG-96292 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Support more module flags for 'configure' scriptKirill Burtsev2021-09-093-11/+38
| | | | | | | | | | | | Support flags passed to main 'configure' and separate 'qt-configure-module' scripts with flags like '-no-build-qtpdf', '-webengine-full-debug-info', '-no-webengine-jumbo-build', etc. Fixes: QTBUG-95717 Pick-to: 6.2 6.2.0 Change-Id: Ia12602e9a9b31f4f2256f983f6c1e3fbe50cb9e3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Disable FTP supportAllan Sandfeld Jensen2021-09-081-0/+1
| | | | | | | | Will be gone in 92 anyway, so avoid it in 6.x Change-Id: Idc1d58bcda6ee7edb81f7b468ff548cc370e40ec Pick-to: 6.2 6.2.0 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add the documented configure commandline optionsJoerg Bornemann2021-09-071-0/+13
| | | | | | | | | | Add the missing src/core/api/qt_cmdline.cmake file that defines the commandline options that are documented in config_help.txt. Pick-to: 6.2 Task-number: QTBUG-95717 Change-Id: I54c88a5bfbfb1f497ee60f3e023b96317f385526 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Make configure -list-features workJoerg Bornemann2021-09-071-8/+11
| | | | | | | | | | | | | | | | | | To list features, qtbase's QtProcessConfigureArgs.cmake must include the configure.cmake files. It includes all configure.cmake files that are in directories that are registered with qt_commandline_subconfig in the repository's top-level qt_cmdline.cmake. Add such a qt_cmdline.cmake files and add only src/core/api, because its configure.cmake is the only one that lists public features. Guard find_package calls in that configure.cmake such that they are not executed when configure's initial feature gathering phase is run. Pick-to: 6.2 Fixes: QTBUG-96196 Change-Id: If61774f467c4df6138f9b63c4c1326a561178af6 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix handling of new window requestKirill Burtsev2021-09-052-27/+10
| | | | | | | | | | | | | | | | | | | | Fixes heap-use-after-free for WebContentsAdapter, which is replaced in the case, when new window set to be opened and adopted by the same page, which triggered this request: for example, when 'this' is returned by 'createWindow' override. Achieve this by scheduling 'deleteLater' on an old adapter. This was already implemented that way for internal 'adoptWebContents', but was overlooked for page's 'createWindow' API. So just unify handling logic. Also, adapt 'customUserAgentInNewTab' test, since adopting existing WebContents from different profile is not supposed to work, and now enforced by the check in 'adoptWebContents'. Unfortunately, test should also be blacklisted, since it's appeared that custom user agent is still not reliably set for newly created window. Task-number: QTBUG-76249 Fixes: QTBUG-94772 Pick-to: 6.2 Change-Id: Ic9dff33eae99cc242a294d45a92be96306cef93d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Enable no opengl buildsMichal Klocek2021-09-044-5/+15
| | | | | | | | | | | | | By mistake opengl was marked as required library, but should be just optional. Fix compilation issues. This should enable build on yet another coin node. Pick-to: 6.2 Change-Id: Id87404928e6b042d902fcfe0a7fed99a6806456f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Adjust install and copy path for locales and resourcesMichal Klocek2021-08-311-11/+19
| | | | | | | | | | | | In case of top level build with prefix, make sure we also copy resources and locales to build dir, so tests can be executed without installing. Pick-to: 6.2 Task-number: QTBUG-95590 Change-Id: Ie64e650259b2c38a6eda8d15a94f7101ad8380a8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>