| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I0d52e4f6684425cb15319760e0001bdb13846997
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep the custom file name if the calling order of setDownloadDirectory()
and setDownloadFileName() changes.
Also do not emit patchChanged signal twice if setDownloadDirectory()
changes the uniquifier of the file name.
Add TempDir for qml auto tests what uses QTemporaryDir() to create
temporary directory for downloads.
See https://cgit.kde.org/messagelib.git/commit/?id=2c113dcb155b11bf2c0af3c85544962485784b26
for details.
Fixes: QTBUG-80566
Change-Id: Ia76f263558eaf55cb297700407948523788c6229
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
This makes reviewing API etc easier.
Change-Id: Ib6cfa74cb130cf1085d6af24eaaa0b9cf403889b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Implements suggestions from 5.14 API review:
- Replace QString with const QString &
- Extend documentation
Change-Id: I08365767128aa72bc7ef2356c761c2abe512e4eb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add functions and property to change the download directory and
file name in QWebEngineDownloadItem and QQuickWebEngineDownloadItem
and deprecate the path() and setPath().
Regenerating the uniquifying download filename after
change the download directory.
[ChangeLog][DownloadItem] Add functions and property
to change the download directory and file name in
QWebEngineDownloadItem and QQuickWebEngineDownloadItem
and deprecate the path() and setPath().
Task-number: QTBUG-56978
Change-Id: I6e63da82a187add8bc3206cc80c8bf6865fbdd35
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][DownloadItem] Add functions and property
to get the suggested download file name.
Task-number: QTBUG-56978
Change-Id: I902870c6358271322da613a15ccc11639384e404
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-72996
Change-Id: I8af67d69a9a88ccbc95e37a252615dd3fd3ca0ca
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
To be able to determine where a download was triggered.
[ChangeLog][DownloadItem] Added a page/view accessor to tell were
the download was triggered.
Change-Id: I21843a545a3e0eb66f5e5fa8a50e77564f2118a7
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously configure was generating two config headers
qtwebengine-config.h and qtwebengine-config_p.h, however
those headers were never installed or included as dependency
in Makefiles. Moreover, due to the name clash all features
were included into qt_lib_webengine_*.pri which is
QtWebEngine QML module.
Move configure to core so all features belong now to
qt_lib_webenginecore*.pri. Fix global includes to include
qtwebenginecore-config*.h.
Drop all DEFINES and use QT_CONFIG instead.
Cleanup all evil looking includes in headers for webengine and
webenginewidgets.
Change-Id: Iddbc8bf4487d9a5f0c19a71a9569535083507756
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the download type property from QtWebEngineCore and replaces
it with a simple boolean 'isSavePageDownload'. On the public API boundary the
type property is reimplemented via this boolean and documented as obsolete.
Rationale being that
1. This feature seems to lack practical use cases, other than perhaps
distinguishing save-page downloads from normal file downloads, which can be
done in a much simpler way.
2. This feature does not work as documented and never has. So far nobody has
complained, hinting again at a lack of practical use cases.
3. In order to fix it we would need to maintain patches on top of Chromium and
Blink (we would, for example, need to propagate the DownloadAttribute type
from Blink to Chromium to WebEngine).
[ChangeLog][Deprecation Notice] (QWebEngine)DownloadItem::type() is deprecated
and replaced with the newly introduced isSavePageDownload() property.
Task-number: QTBUG-62640
Change-Id: Icf4e1e5a635028986df7eab979f4c0527902ff0c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
| |
Adds the ability to pause downloads, and resume paused or interrupted
downloads.
Task-number: QTBUG-56840
Change-Id: I018bd30c3a772a36d48e4154d94f69cb8d8319e4
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A method was added to get a textual description of a
Q(Quick)WebEngineDownloadItem::DownloadInterruptReason.
Basically returns the same description from the QDoc entry, but
shortened where that was to long.
Also moved the ASSERT_ENUMS_MATCHes from
download_manager_delegate_qt.cpp to the newly created
browser_context_adapter_client.cpp.
Task-number: QTBUG-56839
Change-Id: I17c68987b7f12fcaeb71fd27f7ebb35c0ac87bac
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Add FINAL and CONST declarations for every Q_PROPERTY where it is
appropriate. This speeds up the execution in QML.
Task-number: QTBUG-55912
Change-Id: I67d2223d87aee6bdc639fe6087e3364201f2b1c6
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add enum DownloadInterruptReason to BrowserContextAdapterClient,
QWebEngineDownloadItem and QQuickWebEngineDownloadItem. Also add
corresponding attributes to
BrowserContextAdapterClient::DownloadItemInfo,
QWebEngineDownloadItemPrivate and QQuickWebEngineDownloadItemPrivate
as well as getters in QWebEngineDownloadItem and
QQuickWebEngineDownloadItem and interruptReasonChanged signals.
Task-number: QTBUG-56839
Change-Id: I937c14ba0b0884b14ae18ba297024b76dde62605
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
With this property the user gets the requested download's type.
In other words, the user can identify the download where it comes from
based on the type.
Update public API list as well.
Change-Id: I2b066d7eb4df1134266ad67ade0066e3bcc2b454
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: I53645ee5405b1c43807123fd3c196e314cfd1ce9
|
| |
| |
| |
| |
| |
| |
| |
| | |
The mimeType property of the WebEngingeDownloadIten is tagged for REVISION 1
so the related signal should be tagged for REVISION 1 as well.
Change-Id: I918de55c81779424011e42c358d5c7aeed2909ee
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This property is new in Qt 5.7 / QtWebEngine 1.3
Task-number: QTBUG-52338
Change-Id: Ib15a219bd1ec1e542d1c5c13a812b0022485485c
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Update files using old header.LGPL3 to use header.LGPL
Update files using old header.FLD to use new header.FDL
Update files using old header.BSD to use new header.BSD
Change-Id: I36a67aaa8c3ca6c7946308defc9c03c3571a7d23
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
|\|
| |
| |
| | |
Change-Id: I4272eb59cac08c69eaa58dd4d94debf1b8c5cf78
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
An application currently have to rely on suggested filename only to
guess the type of a download. This is often insufficient when the suffix
is misleading or missing.
This patch adds the mimetype to the reported metadata and also adds
a mimetype appropriate suffix to suggested filenames.
Task-number: QTBUG-48206
Change-Id: I4c70f076d6eb5ae820fd6b7f568515eeb7c18df5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
|/
|
|
|
|
|
|
| |
Add the possibility to save web pages as single HTML file,
complete HTML (with resource directory) or MHTML archive.
Change-Id: Ic7e7cfda9432f3534c13350a6369d79bb17fd8b3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
This makes the enum values available as strings in qDebug,
QCOMPARE and such.
Change-Id: Id57a2002451337fcc8aedac673f834445913895c
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
qquickwebenginedownloaditem_p.h:74: warning: Failed to parse token ( in property declaration
Change-Id: I4d9bb4eed5f6fbcc4b81fdad94577f9f06daca39
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
|
|
|
|
|
| |
Change-Id: I95ae03b34631f166d2eed68e20282eb624ff408a
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
Qt copyrights are now in The Qt Company, so we could update the source
code headers accordingly. In the same go we should also fix the links to
point to qt.io.
Change-Id: Ieb6bac7a1be5c25eb7cb917495b58b6a870ca6d4
Reviewed-by: Pierre Rossi <pierre.rossi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename the download signal to downloadRequested and only start a
download if it has been explicitly accepted by the user, else cancel
it by default.
Replace the downloadPercentage property with totalBytes and receivedBytes
to also give the user information about download size.
Additionally this patch adds missing documentation.
Change-Id: I9d895386cf033f2efffe3ebac6f08f94c6fe0c19
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
Reviewed-by: Jocelyn Turcotte <jturcotte@woboq.com>
|
|
|
|
|
| |
Change-Id: If703ff2e5d8fd8ebfe92ad1ac3603c1abe5c7e53
Reviewed-by: Pierre Rossi <pierre.rossi@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
- Also fix the qtwebengineglobal_p.h header include in quickwebneignedownloaditem_p.h,
because it is searched for wrong manner from the tst_publicapi testcase.
Change-Id: I8997fafbf198f19a3d54b194f3408def6370417e
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
This patch exposes downloadStarted and downloadFinished
signals on the WebEngineProfile to notify about downloads.
The WebEngineDownloadItem exposes a subset of Chromium's
content::DownloadItem functionality.
For now we expose minimal requirements to be able to control
downloads in QML but this can be extended in the future.
This patch also adds a DownloadView to quicktestbrowser
to demonstrate the usage of the new API.
[ChangeLog][QtWebEngineQML] Add QtQuick download API
Change-Id: I8d8f0daf02c4e0151000427fc2a4b37d28b9db52
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|