| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Check whether iconUrls is NULL before calling contains(iconUrl) on it,
which, under certain circumstances, caused a SEGFAULT.
Task-number: QTBUG-56330
Change-Id: Ia167d68a4c4d62af4740a8cbab2686bfbc975455
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
Change-Id: I49d99b5ac2cfba243eda1ea705c2a7d71b5542f6
|
| |
| |
| |
| |
| |
| |
| |
| | |
We do not share context between "processes", but between
"threads"
Change-Id: I20f558f913c1f19fc469ade6faab45762f42d528
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|\|
| |
| |
| |
| |
| |
| | |
Conflicts:
src/webengine/api/qquickwebenginesettings.cpp
Change-Id: Ib7e2a7558c685410c49c455218d3b9c30f32358f
|
| |\
| | |
| | |
| | | |
Change-Id: I3e152ee134ed38628d1bf9571df58f469b29e74b
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a link triggers a NewViewRequest, and the latter creates
a new window with a new WebEngineView inside, the "adapter" pointer
can still be NULL when the adoptWebContents is called by openIn.
Therefore is it necessary to test the adapter pointer before using it.
(cherry picked from commit bfc2683ab4ca3f56a2effd1b2f7e68850acb72ba)
Task-number: QTBUG-55765
Change-Id: Iaa7cb4e8c7780a2e3f1a8c85b7b5da0ec541b2f3
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ie355f72a0bf575e66ab465fb2fcada0430ed8c7c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a link triggers a NewViewRequest, and the latter creates
a new window with a new WebEngineView inside, the "adapter" pointer
can still be NULL when the adoptWebContents is called by openIn.
Therefore is it necessary to test the adapter pointer before using it.
Task-number: QTBUG-55765
Change-Id: Ia1a299dd65c229705462c9444b81d7b26567fc09
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ibb470580404f2b09dc8c7c2de275ade97251d612
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|\| |
| | |
| | |
| | | |
Change-Id: I9acebc9f1d01ab9041f75c49749f8a122ffbfe30
|
| |/
| |
| |
| |
| | |
Change-Id: I44105c768a958714590b979d3877724f0db659ee
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/webengine/api/qquickwebenginecertificateerror.cpp
src/webengine/doc/src/webengineview.qdoc
tools/qmake/config.tests/libcap/libcap.cpp
Change-Id: I2a2cfc904a8d6b561fb71ef7a0cc4bfb860124db
|
| |
| |
| |
| |
| | |
Change-Id: I86eea3a64a38f6ec9984f663499abffa03cd9eb2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The docs do not currently get built, because docs for a QML type
need to reside in one file. Also edited the docs for grammar and
style.
Change-Id: Ic62f293e113d0e4bfe0497ce4a665a2a42971eb3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| | |
Change-Id: I8f3aa86b451e57d01937559e595a439529a839ce
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/core/resources/resources.gyp
src/webengine/doc/src/qtwebengine-overview.qdoc
src/webenginewidgets/api/qwebenginepage.cpp
src/webenginewidgets/api/qwebenginescriptcollection.cpp
src/webenginewidgets/api/qwebenginescriptcollection_p.h
tests/auto/widgets/qwebenginepage/BLACKLIST
And readded newly in 5.6 enabled tests to the BLACKLIST.
Change-Id: I4ab1fc54ebfaaf940df81b0d8d6bdd15cae8b7c4
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QExplicitSharedDataPointer is meant for value objects, not for shared
objects. Instead switch to using QSharedPointer.
Change-Id: Ib3791bbcfde627a67508f2819e141d8c538a4a50
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
|\|
| |
| |
| | |
Change-Id: Ic6686df8f82f710a3441501b7eeaffe69fbcbdf7
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If a user does not handle onCertificateError the
instance of QQuickWebEngineCertificateError never
gets to JavaScript land and never gets deleted.
Create a strong reference before emitting the
onCertificateError to guard against the memory
leak.
Change-Id: I49dbf89445d32291e2f52976f0f5e9deda201fcb
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
To ensure Chromium is given a chance to handle editor commands,
we must override these short-cuts.
On OS X we must also perform the action afterwards as these are not
handled internally by the Blink Editor.
The patch solves copy/paste in flash plugins and copy/paste on OS X
when no application short-cuts have been defined. The handling of
short-cut override events is based on how it was handled in Qt WebKit
Task-number: QTBUG-54221
Change-Id: I748671c7bfa5662aae16c6a4b9bbe5e2bce1b907
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I7ce66ad2f1c1c6a408637c5c541cba22c7260591
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: If4d8a25f5a2192a658d031252435935cbc675725
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Suppose QWebEnginePage is destroyed while there's still a combobox popup
open. We would crash with the following stack trace:
1 QtWebEngineCore::RenderWidgetHostViewQt::dpiScale
2 QtWebEngineCore::RenderWidgetHostViewQt::GetViewBounds
3 content::RenderWidgetHostImpl::SendScreenRects
4 content::RenderWidgetHostImpl::OnRenderViewReady
...
16 base::MessageLoop::DoWork
17 WebEngineContext::destroy
18 `anonymous namespace'::destroyContext
19 qt_call_post_routines
20 QApplication::~QApplication
RenderWidgetHostViewQt still holds a pointer to WebContentsAdapterClient.
To fix this, expose the QObject owning the adapter client, and
hide RenderWidgetHostViewQt when it is destroyed so it won't try to render.
Change-Id: Ide5543197b35038a3e1c7491ceda3f5ad10f6f07
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes warnings when building with clang.
Task-number: QTBUG-51295
Change-Id: I4ede7e4ea5c1c3924b3bba852834b8066b539825
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\
| | |
| | |
| | | |
Change-Id: Ic2fad2311550860c5a2f83b6f228a7a648131ece
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The method is documented to be available in the QML API, but hasn't
been exposed so far.
Change-Id: I6f2b8ae132dc10718f1b9181eefeef5c2f2eeed6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\ \ \ |
|
| |\| |
| | | |
| | | |
| | | | |
Change-Id: I561c00b3a844ab493a5bf0148a5923662842cf5d
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Qt Quick Controls 1 always creates "native" windows
for popups, however it does not check if the platform
can support creating "native" windows. As a workaround
disable context menu until Qt Quick Controls 2 are
in place.
Task-number: QTBUG-53467
Change-Id: Iea32e19f256f3d7e81a61e23f7da64dfc7ec660d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently if a QWebEngineView or a QQuickWebEngineView is disabled
using setEnabled(false), after loading a web page, the views are
automatically focused, and a user might see a blinking caret in an html
input for example, even though the user can't interact with it.
Fix consists in not calling the Focus() method whenever a view is
disabled.
Change-Id: I1014fb5898a5ddf01a4e9b14c3eaf5d4006e5131
Task-number: QTBUG-53159
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the qml properties audioMuted or recentlyAudible are accessed / set
on a WebEngineView on application startup, the application will crash
due to accessing a null pointer (the web contents adapter is not
allocated yet).
Add guards against null pointer access, to prevent the crash.
Change-Id: I939be9afa093d1889024b2ff9308deb88b9316bf
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\ \ \
| | | |
| | | |
| | | | |
Change-Id: I00f64f15ec2aee18d8e6c7b5f59dfae49be1cba8
|
| |\ \ \
| | | |/
| | |/|
| | | | |
Change-Id: I01bc98f034ea26414d071fc42fe20bd0b7534b9e
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Building qtwebengine failed with Yocto2.1/GCC5.3 with an IMX.6 ARM
target. Adding the include fixed the issue.
compiling .moc/moc_qquickwebengineview_p.cpp
.moc/moc_qquickwebengineview_p.cpp: In static member function 'static void QQuickWebEngineView::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':
.moc/moc_qquickwebengineview_p.cpp:866:72: error: invalid use of incomplete type 'class QColor'
case 15: *reinterpret_cast< QColor*>(_v) = _t->backgroundColor(); break;
^
In file included from /data/projects/fsl-community-bsp/build/tmp/sysroots/wandboard/usr/include/qt5/QtCore/qobject.h:48:0,
from /data/projects/fsl-community-bsp/build/tmp/sysroots/wandboard/usr/include/qt5/QtCore/QObject:1,
from .moc/../api/qquickwebenginescript_p.h:52,
from .moc/../api/qquickwebengineview_p.h:52,
from .moc/moc_qquickwebengineview_p.cpp:9:
/data/projects/fsl-community-bsp/build/tmp/sysroots/wandboard/usr/include/qt5/QtCore/qmetatype.h:1886:1: note: forward declaration of 'class QColor'
Change-Id: If58315d4c0b5087705687ae582ffe86702063937
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |\ \ \
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/3rdparty
src/core/browser_context_adapter.cpp
src/core/web_contents_adapter.cpp
src/webengine/doc/src/qtwebengine-platform-notes.qdoc
tests/auto/widgets/qwebenginepage/BLACKLIST
Change-Id: I768fc954a9a2147fc3669961286163a0a824def3
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Move some features from the platform notes to the new
topic.
Change-Id: I23bb0593a0e142a18ad4216a03bfe1935965fc10
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\ \ \ \
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/3rdparty
src/core/browser_context_adapter.cpp
src/core/web_contents_adapter.cpp
tests/auto/widgets/qwebenginepage/BLACKLIST
Change-Id: I45ee0a33f6316f585555d58fede8072fe514aecf
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
This appears to have been added to headerclean and is now preventing us
from integrating.
Change-Id: I7c25a85c0d62c945d4f4a68f559000fab8c880cc
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adds the new certificate error CertificateValidityTooLong and adds
asserts to ensure this list is kept up to date in future Chromium
updates.
Change-Id: I6066296c0a09cabcca446f1d0b3e3d458b3f158e
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |/
|/|
| |
| |
| |
| |
| | |
Both property and signal actually where already part of QtWebEngine 1.0
Change-Id: I9534f35199a3c70d78f9f42e3ea6b9f3b462d6b6
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The rest of the spellchecking support was removed with d364c05d.
These notifier signals were left behind, and caused them to be
documented.
Related documentation warnings:
qquickwebengineprofile.h:144: warning: No documentation for 'QQuickWebEngineProfile::spellCheckLanguageChanged()'
qquickwebengineprofile.h:145: warning: No documentation for 'QQuickWebEngineProfile::spellCheckEnabledChanged()'
Change-Id: I3b03f3f22ed984d55c09d6e42a258f961c42c584
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Spellchecking API needs a bit more reviews and love.
Current API is not intuitive and partly broken.
Change-Id: Ie9cd371f38cca2f6b3f56a8699ad874cd332c318
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| |
| |
| |
| |
| | |
Change-Id: I366e35b6de0a46be648de3130eb7d8585fc1a694
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For the Widget API the QIcon returned by QWebEnginePage::icon() function
contains all the candidate icons for the current page.
For the Quick API the QQuickWebEngineFaviconProvider provides the best
quality icon for the requested size from the candidates.
Task-number: QTBUG-51179
Change-Id: I42b8427f957e2f2fc745dd0111bedcc71b577216
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This method is broken, since SpellcheckerService
is lazily initialized and dictionaries might
be not loaded yet. Moreover there is a missing
implementation on mac. Instead log warning
when SpellcheckService can not load dictionary.
Change-Id: Ifa2e769d83307543fa6cdf529475e9ab980022f0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In Chromium 51 WebAudio will be always on, and can not be runtime
enabled or disabled. We should avoid introducing a setting we can
not even support in the next version.
Change-Id: I42f7d4f3f7f952f38361ef73dfe7b318ea1a4cf5
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\ \ |
|
| |\|
| | |
| | |
| | | |
Change-Id: I329397621f19ba3890be5daf44a6bb2d668ad2d8
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ica5adc508113678747c20a9807ad09eaae79ccb1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It turns out that using the temporary zoom factor is meant to set
the zoom factor for one certain view, and this is actually what we
want.
Also added auto tests for this.
Task-number: QTBUG-51851
Task-number: QTBUG-51969
Change-Id: I8912cbc25637d3c1681026380a2ab3068a964868
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>
|