summaryrefslogtreecommitdiffstats
path: root/src/webengine
Commit message (Collapse)AuthorAgeFilesLines
* Document macos specific build limitationsMichael Brüning2023-12-081-0/+4
| | | | | | | | | Universal debug or debug-and-release builds are not supported on macos in Qt 5 due to the way universal build support was added there. Change-Id: Iae59dd5fea5c2a46f22e12cbba41bc4a67a93f65 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Enable accessibility by default on LinuxCarl Schwan2023-04-221-6/+4
| | | | | | | | | | | | | | | | | | | | | Previously this was disabled unless the QTWEBENGINE_ENABLE_LINUX_ACCESSIBILITY was set, as the debian packaging was always enabling accessibility[1] even if a screen reader was not enabled. This is not the case anymore since 5 years ago[2] and now accessibility will only be enabled if a screen reader is detected. Which is the correct upstream behavior of at-spi2-core. So now enable accessibility unless QTWEBENGINE_ENABLE_LINUX_ACCESSIBILITY is set to 0 [1]: https://salsa.debian.org/a11y-team/at-spi2-core/-/commit/2a99b7b40526bbdf091cc574ec08d86c9a46f405 [2]: https://salsa.debian.org/a11y-team/at-spi2-core/-/commit/fde0bbead6aacefd0b5dcf9f6d36f7f50a2c0f3d Change-Id: Ie5554f8b578dcca87a54dad525ae6a83d6f8f9d8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 8f06b3e970f768f6a5776845c83090f1fc8b0162)
* Keep page's zoom level on loading new urlsKirill Burtsev2022-06-012-6/+13
| | | | | | | | | | | | Ammends d236c5a8a3. Zoom level was set as a temporal one, which is invalidated each time when a renderer process or widget are changed (on new navigation, for example), so it needs to be reapplied. Fixes: QTBUG-101030 Change-Id: Iecff9686fbe2b79e99b46f67cab92f66127be085 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 1e27d42a8071532b6cc30a9bcc5f700edc56952a)
* Update documentationAllan Sandfeld Jensen2021-12-151-4/+0
| | | | | | | | | The signal is updated much faster for paused media now. Fixes: QTBUG-98918 Change-Id: Ifa3b54e212436a7c93e101dc244d7edcbf473b63 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit b6099cd9d1efab2af4a38476b3f543796f26f065)
* Do not access accessibility from qt post routinesMichal Klocek2021-11-251-1/+4
| | | | | | | | | | | | | | | | | | | | It seems accessing accessibility from qt post routines ends badly since caches are gone already. Add closingDown() function to web context, which is similar to QCoreApplication::closingDown(), however return true on post routine. Guard delete accessibility calls. Note the widget part is not necessary, but added for completeness, since only qml can release profiles due to garbage collection. Fixes: QTBUG-90904 Change-Id: Ic0e7115cd17eb58f3d58f70fefbc197dfb7a6493 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 89bb3c97eee9cd4bf9fb536f024715e606e49ae0) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix inconsistent number of load signals and their orderKirill Burtsev2021-05-062-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | This change tries to match how chromium treats one single load. Before the pair of loadStarted/loadFinished methods for api classes was called on delegate's DidStartNavigation/DidFinishNavigation, which might be many within one single logical load. This is true for multiple usecases (like multiple redirects on load, immediate form submit on DOM load, page's subresource load, or just an error page load on failure). Tracking these methods and deciding when to emit signals based on states are error-prone and complicates logic for no benefits. Also it somewhat lies about when real load is done, which is only started and finished on outer methods DidStartLoading/DidStopLoading, which are conveniently called only once for all mentioned usecases. So, this change uses these methods to issue signals for load start/finish, and only makes exception for error page, which is needed for quick's private test support. Fixes: QTBUG-65223 Fixes: QTBUG-76802 Fixes: QTBUG-87089 Fixes: QTBUG-90342 Fixes: QTBUG-91773 Fixes: QTBUG-92063 Change-Id: I9cc99b639030fedd8cf6a9dc04d0869d6be6357d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Update platform notesAllan Sandfeld Jensen2021-04-141-2/+2
| | | | | Change-Id: Iafdfb3c740ce42119a9891729be1ea0c89249039 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Depend on QCoreApplication::startingUp() for checking existence of appAndy Shaw2021-04-121-2/+1
| | | | | | | | | | | | | When using QtWebView with WebEngine then it will hook the call to QtWebEngine::initialize() to the start up of the application object which means it will output the warning because it already exists. However there is still time at this point to set what is needed because it is still being initialized. So by checking if the application is running (i.e. !startingUp()) then we can be safe in knowing that it is still able to do the initialization. Change-Id: I8c5d8808b4b09e1e7bbf4be52e5efc0786ce1472 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Notify canGoBack/canGoForward changes based on web actionsJüri Valdmann2021-03-222-2/+9
| | | | | | | | | | | | | | | Before, QQuickWebEngineView's canGoBack/canGoForward change signals are based on urlChanged. But the urlChanged signal may be emitted slightly before the value of canGoBack/canGoForwad actually changes, resulting in a missed change notification. After, they get their own signals, which are forwarded from the QQuickWebEngineAction::enabledChanged signal of the respective web actions. Fixes: QTBUG-91565 Change-Id: Id411eb146c776e2824fd2447660e8857974da32e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix popup positionMichal Klocek2021-02-161-28/+16
| | | | | | | | | This patch fixes popup position when popup have parent window. Make simple offset calculation and add rotated pupups support in another patch. Change-Id: Id53524375eeecbc316dc6f6bef7f32669a72beb3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix mad popup qquickwindows on waylandMichal Klocek2021-02-163-5/+7
| | | | | | | | | | | | | | | | | | | | On wayland with weston the popup quickwindow should have parent otherwise it gets into 'mad' mode and jumps around the screen. This also fixes similar issue on some embedded x11 setups. Adding parent brakes positioning of popups, but the fix is done in followup patch. This patch also has a regression, closing application during opened comobox will cause crash, however before this patch application simply did not remove render process or "hanged" on exit. This issue is also handled in follow up patches. Change-Id: I876b9a5b58a731eee95f30a52a3c2705730631da Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build with Qt 5.12Allan Sandfeld Jensen2021-02-151-1/+1
| | | | | | | No QMap::insert as set or append. Change-Id: Icb05e43c4cb3d45171a164bdda7420d066eab79e Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Remove more leftovers of the old compositorAllan Sandfeld Jensen2021-02-084-28/+6
| | | | | | | Also removes another private dependency Change-Id: Ie0a671c66f9aa49e7001c44e69bf94e11ab058a5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix loadFinished signal if page has content but server sends HTTP errorPeter Varga2021-02-052-2/+5
| | | | | | | | | | | | | | For triggering an error page 3 conditions should be fulfilled: - main frame navigation - the page's document is empty - the HTTP status code indicates an error This fix adds check for the empty document and sends loadFinished signal without expecting an error page if the document is not empty. Fixes: QTBUG-90517 Change-Id: I6463d75fb5e682932feca64b0f059f9aa475795c Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* FIXUP: Doc: Describe the WebEngineView.LoadStoppedStatus enum valuePeter Varga2021-02-031-3/+6
| | | | | | | | | Add description for the WebEngineLoadRequest QML type too. Task-number: QTBUG-57636 Change-Id: I021af3c49e8235b04ce60efa6143b2e547fc65ad Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Update Chromium versionAllan Sandfeld Jensen2021-01-191-1/+1
| | | | | | | Match the already used versions. Change-Id: I8ade97aa38fdc52337a32a0ca92664bb50a0e611 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Update minimum windows sdkMichal Klocek2021-01-181-1/+1
| | | | | | | 87-based requires 10.0.19041 windows sdk. Change-Id: I9c6d09e85836367ebcf9fbb2b8b4d574180d7de5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix position of popup on qmlMichal Klocek2021-01-182-8/+6
| | | | | | | | | | | In case there is no window system with qml simply use screen rect. This will also work well with rotated view (for non windowing system). Task-number: QTBUG-86034 Task-number: QTBUG-89358 Change-Id: Ic042d766d661c8322422b194c08b58609992961b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix blank popups in qmlMichal Klocek2021-01-181-0/+1
| | | | | | | | | | | In qml when on platforms without windowing system we need to send show notification. Note this was not required with old compositor, since it was hooked up differently than viz. Task-number: QTBUG-86034 Change-Id: I3ecdc033802d59c15637bc0e48961cd7748b1c6b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix some warningsPeter Varga2021-01-161-1/+1
| | | | | Change-Id: Ic7cff2556945272761288fedd271796dbf240cb5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Adaptations for Chromium 85Allan Sandfeld Jensen2021-01-131-4/+12
| | | | | Change-Id: I33c1af7c431055d95e0fb540246765cce684de15 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix leak in QQuickWebEngineViewPrivate::contextMenuRequestedAllan Sandfeld Jensen2021-01-121-1/+1
| | | | | Change-Id: Idb41daa68709c769330527a713689241ac073359 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Mention node.js build-time dependencyAllan Sandfeld Jensen2020-10-031-1/+2
| | | | | | | Task-number: QTBUG-87129 Change-Id: Id98aa1e8c839c06022fbc633c0b64c7681205349 Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix favicon engine under device pixel scalingAllan Sandfeld Jensen2020-09-221-2/+21
| | | | | | | | The QIcon::pixmap function does internal scaling messing up our intermediate structures. Change-Id: I727efd58a4cc948fa3e4b23539d97e8ca755d060 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Avoid to reject a certificate error twice in QuickPeter Varga2020-09-161-0/+6
| | | | | | | | Widget API already ignores these cases. This would cause a crash for fatal certificate errors after 83-based. Change-Id: I3e80bb12f023f22e330218a5b20f3e267bb237dc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Ignore QQuickWebEngineNewViewRequest if it is unhandledTamas Zakor2020-08-253-0/+6
| | | | | | | | | | | | This is the case when the WebEngineNewViewRequest.openIn() is not called on newViewRequested(). For example, when opening the view source from context menu in quick minimal example. Fixes: QTBUG-85494 Change-Id: I7c1ae53684361de459b2f268e471904e632821b0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix suggest-override warningsAllan Sandfeld Jensen2020-08-185-9/+9
| | | | | | | Also violates modern Qt code style Change-Id: Ibb12b6db18bbd2669377abe1d25034ed69a86389 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Doc: Document issue with running in Docker environmentLeena Miettinen2020-06-151-1/+8
| | | | | | | | Fixes: QTBUG-80944 Change-Id: Ia77a46fbde89cada32183d9f7dc66c1dae1c7bb5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit f92a4b3028f112616dedac892e379a13e3c53bcd) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Delete unused function editorActionForKeyEventJüri Valdmann2020-05-251-2/+0
| | | | | | | Change-Id: I5fe08380e297cdf8138df0b49b3c82e741f54dd1 Pick-to: 5.15 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 3472641433d0adab3caea008f047aac9637828c4)
* Add support for clearing the feature requestAllan Sandfeld Jensen2020-05-201-4/+6
| | | | | | Task-number: QTBUG-83476 Change-Id: I63ad9801e3e97f7fdac959600c69c04d0105be1f Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Document abiltiy to set QTWEBENGINE_CHROMIUM_FLAGS from within appFredrik Orderud2020-05-201-0/+3
| | | | | | | | | | Using qputenv worked fine for setting this env. variable on Windows, whereas SetEnvironmentVariable did _not_ work, wchich is kind of strange. I therefore want to document this. Task-number: QTBUG-84105 Change-Id: Icf40649910408ed1b5144e26efd95030b5ade97b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add NetworkServiceInProcess feature documentationFredrik Orderud2020-05-201-0/+5
| | | | | | Task-number: QTBUG-84105 Change-Id: I7d265c8319850bd32b4525bf0e2453fc35bbfa6e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Switch away from QT_NO_OPENGLAllan Sandfeld Jensen2020-05-111-1/+1
| | | | | Change-Id: I310265dacc9b1c8d391e82b6adf52b70c037d9b9 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix setting WebEngineView.audioMuted before initializationJüri Valdmann2020-05-052-3/+11
| | | | | | Fixes: QTBUG-83732 Change-Id: Ie07a1ecf87b214436ab7cea07003ddd5aeaedda3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Revive Pointer Lock featureSzabolcs David2020-05-041-4/+1
| | | | | | | | | | | | | | | This change fixes several issues: - Accepting mouse lock permission from modal dialog was not working on Linux. XCB needs some time to activate the parent window after accepting the dialog and we expected to have immediate active focus. - Implementation of RenderWidgetHostViewBase::IsMouseLocked() was missing. - Fixed event.movementX/movementY by disabling ConsolidatedMovementXY feature. Calculate movement properties in WebEngine instead of blink. Task-number: QTBUG-83294 Change-Id: Ic03d05c1026a113cf5e8d22544fc508d9f285876 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge "Merge remote-tracking branch 'origin/5.15.0' into 5.15"Allan Sandfeld Jensen2020-05-042-4/+10
|\
| * Restore behavior of OpenURLFromTab if createWindow returns thisJüri Valdmann2020-04-262-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | Instead of using QSharedPointer's reference count to communicate adoption/non-adoption, change adoptNewWindow to return a adapter pointer, with null meaning non-adoption. Then change QWebEnginePage's implementation to reuse already existing adapters if possible, restoring previous behavior of OpenURLFromTab when createWindow returns this. Task-number: QTBUG-80596 Change-Id: I8ee7c31e4294aabd3207c504cba67d6171c66cb0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add documentation about widevine-pathMichal Klocek2020-04-302-7/+29
|/ | | | | | | | | | | | | Update docs: * explain usage of widevine-path * fix not working link for widevine drm * refer to BitMovin player instead of Shaka Player, since it does not complain about not working cdm Task-number: QTBUG-83035 Change-Id: Ifb2b01a1cf4ac800f40e063530567970b659a55b Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Join some features request and response functionsAllan Sandfeld Jensen2020-04-152-9/+17
| | | | | | | Will make it easier to expands with more features in the future Change-Id: Ic7c1aca23a543c95a4873471c918f74606be2053 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update build requirementsAllan Sandfeld Jensen2020-04-151-6/+6
| | | | | | | Update to requiring macOS 10.13 and Xcode 10. Change-Id: I50aae730096da76e8917041211e7c143a69941eb Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Merge remote-tracking branch 'origin/5.14' into 5.15Allan Sandfeld Jensen2020-04-102-2/+11
|\ | | | | | | Change-Id: I75f7bbf5e5a4d4ed3bf7bfbfb76162de8a89e6fa
| * Doc: Fix docs for playbackRequiresUserGesture WebEngine settingLeena Miettinen2020-04-022-2/+11
| | | | | | | | | | | | Fixes: QTBUG-83101 Change-Id: I7ca8271cc88c7e157c36c79e06fa378f4bce48e4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Update documented chromium versionAllan Sandfeld Jensen2020-04-091-1/+1
| | | | | | | | | | | | Fixes: QTBUG-82763 Change-Id: Idf5cd91ec520aabe2b42b31ed0d2b32fcaec0272 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Adaptations for Chromium 80Allan Sandfeld Jensen2020-04-072-0/+5
| | | | | | | | | | Change-Id: Icaf68648cbc2c13a61fc3b208ff1e64ca36c90b6 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Merge branch '5.14' into 5.15Allan Sandfeld Jensen2020-03-261-2/+2
|\| | | | | | | | | | | | | | | Conflicts: src/3rdparty tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp Change-Id: Idbc9d3b06c0052a721c974fbcbfa3164faaead14
| * Doc: Fix highlighting of QML importKai Koehne2020-03-061-2/+2
| | | | | | | | | | Change-Id: I1420b0c6293fbd3caf5dce3ada3b6fec90c74bfc Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | Keep HTML dropdown always on topPeter Varga2020-03-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | It worked properly when RenderWidgetHostViewQtDelegateQuickWindow had Qt::ToolTip flag because tooltips are forced to be on top by QPA. Force RenderWidgethostViewQtDelegateQuickWindow to stay on top by the Qt::WindowStaysOnTopHint flag. Fixes: QTBUG-82993 Change-Id: Iccc48d6bf3570fee09af6d713f6f0bcd56e22b9b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Doc: Remove \contentspage commandsTopi Reinio2020-03-151-2/+0
| | | | | | | | | | | | | | | | The command is deprecated and has no effect apart from generating a documentation warning. Change-Id: I7f3b71274fb2c51da721f5e35ab1af775f5b2b60 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* | Merge remote-tracking branch 'origin/5.14' into 5.15Allan Sandfeld Jensen2020-03-034-8/+42
|\| | | | | | | | | | | | | Conflicts: tests/auto/quick/qquickwebengineview/BLACKLIST Change-Id: I365daa73d2eb422ac916c32b86c5ad0d3c32086d
| * Update accessibility focus on FocusIn events for QuickPeter Varga2020-03-021-0/+7
| | | | | | | | | | | | | | | | | | | | Without this, an already focused web element might not be read when QQuickWebEngineView gets the active focus. QWidget::setFocus() does this for Widget. Fixes: QTBUG-81539 Change-Id: Iaa418c416871e580583ea05e50b223dea3501fd8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-22 08:21:50 +0000