summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix some compiler warningsPeter Varga2021-06-105-23/+25
| | | | | | | | | | | | | | - Remove deprecated Qt::AA_EnableHighDpiScaling and Qt::AA_UseHighDpiPixmaps from examples. High-DPI scaling is always enabled. - Reorder initialization of members of QWebEngineDownloadRequestPrivate. Also remove m_ prefix from public members' name. - Remove unused parameters from methods of DummyDelegate. - Add missing overrides in auto tests. Change-Id: I18d6973b8bee574b37b73fbaaa8d57002ac8ba2d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 740b8c94f27930a33298c81c2284d1f0a9e2f11b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Switch QWebEnginePage::findText() to std::functionAllan Sandfeld Jensen2021-06-108-14/+18
| | | | | | | | | | Leaving further API modification for later Task-number: QTBUG-63235 Change-Id: I75367ee5d4ce071abaeed361d2dc27c64fb6dd8a Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit f820e8f1993ca2a3e6808467cabca82e464f36e7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumAllan Sandfeld Jensen2021-06-091-0/+0
| | | | | | | | | | | Submodule src/3rdparty d8835555..9e5e3189: > Generate mojo bindings before compiling extension API registration > Try to fix finding xkbcommon.h on OpenSUSE Change-Id: I697c856191a9eae42a4c5beae3ca077cf180d7ce Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit a961779c2c7d13ca5a5d830c4af94a60e4322e26) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QWebEnginePage: add new 'loading' property and expose QWebEngineLoadingInfoKirill Burtsev2021-06-082-5/+28
| | | | | | | | | | [ChangeLog][QWebEngineWidgets][QWebEnginePage] QWebEngineLoadingInfo is now exposed on loadingChanged signal with new 'loading' property Fixes: QTBUG-53333 Task-number: QTBUG-61100 Change-Id: I7773030726faeb1d65cc85a4d688a80f6dbe2c80 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add WebEngine qdocconf for documentationAllan Sandfeld Jensen2021-06-084-11/+16
| | | | | | | | | Probably still needs internal naming updates. Task-number: QTBUG-94130 Change-Id: I3f2522b16a78475d42f9f689cf2d2e994130cf7b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Port to new QML CMake APIFabian Kosmale2021-06-071-2/+6
| | | | | | Change-Id: I3806a435854cf49b3d802a2c40e992463815f242 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Craig Scott <craig.scott@qt.io>
* Replace testsupport's QQuickWebEngineErrorPage with isErrorPageAllan Sandfeld Jensen2021-06-0614-148/+79
| | | | | | | | | | | | | | | | Merge and unify handling of loading started/finished for quick and widgets by removing separate quick's type for monitoring error page load and replace it with an isErrorPage method in WebEngineLoadRequest to indicate, that load ended with an error page being displayed. Effectively this only slightly changes when loading finished gets emitted: now the signal is just postponed until error page is finished loading after initial failure. [ChangeLog][QWebEngineQuick][WebEngineLoadingInfo] New property 'isErrorPage' which indicates that the load resulted in an error page Change-Id: I3e59dc488429d776f7c8e083b6d0489fb30a65fc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Transform/Rotate qml popups in the case of multiwindow supportMichal Klocek2021-06-052-10/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is ugly attempt to cover the case for different screen orientations with qml popups on system with windowing system in form of: Item { anchors.fill: parent rotation: 90 WebEngineView { anchors.fill: parent } } This implemented by adding special transformation for rotation for quickwindow delegate. Do not support move or resize in that case since chromium is not aware of this transformation anyway. Fixes: QTBUG-63888 Fixes: QTBUG-75893 Task-number: QTBUG-73244 Task-number: QTBUG-89358 Pick-to: 5.15 Change-Id: I0a116e0b85dc17e6ad517829a2db1d3f192d32ce Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Port 626830a7 to cmakeMichal Klocek2021-06-051-0/+1
| | | | | | | | | | | | Generate mojo bindings before compiling extension API registration Speculative fix. Add custom qtwebengine mojo_bindings as a dependency for compiling chrome sources. https://codereview.qt-project.org/c/qt/qtwebengine/+/351361 Change-Id: I9d7de2d1f69072249549fa09afd0996f495b23a7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Always send phased wheel events beginning with BeganAllan Sandfeld Jensen2021-06-051-1/+1
| | | | | | | | | The input event router does not like MayBegin. Pick-to: 5.15 Fixes: QTBUG-93082 Change-Id: I4ac9677d7f69da3d36fc33c17541026f011feb42 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Rename WebEngineLoadRequest to WebEngineLoadingInfoKirill Burtsev2021-06-0412-83/+85
| | | | | | | | | | | | Rename it, since it's not a real request (in a sense that there is nothing to accept or reject), and it is also emitted on loading start and failure. [ChangeLog][QWebEngineQuick] WebEngineLoadRequest is renamed to WebEngineLoadingInfo Change-Id: I75b25da456eb4507451014070525a6a8e9d6753d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* WebEngineView: rename navigationHistory to historyKirill Burtsev2021-06-045-9/+9
| | | | | | | | | | Match widgets API name for the same QWebEngineHistory class [ChangeLog][QWebEngineQuick][WebEngineView] 'navigationHistory' property is now just 'history' Change-Id: I78507929baa84c8be08f79050568d04868171b3f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge WebEngineHistory's quick implementation into QWebEngineHistoryKirill Burtsev2021-06-0415-664/+540
| | | | | | | | | | [ChangeLog][QWebEngineCore][QWebEngineHistory] New methods to access navigation history as a model through new class QWebEngineHistoryModel. [ChangeLog][QWebEngineQuick] QQuickWebEngineHistory is merged into QWebEngineHistory. Task-number: QTBUG-74585 Change-Id: I9f9a73bbaf3954282dfc220cfc2c4cb08a37fb73 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Replace FaviconManager with Chromium's Favicon ComponentPeter Varga2021-06-0429-833/+1104
| | | | | | Task-number: QTBUG-51184 Change-Id: Ie050cb23f2c86841a66ec384bfbcdf0713cffa7c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Move QQuickWebEngineNavigationRequest to CoreAllan Sandfeld Jensen2021-06-049-87/+128
| | | | | | | | | Adds navigationRequested() to QWebEnginePage and exposes more information about navigation requests than the old acceptNavigationRequest() method. Change-Id: Ibb8d750bacd1060c3086ffe2c85336abd216bab0 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Turn webrtc back on for non-embedded buildsAllan Sandfeld Jensen2021-06-031-2/+2
| | | | | Change-Id: Ib90aef051ac643406236e9fae63b43a1a9868bcd Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-06-031-0/+0
| | | | | | | | | | | | Submodule src/3rdparty a8c1986a..d8835555: > FIXUP: Stop using C++20 initialization > Fix build error for macOS arm64 on x86_64 > Fix arm64 Skia build for macOS > Make convert_dict as a root project > Adapt favicon and history component for WebEngine Change-Id: I6a11e1859b09e4841f1b076e08e2c38ce1388017 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Drop printsupport dependency from coreSzabolcs David2021-06-0310-232/+185
| | | | | | | | | Prevent linkage of core to widgets by moving printing API from QWebEnginePage to View and using QPagedPaintDevice (the QtGui ancestor of QPrinter) where it's needed. Change-Id: I6ea96edb495b0dcaaa584bbe72632fda025c18d3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Move createWindow to a signalAllan Sandfeld Jensen2021-06-0315-269/+476
| | | | | | | | | | | | | | Ports QQuickWebEngineNewViewRequest to QtWebEngineCore. [ChangeLog][QtWebEngineQuick][WebEngineView] WebEngineView::NewViewRequested is now handled with WebEngineView::acceptAsNewView() instead of with WebEngineNewViewRequest::openIn(). Task-number: QTBUG-74587 Change-Id: I9b27128948076e13f2c228458e1e7491df12153d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add missing FileSelectionMode enum valueBalazs Egedi2021-05-314-1/+4
| | | | | | | FileSelectUploadFolder value is added. Change-Id: Ie69782234bcbf3460d2999ac08ee9f88dea190c7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix compliation without xcb-glxMichal Klocek2021-05-281-13/+13
| | | | | Change-Id: Ibfc51d1937f42264de0eeb1abacb8999d21fe3dc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2021-05-281-0/+0
| | | | | | | | | | Pulls in following changes: * cfdd5dee584 Workaround revoked certificate check on Linux * a8c1986a628 Add support for QT_GN_VERSION Change-Id: Iba0d513e10dfa6aae83c71541ab355019e8deb76 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add support for gn versionMichal Klocek2021-05-282-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | Check the version before using gn, since some systems can have already gn installed. In case of cross builds gn is installed into host qt and can simply end up in /usr/bin path of x86_64 sysroot in case of yocto builds, meaning it will be picked up by the host system path. Moreover, findGn.cmake is also going to be installed and should not just look for non existing builds paths. One can also avoid pointless recompilations of gn for every single clean build. Gn can be easily installed by simply building the "gn" project: cmake path/to/qtwebengine/src/gn cmake --build . --parallel cmake --install . Note setting DCMAKE_INSTALL_PREFIX and/or DESTDIR can install gn to desired location. Change-Id: Ie8f989c838dad2e6e7e346a4f6a861e187ec037f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use fixed qt_add_resource BASE argumentPeter Varga2021-05-281-0/+3
| | | | | | Task-number: QTBUG-86726 Change-Id: I33ec2a73254d9b44de83f4f5491f372b4bb9959b Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Fix generating webrtc logging resources with cmakePeter Varga2021-05-271-1/+8
| | | | | | | Also disable webrtc logging test if extensions are disabled. Change-Id: I49c8d4fb6049c9aed174f62f731b0f56dae490ba Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add major revision to revisioned symbolsAllan Sandfeld Jensen2021-05-268-126/+124
| | | | | | | Should make imports of 2.0 include all of 1.x. Change-Id: Ibaf40d7e363524820dbd06356998ec780752717f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add support for top-level configs and developer buildsAllan Sandfeld Jensen2021-05-252-1/+23
| | | | | | | | | | Guess a toolchain link for top-level builds. Copy the resources to their final destinations, and search for the helper process where it is build in this config. Change-Id: Ie9e829c19d42dddb85df188e48ec269f85268ed4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add missing dependecies, update shasMichal Klocek2021-05-253-3/+7
| | | | | | | | | | | Include WebChannel,Positioning cmake packages into WebEngineQuick and WebEngineWidgets. WebEngineCore depends on it so this should be pick up automatically, but in the case of clean build and due to how things work in cmake this is required otherwise linker genex will complain. Change-Id: I54fe8ffdb824e1fd0c0dcdfbbb43b1bcf06411bb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Adapt to new QtPositioning APIPeter Varga2021-05-251-14/+7
| | | | | | | | | | | Use QGeoPositionInfoSource::errorOccurred after: ced55681 QtPositioning: rename signal error() to errorOccurred() Remove usage of QGeoPositionInfoSource::updateTimeout after: 37ff0744 QtPositioning: remove QGeoPositionInfoSource::updateTimeout signal Change-Id: I7a32173c017571e56ff9d58bf9398106b66f4feb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make handling of certificate errors possible from a signalAllan Sandfeld Jensen2021-05-254-7/+5
| | | | | | Task-number: QTBUG-74587 Change-Id: I9955a4c70b339523b5e9e9d6dffe928e61fbab90 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Switch builds to cmakeMichal Klocek2021-05-221-0/+14
| | | | | | | | | | | | | | | | | * move the sync profile, so we can sync headers for the libs project * update dependencies * add coin module config * extend timeout for build * bump version to 6.2 * disable qmake build by deleting the main pro file * tweak product dependencies, cheat and point to even not merged change Task-number: QTBUG-91760 Change-Id: I02d6cda3a4ce09575ae993836b5089e1655401b9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Revert "Look for resources in macOS standard Resources dir"Michal Klocek2021-05-221-2/+0
| | | | | | | | | | | This reverts commit 3a4e3c807c667491e133d04e3dcbadd0dad19826. With cmake we no longer install into capitalized directories, this went unnoticed for a while, till one of the mac coin nodes got the case sensitive file system. Change-Id: I8442ed6a3f02c37786ba7f98d891a1ddbbf10a2a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2021-05-221-0/+0
| | | | | | | | | | | Pulls in following changes: * f80d7ed91c2 Add cmake link writer for specific configuration * e785a72d31a Fix gn build windows issue * 22968137276 Fix missing dependency for qtwebengine/browser/pdf Change-Id: I0cd5f003f84164b35dac437e0ca63e5d20f5010b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Clean headersMichal Klocek2021-05-224-4/+4
| | | | | | | Fix errors from the 'clean headers' task on coin. Change-Id: I058697e726228800c0fd3220b1d40ac154efb47c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix not working ninja multi config on coinMichal Klocek2021-05-221-27/+40
| | | | | | | | | | | | | | | | On coin we call cmake --build . and we do not specify the config expecting that all configuration are build. However, when using the custom command for ninja build dependencies are incorrectly resolved by cmake and the ninja step is only executed in "default" config context. This breaks debug builds. Cmake 3.20 fixes the issue by adding genex to OUTPUT and support for OUTPUT_CONFIG. Create workaround for now and revert it when minimum version of cmake is bumped to 3.20 Change-Id: Iafaedb5f605ed9195dd4ecaa34d2dff19b7225a6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add windows to the cmake buildMichal Klocek2021-05-2214-100/+142
| | | | | | | | Fix cmake for windows builds and add QtWebEngineSandbox target. Task-number: QTBUG-91760 Change-Id: If962a81ddfb509d104ad8ffbfbf34f1150ae82ce Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add mac builds to cmakeMichal Klocek2021-05-224-18/+84
| | | | | | | | | | | We need to pass -F or -iframework to gn as a compiler flag, however cmake keeps this parameter as include dir and adds internally "-iframework QtFoo.framework/.." for the compiler call. This internal handling can not be accessed with the genex. Add the manual conversion. Task-number: QTBUG-91760 Change-Id: Id12831432ccb0516be52f79bd5f6cfcbe7e87d9c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Refactor and create gn targetMichal Klocek2021-05-226-445/+557
| | | | | | | | | | | | | | | | | Refactor the gn handling and add: * the gn target for encapsulating resources needed to run chromium builds * the support for SOURCES, INCLUDES, DEFINES, COMPILE OPTIONS. * the multi config support for cmake and enable debug, release builds * CONDITION evaluation for the gn target and the gn arg list * the linux specific config and all missing source sets * use REALPATH instead of ABSOLUTE, this fixes missing drive letter on windows Task-number: QTBUG-91760 Change-Id: Ib283d8ab817ff36ee9c94c2b8f44785709c45258 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Bump the minimum required cmake version to 3.19Michal Klocek2021-05-224-4/+4
| | | | | | | | | | | QtWebEngine requires support of TARGET_PROPERTY for genex in gn template generation to dump all compilation flags. This is supported since version 3.19, set examples to 3.16 as rest of the qt. Task-number: QTBUG-91760 Change-Id: Ifa5903c8c6efcb160db05baf1e18c865b48bcf39 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Add WebEngineWidgets, WebEngineQuick modules cmake buildMichal Klocek2021-05-1927-45/+148
| | | | | | | | | Fix some library dependencies and make proper header includes in core. Task-number: QTBUG-91760 Change-Id: I415361dd42ef2cc39716ce3f5f56e6e8556ac4c8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add QtWebEngineCore module cmake buildMichal Klocek2021-05-195-18/+294
| | | | | | | | | | | | | | | | | | | | | Create QtWebEngineCore, QtWebEngineProcess and drive headers sync from the libs project. Main project build should not generate any header files, since the logic in qtbase assumes fixed QT_BUILD_DIR, which is by default CMAKE_BINARY_DIR for prefix builds. Drive all syncqt calls from the libs project and leave the main build just for the feature evolution and the build summary reporting. This fixes header installation issues, however this patch requires also sync.profile update which is done later, to keep the qmake build still functional. Note this patch only adds debug builds for linux. Task-number: QTBUG-91760 Change-Id: I516c26206baa1cf6b966629a694dadce7f79dbec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.15' into devAllan Sandfeld Jensen2021-05-197-7/+107
|\ | | | | | | | | | | | | Conflicts: src/core/render_widget_host_view_qt.cpp Change-Id: I86113b13bb2d8419e9e9a485197f02b2c7399cd4
| * Set enumaration root directory for File.webkitRelativePath APIBalazs Egedi2021-05-131-2/+6
| | | | | | | | | | | | Fixes: QTBUG-93304 Change-Id: If2f30aab1c6a6eb81cfbad51318ec31adf5e96b6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix FilePickerController's path validation for windows and corresponding testsPeter Varga2021-05-121-2/+2
| | | | | | | | | | Change-Id: If2445171232864cb4ac51888ccc93bc00cb099a2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Add support for Keyboard.getLayoutMap()Peter Varga2021-05-126-2/+98
| | | | | | | | | | | | | | | | | | | | | | Pulls in the following changes: Submodule src/3rdparty 6c7b4ffb..1d3b13e9 > 1d3b13e9634 Make clang to inline load/store atomic calls for YieldSortKey struct > f6730fe81a0 Enable XkbKeyboardLayoutEngine::SetCurrentLayoutByName for Qt Fixes: QTBUG-92971 Change-Id: I0c0cddfe4d3e25fd6d3f7e0764b302c300303172 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Follow InProcessGpuThread::Init() on thread priorityAllan Sandfeld Jensen2021-05-101-1/+1
| | | | | | | | | | | | | | If they use NORMAL, then we should too. Change-Id: I252b4606c692ba483434c126fcda3a7484f399e2 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.15' into dev"Allan Sandfeld Jensen2021-05-1326-142/+153
|\ \
| * | Merge remote-tracking branch 'origin/5.15' into devAllan Sandfeld Jensen2021-05-1226-142/+153
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: examples/webenginewidgets/printme/printhandler.cpp src/3rdparty src/core/api/qwebenginepage_p.h src/core/content_browser_client_qt.h src/core/web_contents_adapter_client.h src/core/web_contents_delegate_qt.cpp src/core/web_contents_delegate_qt.h src/webenginequick/api/qquickwebengineview_p_p.h tests/auto/quick/qmltests/data/tst_download.qml tests/auto/quick/qmltests/data/tst_viewSoure.qml tests/auto/widgets/loadsignals/tst_loadsignals.cpp tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp Change-Id: I9c1819ec15e13d4f8e244defe860e26274b5d4be
| | * Remove tracking of frame which load error pageKirill Burtsev2021-05-062-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was added to suppress progress notification for error page load after failure, but since error page load is reported as a new navigation (which clears list of tracked frames), it was actually doing the opposite thing. The only situation where it suppresses progress is when navigation was not finished (due to invalid domain or network error), but in this case it was real progress change for whole load which should propagate further. Change-Id: Ifd1d681fb5c6495fb3afdc4247364afb4472c959 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| | * Fix inconsistent number of load signals and their orderKirill Burtsev2021-05-068-86/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change tries to match how chromium treats one single load. Before the pair of loadStarted/loadFinished methods for api classes was called on delegate's DidStartNavigation/DidFinishNavigation, which might be many within one single logical load. This is true for multiple usecases (like multiple redirects on load, immediate form submit on DOM load, page's subresource load, or just an error page load on failure). Tracking these methods and deciding when to emit signals based on states are error-prone and complicates logic for no benefits. Also it somewhat lies about when real load is done, which is only started and finished on outer methods DidStartLoading/DidStopLoading, which are conveniently called only once for all mentioned usecases. So, this change uses these methods to issue signals for load start/finish, and only makes exception for error page, which is needed for quick's private test support. Fixes: QTBUG-65223 Fixes: QTBUG-76802 Fixes: QTBUG-87089 Fixes: QTBUG-90342 Fixes: QTBUG-91773 Fixes: QTBUG-92063 Change-Id: I9cc99b639030fedd8cf6a9dc04d0869d6be6357d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>