summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix inspector overlayAllan Sandfeld Jensen2022-01-061-0/+2
| | | | | | | | | | Was missing resources that had moved Fixes: QTBUG-99526 Change-Id: I68b05b9de3dbd6c6460e5495a939e2599623a047 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6617cb8edb51bce85861e44035948d8f634c985b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Always generate printing buildflagsAllan Sandfeld Jensen2022-01-051-3/+1
| | | | | | | | | | We include them unconditionally Fixes: QTBUG-99511 Change-Id: I4d9ebbf5777099ade38740ceb41532f0088df4c0 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 7720aa45fa8419da4c90ffed9954fbf7502d062e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update SG backend codeAllan Sandfeld Jensen2022-01-051-53/+21
| | | | | | | | | Correct the debug output and remove references to dead code like ANGLE. Change-Id: I261ecf23a200c4328ea79514f7f75fce991960f5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 3d0b32c93c0d45bf61a77e76ef9ab54efd2b2eeb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Cleanup code and clang build warningsKirill Burtsev2022-01-0316-62/+18
| | | | | | | | | | Fix build noise as reported by clang for issues like api deprecation, unused variables, sign/unsigned mismatch and other non critical issues. Change-Id: I4fba25406eea8170e3283c42e908ae86bd512e3a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 02d58a067fb5f0db32c254e783170f9f283aeb9d) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix crash on meet.google.comSzabolcs David2021-12-301-1/+7
| | | | | | | | | | | Hangout Services extension has a background WebContents. Do not try to access its delegate and settings. Task-number: QTBUG-99119 Change-Id: Ib46867ba98644e14af6263253daa253ef2e6b12a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1552ad5d3e66460bbbb5bbd71ca2083fb9d17d3f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix headers in GN sourcesAllan Sandfeld Jensen2021-12-241-4/+2
| | | | | | | Change-Id: Ib2faa3e0242799e1088d4ec7c610fa89a4d15bbb Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 540b1cadb1888a9adde8cf338fcdbd8630423c0b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* FIXUP: Add onTouchSelectionMenuRequested QML handlerBalazs Egedi2021-12-234-4/+22
| | | | | | | | | Fixed CodeChecker warnings, added missing documentation. Change-Id: I723ea2b0952ded52f513a3cd53ac443b727f1e58 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 56005ae3d52568b469db32498afebd9c52e4881b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdf namespace: export the staticMetaObjectMarc Mutz2021-12-141-1/+2
| | | | | | | | | | Otherwise users outside the module can't access it. Fixes: QTBUG-99144 Change-Id: I8348f64bca9a4cd9bcdbddb8fbfd7554c29f5357 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit cf9ecc2019f9800e33f2963770ccb1ea1bb20813) Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Adopt modern QESDP usageAllan Sandfeld Jensen2021-12-094-40/+14
| | | | | | Change-Id: I654c07c3b9925977dd85821a36fd6f8130556cac Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* QPdfSearchResult: std::move ctor argumentsMarc Mutz2021-12-082-5/+10
| | | | | | | | | | The ctor is a perfect sink for the arguments, and already took them by value. What was missing was to std::move them into place instead of using the copy ctor. Change-Id: I3a708bea2cdd8417ea3e604af2850d99a5966c3f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Replace GeolocationSystemPermissionManager with GeolocationManager after 94 ↵Peter Varga2021-12-084-17/+19
| | | | | | | | | | | | | adaptations This is necessary to fix crash with disabled geolocation on macOS. The change in upstream is: Use GeolocationManager in CoreLocationProvider https://chromium-review.googlesource.com/c/chromium/src/+/2779636 Change-Id: I97143886bc3c98ad880c3cfc739ef08e5bfa3e73 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash with disabled geolocation on macOSPeter Varga2021-12-084-2/+60
| | | | | | | | | | | | | | | | | QtWebEngine uses custom LocationProvider for geolocation. If geolocation is disabled, Chromium fallbacks to NetworkLocationProvider. NetworkLocationProvider uses GeolocationSystemPermissionManager and tThere is no nullptr check for the manager instance so QtWebEngine has to provide it. This fix implements a FakeSystemGeolocationPermissionManager what is meant to be used only on macOS if geolocation is disabled. LocationSystemPermissionStatus is always set to denied by the fake manager. Pick-to: 6.2 Change-Id: I25d51c9ce8911b95ff69cc72bc6aae7023e7edbe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update documentationAllan Sandfeld Jensen2021-12-072-6/+0
| | | | | | | | | The signal is updated much faster for paused media now. Pick-to: 6.2 5.15 Fixes: QTBUG-98918 Change-Id: Ifa3b54e212436a7c93e101dc244d7edcbf473b63 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* qpdfX_p.h: include qpdfX.hMarc Mutz2021-12-073-0/+6
| | | | | | | | It's best practice, and will probably solve a linker failure/ODR issue in a subsequent patch. Change-Id: Ieff9d20ddc3b49286459d554a2ff6a706a41af2e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QQuickTableViewExtra: make ctor explicitMarc Mutz2021-12-071-1/+1
| | | | | | | | | It's a private class, but add the missing explicit keyword to avoid raised eyebrows in the next reader. Task-number: QTBUG-98796 Change-Id: I63bb45d840b8b09f2b1fe3343fd8fe83416fa60e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Make default ctors implicitMarc Mutz2021-12-076-6/+12
| | | | | | | | | | Default ctors should be implicit, because users expect '{}' to call them. If they're explicit, because they're folded into the (QObject* parent) ctors, then that no longer works. Fixes: QTBUG-98881 Change-Id: Ie52812ba76ee0b489c75ecf48b0c048025fde8c7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdf namespace: Q_DECLARE_OPERATORS_FOR_FLAGS inside the namepaceMarc Mutz2021-12-071-2/+1
| | | | | | | | Otherwise the operators aren't found by ADL. Task-number: QTBUG-98796 Change-Id: I9b80f59bf9f8c76234360f07add80528fc4ab326 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Make dtors out-of-lineMarc Mutz2021-12-0714-0/+39
| | | | | | | | | | | Pins vtable to a single TU, instead of duplicating it across all TUs that use the class, possibly causing invalid dynamic_cast<>s and other bugs. Fixes: QTBUG-98880 Task-number: QTBUG-45582 Change-Id: Ic296f4583097181ac4d824fac6dab4671ae14a50 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Mark implicitly-shared classes as Q_DECLARE_SHAREDMarc Mutz2021-12-063-0/+3
| | | | | | Task-number: QTBUG-98796 Change-Id: I2400ef5634ae3c263aaafe1526e843f542a73eef Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-12-061-0/+0
| | | | | | | | | | | | | | | | | Submodule src/3rdparty be03c63b3..735b1a398: > [Backport] Handle long SIGSTKSZ in glibc > 2.33 > FIXUP: Fixes for jumbo build > Compile with GCC 11 -std=c++20 > FIXUP: Fix navigation when clicking on links in a PDF > FIXUP: Adapt accessibility code for our needs after chromium 90 > FIXUP: Add user script data mojo interface and traits > FIXUP: Make GpuSwitchingManager::RemoveObserver() thread safe > [Backport] Return proper value in GLES2DecoderImpl::GetUniformSetup > [Backport][Extensions] Remove string literal conversions by ASCIIToUTF16() > Disable debug info for crbug.com/1224432 Change-Id: I3ddb49ed6853fc78a2b857637888d66af950f8d9 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Check if qt_internal_return_unless_building_tools presentMichal Klocek2021-12-061-2/+3
| | | | | | | | Fixes dev build with 6.2.2 Fixes: QTBUG-97944 Change-Id: I027a473bc7cf239610d2162abb697cf10a557f4a Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix race condition on layout (take2)Michal Klocek2021-12-062-26/+10
| | | | | | | | | | | | | | | | | | | | | Even if layout is 'meaningful' it can still require update before toPlainTextSync call can proceed. Simply wait for frame being loaded in stead of tracking layout update. Depending on DidLoadFinish will brake default toHtml call for empty not loaded page, therefore return expected value if there is no load. This fixes crashes/asserts on certificateError (stacktrace in bug report). Remove blacklist on certificateError as bad certificate is back on line and toPlainTextSync works without issues. Fixes: QTBUG-97414 Pick-to: 6.2 Change-Id: Ib702bbe813f6061eef446e2d87d7e9e455d715c5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdfSearchModel: take a QString arg by cref, not valueMarc Mutz2021-12-032-2/+2
| | | | | | | | The function is not a perfect sink for the argument, and the implementation wasn't moving from the argument, anyway, so do the common thing here and take by cref. Task-number: QTBUG-98796 Change-Id: I4237e50cf9c00817245ad8967bf7e2976ffb7085 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Replace old Qt constexpr defines with constexprAllan Sandfeld Jensen2021-12-021-12/+12
| | | | | Change-Id: Ia68a080fcbf985e2a62178e5ca2722495799f9c9 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Use up-to date LGPL license headerKai Köhne2021-12-0255-605/+770
| | | | | | | | Remove usages of outdated LGPL3 header that references LICENSES.LGPLv3 instead of LICENSES.LGPL3. For the examples, use BSD. Change-Id: I1fae49110160c1183327ec54c9dc447c69588a65 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Allow surface factory with no backendAllan Sandfeld Jensen2021-12-021-3/+6
| | | | | Change-Id: I5fef92c4cb0110e413a7af2d35f2e9cf02a5b16b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 94Allan Sandfeld Jensen2021-12-0266-390/+473
| | | | | Change-Id: I9fb8998a3a7762b0aea70993ca231f0bbf4f7761 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 92Allan Sandfeld Jensen2021-12-0265-320/+363
| | | | | Change-Id: I1849c130ca75615802744275f6e4212a755c39b4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 91Allan Sandfeld Jensen2021-12-0259-191/+175
| | | | | Change-Id: Ie0236697615fd67e4f53df3dca013ce39628cc29 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix build with the latest qtbasePeter Varga2021-11-301-0/+1
| | | | | | Pick-to: 6.2 Change-Id: I66a3536ecaa2d5dded5a645c46f05c559b90eda4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix race condition on layoutMichal Klocek2021-11-252-5/+35
| | | | | | | | | | | | Calling some methods without 'meaningful' layout when render frame is visible tiggers at the best some DCHECKS. Therefore if frame is visible wait for 'meaningful' layout. This fixes some flaky tests on toPlainTextSync call. Pick-to: 6.2 Change-Id: I746a1c436798b440c59f9b8b4a1d297e3fa7e56d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichael Brüning2021-11-231-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 6ae16282af..39aa0ea99a: > CVE-2021-38022: Inappropriate implementation in WebAuthentication > CVE-2021-38015: Inappropriate implementation in input > CVE-2021-38019: Insufficient policy enforcement in CORS > CVE-2021-38009: Inappropriate implementation in cache > Dependency for CVE-2021-38009 > CVE-2021-38010: Inappropriate implementation in service workers > CVE-2021-38005: Use after free in loader (3/3) > CVE-2021-38005: Use after free in loader (2/3) > CVE-2021-38005: Use after free in loader (1/3) > CVE-2021-38007: Type Confusion in V8 > CVE-2021-38017: Insufficient policy enforcement in iframe sandbox > CVE-2021-38012: Type Confusion in V8 > Fixup for CVE-2021-38018: Inappropriate implementation in navigation > CVE-2021-38018: Inappropriate implementation in navigation > CVE-2021-38021: Inappropriate implementation in referrer > CVE-2021-3541 libxml2: Exponential entity expansion attack bypasses all existing protection mechanisms > CVE-2021-3517: libxml2: Heap-based buffer overflow in xmlEncodeEntitiesInternal() in entities.c > CVE-2021-38001 : Type Confusion in V8 > Security bug 1252858 > CVE-2021-38003 : Inappropriate implementation in V8 > CVE-2021-37996 : Insufficient validation of untrusted input in Downloads > CVE-2021-37989 : Inappropriate implementation in Blink > CVE-2021-37987 : Use after free in Network APIs > Security bug 1245870 > CVE-2021-37992 : Out of bounds read in WebAudio > CVE-2021-37993 : Use after free in PDF Accessibility > Security bug 1241912 > CVE-2021-37984 : Heap buffer overflow in PDFium > Fix build with Win10 21H1 SDK and Win11 SDK Change-Id: Ie208cc60c8c65c37ddf0d727fe7e1e315e538255 Task-number: QTBUG-98400 Task-number: QTBUG-98401 Task-number: QTBUG-98523 Fixes: QTBUG-98522 Pick-to: 6.2 6.2.2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QQuickPdfDocument: fix -Werror=deprecatedMarc Mutz2021-11-221-1/+1
| | | | | | | | | C++20 deprecates [=]'s implicit capture of this, but [this] is sufficient, anyway. Pick-to: 6.2 Change-Id: I0e962d62b672883495da05abce12d7ea2f2b1020 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Add dependency to the CMake manualTopi Reinio2021-11-191-0/+1
| | | | | | | Fixes (qdoc) warning: Can't link to 'Versionless commands' Change-Id: Ia2940a3b244df57cdefe386734bdac0df18cd039 Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
* Add cmake api for 'bdict' dictionary conversionMichal Klocek2021-11-172-0/+132
| | | | | | | | | Fix spellchecker example and test to use new api. Note we should not use qt6 prefix in cmake api in examples. Change-Id: Ib800bf2b7bd83e10060fa01ccd8d4a262752e09b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Use new x11 native interface to query xdisplayMichal Klocek2021-11-171-3/+5
| | | | | | | | | | | | | | | | | | | | | The call to nativeResourceForScreen can return egl native display handle if called with "display", since it gets mapped to XLibDisplay but egl device intergration can return EGLDisplay. This is not the case for nativeResourceForIntegration. Use new native QX11Application interface to query for display, note there is not need to use nativeResourceForScreen for "display" anyway since qt does not support multiple x connections to different displays. This fixes places where code queries "display" and bails out if it is null. Fixes: QTBUG-97472 Pick-to: 6.2 6.2.2 Change-Id: Ibc5f8f96e612389bfa24a81268202c9e47a7580b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash in Quick file system access dialogsSzabolcs David2021-11-171-1/+1
| | | | | | | | | | | | In Quick examples, providing any answer to ui::SelectFileDialog::Listener results immediate destruction of FilePickerController and its m_isHandled flag remains false before the controller is destroyed. An "unhandled" controller calls reject() in destructor, so the controller will be answered twice. Pick-to: 6.2 Change-Id: Iaff5b0f4f54b0b11a447ac624f5652e592a88e6e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Do not access accessibility from qt post routinesMichal Klocek2021-11-166-4/+27
| | | | | | | | | | | | | | | | | | | It seems accessing accessibility from qt post routines ends badly since caches are gone already. Add closingDown() function to web context, which is similar to QCoreApplication::closingDown(), however return true on post routine. Guard delete accessibility calls. Note the widget part is not necessary, but added for completeness, since only qml can release profiles due to garbage collection. Fixes: QTBUG-90904 Pick-to: 6.2 6.2.2 5.15 Change-Id: Ic0e7115cd17eb58f3d58f70fefbc197dfb7a6493 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* FaviconImageResponseRunnable: fix -Werror=deprecatedMarc Mutz2021-11-161-2/+2
| | | | | | | | | | C++20 deprecates [=]'s implicit capture of this, but the replacement [=, this] isn't available in C++17. So, need to bite the bullet and list every captured variable manually. Pick-to: 6.2 Change-Id: I47c62f9bf93e5d7b6c64cdbdac73bdcc9ecab8b5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Fix qdoc warnings and enable zero warning limitVenugopal Shivashankar2021-11-1514-51/+69
| | | | | Change-Id: Ifa2914e7bca9c224670a1891785d0ba8262cd61b Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Do not force off DoH upgradeAllan Sandfeld Jensen2021-11-151-2/+0
| | | | | | | | This should enable use of system DoH settings on macOS and Windows Task-number: QTBUG-98284 Change-Id: Iab019e46341f55146224df6830bc7902db85ff40 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Add CF_HTML clipboard format handlingPeter Varga2021-11-133-0/+189
| | | | | | | Fixes: QTBUG-92539 Pick-to: 6.2 Change-Id: Iece974e7b045bd793ceb8870f370803bf2524c33 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Re-enable network-service-in-processAllan Sandfeld Jensen2021-11-111-0/+1
| | | | | | | | | | The network-service isn't sandboxed anyway, so there is no added security by the process separation. Pick-to: 6.2 5.15 Fixes: QTBUG-84105 Change-Id: Ie3fbda26f0cf8f31166b37a8537b7e1b6d11b560 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Check if xkb extension is presentMichal Klocek2021-11-101-0/+6
| | | | | | | | | | | | | According to docs: "You must call XkbQueryExtension or XkbOpenDisplay before using any other Xkb library interfaces" Task-number: QTBUG-97472 Pick-to: 6.2 Change-Id: I84c1bc49b077224a93d9f8d7a9ac29fe089de13e Reviewed-by: Liang Qi <liang.qi@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Add qmake profile naming changes to docsMichal Klocek2021-11-101-0/+7
| | | | | | | Pick-to: 6.2 Task-number: QTBUG-97836 Change-Id: If32e78144695cefd5ff6092bfd3b845c04891dd7 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Fix proprietary codes feature referring to qmakeMichal Klocek2021-11-101-3/+4
| | | | | | | Fixes: QTBUG-97926 Pick-to: 6.2 Change-Id: I2abba9044d64765fca48d987c70494792529f6ca Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Do not cancel custom tooltips by QWebEngineView custom tooltip handlerPeter Varga2021-11-051-12/+12
| | | | | | | | | | | | | | | | | | Tooltips should disappear when chromium requests it and it is done by an explicit call of QToolTip::hideText() (see QTBUG-64933). This, however would also hide a custom "global" tooltip because the custom tooltip event notifies QWebEngineView to remove its own tooltip to avoid more than one in a window. The QWebEngineView's tooltip handler was override and it resulted custom tooltips to hide themselves. As a fix, remove the custom tooltip handler from QWebEngineView and hide tooltips only if requested by Chromium. Fixes: QTBUG-97897 Pick-to: 6.2 Change-Id: I976e49218ec975b10e2f155096f6aec124270fdc Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix some issues with icu for dict toolMichal Klocek2021-10-283-5/+21
| | | | | | | | | | | | | | | | The dict tool can be run during the build, therefore copy just in case icu data file to tool application path, so it does not require installation and can run no matter if it is a prefix non prefix build. Guard for webengine_system_icu since there is no icu file in that case. Remove awesome looking genex from examples. Pick-to: 6.2 Change-Id: I2fd5ecf6c99ae1d003a1ac1c7bce2bb61a05f73f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix setup for 'no-prefix' buildsMichal Klocek2021-10-282-25/+27
| | | | | | | | | | | | | | | | | | | QT_SUPERBUILD is never cached and user can run only qtbase as super build and compile any other module as separate module build, moreover this can be also 'no prefix' build. Fix missing checks to support that case and clean up install of resources. For mac framework builds copy bundle to right place in case of 'no-prefix' builds. Fixes: QTBUG-94604 Task-number: QTBUG-96375 Pick-to: 6.2 Change-Id: I4ab7d4fed2c2be93f2a048a510419849361883ba Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Clean up build optionsMichal Klocek2021-10-283-22/+21
| | | | | | | | | | | | | | We can configure webenigne repository with FEATURE_qtpdf_build and FEATURE_qtwebegine_build so make them public. The handling is still affected by QTBUG-96936,however private vs public features will most likely get better handling soon. Fix build summary to better reflect build options. Pick-to: 6.2 Change-Id: Ic6ef54a68b68d0f05c520a058665e6294efbe041 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>