summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix destruction of qt quick profile after WebEngineContext gets deletedMichal Klocek2019-03-011-1/+2
| | | | | | | | | | Issue takes place when QQmlApplicationEngine is a child of qApp. In case WebEngineContext gets destructed do not try to get default profile, which is anyway already gone. Task-number: QTBUG-74116 Change-Id: I24ea87baf677360a420d444b4c964feb722ab317 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix incrementing download IDTamas Zakor2019-02-282-2/+6
| | | | | | | | | | | | | Adapt DownloadManagerDelegateQt::m_currentId to https://chromium-review.googlesource.com/1144311 Update Chromium: 09516a434b [Backport] Allow DownloadManagerImpl to get InProgressDownloadManager from DownloadManagerService b3edbf2a84 [Backport] Make DownloadManagerImpl to generate download IDs for in-progress DB Task-number: QTBUG-70702 Change-Id: I1224643398a2084fcd5d70d2c04b105ed69c1f3d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge "Merge remote-tracking branch 'origin/5.12.2' into 5.12" into ↵Allan Sandfeld Jensen2019-02-271-0/+0
|\ | | | | | | refs/staging/5.12
| * Merge remote-tracking branch 'origin/5.12.2' into 5.12Allan Sandfeld Jensen2019-02-271-0/+0
| |\ | | | | | | | | | Change-Id: I423ab09061b0fb1963953438e6e6b09b2602254f
| | * Update ChromiumAllan Sandfeld Jensen2019-02-201-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The last of the security fixes from Chrome 72 Changes: 493fab1afff5 [Backport] Fix for security issue 895970 Fixes: QTBUG-73417 Change-Id: If6a4f6f5773c99db3498e3b178cce39e36c85e79 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Merge 5.12 into 5.12.2Kari Oikarinen2019-02-2011-37/+93
| | |\ | | | | | | | | | | | | Change-Id: I660e890b4630fba2c6828571cac99a529f24be50
| | * | Update ChromiumAllan Sandfeld Jensen2019-02-151-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 61b45663dff1 [Backport] Fix for security issue 903500 a3b4be8d0247 [Backport] Fix security issue 901677 82b53e95166e [Backport] Fix security issue 895117 a26c352168ec [Backport] Fix for CVE-2019-5784 Task-number: QTBUG-73417 Change-Id: I149ae5a5cd4d83f17bd0c603dd2e3a1079c86e82 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | | Doc: Fix JavaScriptDialogRequest.DialogTypeBeforeUnload enum valueLeena Miettinen2019-02-271-3/+3
|/ / / | | | | | | | | | | | | | | | Fixes: QTBUG-74070 Change-Id: Iad514671a588c0a3e0405dd0141ef54320ae8c86 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix crash on dynamic_cast in global event filterJüri Valdmann2019-02-256-66/+175
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Installing an event filter on QApplication which uses dynamic_cast will crash the application since QtWebEngine is sending QTimerEvents to classes without RTTI information. Fix by 1. Moving the QObject part of MessagePumpForUIQt into api/ as a private class. 2. Using QTimer directly in WebEngineSettings, without subclassing. Fixes: QTBUG-73833 Change-Id: Ida73006a4fef76637c964f8f05468adcc4a190ce Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix handling of touch icons when it is disabledPeter Varga2019-02-253-14/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Store the icon type in a bitfield because the same icon URL might be used for various types on same page. This way webengine won't ignore to download a default icon what is also set as a touch icon when touch icons are disabled. Moreover, do not store the icon types from the previous page because a subsequent page might use the same icon URL but with different type. With this change the type of the cached icons are updated after each page load. Fixes: QTBUG-70081 Change-Id: I8031a740b07b0c6a8e5759a994f386b13ce87be2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Doc: Always treat \brief as full sentenceKai Koehne2019-02-2211-27/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure all \brief descriptions start with an upper-case letter and end with a . Also start descriptions of \class with the name of the class or struct. Change-Id: Ifd2656201f9c1dff092085508a5423ce516e2d3f Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | Clarify documentation of QWebEnginePage::title()Jüri Valdmann2019-02-222-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Explain what happens when the HTML has no proper <title> defined and clarify the meaning of 'by default': it refers to the state before load()/setUrl()/etc. Fixes: QTBUG-71799 Change-Id: Ib2669007573b3ea53e205d9228237bae392f6f78 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | Doc: Copy minimal example code into overview pageKai Koehne2019-02-211-3/+13
| |/ |/| | | | | | | | | | | | | After change cfe53bce9, the 'minimal' example isn't that minimal anymore. Rather copy the few lines, like we already do for the widget example. Change-Id: I9dd818738edb8d229f54ff24822d4c1723376ccc Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | Remove download properly on profile destruction to avoid use after freeKirill Burtsev2019-02-196-25/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | In the Widgets API, download items are children of the profile and are destroyed when the parent profile destroys its children. The download item's destructor can therefore not access the profile, as it would cause a heap-use-after-free crashes. On quick side turn ongoing downloads cleanup to match widgets one. Fixes: QTBUG-73839 Change-Id: Iabb379e91187e3e68ebcd4693fec35883b72b1f2 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Set download state to finished when cancelling or destroying the download itemKirill Burtsev2019-02-194-10/+34
| | | | | | | | | | | | | | Task-number: QTBUG-73839 Change-Id: Ieebaa802bdfe0c410618e4213a9bedbbae9d0f61 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Doc: Fix type of WebEngineDownloadItem::view propertyKirill Burtsev2019-02-191-1/+3
| | | | | | | | | | | | Change-Id: I46fc228d99ad6d89d6f2a79a7f3c3352befe0a64 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Fix crash in tst_Spellchecking::spellcheckJüri Valdmann2019-02-193-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test tst_Spellchecking::spellcheck crashes when run with QT_LOGGING_RULES=qt.accessibility.cache.debug=true which triggers debug output from QAccessible::registerAccessibleInterface and QAccessible::deleteAccessibleInterface These functions are called during the construction/destruction of BrowserAccessibilityQt. The problem is that BrowserAccessibilityQt is not necessarily in a valid state at these times: BrowserAccessibilityQt relies on it's manager to be *fully* initialized yet BrowserAccessibilityQt may be constructed/destructed *during* the managers construction/destruction. The solution is to override QAccessibleInterface::isValid to return true only if the manager is in a valid state too. This disables the debug output and avoids the crash. Fixes: QTBUG-72878 Change-Id: Icffe4e503145133c24535fb094bbcb606568e57c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Update ChromiumAllan Sandfeld Jensen2019-02-141-0/+0
|/ | | | | | | | | | | | | | | | Changes: 5c76f0592d0e [Backport] Fix for CVE-2019-5776 8b78be4530ae [Backport] Fix for CVE-2019-5775 and CVE-2019-5777 297b64d3d7d7 [Backport] Fix for CVE-2019-5779 42b4075a690d [Backport] Fix for CVE-2019-5783 5ee5529dea3a [Backport] Fix for CVE-2019-5781 5bebe28ae4d0 [Backport] Fix for security issue 912508 48192fb6548b [Backport] Update sqlite 3709910608cd [Backport] Fix for security issue 908358 Task-number: QTBUG-73417 Change-Id: If451e38f04bc4df90230acd51192a38c184df304 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update ChromiumAllan Sandfeld Jensen2019-02-121-0/+0
| | | | | | | | | | | | | | | | | Changes: 509f0033c434 [Backport] Fix for CVE-2019-5762 436537b89cc4 [Backport] Fix for CVE-2019-5763 69210928ceaa [Backport] Fix for CVE-2019-5764 c0f8161a7658 [Backport] Fix for security issue 922677 7f14eb3daf24 [Backport] Fix for security issue 899689 328129c5de09 [Backport] Fix for security issue 912520 a917b0698d8d [Backport] Fix for CVE-2019-5769 6c8f45a91435 [Backport] Fix for CVE-2019-5770 7b5e48775b3a [Backport] Fix for security issue 907047 Task-number: QTBUG-73417 Change-Id: I941f322313f42a6c92712f1d6cb7ae9a915bcf2e Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Shutdown ProxyResolutionSerivceMichal Klocek2019-02-111-0/+3
| | | | | | | | Shut down the ProxyResolutionService before regenerating storage, it may have pending URLRequests. Change-Id: If79efc0bc942762dc48a50a12d74593ff1ee3989 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Better error reporting for QWebEngineUrlSchemeJüri Valdmann2019-02-113-6/+46
| | | | | | | | Add warnings for late registration and invalid configuration. Fixes: QTBUG-72842 Change-Id: I2c103c3b3581112cc885c3a1b4f42c011c3510ab Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Doc: Extend documentation of callbacksTamas Zakor2019-02-083-0/+29
| | | | | | | | Warn about callbacks on QWebEnginePage destruction. Task-number: QTBUG-72816 Change-Id: I8dbc297a8f364bc237b0672a63325af8da197e01 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2019-02-051-0/+0
| | | | | | | | | | | | | | | | | | | Changes: fe4f93f10929 Disable unsupported JavaScript APIs in PDF extension 99bfdd214657 Fix apps_shim build file to properly flag extension related files fd293fc03974 Minor. Drop dependency for ffmpeg for test_support 50d06b752453 [Backport] Fix for CVE-2019-5754 cf5bd0c9157c [Backport] Fix for CVE-2019-5755 7a5167caf765 [Backport] Fix for CVE-2019-5782 09ae6be5bb83 [Backport] Fix for CVE-2019-5756 6605d8f7b430 [Backport] Fix for CVE-2019-5757 3b390539f429 [Backport] Fix for CVE-2019-5758 c350fc2e3258 [Backport] Fix for CVE-2019-5759 63cf07a2a77c [Backport] Fix for CVE-2019-5760 Task-number: QTBUG-73417 Change-Id: Ia72fd847c8c36959189fe9648c81a3eb6dec6a10 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* macOS: Look for the widevine plugin in the possible new locationsAndy Shaw2019-02-041-2/+12
| | | | | Change-Id: Ibaaa64ace3bff9fe630d9448864587bac8f7b128 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Reinstate CT verification using known logsAllan Sandfeld Jensen2019-02-041-2/+11
| | | | | | | | Lost in the transition to Chromium 69 as the function we were using no longer exists. Reimplemented by how it is now done in NetworkContext. Change-Id: I05c986f2941c7d5f2b8641adc8c619ec3f75e0b1 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Merge remote-tracking branch 'origin/5.12.1' into 5.12Qt Forward Merge Bot2019-02-016-93/+60
|\ | | | | | | Change-Id: I4315127d8a329bcb65e6853d4f3625b6dbc55560
| * Update Chromiumv5.12.1Allan Sandfeld Jensen2019-01-161-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 9aa80f767b Fix jumbo build with GCC 35e15c6001 [Backport] Security bug 880207 4848d71bd9 [Backport] Security bug 881252 and 896326 27c402195e [Backport] Security issue 849942 fec48c17fa FIXUP: [Backport] Security bug 881252 and 896326 Fixes: QTBUG-72612 Change-Id: I27c3214b9491112a0ec576ef4f609534e4eb0e94 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Fix incorrect GLX pbuffer attributes terminatorKirill Burtsev2019-01-091-1/+1
| | | | | | | | | | | | | | Reland fix 04337275e4 after adaptations d5bffb5125 Change-Id: Ieca40fd2ac3d245f760c9b24e2d42d21855b836a Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Fix hide/show of delegate widgetMichal Klocek2019-01-091-0/+1
| | | | | | | | | | | | | | | | | | | | For QQuickWidget::show does not work correctly if widget was not hidden. Fixes: QTBUG-72299 Change-Id: I12fba8c18cbf3f847d30de8b057a50e6d9917fde Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| * Fix recreation of cookie store and channel id serviceMichal Klocek2019-01-092-91/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As more things gets mojofy and become services, we can not simply delete parts of storage context. Therefore regenerate whole storage in case of cookie store, cache, agent settings updates. URLRequestContextStorage guards correct order of destruction. This change aims to fix some crashes during cookie store and http cache recreation when ChannelIDService gets deleted. Depending on timing this ends with different stacktraces like in cookie store manager or during ssl handshake. We still keep network delegate outside of storage context to prevent crashes when url requests end their life due to (forced) request cancellation in cancelAllUrlRequests(). Please note this is just band-aid patch, and introduction of 'profile builder' will be a proper fix. Fixes: QTBUG-71895 Change-Id: If33a7af3ebba2632ea33f32d913e1c21a4534817 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Merge 5.12 into 5.12.1Kari Oikarinen2019-01-0816-62/+191
| |\ | | | | | | | | | Change-Id: Ia86d2e001e3575bb4995f5f57b88d6c809246941
| * | Update ChormiumMichal Klocek2018-12-211-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following patches: * b3a4dd9 Fix heap overflow when allocating PowerSaveBlocker * 5463947 Fix use-after-scope on reference temporary detected by ASan Change-Id: I1777cb6d25d3364257e79054b1db23a4265ae00a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | Update ChromiumMichal Klocek2018-12-201-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following patches: * 4010e56 Minor. Remove old src version of sqlite * f97a65c [Backport] Update SQLite / Security bug 900910 * 35b62be [Backport] Prepare for sqllite update * 63dee74 [Backport] Security bug 877843 * 0ccf56b [Backport] Security bug 892643 * 2efddba [Backport] Security bug 839250 * 4627bab Add extensions to Qt build and fix it up for building * daa969c [Backport] Security bug 880665 * 04610f2 [Backport] Security bug 879965 * e1fe9e1 [Backport] Security bug 882270 * 7181bb5 [Backport] Security bug 895885 * 0dbd045 [Backpack] CVE-2018-18359 * 0473fab [Backport] CVE-2018-18358 * ed2a611 [Backport] CVE-2018-18357 * 5ee3488 [Backport] CVE-2018-18356 * 5e8a4ea [Backport] CVE-2018-18355 * 7d3f4e6 [Backport] CVE-2018-18350 * e0811d9 [Backport] CVE-2018-18349 * 26dba65 [Backport] CVE-2018-18347 * f0135d4 [Backport] CVE-2018-18345 * 586c41a [Backport] CVE-2018-18343 Fixes: QTBUG-72632 Task-number: QTBUG-72612 Change-Id: I32ddc57529b96e531cf14504fa0978cc8d490a26 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | Update ChromiumMichael Brüning2018-12-191-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fbc71baba4 - [Backport] CVE-2018-18342 493c18adef - [Backport] CVE-2018-18341 f5ff8d4a62 - [Backport] CVE-2018-18340 f942ac6b4d - [Backport] CVE-2018-18339 58532117f8 - [Backport] CVE-2018-18338 ef4d1e1ef1 - [Backport] CVE-2018-18337 9a197eab29 - [Backport] CVE-2018-18335 c9155825f4 - [Backport] CVE-2018-17481 7f1f62997f - [Backport] CVE-2018-18336 4a26a08520 - [Backport] Security bug 851821 e63b2a8cb8 - [Backport] CVE-2018-17480 Task-number: QTBUG-72612 Change-Id: I6e970d3527249f1a229a7f3f42dea8886eaa1b6e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * | Fix building with -no-opengl on macOSMichael Brüning2018-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Based on a patch Dmitriy Kuminov. Change-Id: I5365b16e3b25fcfc5e8be33e6cdcfb85e3e118e4 Fixes: QTBUG-72540 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Fix permission type conversionKirill Burtsev2019-01-311-0/+1
| | | | | | | | | | | | | | | | | | | | | Amend change for clipboard permission f2bdf9af58 Change-Id: I151766a3fc00c105b656bfb646c565a175691139 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Answer permission checks for clipboard permissionsSzabolcs David2019-01-302-8/+42
| | | | | | | | | | | | | | | | | | | | | | | | Wire page settings into clipboard permissions and add some auto test. Task-number: QTBUG-72714 Change-Id: If921c65cdff7f55a48340d90fc593071febc6ebe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Remove QWebFrame commentsKai Koehne2019-01-301-2/+0
| | | | | | | | | | | | | | | Change-Id: I82855788542dc7b659eb8d83565b6f32d89d0ea5 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Fix build after qtdeclarative change - 9e3c46961aAllan Sandfeld Jensen2019-01-241-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | We depended on another header including qopenglcontext_p.h Fixes: QTBUG-73224 Change-Id: Ifbd7e17cd62b08466ebbe4d2091c92e4091fc8a3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Fix crash on exit with single processMichal Klocek2019-01-231-9/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Shutting down the browser runner in single process mode requires the browser context to be present. Moreover single mode does not support multi browser context. For single mode move profile destruction to PostMainMessageLoopRun. Fixes: QTBUG-45722 Change-Id: I15b5aa17061b4dd7898d0ff9427fada44d2eff74 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* | | Remove download items internally when API objects are deletedAllan Sandfeld Jensen2019-01-216-12/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were never removing internal download item. [ChangeLog][Behavioral Changes] Deleting a download item will now also cancel it if it is still in progress. Change-Id: I2fab497d7acf7ca6ca17f4a61e106b1c18bfb333 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Fix build when we don't have all the X11 dependenciesAllan Sandfeld Jensen2019-01-172-13/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We only enable the GLX backends when we have all the X11 dependencies, but try to build the corresponding sources files even when we don't. And additional xrandr is no longer a dependency. Change-Id: I35c97c34c6d121bd6544344a73653900bf406be3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Do not force wrapping of tooltipsKai Koehne2019-01-081-3/+3
| |/ |/| | | | | | | | | | | | | | | | | | | QToolTip does wrap aggressively if HTML text is shown, which <p>...</p> enforces. Anyhow, this is not the default behavior for most browsers. This reverts part of b43774a9b89ed9. Fixes: QTBUG-72021 Change-Id: Iea0480c51f7c35c466bf3064423b2a81ee5b926c Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Rename leftovers of BrowserContext to ProfileAdapterMichal Klocek2019-01-074-10/+10
| | | | | | | | | | Change-Id: Ia86459503be86eb9b0d97affe94b7ce82d5e29f1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Unify input event timestamps among platformsPeter Varga2019-01-041-21/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Chromium's expected timestamp base is the time when the system was started. QInputEvent::timestamp() returns a timestamp for the actual platform that may differ from the Chromium's standard. Use base::TimeTicks::Now() at the input conversion instead. This may provide less precise but valid timestamp for all cases. Fixes: QTBUG-72654 Change-Id: I2235344a629072c15f7b16c033e13260093de958 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Fix QWebEngineUrlRequestInfo::firstPartyUrl() after 69-basedTamas Zakor2019-01-031-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue was introduced by this Chromium change: https://chromium-review.googlesource.com/c/chromium/src/+/1025772/ Add new auto tests for first party url. Depends on Chromium change: d2f5d6869f Add net::URLRequest::first_party_url() Task-number: QTBUG-70790 Change-Id: Ib43bde69990e7fb1d495cc32ac2f6860a613f185 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Lock profile mutex during interceptRequestJüri Valdmann2019-01-024-7/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes setRequestInterceptor take effect atomically, so it's always safe to delete the interceptor after unsetting it from the profile. On the other hand, we run into a deadlock if the user code tries to wait for a profile operation on the UI thread to finish. It seems quite unlikely though that user code would do that and it would probably still be easier for users to understand and debug than the current non-deterministic use-after-free problems. Task-number: QTBUG-72260 Change-Id: I1784a9d9f00029d440508f0bb076d1081a326758 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | Fix key and keyCode of KeyboardEvents for dead keysJüri Valdmann2019-01-021-6/+77
| | | | | | | | | | | | | | | | | | | | | | 1. Extend Qt::Key to ui::DomKey conversion to handle most Qt::Key_Dead_* keys. 2. Supplement Qt::Key to windows key code conversion with a fall back to DomCodeToUsLayoutKeyboardCode. Fixes: QTBUG-72655 Change-Id: I9ab8dc5f931065c4dc381adc5a1690ee288b8244 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Fix uniquifying download filenameTamas Zakor2019-01-021-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | The QFileInfo::baseName() can’t be used to split the filename when it contains a dot what is not for extension. Moreover, use timestamps after 100 numerically deduplicated filenames as chrome do: https://chromium-review.googlesource.com/c/1278137 Task-number: QTBUG-66262 Change-Id: Ice548ba2824bd43cf7ad00509b598853087274af Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Doc: Fix a broken link to macOS requirementsLeena Miettinen2018-12-131-1/+1
| | | | | | | | | | | | | | The docs we restructured for 5.12. Change-Id: I0b879bc9fb085d5743a16bc89d405e11f22ca66c Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 09:30:56 +0000