summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* PdfDocument: resolve the source URLShawn Rutledge2022-02-112-7/+12
| | | | | | | | | | | | | | Similar to qtdeclarative 0a1e4cc7ec7548f6273befff9cdddb0bc7a58961 except here, setting the source calls QPdfDocument::load() immediately, so we need to resolve the URL right before doing that. The results are visible in most of the manual tests: they again load test.pdf immediately, as in Qt 5. Change-Id: I8c67a9e1c72ac390c24d72d5e229ff0ef9f4aa0d Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 3159ac9ff7edf0eea93fa8331ea6cb8abc201ca2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix crash on WebEngine(View|Profile).userScripts.collection getKirill Burtsev2022-02-1011-21/+180
| | | | | | | | | | | | | | | | To create a javascript list on 'collection' method qml engine is needed for a qml scope, but it's only available for objects, which are created by the QML Engine itself. The only object in hierarchy of classes is an actual WebEngineView, so get it from there on collection init. Also implement delayed initialization of scripts collection for the usage of default profile through WebEngine singleton, and for the reason that it's not really needed until really asked by user code. Fixes: QTBUG-96597 Change-Id: I61e76652a5d0fd5609070fd541816503908f2dc8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit f5fbc34fc16fc9c6e7f7e8bbbf60f5b343b9466d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QQuickPdfSelection: Fix division by zeroPeter Varga2022-02-082-1/+6
| | | | | | | | | | | | | | | | | | | QQuickPdfSelection::m_renderScale is used for division in QQuickPdfSelection::updateResults(). Add warning message to setRenderScale() and ignore the new value if it is zero. Also avoid setting PdfSelection.renderScale to zero in PdfScrollablePageView. The division caused an assert: ASSERT: "divisor < 0 || divisor > 0" in file qtbase/src/corelib/tools/qpoint.h, line 299 It was reproducible with the pdfviewer quick example. Change-Id: I31e08a9a28392fcc132470c8d94af1307447565a Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 4f7b7995552b0220a9e431266e0119cd03a233cf) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QtPdf: Fix QML warning about usage of injected signal parametersPeter Varga2022-02-082-2/+2
| | | | | | | Change-Id: I4bbc3c1adf4ba2bc5cc8d71278e201ee05fc85bd Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit f28c0e6680f3ef8ebb5e82d0fe375afbc6fb0fe9) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix accumulation of compositor-observer bindings for skia-on-glKirill Burtsev2022-02-085-11/+2
| | | | | | | | | | | | | | One of Compositor's derived classes, DisplaySkiaOutputDevice, was missing call to 'unbind' from its observer, leading to not releasing binding from global cache on destroy. Since unbind is done on destroy, remove all explicit calls to unbind from derived classes, and just do them in their base implementations. Ammends b117909825. Change-Id: I75c909eaa22ca1946ad67aa5093a8ee268c3562b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 16b2976e2c983cabe6011cd732e3ec46e3402d22) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add QtPdf iOS buildsMichal Klocek2022-02-082-3/+8
| | | | | | | | | | | | | | | | | | | | | | | QtPDf iOS builds must support fat libs builds. Compared to 5.15 however this is done differently. Before we tweaked gn to compile multi arch with 'Xarch' parameter. This had few downsides as we could not determine which arch/cpu compiles given file as compilation was opaque to gn. The current approach is to follow mac universal builds, compile builds separately for each architecture and lipo the outcome. However, this introduces some issues as ios builds are static builds and creating lipo archive will gather object files, which should end up in final QtPdf lib instead. Therefore create multi arch object file instead of archive and use this one. Note the compiler now uses arch triple for Pdfium as Chromium does, however qt files still use 'arch' and '*-version-min' combination. Task-number: QTBUG-88614 Change-Id: I7775c8b4d1554df497eb61fa6187f12c00b9032d Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 8998563677e3f308083ba1c4c28efd6fe3d850f7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Introduce gn complete static lib target for qtpdfMichal Klocek2022-02-083-4/+7
| | | | | | | | | | | | | | | | | | | | | | | With 6.x we have gn-cmake integration which allows now in case of static builds to switch gn target output to static_library with 'complete static' option instead of shared_library. This way we can avoid installing dependencies in form of internal static Chromium archives as it was done in 5.15 in case of static builds. Unfortunately 'complete static' option can not be used with QtWebEngineCore build as it will exceed 4Gb static archive limitation on Windows, however it will work fine with QtPdf. Note the qtbase 3rdparty static libs have to be still installed in case of qt static build, this patch only eliminates need for Chromium specific ones. Task-number: QTBUG-88614 Change-Id: I6fc4ce48c79a1631b013d0b29c190c62280f7304 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 8e549e6e0ccd6078b3bd2e38b87337fd367dec55) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumMichal Klocek2022-02-081-0/+0
| | | | | | | | | | | | | | | | | | | | | | Pulls in following patches: * 2b0dbbbbe5d Add GN arg to pass gssapi include directory * 5bdf41e551b Revert "[macOS] Fix build error with new deployment target" * ceaca362c9a Fix ios compilation issues * c6dd23dca6e FIXUP: Remove fat lib support * 4d33af9093a Add qtpdf ios gn adaptations * b09e95c3fe8 Revert "Make compile time switch at compile time" * ca78f43edb2 Revert "Disable long presentation time DCHECK" * b042491acb4 Revert "Fix disabling reporting" * d5ae47fe7af [Backport] Fix build for 'enable-reporting=false' * ee7acb3042a [Backport] Remove NOTREACHED assertions from NetworkContext's reporting methods * d133820740f Do not create empty rsp files * 6ca2e0597b8 Revert "Fix build with GCC 10" Change-Id: I22b7c6f5b1866111711ecdc34e0b2295824ec910 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Detect GSSAPI on Linux and pass it onAllan Sandfeld Jensen2022-02-032-0/+8
| | | | | | | | Fixes: QTBUG-100291 Change-Id: Iba9a9b41938e6ff9270bb8f98393c31d30663859 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit a4b28af742592284208a078cee26b20239b72c3e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Do not list native spellchecker feature on LinuxAllan Sandfeld Jensen2022-02-021-2/+5
| | | | | | | | | | | And make the condition more general as it is available on both macOS and Windows. Fixes: QTBUG-100293 Change-Id: If430eaa219f910bc686dc0859178b52a0d0c3fb3 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit a44849f7298de667dd0254f4a19546ffa40552be) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QWebEngineView Designer plugin: Fix crash on Windows when using D3D11Friedemann Kleint2022-02-011-0/+9
| | | | | | | | | | | Disable the plugin for non-OpenGL graphics API similar to qttools/482125b15648944d18ae120644f9ffe11b327ff2 for QQuickWidget. Fixes: QTBUG-100285 Change-Id: Icea3d81c97ef043e953334b134ba632a9daa13a5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit cd716a2ea2a1f0a3222dcb3cea5d4cee903def09) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Improve local scheme access rulesAllan Sandfeld Jensen2022-01-286-43/+57
| | | | | | | | Task-number: QTBUG-96849 Change-Id: Ieb24da12a61e5e37b29ccf2d1a11b7bd863b842e Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 3071de1e07be28d763164a037d946281146bf31d) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2022-01-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty dd2725bea..206bed415: > Allow accessing file protocol from protocols with local-access > Add allow_remote_access_from_local_urls setting > FIXUP: Optimize skvx::fma for GCC > FIXUP: Optimize skvx::fma for GCC > [Backport] Fix wrong mipmap sampling option for Medium filter quality > Speculative fix for build error > [Backport] CVE-2021-4102: Use after free in V8 > [Backport] CVE-2021-4101: Heap buffer overflow in Swiftshader > [Backport] CVE-2021-4100: Object lifecycle issue in ANGLE > [Backport] CVE-2021-4099: Use after free in Swiftshader > [Backport] CVE-2021-4098: Insufficient data validation in Mojo > [Backport] CVE-2021-4079: Out of bounds write in WebRTC > [Backport] CVE-2021-4058: Heap buffer overflow in ANGLE (2/2) > [Backport] CVE-2021-4058: Heap buffer overflow in ANGLE (1/2) > Fix compilation with c++20 > [Backport][heap] implement more stub method to fix build with msvc > Revert "Forward declare newer EGL typedefs" > Revert "Fix Linux kernel lacking V4L2_CID_POWER_LINE_FREQUENCY_AUTO" > Optimize skvx::fma for GCC > Use clang builtins in gcc when available Change-Id: I01d2274ee3b7467dad431365985112864e39a1fc Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 8f45d71a77f34ad250b73b9bbaf02dbaed6cc831) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Guard against favicon provider being removed before ViewKirill Burtsev2022-01-281-1/+1
| | | | | | | | | | | | Avoid using dangling pointer on view's destruction in case favicon provider was removed first by QML engine. Just use a QPointer since it's not used for anything much else internally in a WebEngineView. Fixes: QTBUG-100032 Change-Id: I0560798a02bed02b0aabee61e1b0ae41a6e87d8a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 9392bce5380c5cc04a1e1b0ac15306ed67a7398e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Use IsSameDocument() rather than IsLoadingToDifferentDocument()Benjamin Terrier2022-01-271-1/+1
| | | | | | | | | | | | | | For certain types of redirect navigations (for example, with a non-default useragent set) 'IsLoadingToDifferentDocument()' can be unexpectedly false. In such cases 'navigation_handle->IsSameDocument()' also returns false. Fixes: QTBUG-94924 Change-Id: Ie2c17127e1a00ffc515829526320ba2f71d45af5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit 8b5e3a46f253cd82dc48bc20c4233f1bf79fcb87) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* webenginequick: Avoid deprecated QQmlListReference ctorFabian Kosmale2022-01-262-3/+4
| | | | | | | | | | This doesn't modify the signature of appendExtraItems (which no longer requires the engine pointer) to keep the change minimal. Change-Id: I2a649cd8d8e68c4c6e1a607d881f9180ac931032 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 9bf3cce203cc673880b0429c5c98bb8cc9be204f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Widgets: Add FileSelectionMode::FileSelectSaveSzabolcs David2022-01-203-0/+4
| | | | | | | | | | Now we have an example to trigger this type of dialog, we can expose this as public API. Change-Id: If0964d07a532daaff5e798dac63dc02ec7781d4d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 99b46c0959ec6280ee51c0d9ef8df432fd96a5bc) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add xkbfile to pkgconfigAllan Sandfeld Jensen2022-01-201-4/+3
| | | | | | | | | | To get the correct includes if they are less standard Fixes: QTBUG-99890 Change-Id: Ibd751d46dce7e00e4ce8433549e778d4814dae30 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> (cherry picked from commit 52f0ca90445c633c68694fde84b4630a13c3c14e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Find GIO like qtbase doesAllan Sandfeld Jensen2022-01-191-2/+2
| | | | | | | | | | | | Otherwise it can conflict and cause issue on reconfigure Change-Id: I3e7756b4720bc5a1e82ef0f327b8c9dbc76667ec Fixes: QTBUG-99669 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> (cherry picked from commit 0b6310bf48cfe9772be6ca2b51c685acce3f4ba6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Fix find_package() call for Qt PDFKai Köhne2022-01-171-2/+2
| | | | | | | Change-Id: Id19aa463db605c861a1bd3502eb964c8f9340e4d Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 4f592dbbb1069ef03595e083e34ee6cdbf7c0fec) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Do not override signal handlersAllan Sandfeld Jensen2022-01-151-0/+1
| | | | | | | | | | We used to have this, but it got dropped at some point in an adaptions. Fixes: QTBUG-99263 Change-Id: I3bf86a1b42edca0cd792723c85d7dcb7877fea37 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit fbaab46becbf5ea063a8b4a01abf8cd1d4a1725d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix printing PDF filesSzabolcs David2022-01-143-10/+37
| | | | | | | | | | | | Delegate printing task down to the guest WebContents if any is present. Also update PrintWebViewHelperDelegateQt to find the plugin element properly for printing. Task-number: QTBUG-98941 Change-Id: I81004a2275e0870a17565af527b1450472afb24b Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 455efe7ef204c6cd8de72b9b1f922f1681f58589) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Minor. Fix cmake warningMichal Klocek2022-01-141-1/+1
| | | | | | | Change-Id: I940db4bc953db9e571370886f142387dce5f12bb Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit 85e6646d66b50b9fe471052cbc84b8c7bc253df0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix not working web ui popup (html comboboxes) due to focus out eventsMichal Klocek2022-01-131-1/+6
| | | | | | | | | | | | | | | | | | | | | | | Recent change in qtdeclarative 42d411e2e8 causes a focus out event being delivered in case of popups to "root" item of quickwidget. This is not expected as events are forwarded to parent "view" and loosing a focus will hint Blink to trigger a pop up close request. As a communication with a render process is asynchronous this creates several race conditions in our tests and the Blink's popup close request can close unexpectedly windows creating dangling pointers. Moreover, the focus in never gained back leaving the Blink's logic in a limbo state. Simply ignore a focus out event in case of popups. Fixes: QTBUG-99215 Change-Id: I5ca6eda227101d4f19f15735e41f066cfd8ccea0 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit ba2e26f3d94f0a4bb0077bed19f2b04a7b5104f0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumAllan Sandfeld Jensen2022-01-131-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 735b1a398..dd2725bea: > Do not overwrite signal handlers in the browser process. > Quiet false error message > FIXUP: Stop using C++20 initialization > [Backport] Security bug 1259899 > [Backport] CVE-2021-4057: Use after free in file API > [Backport] CVE-2021-4078: Type confusion in V8 > [Backport] CVE-2021-4059: Insufficient data validation in loader > [Backport] CVE-2021-4062: Heap buffer overflow in BFCache > Fix crashes with MSVC > Bundle all localisation files for DevTools > Speculative fixes for build race conditions > Allow DevTools to download remote translations > FIXUP: Fix disabling reporting > Use wglSetPixelFormat directly only if in software mode > Fix jumbo build: syntax error in v8 token.h(211) > [Backport] CVE-2021-38017: Insufficient policy enforcement in iframe sandbox > [Backport] CVE-2021-37987 : Use after free in Network APIs > [Backport] CVE-2021-38015: Inappropriate implementation in input > [Backport] CVE-2021-38018: Inappropriate implementation in navigation > [Backport] CVE-2021-38021: Inappropriate implementation in referrer > [Backport] CVE-2021-38005: Use after free in loader (3/3) > [Backport] CVE-2021-38005: Use after free in loader (2/3) > [Backport] CVE-2021-38005: Use after free in loader (1/3) > [Backport] CVE-2021-38019: Insufficient policy enforcement in CORS > [Backport] CVE-2021-38007: Type Confusion in V8 > [Backport] CVE-2021-38009: Inappropriate implementation in cache > [Backport] Dependency for CVE-2021-38009 > [Backport] CVE-2021-38012: Type Confusion in V8 > [Backport] CVE-2021-38010: Inappropriate implementation in service workers > [Backport] Security bug 1252858 > [Backport] Security bug 1241912 > [Backport] CVE-2021-37994 : Inappropriate implementation in iFrame Sandbox > [Backport] Dependency for CVE-2021-37994 > [Backport] CVE-2021-37996 : Insufficient validation of untrusted input in Downloads > [Backport] CVE-2021-37989 : Inappropriate implementation in Blink > [Backport] CVE-2021-37985 : Use after free in V8 > [Backport] Security bug 1245870 > [Backport] CVE-2021-37992 : Out of bounds read in WebAudio > [Backport] CVE-2021-37993 : Use after free in PDF Accessibility Change-Id: I1d284f43d5042d094736b89385c638089b9c8c2f Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 026de53d131990c0560e6b037eb93574c8163e8d)
* Add objectName to webengine accessibility objectsAllan Sandfeld Jensen2022-01-084-19/+42
| | | | | | | | | | This requires adding a QObject to represent the backing node. Fixes: QTBUG-99485 Change-Id: I4d8c722a0dfb1f374995f3feab23b93ed5d8752a Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit d95f6a6b23e3052c39a32f50d6e604cf17e698e3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix inspector overlayAllan Sandfeld Jensen2022-01-061-0/+2
| | | | | | | | | | Was missing resources that had moved Fixes: QTBUG-99526 Change-Id: I68b05b9de3dbd6c6460e5495a939e2599623a047 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6617cb8edb51bce85861e44035948d8f634c985b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Always generate printing buildflagsAllan Sandfeld Jensen2022-01-051-3/+1
| | | | | | | | | | We include them unconditionally Fixes: QTBUG-99511 Change-Id: I4d9ebbf5777099ade38740ceb41532f0088df4c0 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 7720aa45fa8419da4c90ffed9954fbf7502d062e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update SG backend codeAllan Sandfeld Jensen2022-01-051-53/+21
| | | | | | | | | Correct the debug output and remove references to dead code like ANGLE. Change-Id: I261ecf23a200c4328ea79514f7f75fce991960f5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 3d0b32c93c0d45bf61a77e76ef9ab54efd2b2eeb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Cleanup code and clang build warningsKirill Burtsev2022-01-0316-62/+18
| | | | | | | | | | Fix build noise as reported by clang for issues like api deprecation, unused variables, sign/unsigned mismatch and other non critical issues. Change-Id: I4fba25406eea8170e3283c42e908ae86bd512e3a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 02d58a067fb5f0db32c254e783170f9f283aeb9d) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix crash on meet.google.comSzabolcs David2021-12-301-1/+7
| | | | | | | | | | | Hangout Services extension has a background WebContents. Do not try to access its delegate and settings. Task-number: QTBUG-99119 Change-Id: Ib46867ba98644e14af6263253daa253ef2e6b12a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1552ad5d3e66460bbbb5bbd71ca2083fb9d17d3f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix headers in GN sourcesAllan Sandfeld Jensen2021-12-241-4/+2
| | | | | | | Change-Id: Ib2faa3e0242799e1088d4ec7c610fa89a4d15bbb Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 540b1cadb1888a9adde8cf338fcdbd8630423c0b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* FIXUP: Add onTouchSelectionMenuRequested QML handlerBalazs Egedi2021-12-234-4/+22
| | | | | | | | | Fixed CodeChecker warnings, added missing documentation. Change-Id: I723ea2b0952ded52f513a3cd53ac443b727f1e58 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 56005ae3d52568b469db32498afebd9c52e4881b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdf namespace: export the staticMetaObjectMarc Mutz2021-12-141-1/+2
| | | | | | | | | | Otherwise users outside the module can't access it. Fixes: QTBUG-99144 Change-Id: I8348f64bca9a4cd9bcdbddb8fbfd7554c29f5357 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit cf9ecc2019f9800e33f2963770ccb1ea1bb20813) Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
* Adopt modern QESDP usageAllan Sandfeld Jensen2021-12-094-40/+14
| | | | | | Change-Id: I654c07c3b9925977dd85821a36fd6f8130556cac Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* QPdfSearchResult: std::move ctor argumentsMarc Mutz2021-12-082-5/+10
| | | | | | | | | | The ctor is a perfect sink for the arguments, and already took them by value. What was missing was to std::move them into place instead of using the copy ctor. Change-Id: I3a708bea2cdd8417ea3e604af2850d99a5966c3f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Replace GeolocationSystemPermissionManager with GeolocationManager after 94 ↵Peter Varga2021-12-084-17/+19
| | | | | | | | | | | | | adaptations This is necessary to fix crash with disabled geolocation on macOS. The change in upstream is: Use GeolocationManager in CoreLocationProvider https://chromium-review.googlesource.com/c/chromium/src/+/2779636 Change-Id: I97143886bc3c98ad880c3cfc739ef08e5bfa3e73 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix crash with disabled geolocation on macOSPeter Varga2021-12-084-2/+60
| | | | | | | | | | | | | | | | | QtWebEngine uses custom LocationProvider for geolocation. If geolocation is disabled, Chromium fallbacks to NetworkLocationProvider. NetworkLocationProvider uses GeolocationSystemPermissionManager and tThere is no nullptr check for the manager instance so QtWebEngine has to provide it. This fix implements a FakeSystemGeolocationPermissionManager what is meant to be used only on macOS if geolocation is disabled. LocationSystemPermissionStatus is always set to denied by the fake manager. Pick-to: 6.2 Change-Id: I25d51c9ce8911b95ff69cc72bc6aae7023e7edbe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update documentationAllan Sandfeld Jensen2021-12-072-6/+0
| | | | | | | | | The signal is updated much faster for paused media now. Pick-to: 6.2 5.15 Fixes: QTBUG-98918 Change-Id: Ifa3b54e212436a7c93e101dc244d7edcbf473b63 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* qpdfX_p.h: include qpdfX.hMarc Mutz2021-12-073-0/+6
| | | | | | | | It's best practice, and will probably solve a linker failure/ODR issue in a subsequent patch. Change-Id: Ieff9d20ddc3b49286459d554a2ff6a706a41af2e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QQuickTableViewExtra: make ctor explicitMarc Mutz2021-12-071-1/+1
| | | | | | | | | It's a private class, but add the missing explicit keyword to avoid raised eyebrows in the next reader. Task-number: QTBUG-98796 Change-Id: I63bb45d840b8b09f2b1fe3343fd8fe83416fa60e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Make default ctors implicitMarc Mutz2021-12-076-6/+12
| | | | | | | | | | Default ctors should be implicit, because users expect '{}' to call them. If they're explicit, because they're folded into the (QObject* parent) ctors, then that no longer works. Fixes: QTBUG-98881 Change-Id: Ie52812ba76ee0b489c75ecf48b0c048025fde8c7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdf namespace: Q_DECLARE_OPERATORS_FOR_FLAGS inside the namepaceMarc Mutz2021-12-071-2/+1
| | | | | | | | Otherwise the operators aren't found by ADL. Task-number: QTBUG-98796 Change-Id: I9b80f59bf9f8c76234360f07add80528fc4ab326 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Make dtors out-of-lineMarc Mutz2021-12-0714-0/+39
| | | | | | | | | | | Pins vtable to a single TU, instead of duplicating it across all TUs that use the class, possibly causing invalid dynamic_cast<>s and other bugs. Fixes: QTBUG-98880 Task-number: QTBUG-45582 Change-Id: Ic296f4583097181ac4d824fac6dab4671ae14a50 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Mark implicitly-shared classes as Q_DECLARE_SHAREDMarc Mutz2021-12-063-0/+3
| | | | | | Task-number: QTBUG-98796 Change-Id: I2400ef5634ae3c263aaafe1526e843f542a73eef Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-12-061-0/+0
| | | | | | | | | | | | | | | | | Submodule src/3rdparty be03c63b3..735b1a398: > [Backport] Handle long SIGSTKSZ in glibc > 2.33 > FIXUP: Fixes for jumbo build > Compile with GCC 11 -std=c++20 > FIXUP: Fix navigation when clicking on links in a PDF > FIXUP: Adapt accessibility code for our needs after chromium 90 > FIXUP: Add user script data mojo interface and traits > FIXUP: Make GpuSwitchingManager::RemoveObserver() thread safe > [Backport] Return proper value in GLES2DecoderImpl::GetUniformSetup > [Backport][Extensions] Remove string literal conversions by ASCIIToUTF16() > Disable debug info for crbug.com/1224432 Change-Id: I3ddb49ed6853fc78a2b857637888d66af950f8d9 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Check if qt_internal_return_unless_building_tools presentMichal Klocek2021-12-061-2/+3
| | | | | | | | Fixes dev build with 6.2.2 Fixes: QTBUG-97944 Change-Id: I027a473bc7cf239610d2162abb697cf10a557f4a Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix race condition on layout (take2)Michal Klocek2021-12-062-26/+10
| | | | | | | | | | | | | | | | | | | | | Even if layout is 'meaningful' it can still require update before toPlainTextSync call can proceed. Simply wait for frame being loaded in stead of tracking layout update. Depending on DidLoadFinish will brake default toHtml call for empty not loaded page, therefore return expected value if there is no load. This fixes crashes/asserts on certificateError (stacktrace in bug report). Remove blacklist on certificateError as bad certificate is back on line and toPlainTextSync works without issues. Fixes: QTBUG-97414 Pick-to: 6.2 Change-Id: Ib702bbe813f6061eef446e2d87d7e9e455d715c5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdfSearchModel: take a QString arg by cref, not valueMarc Mutz2021-12-032-2/+2
| | | | | | | | The function is not a perfect sink for the argument, and the implementation wasn't moving from the argument, anyway, so do the common thing here and take by cref. Task-number: QTBUG-98796 Change-Id: I4237e50cf9c00817245ad8967bf7e2976ffb7085 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Replace old Qt constexpr defines with constexprAllan Sandfeld Jensen2021-12-021-12/+12
| | | | | Change-Id: Ia68a080fcbf985e2a62178e5ca2722495799f9c9 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-20 09:12:15 +0000