| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After configuring Qt there will be an error message if a suitable python
version could not be found.
Add python2 configure test that
- first looks for python2 in PATH
- then looks for python in PATH
- checks the Python version
- stores the result in QMAKE_PYTHON2
Use $$QMAKE_PYTHON2 everywhere where we call python.
Pass $$QMAKE_PYTHON2 to gn for its exec_script feature.
Task-number: QTBUG-60164
Change-Id: I33de1273cbd20a787b3c8889d35280784dbcd5ae
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
QtWebEngine fails to build with -no-opengl due to
src/core/delegated_frame_node.cpp
trying to use QSGFlatColorMaterial without including the header.
Change-Id: I98c12d3c482f7cacb2f61dd13ae32ee0a5740ae2
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When users defined a single-letter short cut it was not possible
to type this letter in HTML input fields.
Fix this by accepting ShortcutOverride events whenever the web page
is editing text.
Use QInputControl::isCommonTextEditShortcut for Qt 5.9 and later.
For the case where QtWebEngine is built against an older Qt a duplicated
code path is used.
Also, ensure users do not override web action short cuts.
Task-number: QTBUG-59053
Change-Id: Ic26cf2a040a72b118273c6645c00b2913b995b0b
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
| |
Task-number: QTBUG-60163
Change-Id: I4763dca3c651c08fb4094a3def6494b3dcd65ebd
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
| |
Change-Id: I95547a19dfa4dc375f93b2c6c1bfdefc05d07a51
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes ::GetVersionEx to report the actual Windows version,
instead of always reporting Windows 8. Note though that this
fixes only the renderer process - the manifest of the user process
is beyond our control.
Chromium currently uses the dynamic checks for Windows 10 to e.g.
enable advanced sandboxing for ppapi, and scroll performance
(see https://bugs.chromium.org/p/chromium/issues/detail?id=517183)
Change-Id: I72870f31eac2074748b2c11a2b6cab9a03e62527
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
| |
Update our overrides to Qt coding standard getting rid of
Q_DECL_OVERRIDE and redundant virtual declarations.
Change-Id: Id8b0750eb05c51fc8f50cac4000a811eebcbf918
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IME managers may set background and foreground color of the composition
string. Since there is no Chromium API for setting the foreground color,
changing the background color to black may produce "black-on-black" text.
Chromium locks the background color to transparent thus we do the same
in this fix.
Task-number: QTBUG-58362
Task-number: QTBUG-60031
Change-Id: I939c8aaaa847de191890d6924ba3c7652465f8a0
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
| |
Gn is called at qmake time. The run_gn target was empty and did nothing.
Change-Id: I570094e013c63a78ca6cec6987f119bfda45e085
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the OS provided QNativeGestureEvents for pinching and smart
zooming. This replaces the usage of the Android based gesture
recognizer on macOS.
This also implements multitouch gestures to work with the Qt Quick
implementation of QtWebEngine for macOS, because touch events
are ignored by default on macOS in QQuickItem.
Task-number: QTBUG-58779
Change-Id: I17399e4e89a57557540b2fd0940a445326b682f3
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
| |
The two nullpointer checks prevent crashes that happened when one
clicked on a link with target="_blank" in 56-based.
Task-number: QTBUG-46713
Change-Id: I1f8a20a52726ab05a85dbca2ec49784985384d06
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Enable brotli if enabled in content features (which it is by default).
Task-number: QTBUG-60049
Change-Id: I67ee51be47de4df0960e378f74c323ef30a7b25a
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-58362
Change-Id: I6c80c8063ccad97aa80aff8ee44aa10a899c5ff5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instruct the render process to change the text selection if it was
requested via an input method event. Raise the selectionChanged() signal
when all the corresponding input method properties are set.
Moreover, add back the remaining input method widget auto tests. The
updated tests are moved to the QWebEngineView tests since the
corresponding APIs (inputMethodQuery() and input event handling) are now
available via the QWebEngineView's focus proxy (aka RWHV).
Task-number: QTBUG-55766
Change-Id: Ia0022d5f38b31dd59b084ff42e4abc2780ae90ec
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
This was used for registering an alternative QtWebEngine.experimental
import, which has however been removed since then (a4dcc5b4894aac).
Change-Id: I0edd869fcc0057b2c6a4932eb39cb8f739f571bc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Change-Id: I5a4f72493fd892c478074705ccbdb363b4002789
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
| |
Change-Id: Iad422ed29cf1781b4537c747bbe498c32f1e5ef0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
| |
The methods got removed from the script API in change
bec2be57891f87f2b8bc04. However, this might break existing code.
Change-Id: Ibc1b4632ade847953f848b3d1a29a14cab3f035b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
The latest version for Qt Webengine in 5.9 will be 1.5, not 1.6.
Change-Id: Ibae42f24f4b7477901923ff0ef5436642599f365
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
| |
Change-Id: I0831cbb21c5f67b74a1df2311f055e6218ae3619
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
| |
Avoids adding --use-ld=gold on the link command line when gold linker
has been deselected in Qt.
Change-Id: I2d34cd3043aa24dca1f5f1604c97d8beccb70093
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take in following fixes:
853d4069 [Backport] Need this to build on vs2017
f3e4afb7 Merge remote-tracking branch 'origin/55-based' into 56-based
3a8bbfb1 Don't use the gesture detector for scrolls and flings on macOS
a3e8625c Export GN calculated sources to qmake
4d83c198 Licenses: Remove invalid URLs to fix QDoc errors
2229fffd Fix build with GCC 7.0
1cc1d80e Allow using quota management API for non-standard URLs
b05f5036 Silence warnings about unknown attributes
ae91fb1e Fix render process crash for windows debug builds on win10
Task-number: QTBUG-58779
Task-number: QTBUG-59776
Task-number: QTBUG-59812
Change-Id: I9ab8e607e83cea9130ce304a7da636b586bbb9db
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
Is now also buildflag and not command line define.
Change-Id: I3c687981928239f669bd285797b5ceee4e994822
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
File creation with FileSystem API is supported, but these files were
not accessible through their filesystem: URLs.
Change-Id: Ic45a8ad766917947a70eb0079d37490576ea5d22
Task-number: QTBUG-56531
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Change-Id: I0dfe290b9d6ac1ed054cecd0911709e9626f8691
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
Was changed to generated buildflag headers instead of command line
defines.
Task-number: QTBUG-59687
Change-Id: Iead64f5321d000c07172ee27a0032394527ec501
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
Chromium now asserts if the clipboard lists the same mimetype twice.
Change-Id: Ibfcbb9a7953a8b4b55035e633e0f2740257af6ad
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
| |
Create a fake project, just for including the files compiled by ninja
in a qmake project that Qt Creator can index, but which we do not build.
Change-Id: I7b4fc7ba23090bddb49ee1e85f76f71fb33544e2
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
| |
Failing to do so would trigger an assert in the PDFium wrapper's
constructor.
Change-Id: Iaa53b1baa54e6483a4e7e9985ad841ac3cfef940
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
| |
Self build of gn ends with error on embedded builds.
Change-Id: I669c61eef7107919dbe11cdb558cf6ae0499621c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Make sure that the path to ninja and the directory uses the correct slashes.
Without it, the call might silently fail.
Task-number: QTBUG-59842
Change-Id: If59eb14b1fb99aae2b78c85a0052e5aefd5d5bf9
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
...to suppress a QDoc error.
Change-Id: I11cb449137af06e11ba4e14a14da97d0088f8416
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Adds a doc link between QWebEngineUrlRequestInterceptor and
QWebEnginePage
Task-number: QTBUG-54507
Change-Id: Ic9aa535fbf19c7c5ccf279ee660adf180057b56b
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This unfortunately means we lose the ability to customize the title with the
default implementation, but it's still better than having a QMessageBox
hardcoded without being able to customize this behavior at all.
[ChangeLog][Qt WebEngineWidgets][QWebEnginePage] The javaScriptConfirm method is
now also called for unload dialogs (onbeforeunload handlers).
Task-number: QTBUG-58673
Change-Id: I82393da2593dc84e94d577ff28f5d6d8988df552
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
| |
qquickwebenginedownloaditem.cpp:368: warning: Can't link to 'interruptReasonString()'
Change-Id: Ia77d31851d17808330cfc701691e41eafb8d0aad
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Take in following fixes:
bba44efa Merge "Merge remote-tracking branch 'origin/55-based' into 56-based" into 56-based
8d882ead target sysroot only with target toolchain
6d52e105 Fixup building with system ICU after 56 merge
e9ca8f4d Merge remote-tracking branch 'origin/55-based' into 56-based
a406e18f Work around internal compiler error on MSVC 2015 Update 3 x86
Task-number: QTBUG-59773
Change-Id: I9c9b5e12722385b9de7e56d5dc180e627218b920
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring back the logic to disable debugging symbols for 32
bit native compilers on Windows (symbol_level = 0), or
only do minimal debugging symbols useful for e.g. stack
traces (symbol_level = 1).
The corresponding gyp logic got removed in commit c5282c347929.
Change-Id: Ibb7d43814992a00f5413d024f9c362d41dc5a3a5
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for finding gperf, bison, yacc, etc. on Windows.
Works only if the gnuwin32 directory is on the same level as the
qtwebengine root directory, which is the case with a qt checkout.
This is a port of 09e53e79 which did the same for the gyp build.
Change-Id: Icd75c44605ba07269f721cd3b9877463c43f8beb
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Adds useful metadata
[ChangeLog][General] Use Q_ENUM on QtWebEngineWidgets interfaces
Change-Id: Iac30298666b560f1ec62adde980d4eff25b49736
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-58362
Change-Id: Id4cf57c60da17538b224bb9bc91277c324c6a55d
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
We don't use or need the service, but Mojo doesn't like when it doesn't
get to do pointless things.
Change-Id: I1be66d1679bf688aa0139e84822de32a28ba3132
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
| |
Change-Id: I78240d7956de4716757761fc6517f031b4adb822
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
Rename to follow our standard naming. This class was one of our oldest
and probably predates our standard naming convention.
Change-Id: I32dfbad9611b789ad13114d9692b07045806f7c0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Merge the generation of the v8_snapshot toolchain back to being made
in configure_host.pro. This is a lot cleaner and safer against errors,
to make it work however we need to cache the target archicture so that
it is still available with option(host_build) enabled.
Change-Id: Iefed9c97528f8ce338e7a0d4fe5c6884fb4ef4bd
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Calculate movementX/movementY at every turn, not only when
the mouse is in locked state.
Task-number: QTBUG-59127
Change-Id: I362e055e6b5d6f831671604a093434373cedf19a
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
...to display all properties available for the type.
Task-number: QTBUG-59673
Change-Id: I0ee61abefcfbcc229812dc7c3875d16fb279f9e0
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|\
| |
| |
| | |
Change-Id: I8a281e308ec1a6e93dc9756ba6399ca1b50210d8
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Calling QWebEngineHistory::currentItem() before the first item is
inserted, caused a segfault, due to accessing an illegal QList index.
We now delegate the lookup to QWebEngineHistory::itemAt(), which checks
the index first and returns a dummy element in case of an illegal
index.
Task-number: QTBUG-59599
Change-Id: I9cdd2533e33415a7b812c29fff5429eb005020dc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When clicking on a blank link target, the constructor of the
RenderWidgetHostViewQtDelegateWidget instance for the newly created
view is called with the originating QWebEngineView as its parent
and will connect its removeParentBeforeParentDelete slot to the
originating view's destroyed signal.
This leads to the situation where the delegate's parent will be set to
null when the originating view is closed, causing the view to display
only an empty widget with the actual web contents remaining live in
the background.
This patch removes the connection to the old view when initializing
the delegate as a child of the QWebEnginePagePrivate instance. The
addition to the layout updates the parent and child relationship
between the view and the delegate internally.
Task-number: QTBUG-58381
Change-Id: I448380478c2bcfcfbddaee8a35caf46010e57972
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| | |
Change-Id: Iae853d4d3ab73306f90d93b62a419d1d440a3259
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|