summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Do not try to delete BrowserAccessibilityInterface twicePeter Varga2023-09-191-10/+15
| | | | | | | | | | | | | | | | | | BrowserAccessibilityInterface is deleted when removing it from the QAccessibleInterface cache. It is removed from the cache in the BrowserAccessibilityQt destructor explicitly. On exit, the QAccessibleInterface cache might be destructed earlier than the corresponding BrowserAccessibilityQt and deletes all the cached interfaces. Reset the interface pointer to nullptr to make sure that the destructor doesn't try to delete an already deleted interface. Fixes: QTBUG-115753 Change-Id: Ide02a84d2230145a3441d9ade47eaa14af897477 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit a931a1ed782b2069749dd316f51ca1044c21a61a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit b65512cafc2e8da767af2d798c73158a8598ca94)
* Update ChromiumMichael Brüning2023-09-183-2/+2
| | | | | | | | | | | | | | | | Submodule src/3rdparty a71ba6ff..14780aaa: * [Backport] Security bug 1427288 (2/2) * [Backport] Security bug 1427288 (1/2) * [Backport] Security bug 1449166 * [Backport] Security bug 1469534 * [Backport] CVE-2023-4909: Inappropriate implementation in Interstitials * [Backport] CVE-2023-4908: Inappropriate implementation in Picture in Picture * [Backport] CVE-2023-4902: Inappropriate implementation in Input Pick-to: dev 6.6 Task-number: QTBUG-117059 Change-Id: I22da560b291cb984fffe1599a5f9845192458107 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QPdfLinkModel: don't re-use QObject::d_ptrMarc Mutz2023-09-183-7/+9
| | | | | | | | | | | Policy in qtwebengine is to use a separate d-pointer to avoid tying the module build to a particular upstream Qt release. Change-Id: I0be241ee379663721225484cda22d952942a95fd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit fa4a418ba62bd7243b1542bee7d1491e6d83b857) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 0fbda774701fca4493657949353c46e59a0ef2bc)
* Chromium VAAPI support depends on Vulkan headers at the momentAllan Sandfeld Jensen2023-09-151-1/+1
| | | | | | | | | Fixes: QTBUG-115722 Change-Id: I34adbb379c62ea59299eafd97c9ae4754983269c Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 56fa2aa75ad4d7a1e3386405794c43d23666cfbc) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 423bfd1b321813270086f279b24189ff70da1d61)
* Doc: QWebEnginePage: Use since-clause in enum \value commandsTopi Reinio2023-09-141-71/+68
| | | | | | | | | | | | The \value command in QDoc now supports adding since information in a bracketed argument. This enables listing new enum values also in the top-level 'What's New in Qt' documentation. Task-number: QTBUG-116843 Change-Id: I1cbaefe89b1b2311e10d10c6260d974412ecccbb Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit b05da249eb3346fd6bf50132aaaf5299fbe3a240) Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* Doc: QWebEngineUrlScheme: Add since information to Flag::FetchApiAllowedTopi Reinio2023-09-141-1/+1
| | | | | | | | | | | This enum value is new in Qt 6.6. Task-number: QTBUG-116843 Change-Id: Ia2525e7fb7ed51a5bde6b113a839c9e00ca6aff5 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 1e5bdadea48d1c9adb2b82adb3bf926fdc78adbd) Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* Update ChromiumMichael Brüning2023-09-142-1/+1
| | | | | | | | | | | | | | | | | | | Submodule src/3rdparty b295bd04..a71ba6ff: * [Backport] CVE-2023-4863: Heap buffer overflow in WebP * Bump V8_PATCH_LEVEL * [Backport] CVE-2023-4762: Type Confusion in V8 * [Backport] CVE-2023-4763: Use after free in Networks * [Backport] blink::HTMLMediaElement::ShouldReusePlayer: avoid dereferencing a potentally NULL domWindow * FIXUP: Qt GN integration * Avoid using libdrm Fixes: QTBUG-115470 Fixes: QTBUG-116501 Change-Id: Ibeff96e0dca65b42ffe512627eab3c2f0f349c8c Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit e4d73afd5464bd7f34063e08aab55e8f6b16aa22) (cherry picked from commit e763db0fb23ec8c38b3423668da2a3d94a0157cd) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QtPdf: migrate to autogenerated cpp exportsIvan Solovev2023-09-123-18/+4
| | | | | | | | | | | This is a prerequisite for using QT_PDF_REMOVED_SINCE. Change-Id: I46adece3ba1ff1a4c95218a1bc731dea05afc1f3 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit 34f93ea4294e2254c95478521fa9886dfed43910) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Use \qml instead of \code for QML code snippetAndreas Eliasson2023-09-121-2/+2
| | | | | | | Change-Id: I2025d77a15eca0b26096344c3f97f91138893378 Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit ae82cd21c55eacb940f90c084302db8fd21e198d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Fix documentation for qWebEngineGetDomainAndRegistry()Topi Reinio2023-09-121-3/+3
| | | | | | | | | Mention the argument 'url' by name and fix minor language issues. Change-Id: I85e48c49fa258a2b4172fee6ec732726ad7009ef Reviewed-by: Topi Reiniö <topi.reinio@qt.io> (cherry picked from commit 80b18a8fdf6bbd0607f6ff876c389ea63b8fdcef) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Port away from QScopedPointer::take() - non-trivial caseIvan Solovev2023-09-121-4/+8
| | | | | | | | | | | | | | | The API was deprecated in Qt 6.0, so use std::unique_ptr instead. The QWebEngineUrlRequestInfo's destructor is private, so create a custom deleter struct which properly deletes the object. This works, because InterceptedRequest is a friend of QWebEngineUrlRequestInfo. Pick-to: 6.5 Change-Id: I69e1b31360ec5ae4b32b6e7f0416b39aecb2f5f9 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 6bd52dc09c0b4d32833c6ffef690838b2cbc73e7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update qwebengineglobalsettings apiMichal Klocek2023-09-094-77/+82
| | | | | | | | | | | | | | Do comments from api review: * use static setDnsMode * use struct for mode and server templates * remove QObject * do not use QScopedPointer * use the namespace instead of the class Change-Id: I766626330e4cc190a170fcd6b5e32b1f60ad675c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 09e224c57c085457dbc5c2896aacb868a19c2ce6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Mark QPdfDocument::pageIndexForLabel() as new in 6.6Kai Köhne2023-09-061-0/+1
| | | | | | | | | Amends b8419577eb99c158 Change-Id: Ie60b418be63699cf1ff2baec5d867ccd85536f2b Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 4efc44c7ef44995cc64dc7c8c25513a2ab210417) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix revisions of QML APIAllan Sandfeld Jensen2023-09-052-2/+2
| | | | | | | | | See QML API review Change-Id: I8eaba74655cb73bac912a48964d86e647c7a854f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 1ea6ee7b4bb4eeec144cd5ffe3be5cd398d8ee8b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumMichael Brüning2023-09-012-1/+1
| | | | | | | | | | | | | | | Submodule src/3rdparty b02cdcee..b295bd04: * FIXUP: Temporary fix for missing macOS 12.3 SDK * Temporary fix for missing macOS 12.3 SDK * Fix build with clang * Disable Windows IME for GPU thread Task-number: QTBUG-73994 Fixes: QTBUG-116278 Change-Id: I9894f341a82b0c5887d38e9d2597ecc2bde11392 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 3e900b7a91a07fe356ffa9d5de8189cda93220a8) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Switch additional response header to QMultiMapAllan Sandfeld Jensen2023-09-016-9/+9
| | | | | | | | For consistency with other response headers, even if it is going to be inconsistent with existing request headers. Change-Id: I9e9c36ac20982d9c833486171fa9944c9059f471 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* QPdfSearchModel: remove onDocumentPageCountChanged()Ivan Solovev2023-08-302-10/+1
| | | | | | | | | | | | | | | | | | This function was introduced in d1347ebbe99b467799680bb6e3cee81932751df5 as a bugfix for QTBUG-111067. The patch was also picked to 6.5, which is not really correct, because we normally guarantee forward BC in patch releases. Generally, there is no reason to expose this method to the API - we could just use a lambda internally. Do it now. Treat the exposed function as internal, and remove it completely both from the API and the ABI. Change-Id: I48b93767c341aca58135872f391fc731561b68d4 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 46531f2cae2d08b9c7e192ac5f657d0a7ad9996c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfView: remove unneeded includes from a public headerIvan Solovev2023-08-302-2/+1
| | | | | | | | | | | Include qpdfdocument.h in the private header instead. Found during Qt 6.6 API review Change-Id: Ia8bed2a789fb1cb5fc8a8bd6d67f3c4efbf0cf54 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 01745f99dddccdd3310ab1679f3a12d2d176a42a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Switch response headers to QMultiMapAllan Sandfeld Jensen2023-08-294-10/+10
| | | | | | | | | | To allow duplicate key values and preserve order within multi key duplicates Change-Id: I8da0a3441255c9b72256d63f4ede10491c96c2dc Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit a6263a5e8d95dad6e3523f87d416a573e0420881) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QtPdf: Fix memory leaksShawn Rutledge2023-08-292-12/+5
| | | | | | | | | | | | | | | | | | | In QPdfBookmarkModelPrivate::appendChildNode it was not necessary to call FPDF_LoadPage() just to be able to call FPDF_GetPageHeight(): the BookmarkModel has the QPdfDocument which can do that for it, using FPDF_GetPageSizeByIndex() instead. 7b8832ca2b84d549c9d374550c3c46b3d4d42a38 added QQuickPdfDocument::carrierFile() returning a pointer that QQuickPdfDocument continues to own. QQuickPdfDocument::setSource() took care of deleting the existing one if we open a different document, but the destructor did not delete it. Task-number: QTBUG-114953 Change-Id: Ie8d9cea456cb91d9541deb575dac17db0d367ead Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 8289e5935c0990a4a97afeb1234296ea00ad8054) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumMichael Brüning2023-08-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty cfa9a71a..b02cdcee: * [Backport] CVE-2023-4430: Use after free in Vulkan * [Backport] CVE-2023-4431: Out of bounds memory access in Fonts * [Backport] CVE-2023-4428: Out of bounds memory access in CSS * [Backport] CVE-2023-4427: Out of bounds memory access in V8 * [Backport] Security bug 1455619 * [Backport] CVE-2023-4365: Inappropriate implementation in Fullscreen. * [Backport] CVE-2023-4362: Heap buffer overflow in Mojom IDL * [Backport] CVE-2023-4358: Use after free in DNS * [Backport] CVE-2023-4357: Insufficient validation of untrusted input in XML. * [Backport] CVE-2023-4356: Use after free in Audio * [Backport] CVE-2023-4355: Out of bounds memory access in V8. * [Backport] CVE-2023-4354: Heap buffer overflow in Skia * [Backport] CVE-2023-4353: Heap buffer overflow in ANGLE * [Backport] CVE-2023-4352: Type Confusion in V8 * [Backport] CVE-2023-4351: Use after free in Network Task-number: QTBUG-116501 Change-Id: Icd416a6218aac88ab0282233ca8f05267dc8f1f3 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit be9f659309f7d71253699d72b579204b885a6235) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumMichael Brüning2023-08-282-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 2d71c20d..cfa9a71a: * Fix for QtWebEngine crash on Windows * FIXUP: Add minimal webrtcdesktopcapture api for hangout services extension * FIXUP: Jumbo build * [Backport] CVE-2023-4078: Inappropriate implementation in Extensions (2/2) * [Backport] CVE-2023-4077: Insufficient data validation in Extensions (3/3) * [Backport] CVE-2023-4077 (2/3) and CVE-2023-4078 (1/2) * [Backport] CVE-2023-4077: Insufficient data validation in Extensions (1/3) * [Backport] Security bug 1429353 (2/2) * [Backport] Security bug 1429353 (1/2), dependency for CVE-2023-4077 and CVE-2023-4078 * [Backport] Security bug 1454544 * [Backport] Security bug 1465224 * [Backport] CVE-2023-4070: Type Confusion in V8 * [Backport] CVE-2023-4073: Out of bounds memory access in ANGLE. * [Backport] CVE-2023-4071: Heap buffer overflow in Visuals * [Backport] CVE-2023-4076: Use after free in WebRTC * [Backport] CVE-2023-4074: Use after free in Blink Task Scheduling * [Backport] CVE-2023-4068: Type Confusion in V8 * [Backport] Security bug 1464680 * [Backport] Security bug 1464682 * FIXUP: Fix build with enable_vulkan=false Task-number: QTBUG-115470 Fixes: QTBUG-115703 Change-Id: I1478381717e2189f74041c9e3b62751bdd089d45 Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit c4e1822f45a8d6a7941c908e72690fc2a578fef7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Disable not supported Picture-In-Picture featureSzabolcs David2023-08-281-0/+3
| | | | | | | | | | It was disabled once, but it disappeared from media switches. The new place to set this is WebPreferences. Change-Id: I4562db45d2d32a684266d0cb92523f9db0f4afd7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 754010362f2af7dbeb9b6fdd3888cd0190d8604a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove QWebEngineUrlResponseInterceptor APIMichael Brüning2023-08-2518-414/+3
| | | | | | | | | | | | | | | | | It has been found to not have any real effect, therefore, we remove it again to not release a non-functional API and create false expectations in users. This reverts commits 3f5de5fab74e6c152cdf5d04f3d893feaa31790b ab21f39c6a54be331dd8a155d3374bfe790e0274 (parts) 082eef1916a86d6d5e0c751d271c7c8a1a5e457d 5e257fb57a211f95556ec387fe6f262a60cbb6fe Task-number: QTBUG-61071 Change-Id: Ifb33e32128e77dfffed863a1a7501ba21796692d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 614c78c6385f6503dce597407c30fb63fa1de451)
* QPdfPageSelector: port from is-a to has-a QSpinBoxMarc Mutz2023-08-233-58/+142
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Yes, the class needs to inherit from QSpinBox in order to override the protected virtuals, but that doesn't mean a QPdfPageSelector should model is-a QSpinBox. E.g. the range of the QPdfPageSelector is taken from the QPdfDocument, and no good can come from a user changing it through the use of QSpinBox API, esp. if one thinks about the class being displayed as a native widget in QtDesigner. In a similar vein, the inheritance from QSpinBox leaves users wondering (and the docs didn't do anything to enlighten them) what properties are pertinent to the task at hand. setValue() to set the page index is ... meh, but still somewhat discoverable. But that text() is only QPdfDocument::pageLabel() if no affixes are set takes quite some digging. Part of this could be fixed by providing domain-specific properties like currentPage for value, but that would just increase the confusion, because those two properties would must needs exist on the same object. Instead, fix by moving the old QPdfPageSelector as QPdfPageSelectorSpinBox into qpdfpageselector_p.h, removing its pimpl and having QPdfPageSelector inherit QWidget instead, aggregating a QPdfPageSelectorSpinBox. This involves a few more objects (the widget, the layout), but gives QPdfPageSelector full control over its interface. Add a few salient properties (more can be added if needed, by copying them from QSpinBox or QAbstractSpinBox). Note how well the new API rhymes with QPdfPageNavigator in the connect() in pdfviewer example's MainWindow. Since we still store everything in QPdfPageSelectorSpinBox, but don't pimpl it anymore, QPdfPageSelectorPrivate can lose the q_ptr now, and merely contains the pointer to its QPdfPageSelectorSpinBox. This could be optimized further, by making QPdfPageSelectorSpinBox and QPdfPageSelectorPrivate the same class, but that's neither BC- nor SC-relevant anymore, and can be done later (or never, seeing as this widget is unlikely to be used more than a few times per application). Found in API-review. As a drive-by, port to the std-compatible subset of the QPointer API. Change-Id: I0d82d098d38d5f2fcf7f1c8c9aed6e792a8deb2d Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 8b20e0636a89dc3e6b06d174286ee16aa427887a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfLinkModel::Role: do not specify an underlying type for enum classIvan Solovev2023-08-221-1/+1
| | | | | | | | | | | | The standard guarantees that int is a default type for enum class, so no need to spell it out explicitly. Found during Qt 6.6 API review Change-Id: I4ec4eb443ffe5d54f24ab20ef1de43105a06bb6d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit bafbe16d60af9bd988c0e4eda1ce8e2367e5ef80) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QWebEngineQuotaRequest: add deprecation guardsIvan Solovev2023-08-212-0/+4
| | | | | | | | | | | This class was marked as deprecated for Qt 6.5, but not everywhere. This commit amends 8fd7140082e3a752ca80882a29128ffc12d12fa4. Change-Id: I7253a88aae20519befbabf01e63bb7d49c37cef0 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit ac946f96e1123f2e6ab1ecb883cbebb2d3898b5c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QQuickWebEngineView: move using declarations outside of QT_DEPRECATED_SINCE ↵Ivan Solovev2023-08-211-3/+2
| | | | | | | | | | | | block Because they are also used in the code which is not guarded by the deprecation checks. Change-Id: I42383ba0f11b08df5602bfa9e0d8d816d2b96be7 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit c252bc6d47d325241a00258b3ce66b42a716d788) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Port away from QVariant::canConvert(int)Ivan Solovev2023-08-211-1/+1
| | | | | | | | | | This API was deprecated in Qt 6.0. Use QVariant::canConvert(QMetaType) instead. Change-Id: I96e387536384d984b4130875f13ec0e6d027e928 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6e745ae1ec16efa000ee3512e5306dc09d4a0682) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Port away from QLibraryInfo::location()Ivan Solovev2023-08-211-2/+2
| | | | | | | | | This API was deprecated in Qt 6.0. Use QLibraryInfo::path() instead. Change-Id: I1e47b41386c1955307785690bccb19843b0dc4b5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 6812131178efaeeaba26123c1671877ac3685034) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Port away from QTouchEvent::touchPoints()Ivan Solovev2023-08-211-1/+1
| | | | | | | | | This API was deprecated in Qt 6.0. Use QPointerEvent::points() instead. Change-Id: I04140ef4f45399c781b1ea5c479b97138237ac49 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit ca737030c634285e2758c5baca1d8c1c386766e7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfLinkModel: mark the destructor as overrideIvan Solovev2023-08-211-1/+1
| | | | | | | | | | | | ... because it does. Found during Qt 6.6 API Review. Change-Id: Ia8f27d3ca1cca0141bd6de7874ba20225171fb63 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit bad7ed9a00cfec66cb246cb23fdf9e7849966d2f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Port away from QScopedPointer::take() - trivial caseIvan Solovev2023-08-212-6/+10
| | | | | | | | | This API was deprecated in Qt 6.0. Use std::unique_ptr instead. Change-Id: I6bdb4db129b6a669eeb3fac6b4c0b097087ec082 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit f65a88d715a31a0902b1b96761babacf6b1e2f50) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix close button in devtoolsMartin Negyokru2023-08-212-1/+6
| | | | | | | | | | Handle CloseWindow call coming from DevtoolsUIBindings. Fixes: QTBUG-115976 Change-Id: If58a96e3901234696c55c9c1402c645ba7a8576b Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> (cherry picked from commit e4eb2dd213df10fb470279763f1ec64e41f26b56) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add missing AltGr mapping in windowsKeyCodeForQtKeyMartin Negyokru2023-08-211-0/+2
| | | | | | | | | | | | | | Unknown windows_key_codes are calculated from native key codes, breaking any remapping. Although it is named windows_key_code it is used on other platforms too. Fixes: QTBUG-115844 Change-Id: I53956fd6c18a6b85afe97b82696ba4f49618008c Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 888afe6d733115c04d28cbc348a5c26ddd77d233) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Output web engine process dSYM info to the builds lib directoryMichael Brüning2023-08-181-1/+2
| | | | | | | | | | | | | | It is necessary to install the web engine process in a structure that enables users to have their applications notarized after using macdeployqt without deleting or moving the dSYM directory manually. Depends on qtbase/ebb361ee3f02d677460fc2b55a47c6cd4bbbc489 Fixes: QTBUG-99555 Change-Id: Ia98187ecc2a3058c5c58131403c768784c1ba893 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit dd8268d5fbab092fbd936edb618d9d5b7546a431) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Replace string literals with already defined constantsMichael Brüning2023-08-181-3/+3
| | | | | | | | | | CodeChecker gave us a friendly hint that our defined constants were not used as they were intended to be. Change-Id: I4d7ae374222000f97f4c4869c9d1e7f357e1cd5f Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> (cherry picked from commit d65add56d146211c5ce53ab1e2fbdd8058f020d5) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfPageSelector: add missing \since 6.6Marc Mutz2023-08-181-0/+1
| | | | | | | | | Found in API-review. Change-Id: I1e92d098d38d5f2fcf7f1c8c9aed6e792a8deb2e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 760540d18fc4df52e328430fb7b14e67d386a2d2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfPageSelector: remove unused fwd declarationsMarc Mutz2023-08-182-3/+0
| | | | | | | | | Found in API-review. Change-Id: Ibd5bf18706833e2a8e8a00b132570f75306fa583 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 4df45d3ee6ca8944302f17b04a5cac073849aa40) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfPageSelector: mark dtor as overrideMarc Mutz2023-08-161-1/+1
| | | | | | | | | | | ... because it does. Found in API-review. Change-Id: Id1004406dbffeb92eb5297ce1623fc609d511494 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit a17fe1a5f7100be4ccad0a8f9033ebf070e455a6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* QPdfPageSelector: port from QScopedPointer to const std::unique_ptrMarc Mutz2023-08-161-1/+3
| | | | | | | | | | | | The former is on extended life-support, there's nothing a const unique_ptr does worse, so use the future-proof version. Found in API-review. Change-Id: Ic734b45b991b1ff81454c86b6a159897f06f815b Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 1df024a1ac83e6e9c288421a125df8d51770aeff) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add missing type to Dns Mode enumMichal Klocek2023-08-141-1/+1
| | | | | | | Change-Id: Ie4f63415c04b2b699500414a78cee2a6bb015dc5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit a43e832284cd8d58d58b63f983d8fdf42e51cae4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* List need for C++20 support in Platform NotesMichael Brüning2023-08-141-0/+1
| | | | | | | | | Chromium 112-based seems to assume C++20 support by default. Change-Id: I145722e1873ba6afc80b567452437095640457a1 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 2da82ea7c211bbf1b576aa7c2f9f5db10754ec48) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Add initial internal version pageMichal Klocek2023-08-144-1/+94
| | | | | | | | | | | | | | | | | | We kept urls in examples to point to company website. However this site is heavy to load and moreover it changes overtime leaving example screenshots obsolete. Introduce internal qt version web ui page which will be default page for examples and which displays basic information and can work offline. For start show version info and command line options for chrome://qt Change-Id: I0271ce6e7b152efe4942a6240b0c74ba382d5fcc Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit a748cb9183143b76cad1e940220dcabf25475493) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Prevent QWebEngineCertificateError from being exported twice to QMLIvan Solovev2023-08-141-1/+8
| | | | | | | | | | | | | | | We need to export the type as a value type, and also export its enums in a namespace. This resulted in duplicated entries in the qmltypes file, which confuses Qt Design Studio. Fix it by introducing a derived class, and using it for exporting the enums. Fixes: QTBUG-115365 Change-Id: I5900f4f76fb6357c9262496cc3cc01b276387e46 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit df4121886dfa11cf90e74c72b1121a96462726bf) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update ChromiumMichal Klocek2023-08-111-0/+0
| | | | | | | | | | | | | | | Submodule src/3rdparty fe861d4b..2d71c20d: * [macOS] Do not subscribe to display callbacks when GPU is disabled * Make NetworkContext resettable * [Revert] Destroy old network context before creating the replacement * [Revert] Expose StoragePartitionImpl::InitNetworkContext * Add internal version page * Bring back *://localhost/* exception for Hangouts extension Change-Id: Ia42fdf08eeea919a780591ee2e9bbdb2cf7e3059 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 800cf14c284690d4f6584abe471b396ed3e4cf21) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Doc: Promote Qt6::WebEngine* cmake targetsKai Köhne2023-08-113-3/+3
| | | | | | | | | | | Be consistent with the other modules, and promote Qt6:: targets instead of the (mostly functionally equivalent) Qt:: one's. Change-Id: I4da0b7a29782d8927de5e5eafcaf934afb128937 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> (cherry picked from commit 58ec902ec47284eee430715ddd39a30d871a18e8) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Rename disableReadingFromCanvas to follow naming styleAllan Sandfeld Jensen2023-08-115-21/+24
| | | | | | | | | | | | We prefer to name settings with Enabled at the end. From API review. Change-Id: I7aacc6dbb92d852fd21b067475d2fd9e7df56163 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> (cherry picked from commit b10ac195de4dac7157575e2899cc19ec45fe1648) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Make webengineview::save a slotAllan Sandfeld Jensen2023-08-111-4/+3
| | | | | | | | | From API review Change-Id: I7071b05bd92eaefd922913e2800e4b9ade71ec1f Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit 73a25202670d7383e3b18319c29fd60f373eb3ca) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fixup: Support MSVC 2019Michael Brüning2023-08-073-2/+2
| | | | | | | | | | Commit aacf93e14a6f102b79f4506b334ae8a4b014f0c2 contained a preliminary SHA1 for the qtwebengine-chromium repository. Update docs and the Chromium security patch version. Fixes: QTBUG-115713 Change-Id: Ic50d191b614144e624c747657303a0aff09907cd Reviewed-by: Michal Klocek <michal.klocek@qt.io>