summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Fix deadlocks on WebEngineContext destructionMichal Klocek2020-03-023-30/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch aims to handle 3 deadlocks on exit: (1) Do not attempt to restart Viz thread on shutdown, this will make deadlock with no separate gpu thread, since force shut down of FrameSinkManager requires interaction with gpu process. (2) QCoreApplication, QGuiApplication, QApplication behave differently when doing qt post routine, ~QGuiApplication calls the post routine handler after closing event dispatcher, which will on windows stop processing timer events, which we need to pump message loop when shuting down viz. Do not use QEventLoop and switch to active pulling. The proper solution is to fix QGuiApplication destructor to call post routine first, but this change might have side effects on already existing user code. (3) Since 7f1649b438329e we delete root frame sink asynchronously, which will in gpu thread running in separate thread create a deadlock. Viz requires gpu to destruct root frame sink, however if main process tries to close gpu process this will in turn try close viz, but viz calls back gpu now since the root frame sink is not destroyed. Use the same solution as in (1). Change-Id: Ic6bc904bdac90ee01a5c5b9398a2e2746be3bbd8 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Clear previous page text selection on new navigation unconditionallyKirill Burtsev2020-02-262-14/+33
| | | | | | | | | | Remove code duplication on triggering new url load, and use direct code to clear SelectedText instead of CollapseSelection as it assumes focused frame and might be ignored. Fixes: QTBUG-81574 Change-Id: I01cf02967e118f407c8a3997e176d5b258478a5a Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Update ChromiumJüri Valdmann2020-02-251-0/+0
| | | | | | | | | | | | | | | | | | | | | This pulls in the following changes: c1be521d4b0 Create an AudioOutputIPCFactory even without WebRTC 35b6d2c4838 third_party perfetto: add missing include for clang, asan and no_pch 6c2cf4c4571 Fix access after move 86de069171e FIXUP: Fix building with g++ 5 5c2d377121c Suppress racy DCHECK 458aa4294db Fix generation of attribution documentation a370b2f7a7e Don't force gpu process launch on macOS with vizdc and no GL 5b79320c013 Expose StoragePartitionImpl::InitNetworkContext bbc3a3082b4 [Backport] Fix input spinner double-increment. 432e1a9b1a0 Suppress DCHECK triggered by NGInlineNode::ComputeMinMaxSize caa20eed16d Add explicit dependencies on spellcheck buildflags c3737fb3824 [Backport] metatrace: remove memset and trivial-ctor assumption 12a57d9c943 Fix recursive deadlock in sandbox::InitLibcLocaltimeFunctions Change-Id: Id06aa2d5a148d3805ebd172ab21db2400f78f19a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix event.key for Ctrl key combinations on WindowsPeter Varga2020-02-251-1/+6
| | | | | | Fixes: QTBUG-81783 Change-Id: I107a4009630dc261013498a05987c0e8e29651eb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix build: remove dependency on Qt private headerThiago Macieira2020-02-241-3/+6
| | | | | | | | | | | | The size of QJsonDocument's binary format is well known and we don't need the header to know what it is. This fixes the build with 5.15, where the contents of the previous QJsonPrivate namespace are now in QBinaryJsonPrivate. web_channel_ipc_transport_host.cpp:148:51: error: 'Header' is not a member of 'QJsonPrivate' Change-Id: Id7decde0c426479bbf61fffd15dcc5c20a9eca2c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix docs for page url request interceptorsMichal Klocek2020-02-211-4/+3
| | | | | | | Profile interceptors run also on ui thread. Change-Id: Iacfce46549e7ffd821033308077ba5f4fa410575 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix quick accessibility on macOSPeter Varga2020-02-174-8/+95
| | | | | | | | | | | | | Same as the widget fix: ffdf7ece Fix widget accessibility on macOS This patch depends on a focusChild() fix in qtdeclarative: 6420ad91d3 Fix QAccessibleQuickWindow::focusChild() to return focused descendant Task-number: QTBUG-78284 Task-number: QTBUG-81539 Change-Id: If0da937d2c778a158ce02e1433b28ca0888692d8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix name filters of GTK file pickerSzabolcs David2020-02-161-0/+3
| | | | | | | | | | Setting an empty string instead of "()" fixes that case where the file input doesn't have "accept" attribute. Task-number: QTBUG-82109 Change-Id: I8a72f819fa6d8bbab4e5f1067b38ad75ff11e118 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Emit title change event asynchronouslyKirill Burtsev2020-02-141-1/+4
| | | | | | | | | | | Ammends 445235bc01. Preserve some previous assumptions on order of change events for url and title. Fixes flaky failures in previously written tests like WebEngineViewSource::test_viewSource. Fixes: QTBUG-81855 Change-Id: I487d27d594d5a0d74d39b7b58e815e5c75a73fb3 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Doc: Remove info about Sandboxing not being supported on WindowsLeena Miettinen2020-02-021-11/+23
| | | | | | | | | | | Since 5.14.1, it is supported. List restrictions on Linux and ways of explicitly disabling sandboxing on all platforms. Fixes: QTBUG-81688 Change-Id: I7f8fc08b921cc0e50056cc143cbf63b62be90b4e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Cleanup FrameSinkManagerImpl before shutting down GPU serviceJüri Valdmann2020-01-303-9/+28
| | | | | | | | | | | | | | | We changed RootCompositorFrameSinks to be destroyed asynchronously (in HostFrameSinkManager::InvalidateFrameSinkId) which means that one can still exist during shutdown in GpuThreadControllerQt::destroyGpuProcess. This results in a deadlock in single threaded GPU mode: in destroyGpuProcess we wait for the viz thread to exit, but the FrameSinkManagerImpl on the viz thread will try to destroy the RootCompositorFrameSink, which waits for work to be done on the GPU=UI thread, which is waiting for the viz thread to exit. Fix by destroying all RootCompositorFrameSinks before destroyGpuProcess. Change-Id: I4cf135f29b90ae0bf78525d5747567dc10a775e6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.14.1' into 5.14Allan Sandfeld Jensen2020-01-281-0/+0
|\ | | | | | | Change-Id: I5a856d3976581806e75b775c2f383c6e4ed35530
| * Update ChromiumMichal Klocek2020-01-201-0/+0
| | | | | | | | | | | | | | | | | | | | Pulls in following changes: * 3bbfff059e3 FIXUP: Support GPU service on UI thread with viz * a9a20127e8a Improve jpeg headers handling Change-Id: I0c81edbb24e984a798bb71444a4a6498a38abb38 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Fix widget accessibility on macOSPeter Varga2020-01-246-4/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | macOS Accessibility queries the window for the focused accessibility element. The window forwards the query to the widget with active focus. This widget is the RWHVQtDelegateWidget if a web element is focused in QWebEngineView. Therefore, a QAccessibleWidget interface has been implemented for the RWHVQtDelegateWidget to forward the request to the QWebEngineView. The focused accessibility element expected to be returned by the QAccessibleInterface::focusChild() method. In case of the macOS accessibility backend, it is called by the accessibilityFocusedUIElement() NSAccessibility API function. It expects the focused web accessibility element otherwise VoiceOver won't focus properly. The focused web accessiblity element is looked up by the new BrowserAccessibilityQt::focusChild() method. RenderWidgetHostviewQtDelegateWidget::focusChild() and QWebengineViewAccessible::focusChild() methods have been also implemented to forward it. This patch depends on a focusChild() fix in qtbase: a132e02540 Fix QAccessibleWidget::focusChild() to return focused descendant Microsoft Narrator also uses focusChild() to query the current focused element when it starts but it is still functional without this fix. Task-number: QTBUG-78284 Task-number: QTBUG-81539 Change-Id: I3c4861e58622ccbb5046c60c4efcc19842400a88 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Update navigation actions when load finishes in a subframePeter Varga2020-01-221-1/+3
| | | | | | | | | | | | | | Fixes: QTBUG-81521 Change-Id: I8ca82224cd834b667471d1e96a44430164d3669e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.14.1' into 5.14"Allan Sandfeld Jensen2020-01-2110-56/+63
|\ \
| * | Merge remote-tracking branch 'origin/5.14.1' into 5.14Allan Sandfeld Jensen2020-01-2010-56/+63
| |\| | | | | | | | | | Change-Id: Ic2b5f2a3e6f5af56d92652e57c05a631481201b3
| | * Update ChromiumMichael Brüning2020-01-181-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in the following change: * 0f7953646c1 [Backport] Allow restricted clock_nanosleep in Linux sandbox Change-Id: I317ff3c5f068577e2eb7e0a49820ec19f4eb5300 Fixes: QTBUG-81313 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Build fix for when configuring with -no-openglAndy Shaw2020-01-181-0/+5
| | | | | | | | | | | | | | | Change-Id: Ifb5f7c866c26746f989ab4e8c49c48bcbdb50077 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Update ChromiumMichal Klocek2020-01-171-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following changes: * c68e3faa08f [Backport] CVE-2019-13735: Out of bounds write in V8 * c0a7f013646 [Backport] CVE-2019-13754: Insufficient policy enforcement in extensions. (1/3) * 11f1bad3655 [Backport] CVE-2019-13754: Insufficient policy enforcement in extensions (2/3) * 9df23a4c06e [Backport] CVE-2019-13754: Insufficient policy enforcement in extensions. (3/3) * fd8cf772447 [Backport] Security bug 1028191 * 8417e835260 [Backport] Security bug 974375 * 046bd9f50b6 [Backport] Security bug 889276 * 5fc987f210c [Backport] Security bug 1033260 * 9f87a1ede7c [Backport] CVE-2019-13755: Insufficient policy enforcement in extensions. * cb8bce9edb2 Fix compile issues for ios * fb54428bc4c Fix crash on page allocator * e687bc69cdc Fix properly not working about_credits target * 41d474d0e7c [Backport] CVE-2019-13745 1/2 * 6cd2b35a453 [Backport] CVE-2019-13746 1/2 * e89fce7cfa3 [Backport] CVE-2019-13746 2/2 * b7ce677ea5c [Backport] CVE-2019-13745 2/2 Task-number: QTBUG-80735 Change-Id: I15be332ef55ede2d110e0ba87c54fa936fd0bf18 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Update ChromiumMichal Klocek2020-01-171-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in security patches: * 545b591cee6 [Backport] Security bug 1027905 * 9e44d0450c1 [Backport] CVE-2019-13747: Uninitialized Use in rendering. * f32f09593b6 [Backport] Security bug 1025089 * 684a48706ad [Backport] Security bug 1016703 * ee0ec6e55f0 [Backport] CVE-2019-13757: Incorrect security UI in Omnibox (1/2) * d5651e21821 [Backport] CVE-2019-13757: Incorrect security UI in Omnibox (2/2) * 05833b160db [Backport] CVE-2019-13739 * 5e753a5b1d7 [Backport] CVE-2019-13738 Task-number: QTBUG-80735 Change-Id: Iad1afccce59ee09496e560f69d9dbe3743b29b06 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Update ChromiumMichal Klocek2020-01-171-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following patches: * 8da0a5162d1 Downgrade ninja to 1.8.2 * b7034d08035 Add icudtl for ios build * 9720a8a9863 [Backport] CVE-2020-6377 * 253d8a0fa71 [Backport] CVE-2019-13728: Out of bounds write in V8 * def05352967 [Backport] Re-land: Only invoke text and element fragment anchors after layout. * 73ef65b5273 [Backport] CVE-2019-13741: Insufficient validation of untrusted input in Blink * f49943cf837 [Backport] CVE-2019-13762: Insufficient policy enforcement in downloads. * 5357f8ae628 [Backport] CVE-2019-13758: Insufficient policy enforcement in navigation. * 5ca9a877b4b [Backport] CVE-2019-13761: Incorrect security UI in Omnibox. Task-number: QTBUG-80735 Change-Id: If217ba889192cc124705faec79c46c9aec535baf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Merge 5.14 into 5.14.1Kari Oikarinen2020-01-152-18/+31
| | |\ | | | | | | | | | | | | Change-Id: Ibc671c7a5ac4b070f3406c41598d071fd978e420
| | * | Update ChromiumMichal Klocek2020-01-141-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following security patches: * cc309aa8518 [Backport] Avoid leaking GamepadService in tests * b7e2744f519 [Backport] Fix for CVE-2019-13727 * 85d5ec666bd Reland [Backport] CVE-2019-13701 * 114a6d752f1 [Backport] Fix for CVE-2019-13730: Type Confusion in V8 * ad6efac8e5b [Backport] Fix for CVE-2019-13732: Use after free in WebAudio * 446eda0fc43 [Backport] Fix for CVE-2019-13764: Type Confusion in V8 * 13e4a6f608c [Backport] CVE-2019-13734: Out of bounds write in SQLite * 7d9eea8e630 [Backport] Security bug 1017020 * 3d5ac733f8b [Backport] Security bug 1017961 * 945f5405f3e [Backport] CVE-2019-13736 * 3299cadf406 [Backport] CVE-2019-13737 Task-number: QTBUG-80735 Change-Id: Iea135ae6c655046464470929296efb728e1286e4 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * | Rework url changed logicMichal Klocek2020-01-148-56/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due security changes to prevent url spoofing, our implementation is getting extra invalidate url requests. Unfortunately, this breaks our url handling, which now gets lots of new back and fort url changed signals and make several unit test failures. After tedious investigation of Chromium omnibox handing and trying out different approaches, it seems that only sensible solution is to follow Chromium logic and make NavigationStateChanged to update 'ui' in asynchronous matter. This change tries not break any tests and simplify url handling. The only side effect of this change is that WebEnginePage::setContent will get extra 'url' signal of initial 'urlData' and later 'baseUrl' change is emitted. Fix one of qml tests which did not expect to have url on LoadStartedStatus. Task-number: QTBUG-63388 Task-number: QTBUG-48995 Change-Id: Id347f4325c036e16bfae7bf2f694905e0f21f8d7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Support Range headers in custom URLRequestJobsSzabolcs David2020-01-203-3/+24
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | This is essential when Chromium tries to load media files in multiple jobs over custom protocols, like qrc. Allow subsequent jobs to continue reading media files from specified positions to avoid media glitches and errors. Task-number: QTBUG-80234 Change-Id: I9a7e98c0cb08b2399b7928ecf026c0deb90a1bcb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix overriding shortcuts in password input fields on WindowsPeter Varga2020-01-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Windows IME does not support hidden text therefore IME input is disabled on password fields. The shortcuts are supposed to be overridden in input fields. Checking the keyboard focus on an input field is done by verifying if the IME is enabled. This won't work with password fields on platforms where hidden text is not supported, so also check if the Qt::ImhHiddenText IME hint is set. Fixes: QTBUG-81206 Change-Id: I81870beb556a9dda67295496dad8b672fbc5eba2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix conversion of tabpanel aria rolePeter Varga2020-01-151-1/+1
| |/ |/| | | | | | | | | Task-number: QTBUG-78284 Change-Id: Ie3bf247752308fb104ab0f244736bd3a8d070762 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix youtube with Qt ltcg buildsAllan Sandfeld Jensen2020-01-131-0/+2
| | | | | | | | | | | | | | | | The exported symbols in the helper process does not work when ltcg is enabled, and we already disable the same for qtwebengine core. Change-Id: Ia0b662bb64f368e77bdfcdc02e6f853525dda0b3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Fix crash when handling QEvent::TouchCancelRomain Pokrzywka2020-01-091-18/+29
|/ | | | | | | | | | | | TouchCancel events have an empty touchPoints() list, which first trips when accessing touchPoints[0], and later on crashes Chromium if we pass the empty list to m_touchSelectionController. Rework handleTouchEvent() to route TouchCancel events like other touch events, and make sure we pass a non-empty touchpoints list to Chromium. Task-number: QTBUG-80893 Change-Id: Ie8396a1191f72b5bbb2b047f131794b37cfded48 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix doc for WebEngineNotification.title typeMiłosz Kosobucki2020-01-061-1/+1
| | | | | | | Was bool but it's really a string. Change-Id: I79eace4892e8048212ce3296b28e342d72c43667 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix the build with -no-guiLiang Qi2020-01-032-1/+2
| | | | | | Task-number: QTBUG-74602 Change-Id: I8ba358e03472e58c40363fede56e87dfd665ae83 Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
* Enable Windows sandboxAllan Sandfeld Jensen2019-12-1910-15/+131
| | | | | | | | | | | | | | | | | Enable sandboxing on Windows. Enable heterogeneous sandbox symbol resolution and statically link the sandboxing code into the helper process. This means we have two copies of the sandboxing code, one statically linked in the executable and one in the shared library. Since they are not exported they don't conflict, but we need to take to initialize the right version in the helper process binary, and pass its sandbox interface to shared library using it. For sandbox debug output, we also need to initialize the second copy of the commandlineparser and logging system. Fixes: QTBUG-51170 Change-Id: I8f503c8d6b40674465f32772ef906817dad2b449 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update chromiumAllan Sandfeld Jensen2019-12-181-0/+0
| | | | | | | | | | Submodule src/3rdparty dd8389c5..325f3b07: > Disable dumb code > Fix 32bit sandboxing on Windows > Merge remote-tracking branch 'origin/upstream-master' into 77-based Change-Id: Ibae8b8269a41eb3d832a706151c45860230980b2 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix Q(Quick)WebEngineDownloadItem::setDownloadDirectory()Tamas Zakor2019-12-185-14/+29
| | | | | | | | | | | | | | | | | | Keep the custom file name if the calling order of setDownloadDirectory() and setDownloadFileName() changes. Also do not emit patchChanged signal twice if setDownloadDirectory() changes the uniquifier of the file name. Add TempDir for qml auto tests what uses QTemporaryDir() to create temporary directory for downloads. See https://cgit.kde.org/messagelib.git/commit/?id=2c113dcb155b11bf2c0af3c85544962485784b26 for details. Fixes: QTBUG-80566 Change-Id: Ia76f263558eaf55cb297700407948523788c6229 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add entitlements to QtWebEngineProcess.appMichael Brüning2019-12-171-0/+12
| | | | | | | | | | | | | | | | | Adds entitlements needed by the QtWebEngineProcess.app bundle when running with the hardened runtime. To use these entitlements when deploying an application with the hardened runtime enabled or notarizing it. To use it, deploy and sign the application using macdeployqt, then re-sign it using the additional entitlements that are contained in this patch. Coming version of macdeployqt may do this automatically when the hardened runtime is enabled. Task-number: QTBUG-77442 Change-Id: I7fde358725cf2d490f5e644934bf6466c2b4e1cb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix typo of gn parameter for clang-clYuhang Zhao2019-12-151-1/+1
| | | | | | | | | When I try to compile Qt WebEngine through clang-cl + lld-link, gn complaints about the unknown parameter "use_ldd" and suggest to use "use_lld" instead. Change-Id: Id996699616db4eb0c67feaa29749a070465fc44c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix ResourceBundle::GetNativeImageNamedJüri Valdmann2019-12-121-3/+1
| | | | | | | | | | Follow Chromium's aura, android, windows, and fuchsia implementations of GetNativeImageNamed by forwarding the call to GetImageNamed. Fixes DCHECK when enabling TouchEmulator in devtools. Change-Id: If5fdc30293bc18843c85d932f75f7cb2c70e5815 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix touch flinging in viz modeJüri Valdmann2019-12-122-0/+6
| | | | | | | | | | | FlingScheduler, in viz mode, is not able to progress the animation unless it has access to our ui::Compositor in RHWVQt for observing OnAnimationStep. Add a GetCompositor virtual method to RHWV and override in RHWVQt. Fixes: QTBUG-80089 Change-Id: I4f52a83d29f5ae4c7c9e8cc4908384d1c7e81a82 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumJüri Valdmann2019-12-121-0/+0
| | | | | | | | | | | | | | This pulls in the following changes: c7bb975f833 Fix manifests for extensions 88050fc712d Fix rebuilding of about resources every time 4a0ac259d12 third_party quiche: add missing include for iostate 819bf79725a [Backport] Set priority for requests whose load is emulated db19ca9c53c Fix FlingScheduler in viz mode dd8389c580c FIXUP: Fix manifests for extensions Change-Id: I7299c2e3c75840e943173191e28f4f1a1d42b087 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.14.0' into 5.14Allan Sandfeld Jensen2019-12-0418-42/+34
|\ | | | | | | Change-Id: I4f73d4b11bee795185d4eaae718d4cfdb3112100
| * Update Widevine path for Linux support of CDM videosv5.14.0-rc1Allan Sandfeld Jensen2019-11-301-1/+6
| | | | | | | | | | | | | | Fixes regression with Amazon Prime and Netflix. Change-Id: Ic96b4fa94fd06bfb9f7d75ca36e7eeddcda81218 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Fix 'setDownloadDirectory' for download item on 'SavePage' actionKirill Burtsev2019-11-2910-16/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromium's DownloadManager doesn't create its download items before path for saving page is confirmed. So assert inside updateDownloadPath was not correct. Moreover, the name is confusing because it's not really updating anything. Remove it and use ProfileAdapterClient::DownloadInfo timestamp to determine updated filename after directory change. Ammends recent new api for changing download directory 0884fab3b1. Fixes: QTBUG-80372 Change-Id: If9efb52979deb3cf21fc4e12989173c85e04e090 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * Update find request id when a new search interrupts an ongoing searchPeter Varga2019-11-281-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the new test became flaky it might happen because the first text search finished before the second findText() call. This is very unlikely, but in this case the test should be modified to not to check if the first find failed. The point is to check we get the correct amount of signals and the second search doesn't assert. If the callbacks will be removed in Qt6, it should be re-considered to remove the "unfinished find" workaround and trigger the first successful findTextFinished() signal even if it happens in the middle of another search. Fixes: QTBUG-80086 Change-Id: I9c1ce20fc43fd81e8af784385a00ac2e7f7603b7 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Update ChromiumMichal Klocek2019-11-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following changes: * 7d2876b9557 Fix url_utils for QtWebEngine * bfea09e6e17 FIXUP: Add net::URLRequest::first_party_url() * 0d4406b3688 [Backport] Security bug 961614 1/8 * b1a56dab182 [Backport] Security bug 961614 2/8 * b9718cd4aa0 [Backport] Security bug 961614 3/8 * 821f375089e [Backport] Security bug 961614 4/8 * ee18fd483a7 [Backport] Security bug 961614 5/8 * 105f1e578c3 [Backport] Security bug 961614 6/8 * 09050e17c6a [Backport] Security bug 961614 7/8 * 634aff72b47 [Backport] Security bug 961614 8/8 * c5eb4cfff7f [Backport] Security bug 775511 * 120ccb55b5c [Backport] Security bug 1015945 * 939daf833ff [Backport] Security bug 955191 Task-number: QTBUG-79465 Change-Id: Ic9585b656477fae364ab17631db7487e8a00d46c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix renderProcessTerminated signalJüri Valdmann2019-11-283-21/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the adaptations for Chromium 76, RenderWidgetHostViewQt was changed to become a RenderProcessHostObserver with the renderProcessTerminated signal being emitted from the override of RenderProcessHostObserver::RenderProcessExited. The problem with this can be seen by setting a breakpoint on the RenderProcessGone override in RenderWidgetHostViewQt. We then get the trace: QtWebEngineCore::RenderWidgetHostViewQt::RenderProcessGone content::RenderWidgetHostImpl::RendererExited() content::RenderViewHostImpl::RenderProcessExited content::RenderProcessHostImpl::ProcessDied ProcessDied iterates over all the observers and calls RenderProcessExited. Both the RenderViewHostImpl and our RWHVQt are observers, but the RVHImpl comes first. The RVHImpl then calls RendererExited, which calls our RenderProcessGone, which does a 'delete this'. Now our RenderProcessExited override can never be called because we have already deleted our observer. Fix by moving the RenderProcessGone code to WebContentsDelegateQt and getting the exit code from WebContents::GetCrashedErrorCode. Also add test. Task-number: QTBUG-80085 Change-Id: I434744286df97a37b64722d7c15a1d4ee11c8af6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix pepper flash plugin permissionTamas Zakor2019-11-281-1/+2
| | | | | | | | | | | | | | Fixes: QTBUG-78280 Change-Id: Ic202314bb7935741791fa8c747e255b10dc7dc61 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
| * [macOS] Update widevine search paths to new Chrome bundle layoutMichael Brüning2019-11-281-2/+2
| | | | | | | | | | | | | | | | | | Re-enables using proprietary codecs used by many popular platforms for streaming video. Fixes: QTBUG-80352 Change-Id: Id1730576a98cfc4b23b523e61c1d8168414e3a48 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update ChormiumMichal Klocek2019-11-281-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following patchs: * 77c86be6077 BASELINE: Update Chromium to 77.0.3865.129 * cbc9c4a3c8d Merge remote-tracking branch 'origin/upstream-master' into 77-based * 6f690b4418f Merge "Merge remote-tracking branch 'origin/upstream-master' into 77-based" into 77-based * d61464c1e69 Fix is_main_frame in intercept_navigation_throttle * 41d6b0b2f16 [Backport] Secuirty bug 1014607 * e751f134d6b [Backport] Security bug 1016450 * 5b40e1d793e [Backport] Security bug 1018406 Task-number: QTBUG-79465 Change-Id: I0fd5c5bbdeb5d3478d9646540bca0550f0eb3819 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update ChromiumMichal Klocek2019-11-271-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following changes: * 1d9d75d072e Fix '/Zc:twoPahse' unknown compiler option warning * 55c0556c1ca [Backport] Security Bug 1003313 * d5f6e269885 [Backport] CVE-2019-13721 * c1fd5c47504 [Backport] Security bug 1011551 * e9b6a6d0cf9 [Backport] Security bug 1006544 * 8a477bb16f9 [Backport] Security bug 997401 * 6ed410d94fc [Backport] Security bug 995591 * ccde4d23e60 [Backport] Security bug 993266 * 8564d6c04aa [Backport] Security bug 989909 Task-number: QTBUG-79465 Change-Id: I54841d9116c65fdab62eba5199382686297e960a Reviewed-by: Michael Brüning <michael.bruning@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-25 04:03:23 +0000