| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
childAt needs to return any child at the given coordinates.
Change-Id: I19bfbd24a9bfc868fd1602f058cb9ce873ceef52
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
On startup we may not yet have an accessibility manager.
Change-Id: I9fda09c20de40ed3c8fb7108fd0314a789eb50f5
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
| |
Setting the Qt role Application will lead Qt to returning the qApp
accessible representation. Instead make it a document.
Change-Id: Id0b0a3462115905664b8147ab7d529bae7e4fa4b
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I837d7f3041aec59ae83c0fe802bc83b746e62b76
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I3a9143c61ecda98513be031fc554fd4bfcef7b7c
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
| |
GYP_ARGS needs a -D option before defining a value.
Change-Id: I4acb78e3f201a5d7369c3e998eb7356769bb7553
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
GetViewBounds should return the bounds of the view, not the screen rect.
The view bounds are for example used to calculate the screen position of
accessible objects (which gets fixed with this patch).
Change-Id: I5b342113af737847c1756a13183cd2b8b8db648a
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I37a32bd5dd8760bc91173968a620a1932ae67b4e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I0301ed0403b56169e610cf1c38a1e5da39ee164f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
The blink root element already has document as role. By setting it in
the webview we'd get two documents in the hierarchy.
Change-Id: Ie14e57b4e2050dbd9495c4fa94de4e2faebc02c1
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
This is in line with how other platforms do it.
Change-Id: Ia258511d3fa35387a69c81c9c02c181fc2995e6c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
| |
With this patch the accessibility hierarchy inside webengine becomes
available when navigating from QWidget based web views.
Change-Id: Ib3625a6ec93b4d3f298fb845ab85209b348349ba
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds the basics to bridge the blink
accessibility classes to QAccessibleInterfaces.
Note that it needs two follow up commits to implement the bridging from
the QWidget/Qt Quick worlds.
[ChangeLog][Accessibility] QtWebEngine now has accessibility
support, enabling assistive technology such as screen readers to work
with it.
Change-Id: Ied1d97e61a024115ac7a9245331211f6d9fac1b4
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 3cd70c11bc7bbe3c5e9e4972d2273cf51bbdc30e in
qtbase Qt modules require cmake tests to be present
which makes QtWebEngine fail with "Missing CMake tests."
We do not support building with cmake at this point,
so disable these tests by setting CMAKE_MODULE_TESTS
to '-' for module pro files.
Change-Id: I777e6b2c7ce975ad021281800987f9d3ce173399
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requesting MediaAudioCapture would unconditionally ask for
QQuickWebEngineViewExperimental::MediaAudioVideoDevices instead of
MediaAudioDevices since the if wrongly tested for the same condition
twice.
In addition fix a warning: variable 'feature' is used uninitialized whenever 'if' condition is false
api/qquickwebengineview.cpp:369:13: warning: variable 'feature' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
api/qquickwebengineview.cpp:371:57: note: uninitialized use occurs here
Q_EMIT e->featurePermissionRequested(securityOrigin, feature);
^~~~~~~
api/qquickwebengineview.cpp:369:9: note: remove the 'if' if its condition is always true
else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
api/qquickwebengineview.cpp:364:4: note: variable 'feature' is declared here
QQuickWebEngineViewExperimental::Feature feature;
^
Change-Id: If63fbb5a59a71dede1d1829695f66c22849a4dcd
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I87d6532babc9475e46e28f6be7d1593622958764
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I4543cc9a42f803fd763b889cf7c36d8cfd54fc42
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is done by setting qt_egl_library and qt_glesv2_library to
the correct value depending on whether the build is using debug or
release config.
This also updates the 3rdparty submodule as necessary.
Change-Id: I536310073d1d2436f7ed529b935421f6c9a8cae9
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I1b7bea888290be340b2e368f8e77b661e8d66018
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash on Windows when dismissing a JavaScript dialog.
It was caused by the JavaScriptDialogController object deleting
itself and its private object from a method call and subsequently
trying to run the JavaScript dialog callback.
Task-number: QTBUG-39883
Change-Id: I74300c53943ec7ebc492362ef7d75d83aa1f8051
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
| |
Change-Id: Icc4219ace4121a4b30302e0348e48dc75cae54cb
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Use QUrl::fromLocalFile to load components from the installation
Qml directory. Using just the absolute file path wasn't a problem
on Linux, but did not work on Windows.
Other Qt modules are also using QUrl::fromLocalFile to do this.
Change-Id: I689c516dc63a6c966435eedb94441d7c9246dd25
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
ICU data file is required by Qt5WebEngineCore.
Change-Id: Ifcbb1119e9dfe25b6a1bb206475176f21278c2a9
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Arrow keys and page-up/page-down was not working. These are detected
on RayKeyDown events which both the Win and GTK versions sends instead
of KeyDown.
Also fixes a mistake in reading the length of the UTF16 text string that
was using sizeof on a pointer.
Change-Id: I441ef21c15430dafcaeda00d43eb9aec81cd88b8
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since all quads are already separated in non-intersecting geometries
and ordered according to their depth by Chromium, there is no need to
keep any z value once the perspective projection has been applied.
Avoid the useless computation and project the quads to z=0 the same
way that QMatrix4x4::toTransform() does when used to flatten
QQuickItem::transform().
Change-Id: I3ec5dc2da23cf431e2d8d0bb8b1ed48f2f2d2d8e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the default behavior of gfx::GLContext, but explicitly do it
for documentation purpose and cover the case of the behavior of
gfx::GLContext would change in the future.
This also updates the submodule to include the change that uses this
value.
Change-Id: I214376d92b4f9f11bd491c2b1263cf8159e5779f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch also changes the way we handle our patches.
We'll always take a new snapshot without patching Chromium
and rebase our patches on top of the snapshot. This removes
the need for separate patch files for the ustream repository
since we can use the patches of the snapshot and apply them
on the upstream checkout if we want to use an upstream build.
This makes it easier for us to have branches for the release
and maintain and minimize the number of patches we need on
top of upstream Chromium.
For now a snapshot checkout is needed to be able to prepare
the patches for an upstream build but in future we cold improve
this to fetch the patches from the remote snapshot repository
if needed.
Change-Id: I6280ffbe2d50d25d252734bc76d19bfaaa081637
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
With Qt 5.3 mac_sdk_path ends up being empty, so make sure to set
the proper flags for chromium to pick the right sdk.
Also add clang_use_chrome_plugins=0 so we can remove it as well from
the Mac-Use-libc-instead-of-stdlibc patch.
Change-Id: Ia132f079f905761644ad26c728f7116f538ea62d
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
clang complains about unknown scoped_refptr
Change-Id: Iee7590f9ad45cab55a5918bf1c756aa769fa3fd9
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On QNX platform, we implement video streaming via OpenGL
EGLStream streams. Changes were added to StreamVideo class
to support EGLStream objects. For non-QNX platforms, we
kept the StreamVideoNode class unchanged - assuming other
platforms will continue to support streaming via EGLImage
objects.
On QNX, cc::StreamVideoDrawQuad contains an
external OES texture that is associated with an
EGLStream. Before we draw with that texture, an
'acquire' is performed to grab latest video frame.
See EGL_KHR_stream specs from Khronos.
Change-Id: Ia3fe25e9047f475594a55591e3e11caa0eab1e6a
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
Currently some variables defined in os independent section.
Change-Id: I661d840b2271dc4bccf98dc2a252feaf6907952c
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The findNext flag tells the frame to search starting from the current
selection, but the code assumes that the flag won't be used when there
isn't any find selection (like when the Frame changed).
Make sure that we won't use that flag after we received a load
committed signal.
Change-Id: I10f0f84226232d150f19fd644d7afe78bc425f74
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QPlatformBackingStore still doesn't enable blending when compositing
a QOpenGLWidget with the rest of the widget tree. This means that a
tranparent pixel will show as black.
Until we get to properly go through the work of making it possible to
render a transparent webview, set the glClear color to white in order
to avoid seeing any black background before we get our first frame
from Chromium.
Change-Id: Idf7bb831a3b0d62b02f2527e2a15d830bf1e8ad4
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Use eglContext instead of eglcontext as a parameter of
nativeResourceForContext() function on windows:
qtbase/src/plugins/platforms/windows/qwindowsnativeinterface.cpp
Change-Id: Id6b4b5b6b8befad5b8a20b44e1c2a80c034921f9
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: Iee7f3dc7fb9deba03e57a80ed48b74069490fe0d
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
| |
Lookup the correct UIDelegates import path once lazily, and reuse
this information. If there is none, then we don't expect any UI
delegation to work, but it should not crash.
Change-Id: I73be7273d83b8d89b74641dc550341cf2b7eb602
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
| |
We only do have the scoped_ptr m_surfaceFactory on Android.
Change-Id: Ia377afa9a8662498fca005994bd5fbec5c41bc9e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
This also explicitly enables impl-side painting, which is enabled
by default on Android, hard-coded behind an #if defined(OS_ANDROID).
Change-Id: Iacc6cff82c0f071d1c8901977748d6164fb0a87d
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
The kEnableScrollPrediction switch uses event timing to extrapolate
events but this considerably reduces the smoothness of pinch-zooming.
Assuming that this feature expects very well timed events, which we
don't have in most of QPA platform plugins, disable the feature.
Change-Id: I96bdd8b9e9cc870e232ad9c98bcad5857608870b
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
| |
Adds the license for Chromium to the legalese part.
Adds some missing documentation to QWebEngineView and QWebEnginePage.
Change-Id: Ie81aaa87db85bb72efb83680defbdb101a134df0
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
The eAndroid mkspec also sets linux, and since the qnx change we
ended up including both android and linux configs. Make it more
obvious why the else is there.
Change-Id: Ia97483d410e280bbb4f4b56cf6fd351f6a4bbbca
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InputHandlerProxy::HandleGestureFling assumes that the timestamp on
the fling gesture is in the same system as base::TimeTicks. By giving
it our smaller relative event timestamps (most often taken from a
QElapsedTimer) this ends up here being calculated as a negative time
on the fling animation curve.
Fix the issue by applying a delta at the ui::TouchEvent conversion so
that the resulting GestureFlingStart has a timestamp that can be
reliably interpreted.
Change-Id: I5e149bf64887305119643359495f89be6e0c3ffb
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
QTooltip's documentation states that "rich text displayed in a
tool tip is implicitly word-wrapped". This seems to be a more
desirable behavior for our needs.
To mitigate any potential malicious tooltip contents, we escape
any eventual html entities, and truncate to a reasonable size.
Change-Id: Iae3ea80e7660840aae39d228d1177dcc56f4a032
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
This snippet contains API that we might not support at all. It is
better to remove it and add a new version in case we reintroduce
this than to present a snippet that does not work or only works
partially.
Change-Id: Ia47ad69108ddcbe529aecff8e4f235b17d80514f
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because of an uninvestigated reason, ImplSidePainting can cause more
than one quad to use the same resource_id in one delegated frame.
Fix the issue by first checking if m_data->mailboxTextures contains
a texture for the resource_id before overwriting it.
This also re-enables the feature on OS_ANDROID where it is enabled by
default.
Change-Id: Ie7842f958e1c049db71ffc2a0a768a5725102a3d
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make sure that this version number appears in the user agent
string and in the QML imports. The plan, unlike other Qt modules,
is to keep our module and QML versions in sync to make it easy
for developers to figure out what API is available in a given version.
The QTWEBENGINECORE_VERSION_STR define is explicitly set in the .pro
file since we don't call syncqt to generate a version header for the
core module.
The 0-major version currently causes the library name to start with
libQt0 instead of libQt5, but this is something that we can fix in
qtbase once we want to officially support linux desktop with
QtWebEngine 1.0.0.
Change-Id: I31915e84869b4db456416ef1f85a2296b8a06c99
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
|
|
|
|
|
|
|
|
| |
QNX is using Ozone, so exclude gl_context_ozone as well.
Change-Id: Icdad9eed3211e9b095fbf884bc5e0243b551c1bb
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Arvid Nilsson <anilsson@blackberry.com>
|
|
|
|
|
|
|
|
|
| |
QNX has since changed to Aura and no longer has its own implementations
of those files.
Change-Id: I193dfa82093530742e6c6599750972bce0e69e39
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Arvid Nilsson <anilsson@blackberry.com>
|
|
|
|
|
|
|
|
| |
Drop hovered title and link text parameters, as we did
in the Quick API.
Change-Id: Ia1a38e0d728afbcbb6858a890486772da74aa813
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
| |
With this patch we get usable debug files.
This also makes qmake strip the core lirary from unneeded sysmbols
which is especially beneficial on embedded.
Change-Id: Ic1cadd87dbedb9817512a8b4f251cc3e43f028d1
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|