summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Native spellchecker: Fix it when disabledSzabolcs David2022-08-161-0/+8
| | | | | | | | | | | | | | SpellCheck is enabled by default "due to peculiarities of the initialization sequence" (see the ctor in components/spellcheck/renderer/spellcheck.cc). It produces red underlines on the fist user interaction even if we disable it from WebEngineProfile, then the lazily initialized SpellcheckService disables it correctly. Initialize the service early for this particular case to avoid undesired spellchecking. Change-Id: Ib2e38fb381d9b169f8f59c8100b4df7af3493aa1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update Qt compat documentationAllan Sandfeld Jensen2022-08-121-2/+2
| | | | | | | | Updated it for Qt 6.4 Change-Id: Ia3a115bfd5bb41bc1ebbb2b2258178b42b938dca Pick-to: 6.4 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix PDF viewerAllan Sandfeld Jensen2022-08-1117-48/+396
| | | | | | | | | | | | | | | | | | | | | | | | | It was broken after 102-based merge Submodule src/3rdparty c57592220..8496e1340: > Revert "Jumbo build mojom files" > FIXUP: Fix building with optimize_webui=false > Revert "Add remove_v8base_debug_symbols to GN" > FIXUP: Fix crashes and asserts > Add missing node modules for PDF support > [Backport] CVE-2022-2614: Use after free in Sign-In Flow > [Backport] CVE-2022-2618: Insufficient validation of untrusted input in Internals > [Backport] CVE-2022-2612: Side-channel information leakage in Keyboard input > [Backport] CVE-2022-2613: Use after free in Input > [Backport] CVE-2022-2624: Heap buffer overflow in PDF > [Backport] CVE-2022-2610: Insufficient policy enforcement in Background Fetch > [Backport] CVE-2022-2615: Insufficient policy enforcement in Cookies > [Backport] CVE-2022-2294: Heap buffer overflow in WebRTC > [Backport] CVE-2022-2478 : Use after free in PDF > Jumbo build mojom files Pick-to: 6.4 Change-Id: I4fc608c21ab8aaa508329e708446b57cccbddf76 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix build with Qt versions < 6.3.0Michael Brüning2022-08-111-0/+4
| | | | | | Pick-to: 6.4 6.3 Change-Id: I754bce59da6d735c3a3adb4086b4d08e75c50b3a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix recovery after sub-process crashAllan Sandfeld Jensen2022-08-116-0/+24
| | | | | | | | | We no longer get RenderViewChanged signal but only a RenderViewReady signal after a crash. Pick-to: 6.4 Change-Id: Ib14cb3092e46e699d55bc252c9dddca524f6b8b7 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Improve finding Chrome/Chromium widevine CDM modules on LinuxPeter Varga2022-08-101-2/+36
| | | | | | | | | | | | | | Also search in the path stored in latest-component-updated-widevine-cdm hint file if available in ~/.config directory. The hint file is only available on Linux and it has been added by: https://crrev.com/c/1826077 Pick-to: 6.4 Fixes: QTBUG-86007 Change-Id: I39d049db004a5ac452a94011603e9dc5f96707bb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Move QPdfBookmarkModel::d_rolesNames to private classAllan Sandfeld Jensen2022-08-102-4/+4
| | | | | | | | | | To protect implementation internals From API Review Pick-to: 6.4 Change-Id: Idaf221546a1d7d00b433759b2f3160b915155cc3 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Add constructor to WebKeyboardEventMartin Negyokru2022-08-091-9/+12
| | | | | | | | | | WebKeyboardEvent type is needed for devtools protocol. Fixes: QTBUG-105082 Fixes: QTBUG-86871 Pick-to: 6.3 6.4 Change-Id: I17e9b38cae73cac606862cf2361ee878c9ae97ba Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Change Rotation values from RotateX to ClockwiseXAllan Sandfeld Jensen2022-08-093-12/+12
| | | | | | | | To avoid syntax such as Rotation::Rotate, and made direction explicit. Pick-to: 6.4 Change-Id: Id7bd7024ba11cfe2f4f23061e4fb05f46d75061e Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Rename _Count to NRolesAllan Sandfeld Jensen2022-08-098-16/+16
| | | | | | | | | | Identifiers shouldn't really begin with underscore even if it works. It is reserved for compiler/library internals. Pick-to: 6.4 Change-Id: I17e1b3ce2dc19af036fcb13a6c90fc1f6f149e17 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Add QT_NO_DEBUG_STREAM protectionsAllan Sandfeld Jensen2022-08-092-1/+6
| | | | | | | | So the header compiles with QDebug disabled. Pick-to: 6.4 Change-Id: I0f89dee4ff07734d53eee4dc5e2183633ee05da1 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Make QWebEngineFileSystemAccessRequest comparisons hidden friendsAllan Sandfeld Jensen2022-08-092-16/+12
| | | | | | | | From API review Pick-to: 6.4 Change-Id: I567767b95852048f56d3ff5b5d0df2b91358f8b1 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Switch QWebEngineFileSystemAccessRequest to std::shared_ptrAllan Sandfeld Jensen2022-08-083-10/+7
| | | | | | | | | | And also inline move constructor From API review Pick-to: 6.4 Change-Id: Ieff59c05df9ca7700579a5d83042f5e98355fe74 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Disable accessibility for guest viewsPeter Varga2022-08-081-0/+17
| | | | | | | | | It is not implemented yet. Pick-to: 6.4 Fixes: QTBUG-105134 Change-Id: Ide86d038729fe2647bd9a5560b30729697a4f575 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2022-08-051-0/+0
| | | | | | | | | | | | | | | Pulls in following patches: * e74437286f2 [Backport] CVE-2022-2480 : Use after free in Service Worker API * 0081e38b3cd [Backport] Security bug 1340335 * bedc4b56837 [Backport] Security bug 1334864 * 54a39c446af [Backport] Security bug 1336014 * ff5ca5ee77f [Backport] Security bug 1340654 * c5759222032 [Backport] Security bug 1287804 Pick-to: 6.4 Change-Id: I2994fa3274ade68ed8a3cbb3fc391755d371aa59 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix single process crash when proxy pac is usedMichal Klocek2022-08-051-1/+9
| | | | | | | | | | | | | | | | | | Using proxy v8 resolver ends up in race condition when render thread tries to evaluate extension handle and v8 proxy resolver evaluates proxy pac script. Disable v8 proxy resolver for single process mode. Issue tracked upstream http://crbug.com/474654 Modify the unit test to catch the crash case, the test loads now network resource but it does not matter as we do not check for failure or success. Fixes: QTBUG-104436 Pick-to: 6.4 6.3 Change-Id: Id3221d1b8b3896f0ced3d0cd7cb9d9eceeb929cc Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Update minimum windows sdkMartin Negyokru2022-08-051-1/+1
| | | | | | | | | 102-based requires 10.0.20348.0 windows sdk. See: https://chromium-review.googlesource.com/c/chromium/src/+/3550827 Pick-to: 6.4 Change-Id: I5797020f56d76831bf957940974e2bc296adb429 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix potential security issue with format stringsPeter Varga2022-08-051-3/+3
| | | | | | | | | | | This is a fixup for f63f7903c Add environment variables to specify resources and locales locations Pick-to: 6.4 Change-Id: I285e7408d138ac445e1c3e140b5b5587ef6ccd50 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
* Adaptations for Chromium 102Allan Sandfeld Jensen2022-08-0458-259/+274
| | | | | | Pick-to: 6.4 Change-Id: I7ef0ad616f2ea0fae482253335e95998aa2d360e Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adaptations for Chromium 100Allan Sandfeld Jensen2022-08-0459-255/+276
| | | | | | Pick-to: 6.4 Change-Id: I217c87657f544a2e868de7291353ff1143e20902 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix -no-opengl build on WindowsPeter Varga2022-08-031-0/+4
| | | | | | Pick-to: 6.4 Change-Id: Id48824fb64125b1fdafcc54866eed8365d5ec3bb Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add environment variables to specify resources and locales locationsPeter Varga2022-08-032-45/+122
| | | | | | | | | | | | | - QTWEBENGINE_RESOURCES_PATH for resources - QTWEBENGINE_LOCALES_PATH for locales (translations) Pick-to: 6.4 Fixes: QTBUG-88595 Fixes: QTBUG-78646 Task-number: QTBUG-103760 Change-Id: I9208ab8cc154d89eae6053eb3c50f007be5ffbb1 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Inline move assign and add swapAllan Sandfeld Jensen2022-07-132-3/+3
| | | | | | | | From API review Pick-to: 6.4 Change-Id: I7c24d4736a14d9b8af52de556523986eea99bc34 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Use SPDX license identifiersLucie Gérard2022-07-0819-441/+46
| | | | | | | | | | | Ammend 9b9d789fcb8f63a8998f1eefe44f2a1c8156c362 : some files were still missing SPDX headers Pick-to: 6.4 Task-number: QTBUG-67283 Task-number: QTBUG-104589 Change-Id: Ia4d2aae636bbdb1a99c422e3b8d3f097c3af34d6 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Doc: Do not advertise Qt module includeKai Köhne2022-07-0812-60/+0
| | | | | | | | | People should rather use class includes, like they are advertised in each class documentation. Pick-to: 6.4 Change-Id: I3fc26c2ff01e35595959878c392dcafa2527d29f Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* Add license headers to cmake filesLucie Gérard2022-07-0721-0/+63
| | | | | | | | | | | | CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: I118bd63694cfe2c9a413af4a38828a31727f8e86 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Doc: Fix linking issues on Qt PDF documentationTopi Reinio2022-07-055-28/+13
| | | | | | | | | | | | | These warnings were not captured by the documentation testing in CI. Fix or remove links to properties from inherited QML types, and remove \sa entries that are already linked to in the documentation. Fix incorrect \inqmlmodule argument for PdfPageImage. Pick-to: 6.4 Change-Id: If2c14d468a6dc3cd464ca4de1f4e39ad48d4d326 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Highlight the multipage pdf viewer exampleShawn Rutledge2022-07-051-0/+2
| | | | | | | | | | ...so that it shows up prominently on Creator's welcome page. Pick-to: 6.4 Task-number: QTBUG-81850 Task-number: QTBUG-103221 Change-Id: I4b61115b45eddb3142fdbc72701fcd005cea39a4 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* QPdfLinkModel: deal with flipped rectangle coordinatesShawn Rutledge2022-06-281-0/+6
| | | | | | | | | | Chromium's pdf/pdfium/pdfium_page.cc provides us a clue that this can happen: at least they seem to have found a need for a workaround there. Task-number: QTBUG-100630 Change-Id: I8b6091389d63687b4c6d9d31252b9b5a873347bc Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Fix build on Mac with native spellchecking enabledSzabolcs David2022-06-271-1/+1
| | | | | | Pick-to: 6.4 Change-Id: I79c69e428eab226c5f2eb954bc2317a1d0e88d99 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Various clean-upsPeter Varga2022-06-2448-151/+71
| | | | | | Pick-to: 6.4 Change-Id: I53e04a247a25149d9f29135484c0528c706de7d8 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix method checkAllan Sandfeld Jensen2022-06-231-1/+1
| | | | | | | | Detected by codechecker. Pick-to: 6.4 6.3 5.15 Change-Id: I8814180ef6bd591ed3e95fc4b4abff3454f10bdf Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Adapt FaviconDriverQt to Chromium 98Peter Varga2022-06-232-58/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adapts upstream Chromium's favicon::ContentFaviconDriver fixes: * Call constructor that takes a WebContents for WebContentsUserData. http://crrev.com/c/3278400 * Rename RenderDocumentHostUserData to DocumentUserData http://crrev.com/c/3208909 * Make helper macros behave consistently for //content/public UserData types http://crrev.com/c/3198788 * Introduce RenderDocumentHostUserData::render_frame_host accessor. http://crrev.com/c/3176183 * [SPC] Support SVG card art icons with no intrinsic size http://crrev.com/c/3148035 * Do not request favicons on regular page reload http://crrev.com/c/3097606 * Replace blink::Manifest with blink::mojom::Manifest http://crrev.com/c/3060401 * [mparch] Move UpdateManifestURL() to PageImpl http://crrev.com/c/2972153 * [content] Introduce WebContents::GetPrimaryPage http://crrev.com/c/2969524 * [mparch] Update a manifest url on the prerendering activation http://crrev.com/c/2952744 * [mparch] Move WebContents::GetManifest to Page. http://crrev.com/c/2955119 * [content] Introduce content::Page http://crrev.com/c/2916488 * Reland "[mparch] Update ContentFaviconDriver" http://crrev.com/c/2852141 * favicons: fix manifest crash http://crrev.com/c/2343718 * favicons: adds CoreFaviconService http://crrev.com/c/2313098 Pick-to: 6.4 Change-Id: I54a3eab98a4b168b22c42a10823ea88eb8fd6f4a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Use SPDX license identifiersLucie Gérard2022-06-22524-19450/+1054
| | | | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I869ffda1080e283f231eb0dc4477b260f2054d99 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Remove widget from QWebEnginePagePrivateAllan Sandfeld Jensen2022-06-223-37/+23
| | | | | | | | | It is redundant with item->m_widgetDelegate, once a few inconsistencies were ironed out. Pick-to: 6.4 Change-Id: I18a90cc195e5854d8421aa8c0951872322b78d28 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Cleanup item delegate logicAllan Sandfeld Jensen2022-06-226-75/+63
| | | | | | | | | Remove two indirect values we can calculate without tracking, and clean up naming in webenginequick. Pick-to: 6.4 Change-Id: Ibfab7013f314b428dca707036fe5f027558dff72 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Update .clang-format and fix messed up stylePeter Varga2022-06-222-14/+19
| | | | | | | | | | | | | | | | - Make sure clang-format doesn't reformat SPDX-License-Identifier (see https://code.qt.io/cgit/qt/qt5.git/commit/?id=6a4dab1134b10b432f69819018fef2044520e0ca ) - Fix C++ version to C++17 (see https://code.qt.io/cgit/qt/qt5.git/commit/?id=fe9efd359498dc342257908f6c9c2183e95fc05d ) - Update _clang_format to avoid adding a space in list-initialization (see https://code.qt.io/cgit/qt/qt5.git/commit/?id=fc7251edfaf782f184030a5787fe3a88feef6083 ) - Disable indentation for preprocessing directives. - Fix indentation of UIDelegatasManager macros and prevent formatting them. Pick-to: 6.4 Change-Id: Ieb59c993ee715430ebc2830828e488b9f62ec727 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Minor. Remove superfluous checkMichal Klocek2022-06-211-4/+0
| | | | | | | | Same check is two lines below. Pick-to: 6.4 6.3 Change-Id: If9a76ec29f7667d940f2cff231bb30facd621908 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update docs and do not recommend to use msys2 or cygwinMichal Klocek2022-06-211-0/+2
| | | | | | | Pick-to: 6.4 6.3 Task-number: QTBUG-102633 Change-Id: I412c10cea98d87ffbbac40baa032261dca12dbf0 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix build of gn with clang-cl on WindowsPeter Varga2022-06-211-1/+6
| | | | | | | | | clang-cl 14 does not support /MACHINE and /PDB flags for linking. Use lld-link instead. Pick-to: 6.4 Change-Id: I018a18af494f115be252b65b24a1386f57af28bd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix assert on devtoolsAllan Sandfeld Jensen2022-06-201-0/+1
| | | | | | | | We must allow file access in the thread as it is off by default Pick-to: 6.4 Change-Id: Ia73a457c29599b51bd284621644a0088992b6737 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Do not use the native dialog to show the color picker on macOSMichael Brüning2022-06-191-0/+4
| | | | | | | | | | | With the native dialog, there were either problems with the modality when using it asynchronously or with the life cycle when using it synchronously. Not using the native dialog avoids these problems. Pick-to: 6.4 6.3 Task-number: QTBUG-102099 Change-Id: Icb9a9afda48c47558b8e8ecb6d89adc0961d5063 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Support HTML5 <datalist> elementPeter Varga2022-06-1927-16/+1339
| | | | | | | | | | | | | | | | | The datalist uses Chromium's autofill component to fetch and filter predefined options in the list and autocomplete the field with the selected option. Autofill component is added to build and bound to WebEngine. All the unnecessary autofill features for datalist are supposed to be disabled: payment/credit card support, password manager, save profile data, store suggestions in database etc. Custom popups for the dropdown are implemented for Widget and Quick. Scrolling in dropdown is not implemented in this change. Fixes: QTBUG-54433 Pick-to: 6.4 Change-Id: I155d02d6dbc9d88fbca4bc5f55b76c19d0ba7a9d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Find modern Chrome, Chromium and Firefox CDM modulesAllan Sandfeld Jensen2022-06-181-5/+49
| | | | | | | | | | The default download location has moved again, but we can now also use firefox CDMs. Pick-to: 6.4 6.3 Task-number: QTBUG-104238 Change-Id: I7ee581fa63e50df970acb31ea6d3f67d332aef59 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix accessibility bounds with HighDPI scaling modesAllan Sandfeld Jensen2022-06-141-0/+2
| | | | | | | | | Disable chromium's uses of zoom for device scale factors. Pick-to: 6.4 6.3 Fixes: QTBUG-101769 Change-Id: I9f2ae7122b59f5fbf8ffcaf8a92940792f4860c9 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Protect against default profile being deleted before its pagesAllan Sandfeld Jensen2022-06-134-3/+13
| | | | | | | | | Can really only happen in QML on exit. Pick-to: 6.3 6.4 Task-number: QTBUG-99445 Change-Id: I1a04d57b6c4c40ae264b5519d2e41c57bca79a61 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update ChromiumAllan Sandfeld Jensen2022-06-134-0/+13
| | | | | | | | | | | | Submodule src/3rdparty 6559e00a3..88398c89a7b: > Fix broken bundled zlib for cross compilation > FIXUP: Fix url_utils for QtWebEngine > Make sure we do not compile minizip from 3rdparty > Trim down some dependencies of push messaging Pick-to: 6.4 Change-Id: I3062f536fd144d00f72ea783ddcc56931a46a98f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Apply url request interceptor on websocket connect as wellAllan Sandfeld Jensen2022-06-124-0/+83
| | | | | | | | | Try to match the types as best as we can, and handle the responses. Pick-to: 6.4 Fixes: QTBUG-92932 Change-Id: I01bc85668d2540b79fd2a52796f99d05f161e8a5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Avoid extra window after change of pageAllan Sandfeld Jensen2022-06-111-5/+21
| | | | | | | | | A widget created for an item in a viewless page, still needs to be tracked as a widget. Pick-to: 6.4 Change-Id: I9d571916b28b1cb2b8bd184d008255b9af105c33 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Switch from QT_NO macros to feature checksAllan Sandfeld Jensen2022-06-1010-33/+33
| | | | | | | | | | | This is safer by ensuring we are checking for a feature that is defined. For some reason, the openssl feature is a private feature, so we need to include the private header to access it. Pick-to: 6.4 Change-Id: Idf7f3baba33e5188f206f5be1b8a0bfd75e79d03 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-12 02:53:34 +0000