summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Note DNS prefetches can overrule remote access permissionAllan Sandfeld Jensen2022-09-291-1/+2
| | | | | | | Pick-to: 6.4 6.3 Fixes: QTBUG-106967 Change-Id: I0407258403ec3b76ce694e0f592fe57b4f45c746 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Work-around GNOME bug misidentifying HTML contentAllan Sandfeld Jensen2022-09-211-1/+4
| | | | | | | | | | Correct application/x-extension-html to text/html Fixes: QTBUG-97392 Fixes: QTBUG-106688 Pick-to: 6.4 6.3 5.15 Change-Id: I0d65c6950c5ba1504586cf564268463c5d4cd483 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix client certificate regression on LinuxAllan Sandfeld Jensen2022-09-201-2/+3
| | | | | | | | | The system certificate store was never generated after the define switched to being a BUILDFLAG Pick-to: 6.4 6.3 Change-Id: I2efa54bd397e2dde55c249747f73a9ffb08e80ea Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix os_crypt setup on windowsMichal Klocek2022-09-151-2/+2
| | | | | | | | | This parts were never compiled on windows. This amends 0ca4eba961. Change-Id: I683badfaf6e8be1cec808f3340e3980e167fbcdb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Check QT_OPENGL for softwareMichal Klocek2022-09-151-0/+7
| | | | | | | | | | | | According to qt docs this variable should have same effect like setting Qt::AA_UseSoftwareOpenGL on application, therefore read that in case of detecting the software mode. Pick-to: 6.4 6.4.0 6.3 Task-number: QTBUG-106095 Change-Id: I00fa8f0607ca44533c445434d1a35a1524bab679 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Do not let print engine multiply number of copiesSzabolcs David2022-09-141-1/+6
| | | | | | | | | | | | | | We print multiple pages by repeatedly drawing in a loop, which works good for PDF targets, but fails for physical printing. PPK_CopyCount flag is provided to the printing backend which multiplies our effort in this case. Temporarily setting the print engine back to 1 seems to be more reliable than trying to distinguish between paper of PDF target. Task-number: QTBUG-104224 Change-Id: Ic1be15c6965e6a739bcd44c8d904ac19f67719b5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Avoid crashing with unparented accessibilityAllan Sandfeld Jensen2022-09-141-6/+6
| | | | | | | | | | We do not get the automation id in this case then, but we have run without it before. Fixes: QTBUG-106588 Pick-to: 6.4 6.3 Change-Id: Ib65f1aaff1d7ef260df56c7de7198b0679e0d644 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Make opengl module name check more relaxedMichal Klocek2022-09-131-1/+1
| | | | | | | | | | | The module filename can be different depending on windows platform for example "openglsw32.dll", "openglsw32.DLL", "openglsw32". Make check more relaxed. Fixes: QTBUG-106095 Pick-to: 6.4 6.4.0 6.3 5.15 Change-Id: I0abd5f61df2a44b395c8a81511e4d3bc807e1537 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Update ChromiumAllan Sandfeld Jensen2022-09-131-0/+0
| | | | | | | | | | | | | Submodule src/3rdparty 43b92e07d..1dc53de69: > [Backport] CVE-2022-3040: Use after free in Layout > [Backport] CVE-2022-3041: Use after free in WebSQL > [Backport] CVE-2022-3038: Use after free in Network Service > Merge branch 'upstream-master' into 102-based Fixes: QTBUG-106254 Pick-to: 6.4 6.4.0 Change-Id: Ifd55481c8d26f0e2cf8cb9e01cdaa8aa530354d8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix using QNetworkReply with custom url schemesAllan Sandfeld Jensen2022-09-121-1/+8
| | | | | | | | | | | | | Sequential QIODevices are allowed to report atEnd() when they have no data to read, but add more data later. To avoid a regression with our own tests, treat a read error from a sequential device at end, as end-of-data. Pick-to: 6.4 6.4.0 6.3 Fixes: QTBUG-106461 Change-Id: Iac1233e6daa978c827c37a7fd3131e2fce764111 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Enable Push MessagingSzabolcs David2022-09-1214-4/+227
| | | | | | | | | | | | | | | | | | Use Chrome's implementation of PushMessagingService. This feature relies on notification permissions, so it is not different from Web Notification from end-users perspective. We don't persist push subscriptions, because it seems these have to be consistent with persisting notification permissions. Make address of push service configurable by a profile setting. It is empty by default - which means the feature is disabled until the user sets the address of a push service. Task-number: QTBUG-98904 Task-number: QTBUG-53457 Change-Id: If44f459fecf2da482c28fee5562f62fe40de103e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix busy waiting on streaming QIODevice'sAllan Sandfeld Jensen2022-09-101-5/+6
| | | | | | | | | | The writable watcher will trigger all the time if we use automatic arming, instead we need to arm it manually when it is needed. Pick-to: 6.4 6.4.0 6.3 Task-number: QTBUG-106461 Change-Id: Ia381db338adb1b1994d1da9b50c6d6ff542ea3e5 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Remove qLcNav logging category from qquickpdfpagenavigator.cppShawn Rutledge2022-09-091-2/+0
| | | | | | | | | | It's not used in QQuickPdfPageNavigator, and causes a linker warning about a duplicate symbol, especially in static builds. Pick-to: 6.4 Fixes: QTBUG-106361 Change-Id: I128c10a1aead1aa9a761dc091c626488fc195d12 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* PdfSelection: mark read-only for IM to avoid showing virtual keyboardShawn Rutledge2022-09-091-2/+1
| | | | | | | | | | | | | | | | | | | | | The Qt::ImReadOnly query enum is new in 6.2 (qtbase c80f262258b7846bf199887bcfdbb6dcfda6ad6f and aae4d52cbb79c61161271473ab5c3a1ba1086e01). It was added to the switch statement in 79d04aa9e3e9aa84d7378260519f9e9a6759dc41 but needs to return `true` to mark this Item as read-only, so that the keyboard will not open when it gets focus. The menu still gets populated with Select and Select All on long-press, and then Copy after a selection is made. That's all we need. The qt_im_readonly property was a sort of private API for Qt 5, and should no longer be needed (albeit the implementation is still in Qt 6 so far). Pick-to: 6.4 Task-number: QTBUG-83811 Fixes: QTBUG-106358 Change-Id: I677363be545d07884dffdfc10d6fdbd488cf2cf0 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Fix typo in CMakeList.txtMichal Klocek2022-09-091-1/+1
| | | | | | | | | | | | Fix typo, which slipped through testing. This covers the case when gn is already built (external project) and user reconfigures qtwebengine after removing cache (for non-prefix build) Pick-to: 6.4 6.4.0 6.3 Task-number: QTBUG-106406 Change-Id: Ic0d105ff7d50a07f3729cb0cd095d2a8daf6911b Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* doc: Mark all QPdfLinkModel docs internal for nowShawn Rutledge2022-09-071-8/+8
| | | | | | | | | | | So far we only have QML API, but we don't have a public header yet; so this class should not appear in public docs. Pick-to: 6.4 6.4.0 Task-number: QTBUG-77511 Change-Id: I1f0f5c6b625597a73a67a3019b9f8271ce9cea9e Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Doc: Add the git repo URL for the Qt PDF examplesVenugopal Shivashankar2022-09-071-0/+1
| | | | | | | | | This should enable the readers to access the up-to-date example code. Change-Id: Ie62bdea39d1374b49f1b8f5bf576b27c8f37996f Pick-to: 6.3 6.2 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* PdfSelection: check m_document before accessingShawn Rutledge2022-09-071-0/+12
| | | | | | | | | | The document is a property that the user needs to bind. If initializing it has been neglected or delayed somehow, we shouldn't crash. Pick-to: 6.4 6.4.0 Fixes: QTBUG-106355 Change-Id: I8e99b4bb84d868b694886058d56166fb3c4eabff Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Pdf[Multi|Scrollable]PageView: enforce zoom limits, don't get stuckShawn Rutledge2022-09-062-6/+8
| | | | | | | | | | | | | | Handlers must not get disabled because the zoom range is beyond limits: rather, let PinchHandler's minimumScale and maximumScale enforce them. So far, PdfMultiPageView and PdfScrollablePageView do not have other ways of zooming (like a WheelHandler for control-mouse-wheel), so we don't need BoundaryRule. But the limits applied by PinchHandler are "hard" limits: you bump up against them instantly, with no easing curve. Pick-to: 6.4 Fixes: QTBUG-104769 Change-Id: I4eb785e572816d1b80ea9c8f4f5b9c925594afac Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Copy gn in case for crossbuildMichal Klocek2022-09-061-0/+17
| | | | | | | | | | | In case of non prefix builds gn should be copied so it can be detected by cross-build from host qt. Pick-to: 6.4 6.3 Change-Id: I02937fc7101c249b22cfa06275c508410f888248 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Doris Verria <doris.verria@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Fix wrong scalingMartin Negyokru2022-09-023-28/+40
| | | | | | | | | | | Use inherited screen_infos_ in RenderWidgetHostViewQt. Handle multiple screens. Fixes: QTBUG-105955 Fixes: QTBUG-105960 Pick-to: 6.4 Change-Id: I6e5d04e29ff1e8bb9936cc3103960f27895904d6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix moc's namespace for qquickwebenginesingletonMichal Klocek2022-09-021-1/+2
| | | | | | | Fixes: QTBUG-106090 Pick-to: 6.4 6.3 Change-Id: If0572c92e5b9fe6ae44c2d93d38dfa0f68289994 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Add touchHandles for widgetsMartin Negyokru2022-08-297-1/+131
| | | | | | | Task-number: QTBUG-100418 Task-number: QTBUG-91712 Change-Id: I69131d3c7c4511ea3114df7a9300bf6ff1a59fee Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Change the license of all CMakeLists.txt and *.cmake files to BSDLucie Gérard2022-08-2621-21/+21
| | | | | | Task-number: QTBUG-105718 Change-Id: I2ad190e5536cdbdc8d2656e61892545d66911a02 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Reestablish default config for embedded buildsAllan Sandfeld Jensen2022-08-262-0/+15
| | | | | | | | | Was missing from the CMake switch-over Pick-to: 6.4 Change-Id: I0171d395f9e66c072e368b7019539fc29ff865b8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix build with disabled webengine_printing_and_pdfPeter Varga2022-08-246-17/+51
| | | | | | | | Now the extensions can be enabled when printing is disabled. Pick-to: 6.4 Change-Id: I6183c795298eedf9cdf5110e580e73ba88f45828 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumPeter Varga2022-08-241-0/+0
| | | | | | | | | | Submodule src/3rdparty 7ed043a1b..a7ecbb5ca: > Avoid calling git in build scripts > FIXUP: Fixes for jumbo build Pick-to: 6.4 Change-Id: I47ae3494c00750adefae192a45da270ca3706e86 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix initial widget focusPeter Varga2022-08-241-1/+0
| | | | | | | | | | | | Avoid WebEngineQuickWidget::rootObject() to steal focus from the content item (RenderWidgetHostViewQtDelegateItem). The root object is supposed to keep the content item alive and not handling input events. Fixes: QTBUG-105072 Pick-to: 6.4 Change-Id: I18e8ff39bfe338b742416bc56f6937edcfd2bc21 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add QWebEngineUrlRequestInfo::httpHeaders()Benjamin Terrier2022-08-234-8/+51
| | | | | | Fixes: QTBUG-105399 Change-Id: I6bc64d7f0b5e80b8645d7dbccb224262ff17c1a4 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumAllan Sandfeld Jensen2022-08-221-0/+0
| | | | | | | | | | Submodule src/3rdparty 4c842ebb1..7ed043a1b: > Move gio to public_config > Fix building with system ffmpeg 4.4 or 5.1 Pick-to: 6.4 Change-Id: I7d657b874a3e7d8307c1af9447b8dffc2ab92546 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Find GIO submodule of GLIBAllan Sandfeld Jensen2022-08-221-1/+1
| | | | | | | | | Seems casing is important. Task-number: QTBUG-105818 Pick-to: 6.4 Change-Id: I43176b6c1aa21cba7d9145067ffdaec4456e3e67 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update ChromiumMichael Brüning2022-08-192-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 8496e134..620599a6: * 2nd fixup for [Backport] CVE-2022-2605 * Fixup for [Backport] CVE-2022-2605: Out of bounds read in Dawn (1/3) * [Backport] CVE-2022-2854: Use after free in SwiftShader * [Backport] CVE-2022-2860: Insufficient policy enforcement in Cookies * [Backport] CVE-2022-2855: Use after free in ANGLE * [Backport] CVE-2022-2857: Use after free in Blink * [Backport] CVE-2022-2853: Heap buffer overflow in Downloads * Disable accelerated_2d_canvas for Intel drivers on Windows * [Backport] CVE-2022-2605: Out of bounds read in Dawn (3/3) * [Backport] CVE-2022-2605: Out of bounds read in Dawn (2/3) * [Backport] CVE-2022-2605: Out of bounds read in Dawn (1/3) * Native spellchecker: Fix it when enabled * Fix build without spellcheck * [Backport] Security bug 1264288 * [Backport] Security bug 1333970 * [Backport] Security bug 1343889 Pick-to: 6.4 Fixes: QTBUG-104640 Task-number: QTBUG-1053266 Change-Id: I9fec122a689bcdf0afdec482b7a60cb5f811543d Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Native spellchecker: Fix it when disabledSzabolcs David2022-08-161-0/+8
| | | | | | | | | | | | | | SpellCheck is enabled by default "due to peculiarities of the initialization sequence" (see the ctor in components/spellcheck/renderer/spellcheck.cc). It produces red underlines on the fist user interaction even if we disable it from WebEngineProfile, then the lazily initialized SpellcheckService disables it correctly. Initialize the service early for this particular case to avoid undesired spellchecking. Change-Id: Ib2e38fb381d9b169f8f59c8100b4df7af3493aa1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update Qt compat documentationAllan Sandfeld Jensen2022-08-121-2/+2
| | | | | | | | Updated it for Qt 6.4 Change-Id: Ia3a115bfd5bb41bc1ebbb2b2258178b42b938dca Pick-to: 6.4 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix PDF viewerAllan Sandfeld Jensen2022-08-1117-48/+396
| | | | | | | | | | | | | | | | | | | | | | | | | It was broken after 102-based merge Submodule src/3rdparty c57592220..8496e1340: > Revert "Jumbo build mojom files" > FIXUP: Fix building with optimize_webui=false > Revert "Add remove_v8base_debug_symbols to GN" > FIXUP: Fix crashes and asserts > Add missing node modules for PDF support > [Backport] CVE-2022-2614: Use after free in Sign-In Flow > [Backport] CVE-2022-2618: Insufficient validation of untrusted input in Internals > [Backport] CVE-2022-2612: Side-channel information leakage in Keyboard input > [Backport] CVE-2022-2613: Use after free in Input > [Backport] CVE-2022-2624: Heap buffer overflow in PDF > [Backport] CVE-2022-2610: Insufficient policy enforcement in Background Fetch > [Backport] CVE-2022-2615: Insufficient policy enforcement in Cookies > [Backport] CVE-2022-2294: Heap buffer overflow in WebRTC > [Backport] CVE-2022-2478 : Use after free in PDF > Jumbo build mojom files Pick-to: 6.4 Change-Id: I4fc608c21ab8aaa508329e708446b57cccbddf76 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix build with Qt versions < 6.3.0Michael Brüning2022-08-111-0/+4
| | | | | | Pick-to: 6.4 6.3 Change-Id: I754bce59da6d735c3a3adb4086b4d08e75c50b3a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix recovery after sub-process crashAllan Sandfeld Jensen2022-08-116-0/+24
| | | | | | | | | We no longer get RenderViewChanged signal but only a RenderViewReady signal after a crash. Pick-to: 6.4 Change-Id: Ib14cb3092e46e699d55bc252c9dddca524f6b8b7 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Improve finding Chrome/Chromium widevine CDM modules on LinuxPeter Varga2022-08-101-2/+36
| | | | | | | | | | | | | | Also search in the path stored in latest-component-updated-widevine-cdm hint file if available in ~/.config directory. The hint file is only available on Linux and it has been added by: https://crrev.com/c/1826077 Pick-to: 6.4 Fixes: QTBUG-86007 Change-Id: I39d049db004a5ac452a94011603e9dc5f96707bb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Move QPdfBookmarkModel::d_rolesNames to private classAllan Sandfeld Jensen2022-08-102-4/+4
| | | | | | | | | | To protect implementation internals From API Review Pick-to: 6.4 Change-Id: Idaf221546a1d7d00b433759b2f3160b915155cc3 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Add constructor to WebKeyboardEventMartin Negyokru2022-08-091-9/+12
| | | | | | | | | | WebKeyboardEvent type is needed for devtools protocol. Fixes: QTBUG-105082 Fixes: QTBUG-86871 Pick-to: 6.3 6.4 Change-Id: I17e9b38cae73cac606862cf2361ee878c9ae97ba Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Change Rotation values from RotateX to ClockwiseXAllan Sandfeld Jensen2022-08-093-12/+12
| | | | | | | | To avoid syntax such as Rotation::Rotate, and made direction explicit. Pick-to: 6.4 Change-Id: Id7bd7024ba11cfe2f4f23061e4fb05f46d75061e Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Rename _Count to NRolesAllan Sandfeld Jensen2022-08-098-16/+16
| | | | | | | | | | Identifiers shouldn't really begin with underscore even if it works. It is reserved for compiler/library internals. Pick-to: 6.4 Change-Id: I17e1b3ce2dc19af036fcb13a6c90fc1f6f149e17 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Add QT_NO_DEBUG_STREAM protectionsAllan Sandfeld Jensen2022-08-092-1/+6
| | | | | | | | So the header compiles with QDebug disabled. Pick-to: 6.4 Change-Id: I0f89dee4ff07734d53eee4dc5e2183633ee05da1 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Make QWebEngineFileSystemAccessRequest comparisons hidden friendsAllan Sandfeld Jensen2022-08-092-16/+12
| | | | | | | | From API review Pick-to: 6.4 Change-Id: I567767b95852048f56d3ff5b5d0df2b91358f8b1 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Switch QWebEngineFileSystemAccessRequest to std::shared_ptrAllan Sandfeld Jensen2022-08-083-10/+7
| | | | | | | | | | And also inline move constructor From API review Pick-to: 6.4 Change-Id: Ieff59c05df9ca7700579a5d83042f5e98355fe74 Reviewed-by: Marc Mutz <marc.mutz@qt.io>
* Disable accessibility for guest viewsPeter Varga2022-08-081-0/+17
| | | | | | | | | It is not implemented yet. Pick-to: 6.4 Fixes: QTBUG-105134 Change-Id: Ide86d038729fe2647bd9a5560b30729697a4f575 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2022-08-051-0/+0
| | | | | | | | | | | | | | | Pulls in following patches: * e74437286f2 [Backport] CVE-2022-2480 : Use after free in Service Worker API * 0081e38b3cd [Backport] Security bug 1340335 * bedc4b56837 [Backport] Security bug 1334864 * 54a39c446af [Backport] Security bug 1336014 * ff5ca5ee77f [Backport] Security bug 1340654 * c5759222032 [Backport] Security bug 1287804 Pick-to: 6.4 Change-Id: I2994fa3274ade68ed8a3cbb3fc391755d371aa59 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix single process crash when proxy pac is usedMichal Klocek2022-08-051-1/+9
| | | | | | | | | | | | | | | | | | Using proxy v8 resolver ends up in race condition when render thread tries to evaluate extension handle and v8 proxy resolver evaluates proxy pac script. Disable v8 proxy resolver for single process mode. Issue tracked upstream http://crbug.com/474654 Modify the unit test to catch the crash case, the test loads now network resource but it does not matter as we do not check for failure or success. Fixes: QTBUG-104436 Pick-to: 6.4 6.3 Change-Id: Id3221d1b8b3896f0ced3d0cd7cb9d9eceeb929cc Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Update minimum windows sdkMartin Negyokru2022-08-051-1/+1
| | | | | | | | | 102-based requires 10.0.20348.0 windows sdk. See: https://chromium-review.googlesource.com/c/chromium/src/+/3550827 Pick-to: 6.4 Change-Id: I5797020f56d76831bf957940974e2bc296adb429 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix potential security issue with format stringsPeter Varga2022-08-051-3/+3
| | | | | | | | | | | This is a fixup for f63f7903c Add environment variables to specify resources and locales locations Pick-to: 6.4 Change-Id: I285e7408d138ac445e1c3e140b5b5587ef6ccd50 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>