| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Most page-state is set in webcontentsadapter::initialize except user
scripts and webchannel. This patch ensures those are initialized too
when changing to a new adapter during history restore.
Change-Id: I4dca23ddab50480b1a72252a038834ce1802ad77
Task-number: QTBUG-50751
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Reviewed-by: David Rosca <nowrep@gmail.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Disabling printing saves us compiling those files and files off a
megabyte on the debug binary.
To keep all the configure options in config, the common options
are moved to a shared common.pri.
Change-Id: Ieffdf9eb7dca58cfdafadd85bd24ea9c2be55ece
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The default implementation of QWebEngineView::createWindow returns a
null pointer. Add missing null pointer check in adoptNewWindow.
Change-Id: Ia6138f372ff169b9d32764b15550939adc247a1c
Task-number: QTBUG-50718
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For view-owned URL scheme handlers the destructor would remove the
handler and then trigger URLRequestContextGetterQt::generateStorage.
This would access the browser context from the IO thread while it
already has been destroyed on the browser thread.
Increment the ref count for the browser context before every call
of generateStorage, and decrement it when generateStorage is
finished.
Task-number: QTBUG-50160
Change-Id: Id8b1505891ec56e93bf9d47f33bb8bc3304eb55a
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Task-number: QTBUG-50037
Change-Id: I9c7a09824172a09d8b454bf8ff5d358c00ce6b88
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The classes were not properly protected against race conditions. To
solve this there is now a class shared between the two thread that is
not deleted until the classes on both threads have been deleted.
Change-Id: I499bd98805ae7a195aca42f30610eb6c2b0fd0f7
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Revert 7c7ee9a9, and fix the issue by passing a raw this pointer to
startAsync. Bind will take care of calling AddRef/Release for us.
Otherwise the WeakPtr would get assigned to the UI thread and must be
invalidated in the same.
Change-Id: Iee741dde521cf085a086e397a8154fa1384d58d1
Task-number: QTBUG-49670
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I1a4b96a2a695b4be4e936275c59f939b887098d1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Generate touch events with the "causesScrollingIfUncanceled"
property set to true. This is checked by
TouchEventQueue::TouchMoveSlopSuppressor
Task-number: QTBUG-50511
Change-Id: I5260100db75ed7afdd7afeff8f530221c22090b0
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-48779
Change-Id: Iaf189f69a9c4434a9417d482e63b83d8fc2f58b1
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is the path used when installing the official Chrome deb
packages on Ubuntu.
Change-Id: Iaa30c1df17ba2c6d069d17f828ecbbd26d16237b
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
URLRequestCustomJob::notifyFailure calls NotifyStartError(status), which
in turn will result in a call to URLRequestCustomJob::Kill.
We must release the lock of m_mutex before calling NotifyStartError,
otherwise m_mutex.lock() will wait forever in Kill.
Change-Id: I319e45049766c2192dfc46a91b352b92ec677bc6
Task-number: QTBUG-50160
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Pulls in the fixes for public CVEs fixed in Chromium 48.
Change-Id: I8738c7d0631e2e42ad844ada2b43dd614b4518c8
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ie6da4f94233a336c497074a5a9a83d27a86329ae
Task-number: QTBUG-43810
Reviewed-by: Martin Smith <martin.smith@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-50092
Change-Id: I1f3bbcab3b1999b9ecc86660ff9fef8330775cb4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When installing/removing URL scheme handlers, do not update the full
URLRequestContextStorage. Only update the job factory.
This avoids calling the - potentially expensive - generateStorage()
method superfluously often.
Change-Id: I99c4ec479fcfdee4e97d86b858ea42f3cdccfec4
Task-number: QTBUG-50160
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I73f6e944e3a64b948b86882e951f85593fdb800f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use this signal to notify the user on JavaScript window move/resize
requests. It works only for windows opened by JavaScript (according to
the Chromium browser's behavior).
Change-Id: I7fdeda4c252cc4badb36b74ed61d947be690f45a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-48435
Change-Id: If7117ecb11a0f06df1204dc91757a29c5444e189
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The class and its members were removed.
Change-Id: Ib8e892da1f9e10ffcf9861f75615ef48d3697886
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
and QFile::exist(f) instead of QFile(f).exists(). It's faster.
Change-Id: I2d5ffb2e64a547d3c703ad048ef0c75a7ccfe0d3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The documentation was still based on the initial version of
the method, where it had to return a boolean value. This is
no longer the case and hence removed from the doc.
Change-Id: Ica1e4a769631c0169bc5e59abd54c25a416cf4a9
Task-number: QTBUG-50513
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The new icon manager uses the WebContents::DownloadImage() API for
downloading icons. It proposes the best quality among the available
favicons via the iconChanged signal.
Change-Id: I66a014365b6f6560ff34d40ee870aee84e4e70e4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Integrate chromium spell checker:
* add spellchecker and dependencies to build
* underline misspelled words in html text areas
* right-click context menu shows up to 4 options to
correct the misspelled word
* toggle spell check from context menu
* add new qml and widget api calls to qwebengineprofile
to enable/disable spell check, select spell check language,
get list of supported languages/dictionaries
* register new qml spell check properties for QtWebEngine 1.3
* CONFIG+="no_spellcheck" to remove spellcheck support
Change-Id: Ie61434ab9493597d7759a6f33794f6859c4e3a4c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
New docs should be placed in the source files. Edited the docs
to fix grammar issues and QDoc errors.
Change-Id: I9f7b1aadccb8a9eac4f93a63e6ce01da82f71eb2
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Update files using old header.LGPL3 to use header.LGPL
Update files using old header.FLD to use new header.FDL
Update files using old header.BSD to use new header.BSD
Change-Id: I36a67aaa8c3ca6c7946308defc9c03c3571a7d23
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
To have them listed in the documentation as reimplemented
functions and to suppress QDoc warnings.
Change-Id: I4e7f9e6649897c31696d68471ecdf93664787476
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In QWebEngineDownloadItem::setSavePageFormat
Change-Id: Ieeefcce8007de6fa2258591028f0ec108fc8c69b
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add option to disable cache with passing NULL as cache backend.
It behaves the same way as using HttpCache::set_mode(DISABLE), but
saves some memory without instantiating backend factory.
Change-Id: I1565cc773eda21a6bc73eebe14ab8046252a7755
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
chromium/build/common.gypi already sets enable_plugins
to true by default for desktop platforms.
Change-Id: I3805a6856fe70ad3bd89606e974b02858e68e263
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Move the resources for remote debugging out of qtwebengine_resources.pak,
into a separate qtwebengine_devtools_resources.pak. This allows developers
to decide at deployment phase whether to ship the (rather large) resources
for the devtools feature, or not.
Task-number: QTBUG-50646
Change-Id: I74c75ad30989b97a63e6bce3abbc33360d1452e4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a QDragMoveEvent is posted, we have to notify Chromium, and wait
synchronously, for the possible drag and drop action at the respective
coordinates. This is done by executing an inner event loop.
The drag move event was processed in the inner event loop as a
side-effect, specifically when another event (like a QMouseMove or
QKeyPress) was forwarded to Chromium, which in turn called DoWork
implicitly.
The side effect led to incorrect behavior, when the
mouse button is released and the drag operation should be finished.
What actually happened is that additional queued DragMove events
were being sent by OSX after the mouse release, and the process
was stuck in the inner event loop, because Chromium's DoWork was
never called. And only after moving the mouse a bit (and thus
forwarding MouseMove events), the inner event loop was quit, and
the drag operation finished.
To actually make Chromium handle the DragMove event, we have to
manually call DoWork on the inner event loop.
Also because the possible drag and drop action is sent via IPC from the
render process to the main process, there is a race condition that the
the message might not be handled on the first manual call of DoWork,
so we set up a QTimer to continuously call DoWork, thus polling for
the message. Once the message is handled, the timer is stopped. In
practice this leads to at most two timer timeouts.
Change-Id: I8dc37a9c47ea5b675e15ebd138bc0e616b522049
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Enable loading Google Chrome's Widevine pepper plugin.
Flash and Widevine plugins will now also be searched for in
the plugins/ppapi directory.
Task-number: QTBUG-50132
Change-Id: I28fb56bb08d7e81629e34420be626621a7981181
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
|\ \ \ \
| | |/ /
| |/| |
| | | | |
Change-Id: I038f3544785862f3a2e2f35b8fab0b163e75d542
|
| |\ \ \
| | |/ /
| |/| /
| | |/ |
Change-Id: I591be7a7131d85a269bf12fbd5c47a0ccf6ce574
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This amends commit 3b4eec9b.
Change-Id: I19e8a295fa7e64ff83c26b6965097bd0ae3cbf73
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Copy additional key code mappings from PlatformKeyboardEventQt.cpp.
Also add a mapping for missing numeric keypad equals key.
Change-Id: Ia6c4413795293be84bcd8ea9d981d8cdfb94509b
Task-number: QTBUG-50401
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A few KeyEvents to key code mappings were incorrect or missing. Fix
them.
Change-Id: I74087768fddd467993f04ed8b4c2dc6345d20e8a
Task-number: QTBUG-50354
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
OnCanSetCookie and OnCanGetCookies should
both be mapped to API. Since the other
call is missing (filter cookies which should
be send) remove existing one from 5.6
Change-Id: I4f42c4a1fee6add7a5efffaf4c38877a1f35ce61
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove all callback api calls, rename getAllCookies
to loadCookies, update documentation. New function
name reflects the fact the cookieAdded signal is always
emitted when cookies are loaded from the store.
Change-Id: Iab7bb04871c7396d2e23306a10084d425426a19f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Do not cache the end iterator, because erase might invalidate it.
Do not increment the iterator in the erase case.
Change-Id: I1cbad04fdaaf1bf4cfae252bb7569d817b6ab5a5
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The string parts inside the lambda construction were already freed, so
instead use a simpler construction where we are sure we are still
holding the stringlist.
Change-Id: I3559ab9d203b368e2d62efef73497ce7f9135cc5
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QSortFilterProxyModel does not like negative values
which were returned when adapter was not yet initialized.
Add missing guards for adapter.
Change-Id: I3d1dd5343aaf2c4d5504950005b05fb650835884
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Icde2ed5519fe27d7b69d89e1c734d466cf65dfe3
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If deleteLater is called from the destructor of LocationProviderQt,
QtPositioningHelper shouldn't be accessing LocationProviderQt from its
destructor.
Change-Id: I1f2344edc1918fcfa566c3cd6045694cabf89768
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The initialization order did not match the declaration order causing
compiler warnings.
Change-Id: I3c852525736a145202085a698b542a7df7c3a9d9
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We must separate WeakPtrs per thread.
Otherwise we run into a DCHECK in weak_ptr.cc:
"WeakPtrs must be checked on the same sequenced thread.".
Done-by: Allan
Change-Id: I6ae971b01fb8f8ecda13e50798d6315dcf19d96e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
javaScriptEnabled is true by default, so setting it
explicitly to true is a bit dubious. Enabling
pluginsEnabled (which is false by default) is a better
example.
Change-Id: I8a94d0fed895c6bc4211bd6718aaba34a437f8c5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I6742fb003420404dafdcf204b5c3e9ffd9f474fc
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|