summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Update ChromiumJüri Valdmann2019-08-211-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This pulls in the following changes: a90e18d2d30 [Backport] Security bug 983938 0699308555b [Backport] Security bug 976050 852040586ec [Backport] Security bug 983850 a9f2f201ec6 [Backport] Security bug 973893 4bc95ce8486 [Backport] Security bug 958717 456aa9409ea [Backport] CVE-2019-5856 8ad3193acea [Backport] CVE-2019-5852 c1a19035306 [Backport] CVE-2019-5854 de78692c035 [Backport] CVE-2019-5855 ac7d5d7df5a [Backport] CVE-2019-5851 81417ff67b7 [Backport] Critical security issue 977057 ffbd836a7c8 [Backport] CVE-2019-5857 6693cf14341 [Backport] CVE-2019-5860 134a78ac91b [Backport] Security bug 981602 e981e2326a8 [Backport] CVE-2019-5865 b814b7b7d71 [Backport] CVE-2019-5862 1/4 dbb531a8212 [Backport] CVE-2019-5862 2/4 8502a1f7be2 [Backport] CVE-2019-5862 3/4 b71efe4a834 [Backport] CVE-2019-5862 4/4 d377f182ec3 [Backport] CVE-2019-5861 1/2 e13a9847f21 [Backport] CVE-2019-5861 2/2 4d84676d74a [Backport] Security bug 974627 d0d509db8c7 [Backport] Security bug 961674 691d632f7af [Backport] Security bug 960785 bdb7acb5afd [Backport] Security bug 964002 6e2562dd1ef Fix build with recent linux kernel. 7a779d01607 Fix skcms build with avx Fixes: QTBUG-77402 Change-Id: Ib9fe63c806149c299714bb1f76e4adf2877389d5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2019-08-051-0/+0
| | | | | | | | | | | | | | Pulls in following changes: * f7765bc8 [Backport] Security bug 959518 * 3b775d71 [Backport] CVE-2019-5842 * 05e857bc [Backport] Security bug 934161 * a57309fa [Backport] Security bug 950005 * b0859392 [Backport] Security bug 948172 Task-number: QTBUG-76207 Change-Id: I54fb67a97564b24f34c58b93b048b347f01dc306 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2019-08-041-0/+0
| | | | | | | | | | | | | | Pulls in following changes: * 7a9ec163 [Backport] Security bug 962083 * 7242b69e [Backport] Security bug 948944 * a0218a0c [Backport] Security bug 952849 * 3d7891fd [Backport] Security bug 956625 * 7b993cc6 [Backport] Security bug 958457 Task-number: QTBUG-76207 Change-Id: I5753e64d396098a481da8d06a47560e4ba46bfb1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2019-08-041-0/+0
| | | | | | | | | | | | | | | Pulls in following changes: * c5c158eb [Backport] Security bug 958689 * a33c416a [Backport] Security bug 959193 1/2 * e339bd3a [Backport] Security bug 959193 2/2 * 44d5ec60 [Backport] Security bug 961597 * 33647d6f [Backport] Security bug 939644 * dd0c0a92 [Backport] Security bug 948228 Task-number: QTBUG-76207 Change-Id: I4ba94d0ee4fac31ea36688dcfa5d12905c9ec5f2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix tooltip text wrappingTamas Zakor2019-07-252-4/+6
| | | | | | | | Also set the hiding delay to a reasonable time. Fixes: QTBUG-76122 Change-Id: Id971edbd9fb87cc96df53f73f2e7c61bde5855ef Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix use-after-free of HostResolverJüri Valdmann2019-07-242-1/+3
| | | | | | | | | Create one HostResolver per profile to avoid use-after-free in NetworkHintsMessageFilter (5.12) or NetworkContext (5.13). Fixes: QTBUG-75884 Change-Id: Ic1a2973b4fb0aed6bd0fa1bb9a1d7c3012c30fe0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichal Klocek2019-07-221-0/+0
| | | | | | | | | | | | | | | | | | | | Pulls in following changes: * 0a0221c [Backport] CVE-2019-5839 * 3c46be6 [Backport] CVE-2019-5837 4/4 * c23cb87 [Backport] CVE-2019-5837 3/4 * f123d13 [Backport] CVE-2019-5837 2/4 * 10d98e6 [Backport] CVE-2019-5837 1/4 * 8ffc041 [Backport] CVE-2019-5832 * a97fa0a [Backport] CVE-2019-5831 * ec89d97 [Backport] CVE-2019-5829 * 2323dc9 Fix segfaults with arm 32bit on metrics * 6f3c15d Bump V8 patch level * e8eec84 Fix changing should_override_user_agent_in_new_tabs_ Task-number: QTBUG-76207 Change-Id: Ifc6b76ae4b253a7ea385398bfdc1bc0fcf699de7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Edit docs on script injectionLeena Miettinen2019-07-226-12/+21
| | | | | | Task-number: QTBUG-76489 Change-Id: If489ebed802d273b0015bc6cfc190d948c4896e3 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix use-after-free in WebContentsAdapter::loadJüri Valdmann2019-07-181-3/+7
| | | | | | | | | Pass WebContentsAdapter pointer to lambda via QWeakPointer in case the adapter has been deleted already. Fixes: QTBUG-76958 Change-Id: I1962ba3dd1794a27e7013a2ad1b729fe7a08c079 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Reset findText reply id on StopFinding to prevent callback laterKirill Burtsev2019-07-163-1/+4
| | | | | | | | | Not updating lastReceivedFindReply caused next findText call after StopFinding to trigger redundant callback call on checking stale query. Fixes: QTBUG-77029 Change-Id: Iad4b71364ecb3ec3db3096b739e77620d12731f9 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Do not proceed with uninitialized resourcesMichal Klocek2019-07-121-4/+4
| | | | | | | | | | | | QRC files can be optimized with CONFIG+=qtquickcompiler and removed, in that case 'size' of resource is zero. Do not process 'empty' resources. Throw warning. Fixes: QTBUG-76403 Change-Id: If21ff698e7985f82e6456500d4d24cb366cff012 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Make enabling full debug information easierAllan Sandfeld Jensen2019-07-121-0/+12
| | | | | | | | Avoids asking customers to edit source files or add CONFIG to qmake on the command line to enable full debug information. Change-Id: Id58388565df88442e74e02687eb3189136e998f3 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* If Qt is configured with ccache feature pass that along to GNAlexandru Croitor2019-07-121-0/+4
| | | | | | | | | This will set the cc_wrapper to ccache when running GN, which in turn will prefix all compiler calls with ccache. This allows a nice way of using ccache and icecream on macOS. Change-Id: I19ca1261aa8ebc4aaf7f8c34b3cb363baa29de01 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Update requirements for building on WindowsLeena Miettinen2019-07-121-1/+6
| | | | | | | | Visual Studio 2017 version 15.8 or later is now required. Task-number: QTBUG-76606 Change-Id: Ib115336acc341d799c7ff0f08e89abc56bc6c6d9 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Fix detection of ozone x11 supportMichal Klocek2019-07-124-6/+22
| | | | | | Fixes: QTBUG-77011 Change-Id: I0136b360c74970b912124f6f308f598c80eceba3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fully setup replaced QMouseDblClickEvent with source and flagsKirill Burtsev2019-07-081-1/+1
| | | | | | | | | | | | Not fully preserving properties causes event to not be considered synthesized by system and be forwarded into chromium. Receiving one single press event and no release event confuses input event_handler and triggers infinite loop and renderer process crash for pages with multiple nested iframes. Fixes: QTBUG-62106 Change-Id: Iabb8bff78fc3475923b4aa3209b720453a5b6ce5 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Unset global share context pointer on deletionJüri Valdmann2019-07-041-0/+2
| | | | | | Fixes: QTBUG-76828 Change-Id: I43eae3c04a23abe118f51c69742772ddb38646f0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Set custom user-agent manually on new windowsAllan Sandfeld Jensen2019-06-071-0/+5
| | | | | | | | | | | | Chromium forgets to set ShouldOverrideUserAgentInNewTabs(), so we need to manually set the override. Fixes: QTBUG-76249 Change-Id: Id240ee525dacec3cd8389aca058a61d3af62b00a Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Do not forward key-events on QQuickItem levelAllan Sandfeld Jensen2019-06-141-8/+0
| | | | | | | | | | | | We forward the real events earlier, anything coming in at QQuickItem level is synthetic. Fixes: QTBUG-76268 Change-Id: I067f8f94cc5e07bb0cd500b5ae9b9d6bbe66310b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Accept handled eventsAllan Sandfeld Jensen2019-06-141-0/+2
| | | | | | | | | If we let tablet events pass through without handling it, it will come back to haunt us as a mouse event. Fixes: QTBUG-76347 Change-Id: I93297f543620350db0329fe993d18a04e33c7d18 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Use Chromium linker flagsMichal Klocek2019-06-041-5/+9
| | | | | | | | | Add all Chromium linker flags by default and explicitly blacklist some of them. Change-Id: Icb461838f71c8511fe5730d4601eb20bc2aa135c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge "Merge remote-tracking branch 'origin/5.12.4' into 5.12"Allan Sandfeld Jensen2019-06-077-24/+37
|\
| * Merge remote-tracking branch 'origin/5.12.4' into 5.12Allan Sandfeld Jensen2019-06-077-24/+37
| |\ | | | | | | | | | Change-Id: I243662eee18709478038e918ff6b16aabd1f0662
| | * Update ChromiumMichal Klocek2019-06-061-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * bd792030 [Backport] Fix for security issue 951322 * b82fa580 [Backport] Fix for CVE-2019-5827 * 77de851f [Backport] Fix for CVE-2019-5825 * 3b283bc5 [Backport] Fix for CVE-2019-5826 * 546e8a27 [Backport] Fix for CVE-2019-5824 * 1660b7b1 [Backport] Fix for security issue 894933 * 048b1aee [Backport] Fix for security issue 937663 * bf0e274c [Backport] Fix for security issue 908669 * b8f953da [Backport] Fix for security issue 931949 (2/2) * 422411de [Backport] Fix for security issue 931949 (1/2) * f659a4d7 [Backport] Fix for security issue 939316 * f3378a1c [Backport] Fix for security issue 940205 * af9444ec [Backport] Fix for security issue 949015 * 8f58d94e [Backport] Fix for CVE-2019-5823 Task-number: QTBUG-75497 Change-Id: Id4330b3d08a444dcd95d072905dac6da212fd93b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Update ChromiumMichal Klocek2019-06-061-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 41a5b412 [Backport] Fix for CVE-2019-5822 * 233802ed [Backport] Fix for CVE-2019-5821 * c9ade8f0 [Backport] Fix for CVE-2019-5820 * c2dbb31a [Backport] Fix for CVE-2019-5819 * 7a8ae930 [Backport] Fix for CVE-2019-5818 * b5436c7a [Backport] Fix for CVE-2019-5815 * d3584684 [Backport] Fix for CVE-2019-5814 * 891c0a91 [Backport] Fix for CVE-2019-5808 * 23e798e8 [Backport] Fix for CVE-2019-5806 * 4d6500c2 [Backport] Fix for CVE-2019-5805 * 7b6a459e Try different versions when creating a CoreProfile context on macOS Task-number: QTBUG-75497 Task-number: QTBUG-73799 Change-Id: Ica812747467fc02a142f83d8638ec995589f1e5a Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Don't allow QtWebEngineCore to request executable stackThiago Macieira2019-05-312-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Chromium sources contain assembly code that causes the library to default to executable stack (the linker requires that *all* .o files have a .note.GNU-stack section in order to default to non-executable). So add the -z noexecstack linker flag to change the setting. The other libraries are not affected. Change-Id: I0bf9ebeb5aa34d19be30fffd15a3d3063dea2005 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Fix automatic NTLM authentication by backporting server white list supportAllan Sandfeld Jensen2019-05-291-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support --auth-server-whitelist Read it and pass it to an HttpAuthPreference. Change-Id: I37c23f4d777ff11b2c0480fa9c28ea6fbe029737 Task-number: QTBUG-75539 Task-number: QTBUG-57729 Reviewed-by: Kai Koehne <kai.koehne@qt.io> (cherry picked from commit b81d7095825cdd4f486e83894c801e596f248936) Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Update ChromiumJüri Valdmann2019-05-291-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This pulls in the following changes: 11c5d00ab75 Use MessagePumpMac for desktop capture thread on macOS Fixes: QTBUG-76045 Change-Id: I9fe920afeb39b34b837d9a5603c79e128942922d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Make linker call look great againMichal Klocek2019-05-274-11/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix issues with messed up linker path: * do not use LIBS_PRIVATE on linux at least for passing object and archive responses files. * do not use QT and QT_PRIVATE with same libs, it simply includes libs in LIB and LIB_PRIVATE so doubles linker libs. * remove bogus dependency for gui and core for webengineheaders pseudo module. * remove unused egl config flag Fixes: QTBUG-75832 Task-number: QTBUG-75357 Change-Id: I1720394e636e3f89d546f372b10932dd4ad395fe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit ee12b53eba009e8a3ca12ef77031d9a48c609cb4) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Fix linker too long argument listMichal Klocek2019-05-271-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For yocto builds linker can get quite long path since all archives are listed as absolute paths. This can end up as "execvp: /bin/sh: Argument list too long" Use rsp files also for archives. Change-Id: I096e2f35ed72b68261bf465e84baddd1f78cd917 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 546c42e42643a209d893d5291c26c3f8ef7102a3) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Doc: Improve documentation for QWebEngineView::setHtml()Leena Miettinen2019-06-072-3/+9
|/ / | | | | | | | | | | | | | | | | | | | | ...and QWebEngineView::setContent()and WebEngineView.loadHtml() The baseUrl cannot be empty. Fixes: QTBUG-75760 Change-Id: If276767ed6a7a9421292299e0ac79d02bbbca0e3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* / Disable edit actions when content has no focused framePeter Varga2019-05-2713-7/+145
|/ | | | | | | | | Task-number: QTBUG-75505 Change-Id: Ia1329ff554a86e307aa7995e9af1665ea6c5e64c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add path validation for QWebEngineDownloadItem::setPath()Tamas Zakor2019-05-202-0/+23
| | | | | | | | | | | Do not set path if it ends with separator or if it matches with an already existing directory name. Task-number: QTBUG-75566 Change-Id: I4b78b28afe034c7589633c569a4945a36b32008e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix detection of the webengine-arm-thumb featureJoerg Bornemann2019-05-212-0/+14
| | | | | | | | | | | | | | | | Configure tests must run in a clean environment. That's why functions that are defined below the mkspecs directory are discarded during the configure run. As a result, extractCFlag could not be found when running qtConftest_hasThumbFlag. This patch moves extractCFlag to src/core/config/functions.pri. Also, extractCFlag gets a qtwebengine_ prefix to avoid collisions with functions defined in other modules. The alias extractCFlag in functions.prf lets us use the old function within QtWebEngine itself. Fixes: QTBUG-75748 Change-Id: I6be613fbc569d5f7b3c145ef44b9a7be8e2ecb9d Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Referrer HTTP Header no longer ignored when set via RequestInterceptorLeander Beernaert2019-05-201-3/+10
| | | | | | | | | | | Make sure the HTTP referer is properly placed on a request when it's set via the QWebEngineUrlRequestInterceptor. Added test case to catch future incidents. Fixes: QTBUG-60203 Change-Id: Ida2f713a7352c3199fc9f8e15b5d8350d50afdda Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Add \a commands for WebEngineView signal and method argumentsLeena Miettinen2019-05-151-25/+28
| | | | | | | | To suppress QDoc warnings in the doc snapshot server: http://doc-snapshots.qt.io/qt5-5.13/qdoc-warnings.log Change-Id: I75a54cb584251877e329c22c380ec4ae5f95f2fb Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Update ChromiumJüri Valdmann2019-05-101-0/+0
| | | | | | | | | | | This pulls in the following changes: * 8d400b02 Fix crashes due to pa_context_get_server_info * b439cd9e Link with -latomic on mipsel * 4c061bfd Fix building GN with VS 2019 Change-Id: I26bef10d1ad051d29dd4a809d8c089a157d93ea9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update docs and test for runJavaScriptJüri Valdmann2019-05-092-0/+10
| | | | | | | Fixes: QTBUG-69567 Change-Id: Icdf5a200f7be1eb7a98cce62848e3a641c49e804 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Q(Quick)WebEngineProfile: Update list of internal schemesJüri Valdmann2019-05-074-64/+43
| | | | | | | | | | | Disallow installing handler for "about" and everything in kStandardURLSchemes of url/url_util.cc. Except for "gopher" which is used in tests. Suppress warning about custom schemes for "gopher" since it's not a custom scheme. Also lowercase the scheme in urlSchemeHandler() and removeUrlSchemeHandler(). Change-Id: I72b06d4fa6433882019405a0d600a593c8971bf1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Skip qtwebengine for -no-gui build (also in the configure system)Kai Koehne2019-05-061-0/+1
| | | | | | | | This amends 26ac59af2306 Fixes: QTBUG-75465 Change-Id: I22df5dc851f80724a44c028310269289548dacc5 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Do not crash on QWebEnginePagePrivate::releaseProfile()Allan Sandfeld Jensen2019-05-031-5/+9
| | | | | | | | | Deregistering the widget or deleting the view should be able to handle a now missing d_ptr in the old page. Change-Id: Ic843f7bde12776b6aad4fad865ccf14a25695154 Fixes: QTBUG-75547 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Doc: Add notes about delegating navigation requestsLeena Miettinen2019-05-022-5/+22
| | | | | | | | ...by overloading QWebEnginePage::acceptNavigationRequest() Task-number: QTBUG-75185 Change-Id: Ieaf9cacd5dd9259159767edba319191cf93f19ad Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Handle corner case of assigning an implicit page to a new viewAllan Sandfeld Jensen2019-04-301-9/+13
| | | | | | | | Pass the ownership on to the the new view, so it is still handled like an implicit page. Change-Id: I76ad3cb349a492e60e3ad2bdd4aebaabed07bd4f Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* QWebEngineUrlScheme: Prevent registration of standard schemesJüri Valdmann2019-04-291-0/+5
| | | | | Change-Id: I05ef67b81d9b871d38fcc51639b742b2a7b8a387 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Allow VS 2019 to try to build QtWebEngineAllan Sandfeld Jensen2019-04-181-0/+2
| | | | | | Task-number: QTBUG-75212 Change-Id: I1d1a99d9a5b6684d23e51cf55d384e7dfee6ef2a Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix printing of landscape orientationSzabolcs David2019-04-171-13/+15
| | | | | | | | | | QPageLayout::pageSize() is always defined in portrait orientation. Removing margins without considering the actual orientation was incorrent. Use QPageLayout::paintRect() instead. Task-number: QTBUG-75092 Change-Id: I34c19d3f0587ae21da2d985e3107b6ec673f53d0 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix QWebEngineView::setPage not deleting old pageJüri Valdmann2019-04-173-0/+10
| | | | | | | | | | | Also fix QWebEnginePage::setView not deleting old page Also fix wrong page being deleted if it's parented to the view. Fixes: QTBUG-75131 Fixes: QTBUG-75175 Change-Id: Ie4dfb15b3182de7aa3a94cddcac54ea40a86121b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix resolving relative URLs with custom schemesJüri Valdmann2019-04-161-0/+0
| | | | | | | | Pull in 3rdparty patch and add test. Fixes: QTBUG-74864 Change-Id: I5440f58ff55297c2a51f896d43f479404ff6ca2f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Take BrowsingDataRemoverDelegateQt instance ownership by ProfileQtKirill Burtsev2019-04-122-1/+5
| | | | | | | Delegate assumed to be owned and released by BrowserContext instance Change-Id: I1b5dc3ad2ace6f5c40b9f56e7ed7eb6b23b60925 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Run non-MainWorld DocumentCreation scripts even if JS disabledJüri Valdmann2019-04-081-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes regression, introduced by the fix for QTBUG-66011, where setting JavascriptEnabled to false stops all scripts from running instead of only MainWorld scripts (as documented). Only the DocumentCreation injection point is affected. The original change which introduced the regression consisted of moving the DocumentCreation injection point from ContentRendererClient::RunScriptsAtDocumentStart to RenderFrameObserver::DidClearWindowObject. The problem of scripts not working on view-source URLs was fixed by this move, but it turns out that the call to DidClearWindowObject happens to be conditional on Document::CanExecuteScripts and this is, of course, false if JS is disabled. Hence the regression. This new patch moves the injection point again to a task launched from RenderFrameObserver::DidCommitProvisionalLoad. DidCommitProvisionalLoad and DidClearWindowObject are both indirectly called from DocumentLoader::InstallNewDocument, however the former is called before the Document is opened and is therefore too early for script execution. As such, the execution is delayed by posting a task which, in theory, should be scheduled very soon after the normal call to DidClearWindowObject. Fixes: QTBUG-74304 Change-Id: Iac8714bcc5651c287b73181811af26996d955af5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-27 00:08:21 +0000