| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Change some compares to tryCompares to wait for
downloadStateChanged signal before comparing downloadState.
Change-Id: If8f7f15a776e60c937f0e006d2ac337f6c1f9ad9
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
tst_loadProgressSignal.qml is a duplicate of tst_loadProgress.qml.
Move loadProgressChanged signal check to tst_loadProgress.qml
and delete tst_loadProgressSignal.qml.
Change-Id: I14821d4979def7b9f1985859384224b8f8111bd6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Change-Id: I9eccddd420cd0eb8b5be3006a4091465d4b3fab0
Task-number: QTBUG-60472
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When opening a new window, for example by using the JavaScript
method window.open('...'), the requested url is not stored
in the content::WebContents object we get in
WebContentsDelegateQt::createWindow (at this point, it should
at least be stored as pending request in the WebContents'
NavigationController, but it is not).
Because of this, the QQuickWebEngineNewViewRequest object
in QQuickWebEngineViewPrivate::adoptNewWindow never contained
the url. We have access to the target url in
WebContentsDelegateQt::WebContentsCreated, so now we store
it there in a new property m_initialTargetUrl, from where
WebContentsDelegateQt::createWindow takes it and passes it
to WebContentsAdapter::adoptNewWindow as a new parameter.
[ChangeLog][WebEngine] Fix WebEngineNewViewRequest::requestedUrl being empty when opening window from JavaScript
Task-number: QTBUG-57675
Change-Id: I7e2c7866899baade17ce2517e6be8b2b2709699e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Change-Id: I3e22f09b0847cb7c5edc50ad12c73b62c4525072
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Valentin Fokin <fokinv@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
The typeAheadTimeout is set to 1sec in Blink. Wait a bit more when
selecting the next option in a HTML select element in auto tests.
Change-Id: Ia3d9fde05b4d6cde9186aaa701ca48354ca74b4d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
6252f0231f85e5f4e6b887a6814d4968acae13bd tried fixing
these autotests. As it evidently didn't work, we bring
the blacklisting back.
Task-number: QTBUG-55870
Change-Id: I12dc54a81cc25f743f1b37e321a6524ba6b5915c
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the test moves the mouse cursor out of the link area it positions
the cursor above an iframe. We should not expect linkHovered signal
above an iframe until its load is succeeded. Since we don't have API to
test iframes' loading state, remove the iframe from the test.
Moreover, increase signal timeout values to 12sec as it is used in other
tests too since the 55-based chromium update.
Task-number: QTBUG-55870
Change-Id: Id47494ac41a9d34f8a5bf4804fc5c157868cf923
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-58787
Change-Id: If0a658507c0caaa2d169da973109f801f9501914
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The issue has been fixed in the qtwebengine-chromium 55-based branch:
2890c82cbd3a3e66d7062c9d9f4f065f5cc09d9e
This test is based on the corresponding chromium test:
https://codereview.chromium.org/2537773008/patch/1/10002
Change-Id: Ia930c42f2c3337f10fe133a35ffb5b596aa61d9f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Use Custom Dialog API instead of Test Support API for testing form
validation messages. Moreover, remove the form validation part from the
Test Support API.
Change-Id: I8ecc80745ddad26f90df413d9a1d04045512af6c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
The new handler prints stack trace if the browser process crashes due to
segmentation fault while running QML tests. The solution is based on the
QTestLib signal handler implementation.
Change-Id: I5ccffc92043375fbf6fa5805a4592c61603efb3f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: Iff6ab3c287c58d8ec84a1513460bfce5218e8a61
|
| |
| |
| |
| |
| | |
Change-Id: I1b4f10facdacde432a7b135419ae3c81acf6ce74
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Changes our automated tests to use off-the-record profiles so that we
do not create profile directories on disk.
Change-Id: Ide1fad7431e2bacd72c469f1c8ebdf473ecf25b6
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since change https://codereview.chromium.org/2200833007 input elements
are inappropriate for testing unconsumed key events. Test focus change
on div elements instead.
Change-Id: Ifa2f3e1bc9d6d9cb396fbad7caea907616d085b7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Load failures now have a Chromium side timeout of 10s so we need to wait
longer than that. Additionally error-pages no longer have descriptive
titles, so we can not rely on that in our tests any longer.
Change-Id: I33ac8b9f1247403eb214f7260267edb887fe10d0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These tests have been broken for some time but we didn't catch that
the web-process self-terminated.
This change ensures we catch it and adds the failing tests to the black
list.
It also fixes BLACKLIST support by following what QUICK_TEST_MAIN does.
Change-Id: I31cc123e1d653f37e33ccb3a754b9fae8cfe02d6
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|\|
| |
| |
| | |
Change-Id: I0c3654ad097809fe10bcc6a15827a0af3006c4e6
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-55870
Change-Id: I3367889041614a5e7489909dd37c7af638edf16b
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|/
|
|
|
|
|
|
| |
Add API tests in order to try how it works in C++ and QML.
Task-number: QTBUG-51034
Change-Id: I1680297e2dafba39dbd4b161f0dbdb14fb6d4243
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Give more time for render process to handle mouse hover events.
Task-number: QTBUG-55870
Change-Id: I9922fc5d988351a2dd6cc2ed6a7af435a34600de
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: Ic200807246c5feb8e1f33215cbc6194b03765359
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The linkHovered signal can be emitted only if the page is rendered.
Waiting for rendering and for the UpdateTargetURL event may exceed the
time limit so add wait for the rendering too.
Task-number: QTBUG-55870
Change-Id: I3aa8e323a3bf8ff3f4a85c3de9efd3ab0f459f62
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-55870
Change-Id: I0d8dc7253e49662d1f73e7ef09d2529c530595b1
Reviewed-by: Milla Pohjanheimo <milla.pohjanheimo@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
The issue has been fixed in the quick test framework.
Task-number: QTBUG-56223
Change-Id: I101ca4cdd3f741623111d35d13dfcdb35ca85ea3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
This patch is intended to fix flaky failure and factors focus related test
functions out to TestWebEngineView.
Task-number: QTBUG-56540
Change-Id: Id7e17c08a4a9e863389ae991c9cadc00379377db
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I3b6353b5c58d62c968c704b20224ff8ee600a524
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-56661
Change-Id: I546222dde64c54955c62d2c30df79d4773b9973c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of some potential flaky issues:
- Fix typo in redirect.html
- Do not check URL before wait the result of the load. As a corner case
the load might be finished earlier than the comparison.
- Get rid of unnecessary signal handlers for unrelated test cases. The
superfluous operations might have enough overhead to cause a comparison
to be timed out.
- Separate data URL test case and blacklist it due a to known issue
(QTBUG-56661)
Task-number: QTBUG-56180
Task-number: QTBUG-56661
Change-Id: I76cec4e761be646c2f60588a34bae806cf558b3a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-56242
Change-Id: Ib6689d6f183532502382c86f92fdbdf27dd6c37c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
| |
Update Chromium for the actual fix. Add quick auto test for the issue
and unskip WebViewFindText::testfindTextManyMatches.
Task-number: QTBUG-56373
Change-Id: Id70291e5231f572c85b0a7c1ec1b6facd161115a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
| |
Title might be changed after a successful page load too. The order is
not guaranteed. Implement wait for the expected title change.
Task-number: QTBUG-56180
Change-Id: If8c529e6246fe9e8c93e41be84c8934c8ed8d729
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
| |
Simplify code and remove unnecessary wait calls.
Change-Id: If3a783a2a4f97e84de993b9394f5cfa0df948ec2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
This fix implements an attempt to remove wait from the test.
Task-number: QTBUG-56180
Change-Id: I2bfeb14ebc9451a1237178aa3c97bd1b27e9485c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Reimplement setting focus on a HTML element in JavaScript.
Change-Id: I1db53bcb526fd52df1fa23527089f8186dfd0ea3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-56540
Change-Id: Ic48883f94d72acf9a965fe8687abb20205a4703b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-56373
Change-Id: I599c02a12a0dfb35bb8b3d1d3abbede1c6498f9e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-55765
Change-Id: I5576876191fe1c819aa85f2e312391126c904201
Reviewed-by: Christophe Chapuis <chris.chapuis@gmail.com>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Based on code review for qqc2 integration,
apply cleanup changes to qqc1.
Change-Id: I9752ce944385a529a1d999a5419638868e18d799
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-56092
Change-Id: I026a0d153269a71e4e44f0fd30ef5ca054edd0e7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
The second mouse click in the test was handled as a double click.
Workaround the issue by changing click coordinate in the initialization.
Task-number: QTBUG-56180
Change-Id: I12e94ed5dbccdde4c0e6335e8a1c8a5e59b2d6a6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
The sequence of the titleChanged and loadingChanged signals is not
guaranteed. Wait for both of them to avoid flaky behavior.
Change-Id: I981cd20f6535187fa0f8144db0084c8bb64ab41c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Also allow the title to change to the URL during loading until the
content title is parsed.
Change-Id: Ie8059885576c840dbee639a597f78e1004ba1851
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
| |
Wait asynchronously on the title change.
Change-Id: I4e3826c5206e1a1a77c095c3226406d4eee64eba
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Only wait on title-changed signal before checking, this also makes it
safe to reduce the timeout for changing title, speeding up the test.
Change-Id: I4ecaf9400dfea624b39c73277425e09a52ea7b92
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
| |
A number of tests are failing randomly on the windows CI. This patch
disables them for now until they are stabilized.
Task-number: QTBUG-56180
Change-Id: Ifddbd52ef0b3c123cccd934457fc8bdbb7a89613
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/core/delegated_frame_node.h
src/webengine/api/qquickwebenginecontextmenudata.cpp
Change-Id: I163488d0d32cd981351608b2886f12e547e24672
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Wait for scroll position change before reload.
Task-number: QTBUG-55855
Change-Id: Ia42af1a4a76b2c507f4a88b39a469e3e37184ef7
Reviewed-by: Adam Kallai <kadam@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
User may miss the URL scheme (eg. http://) when type a view-source url
into the browser's location bar (eg. view-source:qt.io). This is not
handled by the Chromium thus will produce an empty view-source page.
The new autocompletion extends the incomplete view-source URL thus it
will provide valid URL if it is possible (eg. view-source:http://qt.io/)
Change-Id: I3edcd271cd0a971c9754e875db8f2a55a9a545de
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|