| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/3rdparty
src/core/web_contents_adapter.cpp
src/webengine/api/qquickwebengineprofile.cpp
src/webenginewidgets/api/qwebengineprofile.cpp
tests/auto/widgets/qwebenginedownloads/tst_qwebenginedownloads.cpp
tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
Change-Id: I56c093ebab5ee8b577783ce71761719159cd3ddd
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Unlike QNetworkProxy, Chromium's net::ProxyServer expects the hostname and port
to be at default values for special schemes (DIRECT and INVALID). Otherwise, a
DCHECK is triggered at proxy_server.cc:73.
Change-Id: I1ac6c425ea03fcbfe084d25c2fd05bf174c753d6
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/core/web_event_factory.cpp
src/core/web_event_factory.h
src/webengine/render_widget_host_view_qt_delegate_quick.h
Change-Id: Ic43787e2689c81b501ed395a990190eb67d83a2b
|
| |\|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/3rdparty
tests/auto/quick/qmltests/qmltests.pro
tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp
Change-Id: I2a1e3a83e29a1d6709f3e98fda3f7b4ab7ab297e
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove strange options for call to QUrl::path and add test for "qrc" protocol.
Change-Id: I6528d858b7661832852c333a7f932d4714f953f2
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Consider the scenario
1. user enters url "http://localhost:8000/"
A new navigation entry is created and committed in the
NavigationController.
2. user enters url "http://localhost:8000/download.bin"
A new navigation entry is created and a download is triggered, but the
pending navigation entry in the NavigationController is neither committed
nor discarded (since our WebContentsDelegate's ShouldPreserveAbortedURLs()
returns true).
3. user enters url "http://localhost:8000/download.bin"
At this point the NavigationController will have "http://localhost:8000/"
as the committed navigation entry and "http://localhost:8000/download.bin"
as the pending entry. NavigateToPendingEntry will see that the user is
trying to navigate again to the same URL as the last pending entry and will
therefore identify this new navigation as a reload.
However Blink interprets 'reload' to mean reloading the last committed
entry, i.e. "http://localhost:8000/", and so we end up trying to download
"http://localhost:8000/" instead of "http://localhost:8000/download.bin" as
the user might have expected.
The patch removes the ShouldPreserveAbortedURLs override and relies on the
default implementation which always returns false. As a result the pending
navigation entry in step 2 above is discarded once the download has been
triggered and the unexpected behavior in step 3 is no longer triggered.
Removing the override resurrects QTBUG-48995 where, for example, calling
QWebEnginePage::setUrl triggers first a urlChanged signal for the *old* URL. The
patch adds url and title properties to WebContentsDelegateQt so that property
change signals are triggered only if the properties have actually changed. A
consequence of this fix is that the first urlChanged signal is delivered
directly from the setUrl/load method and not asynchronously once the loading
starts (this is also how Chrome's URL bar is updated).
Task-number: QTBUG-63388
Change-Id: Icfa300b165e5e56f1fbc8978a00a237c263df183
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Document the somewhat strange behavior of the signals
QWebEnginePage::urlChanged,
QWebEnginePage::titleChanged, and
QWebEnginePage::loadFinished
when trying to load invalid URLs via QWebEnginePage::setUrl.
Change-Id: I5218a49105ad6187f87e7091589b5175f4349593
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is done to make sure there are no conflicts with features in
other modules, because they all share a global namespace.
Change-Id: I95b3b7fadd8ffc2979ee3aad2234ee543d57c7d8
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A 5 second timeout might not be enough for our underpowered CI VMs.
Also, if the page isn't loaded (to slow or for other reasons), we
must abort, to prevent the JavaScripts from being run on different
pages (first scripts to the old page, then to the new page if it
eventually finishes loading).
The first JavaScript in particular is rejected on the old page,
because "about:blank" doesn't have a secure origin. This could
even make the test accept wrongfully if all scripts are run on the
old page, because the request (which is supposed to be rejected)
can be rejected for being run on the wrong page, instead of for
requesting forbidden permissions.
Task-number: QTBUG-63347
Change-Id: Ib63d55477d35001b174900b73dc3dd23d33c7263
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\| |
| | |
| | |
| | | |
Change-Id: Ibc1c881a67bf088ba6fb044e2553c74c7e9e24ca
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I5cb198445f283c6cea8187a1a2883896df0ee918
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I8e75d21853ac8f7681b20101e40597154bcaca2d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\| |
| | |
| | |
| | | |
Change-Id: I3a411e4019a5ec2f7d1a967b62a00ad7cf92f6f4
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously when a find operation was finished by calling findText(""),
the selection buffer was cleared and calling selectedText() would
return an empty string, even though on the UI side a blue rectangle
selection was still visible.
This was due to an incorrect Unselect() call in
WebContentsAdapter::stopFinding().
With the new selection change support in the parent patch, and with the
removed Unselect() call, selectedText() now properly returns the value
of the highlighted blue selection after searching is finished.
Task-number: QTBUG-60673
Task-number: QTBUG-54071
Task-number: QTBUG-53134
Change-Id: I89e0eddb0c14af6d6c06ee878e706be65d3b0831
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/webengine/api/qquickwebenginesettings_p.h
src/webenginewidgets/doc/src/qwebenginesettings_lgpl.qdoc
Change-Id: I9cac7059557084a575af02782af886f55a8d404f
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Do not store flags in qmake.cache with WEBENGINE_CONFIG.
Use directly qtConfig values insted. This makes configuration
more consistent, simplifies handling and avoids passing
values from qtConfig to WEBENIGNE_CONFIG, which then
were passed to gn.
[ChangeLog] Removing WEBENGINE_CONFIG from qtwebengine configure
Change-Id: I1a773fb4bff6d67ad75c237d044998051d92ab51
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Positive options are more intuitive and make for a better API.
Task-number: QTBUG-63179
Change-Id: I632ee768dba52554e7d37d9da84661a1d01f1f37
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|\| |
| | |
| | |
| | | |
Change-Id: If9b7ec5e67a49aa017b49b75d7ccf6d45820f72e
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: I536258e22c2ec143f2fd3f1cbda229e0611b6af4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before this setting was added in Qt 5.8, the behavior was that
QWebEngineView/WebEngineView got the focus automatically. With the new
setting added it is configurable, but it was left enabled for
compatibility reasons. It would had to be changed at some point anyway:
none of other QML items or widgets grab the focus after creation, so why
would QWebEngineView/WebEngineView do?
This patch also fixes a bug with the text cursor in WebView (the cursor
was blinking as if WebView had the focus when it did not).
[ChangeLog][Important Changes][QtWebEngine][General]
focusOnNavigationEnabled setting which allows controlling whether
a web view will receive focus on a navigation request is now disabled
by default.
Task-number: QTBUG-60152
Task-number: QTBUG-60149
Change-Id: I78dc9bb9ffc70bf06217952acd456b97651c5185
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Expose navigator.webkitPersistentStorage.requestQuota() calls to
the API layer as a permission API. It allows the users to accept
these requests and specify a quota for persistent storage.
https://developer.chrome.com/apps/offline_storage#managing_quota
[ChangeLog] navigator.webkitPersistentStorage.requestQuota() calls
were rejected by default and now they will emit signal
quotaPermissionRequested in both WebEngineView and QWebEnginePage.
Task-number: QTBUG-56354
Change-Id: Id192577ffb403694d3051414744ded89bbfd2aa8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The deletion of CallBackSpy before web engine page destruction
could end up in segmentation fault.
Make CallbackSpy safe to be deleted before web engine page.
Change-Id: I71a184091c0251c61e3383010e3badfef5cb6124
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
[ChangeLog][Settings] Added setting to hide scrollbars.
Change-Id: I17695bb54a460621358345d303302b93eb342696
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The tested QWebEnginePage::scrollToAnchor API can't be added to
QtWebEngine for now. Currently, Chromium Content API doesn't support to
control page scroll. The corresponding feature can be used by URL
fragment identifier (#anchor) or JavaScript API (location.href).
Change-Id: Ie9c87758d458858ba677d309a548cdced525557b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Use feature permissions system instead of hard-coded dialog.
- Add QML test for getUserMedia() and extend existing widgets test.
Task-number: QTBUG-60832
Change-Id: I533bed5021b3b0ee199b8abc6ddbd516cbd14ff6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adjustments to auto tests to pass with Chromium 58
Change-Id: I7f6905e5344c528c608734bc660cbf43c89d4a63
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
|\|
| |
| |
| | |
Change-Id: I962033871a1ef624807a4e1869fe869406aa73f7
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the Q_VERIFY(current >= previousValue) fails, the output was
not verbose enough. The additional outputs will tell us more about
what caused the test to fail.
Task-number: QTBUG-57839
Change-Id: Ieeefe68ede111be7dba5eda9f2a770e975efc0ee
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
src/3rdparty used sha1 from 5.9, because both 5.9 and dev are
using same branch now.
Conflicts:
src/3rdparty
tests/auto/widgets/qwebenginepage/BLACKLIST
Change-Id: I16a33e0f91779d1ee3a230070ff4248699c2e1bd
|
| |
| |
| |
| |
| | |
Change-Id: If3581b261bfb1961320e145f94d27417ab8f8ee8
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instruct the render process to change the text selection if it was
requested via an input method event. Raise the selectionChanged() signal
when all the corresponding input method properties are set.
Moreover, add back the remaining input method widget auto tests. The
updated tests are moved to the QWebEngineView tests since the
corresponding APIs (inputMethodQuery() and input event handling) are now
available via the QWebEngineView's focus proxy (aka RWHV).
Task-number: QTBUG-55766
Change-Id: Ia0022d5f38b31dd59b084ff42e4abc2780ae90ec
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-59808
Change-Id: I25b73f1a89fb9e19d04c5a4ccbadbe44acea039d
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-59808
Change-Id: Id24f09a0502a3b48db2d3320d3c400bd349061e0
Reviewed-by: Liang Qi <liang.qi@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I3a6f92b6da850b124aae68af390211b613d3d640
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Calculate movementX/movementY at every turn, not only when
the mouse is in locked state.
Task-number: QTBUG-59127
Change-Id: I362e055e6b5d6f831671604a093434373cedf19a
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This patch adds the missing QRegExp includes in prevision of
the qtbase include cleanup.
Change-Id: Ic2cfddcd30207944c573096990032f7f7616a2b1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
|
|\|
| |
| |
| | |
Change-Id: I037dced1a6e6385305e7121cfc079ac586c68a31
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Load failures now have a Chromium side timeout of 10s so we need to wait
longer than that. Additionally error-pages no longer have descriptive
titles, so we can not rely on that in our tests any longer.
Change-Id: I33ac8b9f1247403eb214f7260267edb887fe10d0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|/
|
|
|
|
|
|
|
| |
It seems to be working after 2b2c7fc77d358f1ff0a0694f9c5f7c5cdfb3f247
in qtwebengine-chromium.
Change-Id: I691031cad05a2a84c7eea40a0e090d81df62672e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: Ic36a80502730d404ab96dfa11ff1eb0ac6eb302d
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-55766
Change-Id: I3be3b224dfef9ecc1ce39f4f20ec5c1d13c0fa69
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp
Change-Id: I070173576fc4be53689ce0dd9e1fd4133f5814da
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-55766
Change-Id: I4e6ade8f000f66ff1bb28f3b856ae140834292f1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Moreover, set ImHiddenText hint for password fields and add back the
corresponding widget auto test.
Task-number: QTBUG-55766
Change-Id: I3f76e19c8c33e11f3d9f515b6dc7d6e998c3c9a4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Moreover, update the Chromium SHA1 for enabling virtual keyboard support
for macOS.
Task-number: QTBUG-55766
Change-Id: Ic50ae79ab13a62a4b9289afedce2d6647e266f86
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: If16bfc6f0fbfd0040e13a8a3cbaa113fda10f387
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-51572
Change-Id: Ie8e7e5ef38f88ae91d892b703cd9702b2637daa2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently printing and pdf are bounded together. Make compilation
optional by adding it as a feature.
Fix formatting of embedded_linux.pri
Task-number: QTBUG-57731
Task-number: QTBUG-58108
Change-Id: I53a2baea656df0a5b6139365ed06385c9ebc5830
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog][Important Changes] Printing to a PDF file will now emit
signal the signal pdfPrintingFinished in both QQuickWebEngineView
and QWebEnginePage.
The boolean passed with the signal to indicate if the printing and
saving of the PDF was successful. The path of the created file is
also passed to enable the user to map the signal to a print request.
Task-number: QTBUG-56677
Change-Id: Ifab5a20b048f33a8cd872165bd4d453b01708037
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
| |
If a test fails it may trigger an assert in debug mode because
the delete wasn't performed. Move QWebEngine* objects to the stack
or use QScopedPointers to avoid these assertion fails.
Change-Id: Ic44c3fddc7cd9cf57a0e2d1c57e0a6fd99033e02
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|