| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Expand many more timeouts as loading basic test cases can now take
many seconds.
Task-number: QTBUG-79290
Change-Id: I749fe50525919b24a4a3fcba905745b6d6648121
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all warnings save for -Wdeprecated-declarations in tests.
Warnings from GCC 9.2.0:
src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23:
warning: variable 'resource_root_relative_path' set but not used
[-Wunused-but-set-variable]
src/core/chromium_overrides.cpp:121:21:
warning: moving a local object in a return statement prevents copy elision
[-Wpessimizing-move]
src/core/render_widget_host_view_qt.cpp:540:12:
warning: enumeration value 'kNull' not handled in switch [-Wswitch]
warning: enumeration value 'kMiddlePanningVertical' not handled in switch
[-Wswitch]
warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch
[-Wswitch]
warning: enumeration value 'kDndNone' not handled in switch [-Wswitch]
warning: enumeration value 'kDndMove' not handled in switch [-Wswitch]
warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch]
warning: enumeration value 'kDndLink' not handled in switch [-Wswitch]
warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch]
src/core/type_conversion.cpp:57:12:
warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch
[-Wswitch]
src/core/api/qtbug-60565.cpp:83:6:
warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)'
alias between functions of incompatible types 'void(void*, const
std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:79:6:
warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias
between functions of incompatible types 'void(void*, const std::nothrow_t&)
noexcept' and 'void(void*)' [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:75:6:
warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)'
alias between functions of incompatible types 'void(size_t, const
std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const
std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned
int)'} [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:71:6:
warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias
between functions of incompatible types 'void(size_t, const std::nothrow_t&)
noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'}
and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=]
Warnings from Clang 9.0.1:
src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29:
warning: private field 'm_dispatcher' is not used [-Wunused-private-field]
src/core/web_event_factory.cpp:1296:5:
warning: unannotated fall-through between switch labels
[-Wimplicit-fallthrough]
src/core/compositor/compositor_resource_fence.h:55:81:
warning: extra ';' after member function definition [-Wextra-semi]
src/core/renderer/render_frame_observer_qt.h:81:10:
warning: 'ReadyToCommitNavigation' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27:
warning: private field 'guest_' is not used [-Wunused-private-field]
src/core/chromium_overrides.cpp:121:12:
warning: moving a local object in a return statement prevents copy elision
[-Wpessimizing-move]
src/core/chromium_overrides.cpp:145:64:
warning: missing field 'set_up_command_line' initializer
[-Wmissing-field-initializers]
src/core/chromium_overrides.cpp:146:55:
warning: missing field 'set_up_command_line' initializer
[-Wmissing-field-initializers]
src/core/render_widget_host_view_qt.cpp:540:13:
warning: 7 enumeration values not handled in switch: 'kNull',
'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch]
src/core/compositor/stream_video_node.cpp:50:18:
warning: 'updateState' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
src/core/compositor/stream_video_node.cpp:103:18:
warning: 'initialize' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
src/core/type_conversion.cpp:57:13:
warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in
switch [-Wswitch]
src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60:
warning: extra ';' outside of a function is incompatible with C++98
[-Wc++98-compat-extra-semi]
tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10:
warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62:
warning: lambda capture 'item' is not used [-Wunused-lambda-capture]
tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55:
warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
Bumb up timeouts to even more higher levels to accommodate even
slower CI instances.
Task-number: QTBUG-79290
Change-Id: I33a4660165f72837273c3089092687a8962c83ba
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Being flaky
Change-Id: Ic9286b66296e58ce16dde63443c7e83e54c56682
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
config.tests/glibc/glibc.cpp
src/3rdparty
src/core/configure.json
src/core/profile_io_data_qt.cpp
src/webengine/configure.json
src/webenginewidgets/api/qwebenginepage.cpp
tests/auto/widgets/qwebenginepage/BLACKLIST
Change-Id: I3e1781048c3cb09bfbf7427dfc5dd1fec11a2b97
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Calling
view.show();
view.load(...);
view.hide();
results in a WebContents in visible state because the first call to show() is
delayed via a timer and never canceled so it takes effect after the hide().
Also, the page's visibility state is not updated when changing views, so that a
visible QWebEngineView can be set to display a hidden QWebEnginePage.
Fixes: QTBUG-77209
Change-Id: I0243c659f4039a35c36e04ea55c5972666170fd0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Replaced the following deprecated APIs:
QWebEngineProfile::setRequestInterceptor -> QWebEngineProfile::setUrlRequestInterceptor
QWebEngineSettings::globalSettings -> WebEngineSettings::defaultSettings
QLayout::setMargin -> QLayout::setContentsMargins
QWheelEvent::{x, y} -> QWheelEvent::position
QWheelEvent::{globalX, globalY} -> QWheelEvent::globalPosition
QSysInfo::windowsVersion -> QOperatingSystemVersion::current
Qt::InputMethodQuery::ImMicroFocus -> Qt::InputMethodQuery::ImCursorRectangle
QDesktopWidget::screenGeometry -> QGuiApplication::primaryScreen::geometry
QTime -> QElapsedTimer
- Fixed the tests to compile when deprecated APIs are disabled.
- Replaced the doc references to deprecated APIs with the new ones.
Made the docs for deprecated APIs compile conditionally, based on
deprecation version.
Task-number: QTBUG-76491
Change-Id: I5c6b7c628957deb9163f0bd2b6bc31bde1c7daec
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/core/core_chromium.pri
tests/auto/quick/qmltests/BLACKLIST
tests/auto/quick/qquickwebengineview/BLACKLIST
tests/auto/widgets/qwebenginepage/BLACKLIST
tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
tests/auto/widgets/qwebengineview/BLACKLIST
Change-Id: I11b26f5eebde29c4c62247b90e11e3ae40789fe4
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After change 5a6a8509a9 selectionChanged emitted asynchronously. That
means it's not right to assume this signal be emitted after receiving
and processing InputMethodQueries for QPlatformInputContext.
Change-Id: Ibe06bdbb5d39f7805f938740e3925a8e47b95e40
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.qmake.conf
tests/auto/quick/qmltests/BLACKLIST
tests/auto/quick/qquickwebengineview/BLACKLIST
Change-Id: I29b68dec8692d0369a2dda56350ee62d3ad73e08
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove from the blacklist some tests which, according to Grafana, have had no
failures in the last 90 days on 5.12 branch.
Change-Id: I3f174c82b5644d74b70fffa3856ae79f8c9893f8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The TestInputContext object should be destroyed before the
QWebEngineView.
Otherwise when the view gets destroyed, Chromium's TextInputManager
unregisters itself, which generates an input context event sent
to the partially destroyed view, which tries to access an already
unregistered Chromium TextInputManager.
Change-Id: I54efc5481d343cd5351908623eb643014e78549e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Flaky on Windows and macOS
Change-Id: I8742765a89f9cb0a760ab797b8ca5f2ba0e4a951
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Icdefa05eec39c632328dfc40862e5b734170bf3f
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These tests have not failed on the removed platforms for at least 60 days
Task-number: QTBUG-76608
Change-Id: I4f6cec6ff5e7408542085fd7ae8cecbe04b6fd28
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
|\| |
| | |
| | |
| | | |
Change-Id: Ib61d4087aa999ae93240be620496e60f4fa73f63
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I82726c9286e1cc7b2904887a5c0b05df4c669233
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Has failed twice in a row now.
Change-Id: I9433ec9a3b2f1720efbaf7a34fcaa563525126e5
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
[ChangeLog][QtWebEngine][WebEngineView] WebEngineView now supports lifecycle
states that can be used for reducing CPU and memory consumption of invisible
views.
[ChangeLog][QtWebEngineWidgets][QWebEnginePage] QWebEnginePage now supports
lifecycle states that can be used for reducing CPU and memory consumption of
invisible pages.
Fixes: QTBUG-74166
Fixes: QTBUG-55079
Change-Id: I7d70c85dc995bd17c9fe91385a8e2750dbc0a627
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|\ \ \
| |/ /
|/| /
| |/
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/core/profile_adapter.cpp
src/core/profile_adapter.h
src/webengine/api/qquickwebengineprofile.cpp
src/webenginewidgets/api/qwebengineprofile.cpp
tests/auto/widgets/qwebengineprofile/tst_qwebengineprofile.cpp
Change-Id: Ic561f22b361e32a0a63668c73bf6c0fc9c1ce16f
|
| |
| |
| |
| |
| |
| |
| |
| | |
Pass the ownership on to the the new view, so it is still handled like
an implicit page.
Change-Id: I76ad3cb349a492e60e3ad2bdd4aebaabed07bd4f
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I051052a70a6e764202a90d77fc1a0f73688d3704
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also fix QWebEnginePage::setView not deleting old page
Also fix wrong page being deleted if it's parented to the view.
Fixes: QTBUG-75131
Fixes: QTBUG-75175
Change-Id: Ie4dfb15b3182de7aa3a94cddcac54ea40a86121b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I8806a3fb466006f14cf92f17510cdea8b50e8345
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I0822fb8a10945a252cfd1aacaf0b6d9902cc8831
|
| |\
| | |
| | |
| | | |
Change-Id: I4315127d8a329bcb65e6853d4f3625b6dbc55560
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
For QQuickWidget::show does not work correctly
if widget was not hidden.
Fixes: QTBUG-72299
Change-Id: I12fba8c18cbf3f847d30de8b057a50e6d9917fde
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
With enabled error page isolation it is not possible to change language
of error messages among views because error pages would be rendered in
the same dedicated process.
The error page isolation is enabled since Chromium 71:
https://chromium-review.googlesource.com/1115203
Change-Id: Icc100531596dc8fc1caa927d401f923f1151aa02
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ib650113b05dfd4771240804f94e33c07aa317bf2
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.qmake.conf
src/core/net/network_delegate_qt.cpp
src/core/profile_io_data_qt.cpp
src/core/web_engine_context.h
tests/auto/core/qwebengineurlrequestinterceptor/tst_qwebengineurlrequestinterceptor.cpp
Change-Id: Id98e3f52f548ceb5b68abd80aedd6ae59db72cc0
|
| |/
| |
| |
| |
| |
| |
| | |
Like the quick version, this also can't be const, as they are assigned.
Change-Id: Icdbf3d62b9da1e824da719c96f3be480cc748005
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|/
|
|
|
|
|
|
|
| |
This patch updates the tests to use QRegularExpression in place of
QRegExp which is to be considered deprecated.
Fixes: QTBUG-72596
Change-Id: Idebd9595b60d653974aa6ac49a75e2f90fea184f
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium implements its own ones and we don't want to conflict with them.
This disables the QtVirtualKeyboard's selection handle what is not
functional with QtWebEngine.
Task-number: QTBUG-59999
Change-Id: I6a615a04d5eac1ce2d0392d63ba0fc9039583914
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This is a workaround to avoid issues with QtVirtualKeyboard when used
with QtWebEngine.
Task-number: QTBUG-70158
Task-number: QTBUG-71995
Change-Id: I1e6fcd4dceb131dbe781dd7ab3856cb154ac6a18
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do the update after the input properties are changed in
RenderWidgetHostViewQt. Moreover, always update on input
state changes, like cursor position, surrounding text and
text selection (see QInputMethod::update() docs).
Task-number: QTBUG-70158
Task-number: QTBUG-71995
Change-Id: I9d5c6e299826fbe66f5285b648013ef79aabed9b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I64a39975788cc40c5e0595c1a0c5db9000889bfd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: Ib8b19335148ff71fa8817ce3d9a5d2af2fb9916e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
We were lacking the mojo_bindings.js resource.
Change-Id: I7afa4dc101fb9dfd7e28e17ccb7f3edef0a5566b
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
QWebEngineView now also emits url, title, icon and selection
changes on setPage in the save way when url changes. Before,
those updates were only forwarded from current page.
Fixes: QTBUG-69300
Change-Id: If827205094423bc00064a123ddb143b6002d2e7c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Needed by chrome://accessibility
Updates chromium to related change:
224fc0748a Do not assert on --disable-gpu
0ba5e6626a FIXUP: Add ifdefs to exclude ATL and accessibility from the build
Change-Id: Ida0b03048ab6aa04686251d16ccfbf4855a37690
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
| |
Change-Id: Ifeaf0ee13213dc5a24d2f2b4655cf7f405cddef7
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/core/core_common.pri
Change-Id: I36dc3a70aa653e6c8a610c787b615034180a6127
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Somehow it's the case that QtTest 5.9 doesn't know how to QCOMPARE a QString
with a normal string literal:
ld: error: undefined symbol: bool QTest::qCompare<QString, char [31]>(QString
const&, char const (&) [31], char const*, char const*, char const*, int)
Change-Id: I13ce50689d9f1c157378b862fb1ed4a572ac7f79
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also fixes potential double delete if you do delete a view's implied
page.
Change-Id: Ib74128c0801f992694f4a5d8c148974039a6c7b2
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Zakor Tamas <ztamas@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Usually this field should be computed from the native scan code, but sometimes
we do not have a native scan code (in tests, for example). Add a fallback case
to compute this field from windows_key_code, with test.
Task-number: QTBUG-69442
Change-Id: I046094032576f4215cc8b3a6ced699a86ea148a9
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
.qmake.conf
configure.json
examples/webenginewidgets/markdowneditor/resources/3rdparty/marked.js
examples/webenginewidgets/markdowneditor/resources/3rdparty/qt_attribution.json
examples/webenginewidgets/markdowneditor/resources/markdowneditor.qrc
mkspecs/features/platform.prf
src/3rdparty
src/core/media_capture_devices_dispatcher.cpp
src/core/net/url_request_context_getter_qt.cpp
src/core/net/url_request_context_getter_qt.h
src/core/web_contents_adapter.cpp
Change-Id: I467133ba455b1f85f6bb61793794c31cb1094541
|
| |
| |
| |
| |
| |
| |
| | |
Fix classic race in using QSignalSpy::wait
Change-Id: If922609825c8652f326c2e252f64cc407e06ad9c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-69360
Change-Id: Ia17ce79a8221aa339c72763a984bf1958935ef96
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
We keep getting progress 100 without any in between on some CIs
Change-Id: Iaa3a9911b97ab5b5f642ee32668b9e081cd0fe51
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Set focus on navigation if testing IME composition in an input field.
Otherwise, RenderWidget::ShouldHandleImeEvents() may ignore the event.
Related fails occurred after 67-based update on macOS.
Change-Id: I9e048a52dcc14a4bd99fe00c4a42cd3f8330c8f4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|