summaryrefslogtreecommitdiffstats
path: root/tests/auto/widgets/spellchecking
Commit message (Collapse)AuthorAgeFilesLines
* Merge remote-tracking branch 'origin/5.13' into devAllan Sandfeld Jensen2019-07-241-8/+35
|\ | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/3rdparty src/core/core_chromium.pri tests/auto/quick/qmltests/BLACKLIST tests/auto/quick/qquickwebengineview/BLACKLIST tests/auto/widgets/qwebenginepage/BLACKLIST tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp tests/auto/widgets/qwebengineview/BLACKLIST Change-Id: I11b26f5eebde29c4c62247b90e11e3ae40789fe4
| * Fix spellcheck test flaky failure with misspelled word missingKirill Burtsev2019-07-121-8/+35
| | | | | | | | | | | | | | | | | | Work is done asynchronously by chromium SpellChecker object. Therefore there is no guarantee that on ShowContextMenu event for WebContents there will be a result with misspelled word. Change-Id: I2978ed99e4c14f0a7d9086853c5218f82ea1ab60 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Ignore persisted spellchecking preferencesJüri Valdmann2019-07-151-35/+48
|/ | | | | | | | | | | | | | | | | | | | | | Ignore on-disk values of spellCheckEnabled and spellCheckLanguages prefs to preserve backwards compatibility. Fixes deterministic failure in second run of tst_spellchecking because the first run disabled spellchecking. Put all settings-related tests in tst_spellchecking into one test and pretend to check that settings are not persisted. Since settings are currently read and written on independent task sequences without guaranteed ordering, the test would succeed even if settings were persisted. Specifically, in code like this profile = new QWebEngineProfile("MyProf"); // 1 delete profile; // 2 profile = new QWebEngineProfile("MyProf"); // 3 the write from line 2 will usually happen after the read from line 3. Once persistence becomes a public feature we probably should add some way to guarantee the proper ordering of reads and writes. Change-Id: Icb2290417049848dbe68b7f991bbe2d52756f295 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Clean-up of test namesAllan Sandfeld Jensen2018-07-238-0/+309
We want to only use the qwebengine-prefix for tests of actual classes. Change-Id: I0ab4e17f3b4994cc67e836112965307236d61549 Reviewed-by: Kai Koehne <kai.koehne@qt.io>