| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Task-number: QTBUG-62433
Change-Id: Icdc3355ca9d1ec4fb25d512c56c19aca94ae8928
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I8ef0b65fe365f468eeb3336e9bd2569e49257113
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: I7094e85a7770303a2ae30baccbc484c04f33600e
|
| |
| |
| |
| |
| | |
Change-Id: I5dd8c3251587c706f1fd3b90f77e4ac03c2fba97
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Pass JavaScript result via callback instead of using console.log.
Change-Id: Ie464f038d4fa778b1f64e95eca58e86e29184c1e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Tests should all be GPL-EXCEPT.
Task-number: QTBUG-60006
Change-Id: I2466374e863bd1c3cd791ade45caf1087be78cef
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fix is based on afc9e2d9674f7ab5800df4803cc68c71d1ae691a
Moreover, new quick auto test has been added to check that the commit
happens in case mouse and touch input events.
Task-number: QTBUG-62942
Change-Id: Ie9d55e0bb5b3bbc34c099502e735b94f37c5d5f8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously when a find operation was finished by calling findText(""),
the selection buffer was cleared and calling selectedText() would
return an empty string, even though on the UI side a blue rectangle
selection was still visible.
This was due to an incorrect Unselect() call in
WebContentsAdapter::stopFinding().
With the new selection change support in the parent patch, and with the
removed Unselect() call, selectedText() now properly returns the value
of the highlighted blue selection after searching is finished.
Task-number: QTBUG-60673
Task-number: QTBUG-54071
Task-number: QTBUG-53134
Change-Id: I89e0eddb0c14af6d6c06ee878e706be65d3b0831
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Do not store flags in qmake.cache with WEBENGINE_CONFIG.
Use directly qtConfig values insted. This makes configuration
more consistent, simplifies handling and avoids passing
values from qtConfig to WEBENIGNE_CONFIG, which then
were passed to gn.
[ChangeLog] Removing WEBENGINE_CONFIG from qtwebengine configure
Change-Id: I1a773fb4bff6d67ad75c237d044998051d92ab51
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Positive options are more intuitive and make for a better API.
Task-number: QTBUG-63179
Change-Id: I632ee768dba52554e7d37d9da84661a1d01f1f37
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I123ce22ea3a3d8b7b80c67fa322cb817d924f2e0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ia248991e9b623e6d19fb34b10427ebaef72b9eae
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I0860a46b981c1f711bec45d7a495bcec2a80ee1f
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Note that the Referer header still won't be sent if the download is triggered
via an anchor element with the 'download' attribute: crbug.com/455987 .
Task-number: QTBUG-61354
Change-Id: I5af971af916b2190756e3e58f19736072a213922
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I6d9261292e44484cded421402fc06ee2eb08bdea
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I8342aa806c3d1a8f4f1a5e822ef1be0e1755220c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ide3294840ceb3d18da0c4da92d892ff467a9b739
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| | |
Change-Id: I536258e22c2ec143f2fd3f1cbda229e0611b6af4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this setting was added in Qt 5.8, the behavior was that
QWebEngineView/WebEngineView got the focus automatically. With the new
setting added it is configurable, but it was left enabled for
compatibility reasons. It would had to be changed at some point anyway:
none of other QML items or widgets grab the focus after creation, so why
would QWebEngineView/WebEngineView do?
This patch also fixes a bug with the text cursor in WebView (the cursor
was blinking as if WebView had the focus when it did not).
[ChangeLog][Important Changes][QtWebEngine][General]
focusOnNavigationEnabled setting which allows controlling whether
a web view will receive focus on a navigation request is now disabled
by default.
Task-number: QTBUG-60152
Task-number: QTBUG-60149
Change-Id: I78dc9bb9ffc70bf06217952acd456b97651c5185
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This is workaround till qtqa patch is in.
Task-number: QTBUG-63005
Change-Id: I0e94304df489160f475e6b6542ca11220f52a63b
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
These will be restored once 60-based Chromium is used.
Task-number: QTBUG-62973
Change-Id: Ia1ad8e1dd7914e41f92d7a790f7c0b3956c68f28
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Qt WebEngine implements a custom handler for multiple mouse clicks.
These tests are intended to test whether the mouse click events are
properly forwarded to the Chromium's RenderWidgetHost.
Custom mouse click test functions have been also added for the custom
mouse click handler.
Change-Id: Ifdc7d09f5e0f0f76c37e137e5743482bf3fb8abb
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The deletion of CallBackSpy before web engine page destruction
could end up in segmentation fault.
Make CallbackSpy safe to be deleted before web engine page.
Change-Id: I71a184091c0251c61e3383010e3badfef5cb6124
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We now track the values we send to the loadProgress signal. We store
the last value in a new int WebContentsDelegateQt::m_lastLoadProgress
and only send values that are >= m_lastLoadProgress to ensure
monotonicity.
A value < 0 indicates that no loading is going on. Only on loadStarted
it is set to 0 (and a loadProgress is emitted with progress 0) and
on loadFinished, it is set to -1 (and a loadProgress is emitted with
progress 100).
This way, we ensure that you first get a loadStarted signal, at least
two loadProgress signals (0 and 100) and a loadFinished signal
AND all loadProgress signals come in a monotonous order.
Task-number: QTBUG-57839
Task-number: QTBUG-61815
Change-Id: I219d3bffbd5691adb892a11b79647ba9e1ed248e
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|\|
| |
| |
| |
| |
| | |
Includes sha1 bump of src/3rdparty to head of 58-based.
Change-Id: I37743c3979c1b6fb21f71eab7048e82f7aa5d78b
|
| |
| |
| |
| |
| |
| |
| |
| | |
Wait for receiver object to be set after show.
Task-number: QTBUG-61816
Change-Id: I2eb62775d30b0f8f9ec3e76d60a924b56c811865
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Unhandled key presses for printable keys were not received by the parent
widget anymore. This was a regression from 5.8.0.
The propagation is suppressed if NativeWebKeyboardEvent::skip_in_browser
is true.
Commit 4501b9d8 accidentally removed the wrong skip_in_browser
assignment.
Task-number: QTBUG-61621
Change-Id: I7eafa1fac5fb9a7edc4af2bc1aac21c106264713
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously when a default QSurfaceFormat was set with an OpenGL Core
profile, all the contexts created on the Qt side would obey the profile,
but Chromium would still use the Compatibility profile for its contexts
leading to warnings when trying to create shared contexts.
The fix is to check which OpenGL profile is used in the Qt global
shared context, and pass that information along to Chromium.
Note that this works only on macOS for now, and the default non-Core
profile is used on other platforms, even though Core was requested.
Passing CoreProfile to Chromium on Windows and Linux currently leads
to crashes.
Task-number: QTBUG-60605
Change-Id: I27a77091923624d19ccc2019953a5b07f9282916
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
[ChangeLog][Settings] Added setting to hide scrollbars.
Change-Id: I17695bb54a460621358345d303302b93eb342696
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes the case when the text selection is triggered by JavaScript.
Text selection changes triggered by IME composition text replecement are
ignored. Test has been added for mouse selection clipboard: non-user
text selection should not update the clipboard.
Pulls in Chromium changes:
3deea95 Update TextSelection for non-user initiated events
Task-number: QTBUG-53134
Task-number: QTBUG-60381
Change-Id: Ib94f57a2aa61248fba75f595245fb388b9609b6c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The tested QWebEnginePage::scrollToAnchor API can't be added to
QtWebEngine for now. Currently, Chromium Content API doesn't support to
control page scroll. The corresponding feature can be used by URL
fragment identifier (#anchor) or JavaScript API (location.href).
Change-Id: Ie9c87758d458858ba677d309a548cdced525557b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the verify(loadProgressMin <= loadProgress) fails, the output was
not verbose enough. The additional outputs will tell us more about
what caused the test to fail.
Task-number: QTBUG-61815
Change-Id: Ia9b45ef4f09a5b25a344e423a7b0c61d5d430542
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The timespans here are 5 seconds by default. These are not enough for
this test and make it fail often. We therefore increase the timespans
and un-blacklist the test.
Task-number: QTBUG-61887
Change-Id: I6acc2dee78fb4d589fd87f7557e0d48725b36f08
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Use feature permissions system instead of hard-coded dialog.
- Add QML test for getUserMedia() and extend existing widgets test.
Task-number: QTBUG-60832
Change-Id: I533bed5021b3b0ee199b8abc6ddbd516cbd14ff6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We blacklist the qmltest WebEngineViewLoadProgress::test_loadProgress
for now, because it fails often, causing trouble with integrations on the
dev branch.
Task-number: QTBUG-61815
Change-Id: Ifa74dcc0536075842af935613b5ad8ffcd56cef1
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|\ \ |
|
| |\|
| | |
| | |
| | | |
Change-Id: Idffd0c603f7925b8b9b037ce2d63cb13e964c20e
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When one searches for text on one page and then navigates away,
results for the search-term are also highlighted on the new page.
To stop this from happening, we now call adapter->stopFinding()
when we navigate away from a page.
Task-number: QTBUG-61506
Change-Id: I09e064d7788b12eae0a67c01e4f5872d94924617
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Id696dd7e56105a67b62b6d045e5af004de19ef79
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-61887
Change-Id: I06e01774687935f8751ac4b601826499d6f08531
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
In these cases two NavigationHandles are created. One for the data URL
and another one for the base URL. Suppress the loadStarted signal for
data URL one since it is expected to be informed about the base URL.
Change-Id: I1a3006cf552a26b8419bd76454e26c0e33c2e898
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: Ida702fd5fa05a32d6cd7fc737aa061da74b675a0
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-61429
Change-Id: I936f1c924ae8158a5243fdf20d12e6c5508b684a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Otherwise an application shortcut like Shift+Delete would no longer
work when webengine has focus (e.g. "delete mail" in KMail)
This removes unconditional calls to editorActionForKeyEvent for
ShortcutOverride event handling. We can remove those, because the key
sequences that are checked by editorActionForKeyEvent are a subset of
the key sequences checked by isCommonTextEditShortcut.
This amends commit 3902b27e.
Change-Id: I12a98368381edef36f11457c8b864d843efb871a
Reviewed-by: David Faure <david.faure@kdab.com>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Change some compares to tryCompares to wait for
downloadStateChanged signal before comparing downloadState.
Change-Id: If8f7f15a776e60c937f0e006d2ac337f6c1f9ad9
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
tst_loadProgressSignal.qml is a duplicate of tst_loadProgress.qml.
Move loadProgressChanged signal check to tst_loadProgress.qml
and delete tst_loadProgressSignal.qml.
Change-Id: I14821d4979def7b9f1985859384224b8f8111bd6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
tst_QWebEngineHistory has lots of race conditions similar to those
we have seen for example in tst_QWebEngineView. We now use QSignalSpy
and QTRY_COMPARE instead of SignalBarrier and ensureSignalEmitted(),
because these are more robust. We did the same for
tst_QWebEngineView.
Task-number: QTBUG-58473
Change-Id: I1d12914670aa1c08b7edf7593df8c950ad6d4b0b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-55766
Change-Id: Ic90eb7b9a211b09281ccbb3eae727e8a1c081b9a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| | |
Change-Id: I9eccddd420cd0eb8b5be3006a4091465d4b3fab0
Task-number: QTBUG-60472
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When opening a new window, for example by using the JavaScript
method window.open('...'), the requested url is not stored
in the content::WebContents object we get in
WebContentsDelegateQt::createWindow (at this point, it should
at least be stored as pending request in the WebContents'
NavigationController, but it is not).
Because of this, the QQuickWebEngineNewViewRequest object
in QQuickWebEngineViewPrivate::adoptNewWindow never contained
the url. We have access to the target url in
WebContentsDelegateQt::WebContentsCreated, so now we store
it there in a new property m_initialTargetUrl, from where
WebContentsDelegateQt::createWindow takes it and passes it
to WebContentsAdapter::adoptNewWindow as a new parameter.
[ChangeLog][WebEngine] Fix WebEngineNewViewRequest::requestedUrl being empty when opening window from JavaScript
Task-number: QTBUG-57675
Change-Id: I7e2c7866899baade17ce2517e6be8b2b2709699e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|