summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Unskip downloadUniqueFilenameWithTimestamp auto testPeter Varga2019-04-091-7/+4
| | | | | | Task-number: QTBUG-74764 Change-Id: I0e872449584b37c484e4d5ea46ba0bbc47124f51 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge branch '5.12' into 5.13Allan Sandfeld Jensen2019-04-093-1/+51
|\ | | | | | | | | | | | | | | | | | | Conflicts: src/3rdparty src/core/renderer/user_resource_controller.cpp src/core/web_contents_adapter.cpp src/webengine/doc/src/qtwebengine-overview.qdoc Change-Id: I46be9d33b3b65d61dfa099ee72a3509afb9bd6a4
| * Run non-MainWorld DocumentCreation scripts even if JS disabledJüri Valdmann2019-04-081-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes regression, introduced by the fix for QTBUG-66011, where setting JavascriptEnabled to false stops all scripts from running instead of only MainWorld scripts (as documented). Only the DocumentCreation injection point is affected. The original change which introduced the regression consisted of moving the DocumentCreation injection point from ContentRendererClient::RunScriptsAtDocumentStart to RenderFrameObserver::DidClearWindowObject. The problem of scripts not working on view-source URLs was fixed by this move, but it turns out that the call to DidClearWindowObject happens to be conditional on Document::CanExecuteScripts and this is, of course, false if JS is disabled. Hence the regression. This new patch moves the injection point again to a task launched from RenderFrameObserver::DidCommitProvisionalLoad. DidCommitProvisionalLoad and DidClearWindowObject are both indirectly called from DocumentLoader::InstallNewDocument, however the former is called before the Document is opened and is therefore too early for script execution. As such, the execution is delayed by posting a task which, in theory, should be scheduled very soon after the normal call to DidClearWindowObject. Fixes: QTBUG-74304 Change-Id: Iac8714bcc5651c287b73181811af26996d955af5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Increase timeout and add some debug info to tst_dialogMichal Klocek2019-04-042-1/+3
| | | | | | | | | | | | Task-number: QTBUG-72113 Change-Id: I9b2dfb360a18995cae9e0e4a98443e796c3d8ad0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Make tst_dialogs less flakyMichal Klocek2019-04-031-0/+1
| | | | | | | | | | | | | | | | | | Wait to finish javascript execution before opening next dialog. Task-number: QTBUG-72113 Change-Id: I383e3fc3c405a94ddcbd74fe1cc7ab0d81c4e315 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Notification API cleanupKirill Burtsev2019-04-055-19/+24
| | | | | | | | | | | | Task-number: QTBUG-74543 Change-Id: Ice5a0dbfc3485c8b7e6fa900ef427a9aed871d42 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix tst_Dialogs::authenticationDialogRequestedMichal Klocek2019-04-044-13/+21
| | | | | | | | | | | | | | | | | | | | Chromium returns unexpected proxy reply if localhost is used. Since proxy resolver works now, the workaround to trigger dialog with "localhost proxy" can be skipped. Change-Id: I26d88c43779809e4f481101266e6b8784a6b196d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Remove our last uses of Q_DECL_OVERRIDE and Q_NULLPTRAllan Sandfeld Jensen2019-04-036-12/+12
| | | | | | | | | | Change-Id: I8806a3fb466006f14cf92f17510cdea8b50e8345 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Make the skip actually compileAllan Sandfeld Jensen2019-04-021-1/+1
| | | | | | | | | | Change-Id: I348fd097db179557d04cde224f6a49f0d1c2f97d Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Skip downloadUniqueFileNameWithTimeStamp auto test on WindowsPeter Varga2019-03-281-0/+3
| | | | | | | | | | | | Task-number: QTBUG-74764 Change-Id: I2638a6857e1d29ebacaafac3fff5daab57268b54 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Blacklist tst_QWebEnginePage::runJavaScriptFromSlot on macOSAllan Sandfeld Jensen2019-03-281-0/+3
| | | | | | | | | | | | | | | | | | This is our most flaky test at the moment Task-number: QTBUG-74718 Change-Id: Ia7668347a74982abfb0297169f564db89944e87c Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Do not run offscreen test on windowsMichal Klocek2019-03-271-0/+2
| | | | | | | | | | | | | | | | Offscreen plugin tries to open opengl handle and fails. Disable test for now. Change-Id: I6cecfef4e47a700ff720811f8e8dc4829a814821 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Normalize download path on WindowsAllan Sandfeld Jensen2019-03-261-9/+0
| | | | | | | | | | | | Task-number: QTBUG-74698 Change-Id: I3fd4b932b1d4b0ecc844818f87c1824eac1f56e6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Blacklist download dir tests for windowsAllan Sandfeld Jensen2019-03-261-0/+11
| | | | | | | | | | | | | | | | | | Needs some cleanup to do comparisons FS-agnostic, and is currently blocking. Task-number: QTBUG-74698 Change-Id: Idca2753992aa8d1d63456694129325e757e572bc Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Fix disabling http cache after 73-basedPeter Varga2019-03-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BrowserDataRemoverImpl::Remove() indirectly calls TransportSecurityState::DeleteAllDynamicDataSince() which notifies by a callback about the finished deletion since: https://chromium-review.googlesource.com/c/chromium/src/+/1335939 During the deletion the ProfileIODataQt::requestStorageGeneration() should not be called because it deletes net::TransporSecurityPersister which background_runner is where the finished deletion callback is scheduled. Change-Id: I4782d701f706ed7c8e104a78ba84a27183166fa4 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Adaptations for Chromium 73Allan Sandfeld Jensen2019-03-233-5/+8
| | | | | | | | | | Change-Id: I565d1e327852110a5abebed3388d7cd6986bef06 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Adaptations for Chromium 72Allan Sandfeld Jensen2019-03-232-3/+6
| | | | | | | | | | Change-Id: Ic355257066c7c1433862cb41e6f2bfa831147e0d Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.12' into 5.13" into ↵Allan Sandfeld Jensen2019-03-203-1/+16
|\ \ | | | | | | | | | refs/staging/5.13
| * | Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-03-203-1/+16
| |\| | | | | | | | | | Change-Id: If0a4c869d801fe94df23201391c30c1efc5000e0
| | * Do not report client redirects as link-clickedAllan Sandfeld Jensen2019-03-193-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes false navigation type on http-equiv refresh, and javascript redirects. Task-number: QTBUG-74490 Change-Id: Ie6fa5c94ae9642a7e9c689198a4977747f4101ce Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Remove Entry type from QWebEngineClientCertificateStoreAllan Sandfeld Jensen2019-03-201-6/+6
|/ / | | | | | | | | | | | | | | It is now only possible to list contained certificates, which is used by the existing tests. Change-Id: I3eada816a05cff2bb9cc5d39125136e9084a1a2f Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Notification API cleanup: direction type, parameter and method namesKirill Burtsev2019-03-194-7/+14
| | | | | | | | | | Change-Id: I0349f3eea0028a4df917af8599c073227e0d0ec1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Enable core auto test on qemuMichal Klocek2019-03-151-3/+1
| | | | | | | | | | | | Task-number: QTBUG-63346 Change-Id: Id2bbb731cad5cb222f4dbaa540d4b9a9c19e2a72 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Enable running some tests on qemuMichal Klocek2019-03-142-5/+6
| | | | | | | | | | | | | | | | | | Add some tests which looks stable enough and do not require blacklisting. Task-number: QTBUG-63346 Change-Id: I071669895f6c81af498b5348ef86d81d551c899d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Fix -no-ssl buildv5.13.0-beta1Peter Varga2019-03-071-1/+3
| | | | | | | | | | Change-Id: I978f70545484060218f5243c74978c85bc603c16 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Un-blacklist tst_QWebEnginePage combobox auto testsTamas Zakor2019-03-062-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | tst_QWebEnginePage::comboBoxPopupPositionAfterMove(): Fix moving view by changing coordinates according to the old view position instead of the screen position. tst_QWebEnginePage::comboBoxPopupPositionAfterChildMove(): Fix resizing spacer widget to change position of view properly. Task-number: QTBUG-55158 Change-Id: I62ebb06ee3f9dadd80888eae05d037e7129bcd69 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add simple offscreen qpa testMichal Klocek2019-03-043-1/+68
| | | | | | | | | | | | Task-number: QTBUG-63346 Change-Id: Ie33cea29ca4e274070f3fa52aef499f02a080108 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.12' into 5.13" into ↵Allan Sandfeld Jensen2019-03-044-6/+143
|\ \ | | | | | | | | | refs/staging/5.13
| * | Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-03-044-6/+143
| |\| | | | | | | | | | Change-Id: I1dd136df7004b11e2f38a2ec4e82a6fa81627479
| | * Fix handling of touch icons when it is disabledPeter Varga2019-02-252-0/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Store the icon type in a bitfield because the same icon URL might be used for various types on same page. This way webengine won't ignore to download a default icon what is also set as a touch icon when touch icons are disabled. Moreover, do not store the icon types from the previous page because a subsequent page might use the same icon URL but with different type. With this change the type of the cached icons are updated after each page load. Fixes: QTBUG-70081 Change-Id: I8031a740b07b0c6a8e5759a994f386b13ce87be2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Remove download properly on profile destruction to avoid use after freeKirill Burtsev2019-02-191-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the Widgets API, download items are children of the profile and are destroyed when the parent profile destroys its children. The download item's destructor can therefore not access the profile, as it would cause a heap-use-after-free crashes. On quick side turn ongoing downloads cleanup to match widgets one. Fixes: QTBUG-73839 Change-Id: Iabb379e91187e3e68ebcd4693fec35883b72b1f2 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| | * Update public QML API test and enforce failure checkKirill Burtsev2019-02-191-6/+40
| | | | | | | | | | | | | | | Change-Id: Ie6dd101b15ac5bd7b6d60b61922b5db688aff785 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Update publicapi testAllan Sandfeld Jensen2019-03-041-0/+18
|/ / | | | | | | | | Change-Id: Ib210bbf873493cb8f19d99a4e4fb0cbdb3769312 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Tie client certificate stores to profilesAllan Sandfeld Jensen2019-03-011-9/+10
| | | | | | | | | | | | | | | | Move the client certificate store from being global to being tied to individual profiles. Change-Id: Ib21ae14c501b7d0612b84ae7535120291aeeada2 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Make client certificate store thread safeAllan Sandfeld Jensen2019-02-251-1/+1
| | | | | | | | | | | | | | | | If the users manipulate the API from the UI, we need to read from the UI thread as well. Change-Id: I8af787a357954cff4fbdd94bcf27b880fb6aecb4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Remove duplicate RESOURCES in QWebEngineClientCertificateStore testJüri Valdmann2019-02-221-3/+0
| | | | | | | | | | | | | | | | | | | | | | Makefile:530: warning: overriding recipe for target '.rcc/qrc_tst_qwebengineclientcertificatestore.cpp' Makefile:522: warning: ignoring old recipe for target '.rcc/qrc_tst_qwebengineclientcertificatestore.cpp' The resource file tst_qwebengineclientcertificatestore.qrc is already automatically added to RESOURCES by tests.pri, no need to add it again. Change-Id: Idfbde5da06337c5e436734c6a88651c153223bfc Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Emit QWebEnginePage::selectionChanged asynchronouslyJüri Valdmann2019-02-211-0/+23
| | | | | | | | | | | | | | | | | | | | Currently selectionChanged is emitted from a Chromium task, meaning our MessagePump is blocked and, even with a nested QEventLoop, it's not possible to for Chromium code to make any progress during the handling of this signal. Fixes: QTBUG-73876 Change-Id: I45135238cffa81fb0db74ddfd53037c7f1b94348 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Add client certificate store test casesVijith Kini2019-02-208-0/+212
| | | | | | | | | | Change-Id: Ib8fdfdd21c064f31acfcf8ce2cf840463d10c07e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add proxy authentication unit testMichal Klocek2019-02-195-1/+229
| | | | | | | | | | | | Task-number: QTBUG-58121 Change-Id: Id2f983903f2e631cc6ec0632a70ac6ec3ef3c1ce Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-02-153-4/+40
|\| | | | | | | Change-Id: I0822fb8a10945a252cfd1aacaf0b6d9902cc8831
| * tst_origins: Don't create SharedWorkers from unregistered schemeJüri Valdmann2019-02-051-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Triggers DCHECK in content::SharedWorkerInstance::Matches on CI. According to the DCHECK, SharedWorkers cannot be constructed from unique origins (worker and constructor page need to be same-origin and unique origins are never same-origin with anything). In release builds the construction will just fail as expected. The DCHECK is only triggered if at least one other active SharedWorker already exists in the same storage partition. The reason it only happens on CI might be that the previous renderer process is not torn down fast enough and the previous SharedWorker remains active. Change-Id: I0906e1b5c85587df67b768ef022386d599ce9541 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Merge remote-tracking branch 'origin/5.12.1' into 5.12Qt Forward Merge Bot2019-02-012-0/+39
| |\ | | | | | | | | | Change-Id: I4315127d8a329bcb65e6853d4f3625b6dbc55560
| | * Fix hide/show of delegate widgetMichal Klocek2019-01-091-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For QQuickWidget::show does not work correctly if widget was not hidden. Fixes: QTBUG-72299 Change-Id: I12fba8c18cbf3f847d30de8b057a50e6d9917fde Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| | * Fix recreation of cookie store and channel id serviceMichal Klocek2019-01-091-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As more things gets mojofy and become services, we can not simply delete parts of storage context. Therefore regenerate whole storage in case of cookie store, cache, agent settings updates. URLRequestContextStorage guards correct order of destruction. This change aims to fix some crashes during cookie store and http cache recreation when ChannelIDService gets deleted. Depending on timing this ends with different stacktraces like in cookie store manager or during ssl handshake. We still keep network delegate outside of storage context to prevent crashes when url requests end their life due to (forced) request cancellation in cancelAllUrlRequests(). Please note this is just band-aid patch, and introduction of 'profile builder' will be a proper fix. Fixes: QTBUG-71895 Change-Id: If33a7af3ebba2632ea33f32d913e1c21a4534817 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix incrementing download IDTamas Zakor2019-02-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | Adapt DownloadManagerDelegateQt::m_currentId to https://chromium-review.googlesource.com/1144311 Change-Id: I74d0165b096d5d02261290a7f84fda420a2b146c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Web Notifications APIKirill Burtsev2019-02-069-13/+332
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implements API for end-user notifications. Co-authored by Allan Sandfeld Jensen [ChangeLog][Profile] Support for Web Notifications API for end-user notifications through QWebEngineNotification Task-number: QTBUG-50995 Fixes: QTBUG-51191 Change-Id: Icebaaa05275a713e801f1f8ecdaaec725fa264c8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Move QWebEngineUrlRequestInterceptor::intercept to ui threadMichal Klocek2019-02-041-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently interceptor sufferers thread safety issues, when custom profiles are deleted, interceptor is set to be nullptr, however it can be still referenced in IO thread. Since profile was split to ui and io part, where io part can outlive the ui part, this can boost thread safety issues. Since QWebEngineUrlRequestInterceptor is living on ui thread simplify the logic move intercept call to ui thread. This fixes the issue of referencing interceptor in io thread. Add new method to install interceptor setUrlRequestInterceptor, and deprecate old one. Update interceptor install method name on page to match the profile one. Task-number: QTBUG-69844 Change-Id: I5dd2b6b734fd91906cccc6c1408ffbe7b1b4250c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add proxy switches handlingMichal Klocek2019-02-042-25/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds switches for proxy: https://www.chromium.org/developers/design-documents/network-settings [ChangeLog] Uses proxy switches for initial proxy configuration Fixes: QTBUG-71229 Change-Id: I1bc02f20c20d737234c650a18f0e0f7c1c63a464 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Disable error page isolationPeter Varga2019-02-043-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With enabled error page isolation it is not possible to change language of error messages among views because error pages would be rendered in the same dedicated process. The error page isolation is enabled since Chromium 71: https://chromium-review.googlesource.com/1115203 Change-Id: Icc100531596dc8fc1caa927d401f923f1151aa02 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Merge remote-tracking branch 'origin/5.12' into 5.13Allan Sandfeld Jensen2019-02-011-0/+33
|\| | | | | | | | | | | Change-Id: I2889e49fe9f71bfc996689feb0f350e09569f611