summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Reset findText reply id on StopFinding to prevent callback laterKirill Burtsev2019-07-161-0/+4
| | | | | | | | | Not updating lastReceivedFindReply caused next findText call after StopFinding to trigger redundant callback call on checking stale query. Fixes: QTBUG-77029 Change-Id: Iad4b71364ecb3ec3db3096b739e77620d12731f9 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Remove qt.io load from findTextInterruptedByLoad and ensure checksKirill Burtsev2019-07-161-5/+13
| | | | | | | | | | | | Load of real website is not really needed, simple html is enough to verify that on load no findText callback is executed from previous query. Ensure callback is not called with timeout and additional check inside it to verify that it's not called twise. Task-number: QTBUG-75541 Change-Id: Iebf207e40d8f4d4f680b46bb0f32480edd72f36d Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix quick dialog test wrong message on view's LoadStatus changedKirill Burtsev2019-07-121-4/+5
| | | | | Change-Id: Ic8eb671409794799bcdad4760dc58e84de3b109f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix spellcheck test flaky failure with misspelled word missingKirill Burtsev2019-07-121-8/+35
| | | | | | | | | Work is done asynchronously by chromium SpellChecker object. Therefore there is no guarantee that on ShowContextMenu event for WebContents there will be a result with misspelled word. Change-Id: I2978ed99e4c14f0a7d9086853c5218f82ea1ab60 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Wait for SelectAll to be enabled in tst_QWebEnginePage::findTextJüri Valdmann2019-07-091-0/+1
| | | | | | | | Fixes flaky m_view->hasSelection() assertion. Change-Id: Idba17916c38ac76b8002e30bab08d7f9e1064b2a Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Un-blacklist some passing testsJüri Valdmann2019-07-084-26/+0
| | | | | | | | Remove from the blacklist some tests which, according to Grafana, have had no failures in the last 90 days on 5.12 branch. Change-Id: I3f174c82b5644d74b70fffa3856ae79f8c9893f8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Bump timeout in tst_InspectorServer::openRemoteDebuggingSessionJüri Valdmann2019-07-041-1/+1
| | | | | | | Flaky on Windows 10. Change-Id: Idaf73ccaf29831010e84397ae722dbe54a2de9bb Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Set custom user-agent manually on new windowsAllan Sandfeld Jensen2019-06-071-0/+65
| | | | | | | | | | | | Chromium forgets to set ShouldOverrideUserAgentInNewTabs(), so we need to manually set the override. Fixes: QTBUG-76249 Change-Id: Id240ee525dacec3cd8389aca058a61d3af62b00a Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Disable edit actions when content has no focused framePeter Varga2019-05-272-2/+147
| | | | | | | | | Task-number: QTBUG-75505 Change-Id: Ia1329ff554a86e307aa7995e9af1665ea6c5e64c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add path validation for QWebEngineDownloadItem::setPath()Tamas Zakor2019-05-201-0/+123
| | | | | | | | | | | Do not set path if it ends with separator or if it matches with an already existing directory name. Task-number: QTBUG-75566 Change-Id: I4b78b28afe034c7589633c569a4945a36b32008e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Referrer HTTP Header no longer ignored when set via RequestInterceptorLeander Beernaert2019-05-202-0/+44
| | | | | | | | | | | Make sure the HTTP referer is properly placed on a request when it's set via the QWebEngineUrlRequestInterceptor. Added test case to catch future incidents. Fixes: QTBUG-60203 Change-Id: Ida2f713a7352c3199fc9f8e15b5d8350d50afdda Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update docs and test for runJavaScriptJüri Valdmann2019-05-091-0/+12
| | | | | | | Fixes: QTBUG-69567 Change-Id: Icdf5a200f7be1eb7a98cce62848e3a641c49e804 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Q(Quick)WebEngineProfile: Update list of internal schemesJüri Valdmann2019-05-071-0/+41
| | | | | | | | | | | Disallow installing handler for "about" and everything in kStandardURLSchemes of url/url_util.cc. Except for "gopher" which is used in tests. Suppress warning about custom schemes for "gopher" since it's not a custom scheme. Also lowercase the scheme in urlSchemeHandler() and removeUrlSchemeHandler(). Change-Id: I72b06d4fa6433882019405a0d600a593c8971bf1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Do not crash on QWebEnginePagePrivate::releaseProfile()Allan Sandfeld Jensen2019-05-031-0/+19
| | | | | | | | | Deregistering the widget or deleting the view should be able to handle a now missing d_ptr in the old page. Change-Id: Ic843f7bde12776b6aad4fad865ccf14a25695154 Fixes: QTBUG-75547 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Silence warnings in tst_qwebengineprofileAllan Sandfeld Jensen2019-04-301-0/+20
| | | | | | | Register custom schemes Change-Id: I536a27da8f936e4ea6569e39a8ec6e30e23af03a Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Handle corner case of assigning an implicit page to a new viewAllan Sandfeld Jensen2019-04-301-0/+15
| | | | | | | | Pass the ownership on to the the new view, so it is still handled like an implicit page. Change-Id: I76ad3cb349a492e60e3ad2bdd4aebaabed07bd4f Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Profile test: fix buffer for request job being deleted on main threadKirill Burtsev2019-04-231-2/+1
| | | | | Change-Id: I894946ce7c9dcf4f787c5c928e3737cd80a7dc52 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix QWebEngineView::setPage not deleting old pageJüri Valdmann2019-04-171-0/+46
| | | | | | | | | | | Also fix QWebEnginePage::setView not deleting old page Also fix wrong page being deleted if it's parented to the view. Fixes: QTBUG-75131 Fixes: QTBUG-75175 Change-Id: Ie4dfb15b3182de7aa3a94cddcac54ea40a86121b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix resolving relative URLs with custom schemesJüri Valdmann2019-04-161-0/+49
| | | | | | | | Pull in 3rdparty patch and add test. Fixes: QTBUG-74864 Change-Id: I5440f58ff55297c2a51f896d43f479404ff6ca2f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Profile test: fix waiting for load finished signalKirill Burtsev2019-04-111-1/+2
| | | | | Change-Id: I797b596b73d62e420592ef9e96601c35ea7ecad6 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Run non-MainWorld DocumentCreation scripts even if JS disabledJüri Valdmann2019-04-081-0/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes regression, introduced by the fix for QTBUG-66011, where setting JavascriptEnabled to false stops all scripts from running instead of only MainWorld scripts (as documented). Only the DocumentCreation injection point is affected. The original change which introduced the regression consisted of moving the DocumentCreation injection point from ContentRendererClient::RunScriptsAtDocumentStart to RenderFrameObserver::DidClearWindowObject. The problem of scripts not working on view-source URLs was fixed by this move, but it turns out that the call to DidClearWindowObject happens to be conditional on Document::CanExecuteScripts and this is, of course, false if JS is disabled. Hence the regression. This new patch moves the injection point again to a task launched from RenderFrameObserver::DidCommitProvisionalLoad. DidCommitProvisionalLoad and DidClearWindowObject are both indirectly called from DocumentLoader::InstallNewDocument, however the former is called before the Document is opened and is therefore too early for script execution. As such, the execution is delayed by posting a task which, in theory, should be scheduled very soon after the normal call to DidClearWindowObject. Fixes: QTBUG-74304 Change-Id: Iac8714bcc5651c287b73181811af26996d955af5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Increase timeout and add some debug info to tst_dialogMichal Klocek2019-04-042-1/+3
| | | | | | Task-number: QTBUG-72113 Change-Id: I9b2dfb360a18995cae9e0e4a98443e796c3d8ad0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make tst_dialogs less flakyMichal Klocek2019-04-031-0/+1
| | | | | | | | | Wait to finish javascript execution before opening next dialog. Task-number: QTBUG-72113 Change-Id: I383e3fc3c405a94ddcbd74fe1cc7ab0d81c4e315 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Do not report client redirects as link-clickedAllan Sandfeld Jensen2019-03-193-1/+16
| | | | | | | | | Fixes false navigation type on http-equiv refresh, and javascript redirects. Task-number: QTBUG-74490 Change-Id: Ie6fa5c94ae9642a7e9c689198a4977747f4101ce Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix handling of touch icons when it is disabledPeter Varga2019-02-252-0/+71
| | | | | | | | | | | | | | | | Store the icon type in a bitfield because the same icon URL might be used for various types on same page. This way webengine won't ignore to download a default icon what is also set as a touch icon when touch icons are disabled. Moreover, do not store the icon types from the previous page because a subsequent page might use the same icon URL but with different type. With this change the type of the cached icons are updated after each page load. Fixes: QTBUG-70081 Change-Id: I8031a740b07b0c6a8e5759a994f386b13ce87be2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove download properly on profile destruction to avoid use after freeKirill Burtsev2019-02-191-0/+32
| | | | | | | | | | | | | In the Widgets API, download items are children of the profile and are destroyed when the parent profile destroys its children. The download item's destructor can therefore not access the profile, as it would cause a heap-use-after-free crashes. On quick side turn ongoing downloads cleanup to match widgets one. Fixes: QTBUG-73839 Change-Id: Iabb379e91187e3e68ebcd4693fec35883b72b1f2 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Update public QML API test and enforce failure checkKirill Burtsev2019-02-191-6/+40
| | | | | Change-Id: Ie6dd101b15ac5bd7b6d60b61922b5db688aff785 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* tst_origins: Don't create SharedWorkers from unregistered schemeJüri Valdmann2019-02-051-4/+1
| | | | | | | | | | | | | | | Triggers DCHECK in content::SharedWorkerInstance::Matches on CI. According to the DCHECK, SharedWorkers cannot be constructed from unique origins (worker and constructor page need to be same-origin and unique origins are never same-origin with anything). In release builds the construction will just fail as expected. The DCHECK is only triggered if at least one other active SharedWorker already exists in the same storage partition. The reason it only happens on CI might be that the previous renderer process is not torn down fast enough and the previous SharedWorker remains active. Change-Id: I0906e1b5c85587df67b768ef022386d599ce9541 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.12.1' into 5.12Qt Forward Merge Bot2019-02-012-0/+39
|\ | | | | | | Change-Id: I4315127d8a329bcb65e6853d4f3625b6dbc55560
| * Fix hide/show of delegate widgetMichal Klocek2019-01-091-0/+23
| | | | | | | | | | | | | | | | | | | | For QQuickWidget::show does not work correctly if widget was not hidden. Fixes: QTBUG-72299 Change-Id: I12fba8c18cbf3f847d30de8b057a50e6d9917fde Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| * Fix recreation of cookie store and channel id serviceMichal Klocek2019-01-091-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As more things gets mojofy and become services, we can not simply delete parts of storage context. Therefore regenerate whole storage in case of cookie store, cache, agent settings updates. URLRequestContextStorage guards correct order of destruction. This change aims to fix some crashes during cookie store and http cache recreation when ChannelIDService gets deleted. Depending on timing this ends with different stacktraces like in cookie store manager or during ssl handshake. We still keep network delegate outside of storage context to prevent crashes when url requests end their life due to (forced) request cancellation in cancelAllUrlRequests(). Please note this is just band-aid patch, and introduction of 'profile builder' will be a proper fix. Fixes: QTBUG-71895 Change-Id: If33a7af3ebba2632ea33f32d913e1c21a4534817 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Answer permission checks for clipboard permissionsSzabolcs David2019-01-301-0/+33
| | | | | | | | | | | | | | | | Wire page settings into clipboard permissions and add some auto test. Task-number: QTBUG-72714 Change-Id: If921c65cdff7f55a48340d90fc593071febc6ebe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Remove download items internally when API objects are deletedAllan Sandfeld Jensen2019-01-213-6/+49
| | | | | | | | | | | | | | | | | | | | We were never removing internal download item. [ChangeLog][Behavioral Changes] Deleting a download item will now also cancel it if it is still in progress. Change-Id: I2fab497d7acf7ca6ca17f4a61e106b1c18bfb333 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Fix building testsAllan Sandfeld Jensen2019-01-161-2/+2
| | | | | | | | | | | | | | Like the quick version, this also can't be const, as they are assigned. Change-Id: Icdbf3d62b9da1e824da719c96f3be480cc748005 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Fix tst_QWebEnginePage::dynamicFrameAllan Sandfeld Jensen2019-01-091-1/+2
|/ | | | | | | | Any error pages would overwrite the content of the iframe. Fixes: QTBUG-72883 Change-Id: I5f9e6a4c5af74e8ee1e1b6044b5a5f58d2bedbf1 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix building with clangAllan Sandfeld Jensen2019-01-041-2/+2
| | | | | | | | We are doing an assign later, so the properties can't be const, or the default assign operator is automatically deleted. Change-Id: I4ddb46cbde9098ad5c3aa72687c3107da9485a96 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix QWebEngineUrlRequestInfo::firstPartyUrl() after 69-basedTamas Zakor2019-01-0318-18/+323
| | | | | | | | | | | | | | The issue was introduced by this Chromium change: https://chromium-review.googlesource.com/c/chromium/src/+/1025772/ Add new auto tests for first party url. Depends on Chromium change: d2f5d6869f Add net::URLRequest::first_party_url() Task-number: QTBUG-70790 Change-Id: Ib43bde69990e7fb1d495cc32ac2f6860a613f185 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Disable external text handles and edit menuPeter Varga2018-12-082-2/+2
| | | | | | | | | | | Chromium implements its own ones and we don't want to conflict with them. This disables the QtVirtualKeyboard's selection handle what is not functional with QtWebEngine. Task-number: QTBUG-59999 Change-Id: I6a615a04d5eac1ce2d0392d63ba0fc9039583914 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Disable text prediction for inputPeter Varga2018-12-072-2/+2
| | | | | | | | | | This is a workaround to avoid issues with QtVirtualKeyboard when used with QtWebEngine. Task-number: QTBUG-70158 Task-number: QTBUG-71995 Change-Id: I1e6fcd4dceb131dbe781dd7ab3856cb154ac6a18 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Blacklist failing tst_QQuickWebEngineView tests in openSUSE 15.0Tony Sarajärvi2018-12-042-4/+5
| | | | | | | | This time we blacklist in the right directory Task-number: QTBUG-71461 Change-Id: If60b128f485b6d1810d759c44275555a5a422525 Reviewed-by: Liang Qi <liang.qi@qt.io>
* Fix input method updatePeter Varga2018-11-292-0/+373
| | | | | | | | | | | | Do the update after the input properties are changed in RenderWidgetHostViewQt. Moreover, always update on input state changes, like cursor position, surrounding text and text selection (see QInputMethod::update() docs). Task-number: QTBUG-70158 Task-number: QTBUG-71995 Change-Id: I9d5c6e299826fbe66f5285b648013ef79aabed9b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix IME with negative start positionPeter Varga2018-11-221-0/+42
| | | | | Change-Id: I64a39975788cc40c5e0595c1a0c5db9000889bfd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Test-case for closing opener tabAllan Sandfeld Jensen2018-11-161-0/+37
| | | | | Change-Id: Ib8b19335148ff71fa8817ce3d9a5d2af2fb9916e Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix typos in html testsTamas Zakor2018-11-145-5/+8
| | | | | Change-Id: I578595a1efa5e9a560b98e7a0a138621fdd04245 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix building tst_printing against libc++Jüri Valdmann2018-11-071-2/+2
| | | | | | | Linking fails if system poppler-cpp is built against libstdc++. Change-Id: I5c46cb56770abe3ed6c2bfa461ee08d32f476f16 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Blacklist failing tst_QQuickWebEngineView tests in openSUSE 15.0Tony Sarajärvi2018-10-291-0/+4
| | | | | | Task-number: QTBUG-71461 Change-Id: I837cf81c1685ad210a17a8d548c4f6e439e181d6 Reviewed-by: Liang Qi <liang.qi@qt.io>
* Test world-ids over 11Allan Sandfeld Jensen2018-10-231-3/+14
| | | | | | | Add a test that we can have larger world ids. Change-Id: Ibc8a0eb5e6f56aa41183adb3726b2c3141197c84 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Merge remote-tracking branch 'origin/5.11' into 5.12Allan Sandfeld Jensen2018-10-226-0/+257
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: configure.json src/3rdparty src/core/content_browser_client_qt.cpp src/core/content_browser_client_qt.h src/core/login_delegate_qt.cpp src/core/login_delegate_qt.h src/core/net/url_request_context_getter_qt.cpp src/core/net/url_request_context_getter_qt.h src/core/qtwebengine.gni 3rdparty changes: 616a7f558c7e This is expected for us, so don't report it as an error. c30febceaa1b Do not write <protocol>.json to source directory 9e68e4f2d92c Remove incomplete logic to detect AMD K2 CPU's e0ed41c8e90a FIXUP: This is expected for us, so don't report it as an error. f9fd9109b4b7 Fix --single-process --disable-gpu combination not to hit asserts f305d65cc27e Reduce severity level of messages when kDisableGpu switch is used 5e3e5074bb78 Work around MSVC2017 optimizer bug when printing a page usind Pdfium 34f52ec3bae8 Bump maximum number of custom isolated world ids f7a2f8153c82 Fix hunspell::NodeReader::affix_id_for_leaf bounds check 1e80090f7044 Fix resolve_proxy service permissions 2e498629651d Add proxy_resolver_manifest Change-Id: I2b176c80aa315a0ae0a22b5707694fdcd407407b
| * Adds proxy pac testMichal Klocek2018-10-186-0/+257
| | | | | | | | | | | | | | | | Task-number: QTBUG-71128 Task-number: QTBUG-69281 Task-number: QTBUG-71229 Change-Id: If6b839ce12efb3ccd69c270d99b10b3756014bb2 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Allow XMLHttpRequests from qrc to fileJüri Valdmann2018-10-184-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add test for cross origin XMLHttpRequests from/to custom schemes. By default, this is not allowed, but can be changed by adding an origin access whitelist entry to blink::WebSecurityPolicy in the renderer. Do this for the qrc scheme. As a result SecurityOrigin("qrc").CanRequest("file") will return true, which makes DocumentThreadableLoader::Start disable CORS for the request. Otherwise, CORS would be used, which only works with CORS enabled schemes. Fixes: QTBUG-70228 Change-Id: I2da60fddbbfb490c6d2f03329be286dbc28e1f12 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>