summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Override shortcuts only when an HTML input field has focusJoerg Bornemann2017-06-082-9/+15
| | | | | | | | | | | | | | | | Otherwise an application shortcut like Shift+Delete would no longer work when webengine has focus (e.g. "delete mail" in KMail) This removes unconditional calls to editorActionForKeyEvent for ShortcutOverride event handling. We can remove those, because the key sequences that are checked by editorActionForKeyEvent are a subset of the key sequences checked by isCommonTextEditShortcut. This amends commit 3902b27e. Change-Id: I12a98368381edef36f11457c8b864d843efb871a Reviewed-by: David Faure <david.faure@kdab.com> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Stabilize tst_download.qml and add check for downloadInterruptReasonValentin Fokin2017-06-081-4/+13
| | | | | | | | | Change some compares to tryCompares to wait for downloadStateChanged signal before comparing downloadState. Change-Id: If8f7f15a776e60c937f0e006d2ac337f6c1f9ad9 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge loadProgressSignal qml test into loadProgressValentin Fokin2017-06-083-65/+17
| | | | | | | | | | tst_loadProgressSignal.qml is a duplicate of tst_loadProgress.qml. Move loadProgressChanged signal check to tst_loadProgress.qml and delete tst_loadProgressSignal.qml. Change-Id: I14821d4979def7b9f1985859384224b8f8111bd6 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Replace SignalBarrier by QSignalSpy in tst_QWebEngineHistoryViktor Engelmann2017-06-011-66/+65
| | | | | | | | | | | | tst_QWebEngineHistory has lots of race conditions similar to those we have seen for example in tst_QWebEngineView. We now use QSignalSpy and QTRY_COMPARE instead of SignalBarrier and ensureSignalEmitted(), because these are more robust. We did the same for tst_QWebEngineView. Task-number: QTBUG-58473 Change-Id: I1d12914670aa1c08b7edf7593df8c950ad6d4b0b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add back widget auto tests for inputMethodQuery and inputMethodHintsPeter Varga2017-05-312-118/+117
| | | | | | Task-number: QTBUG-55766 Change-Id: Ic90eb7b9a211b09281ccbb3eae727e8a1c081b9a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add QML auto test for findText interrupted by page loadPeter Varga2017-05-311-0/+58
| | | | | | Change-Id: I9eccddd420cd0eb8b5be3006a4091465d4b3fab0 Task-number: QTBUG-60472 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Store Target URL in WebContentsDelegateQt::WebContentsCreatedViktor Engelmann2017-05-301-6/+12
| | | | | | | | | | | | | | | | | | | | | | | When opening a new window, for example by using the JavaScript method window.open('...'), the requested url is not stored in the content::WebContents object we get in WebContentsDelegateQt::createWindow (at this point, it should at least be stored as pending request in the WebContents' NavigationController, but it is not). Because of this, the QQuickWebEngineNewViewRequest object in QQuickWebEngineViewPrivate::adoptNewWindow never contained the url. We have access to the target url in WebContentsDelegateQt::WebContentsCreated, so now we store it there in a new property m_initialTargetUrl, from where WebContentsDelegateQt::createWindow takes it and passes it to WebContentsAdapter::adoptNewWindow as a new parameter. [ChangeLog][WebEngine] Fix WebEngineNewViewRequest::requestedUrl being empty when opening window from JavaScript Task-number: QTBUG-57675 Change-Id: I7e2c7866899baade17ce2517e6be8b2b2709699e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.9.0' into 5.9Allan Sandfeld Jensen2017-05-291-2/+93
|\ | | | | | | Change-Id: Iba6114263488d6bf84b255b38182904dc5880386
| * Fix selectionChanged signal out of input fieldPeter Varga2017-05-171-2/+93
| | | | | | | | | | | | Task-number: QTBUG-60688 Change-Id: I6d0b78e6b8df54c40ae30d5f0909c631c440a9cd Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Make error message more verbose in tst_QWebEnginePage::progressSignalViktor Engelmann2017-05-231-1/+7
| | | | | | | | | | | | | | | | | | | | If the Q_VERIFY(current >= previousValue) fails, the output was not verbose enough. The additional outputs will tell us more about what caused the test to fail. Task-number: QTBUG-57839 Change-Id: Ieeefe68ede111be7dba5eda9f2a770e975efc0ee Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* | Disable/blacklist failing tests for boot2qtSami Nurmenniemi2017-05-083-0/+11
|/ | | | | | | | | Currently boot2qt is tested with QEMU and some tests fail. Disabling them for now to make it possible to enable qt5 tests for Coin. Task-number: QTBUG-60266 Change-Id: I91a61bfb99b2629cb549b76d60c24f1d5f8c3ad8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix typo in tst_newViewRequest.qmlPeter Varga2017-05-031-3/+3
| | | | | | | Change-Id: I3e22f09b0847cb7c5edc50ad12c73b62c4525072 Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by: Valentin Fokin <fokinv@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Stabilize keyboardEvents auto testsPeter Varga2017-04-282-2/+2
| | | | | | | | The typeAheadTimeout is set to 1sec in Blink. Wait a bit more when selecting the next option in a HTML select element in auto tests. Change-Id: Ia3d9fde05b4d6cde9186aaa701ca48354ca74b4d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Override shortcuts in HTML input fieldsJoerg Bornemann2017-04-251-0/+58
| | | | | | | | | | | | | | | | | | | When users defined a single-letter short cut it was not possible to type this letter in HTML input fields. Fix this by accepting ShortcutOverride events whenever the web page is editing text. Use QInputControl::isCommonTextEditShortcut for Qt 5.9 and later. For the case where QtWebEngine is built against an older Qt a duplicated code path is used. Also, ensure users do not override web action short cuts. Task-number: QTBUG-59053 Change-Id: Ic26cf2a040a72b118273c6645c00b2913b995b0b Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Blacklist tst_QWebEngineView::imeCompositionPeter Varga2017-04-241-0/+3
| | | | | | Task-number: QTBUG-60381 Change-Id: Ib0e7ac3e5d7c3a9cea453fee96b2c5984567aa99 Reviewed-by: Liang Qi <liang.qi@qt.io>
* Rename macos blacklisting to osxTony Sarajärvi2017-04-241-1/+1
| | | | | Change-Id: If3581b261bfb1961320e145f94d27417ab8f8ee8 Reviewed-by: Liang Qi <liang.qi@qt.io>
* Disable setting background color in QInputMethodEventPeter Varga2017-04-211-0/+6
| | | | | | | | | | | | | IME managers may set background and foreground color of the composition string. Since there is no Chromium API for setting the foreground color, changing the background color to black may produce "black-on-black" text. Chromium locks the background color to transparent thus we do the same in this fix. Task-number: QTBUG-58362 Task-number: QTBUG-60031 Change-Id: I939c8aaaa847de191890d6924ba3c7652465f8a0 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Handle QInputMethodQueryEvent forwarded by RWHVQDWPeter Varga2017-04-121-0/+80
| | | | | | Task-number: QTBUG-58362 Change-Id: I6c80c8063ccad97aa80aff8ee44aa10a899c5ff5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix text selection and input method queryPeter Varga2017-04-122-565/+385
| | | | | | | | | | | | | | | Instruct the render process to change the text selection if it was requested via an input method event. Raise the selectionChanged() signal when all the corresponding input method properties are set. Moreover, add back the remaining input method widget auto tests. The updated tests are moved to the QWebEngineView tests since the corresponding APIs (inputMethodQuery() and input event handling) are now available via the QWebEngineView's focus proxy (aka RWHV). Task-number: QTBUG-55766 Change-Id: Ia0022d5f38b31dd59b084ff42e4abc2780ae90ec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Extend blacklisting of tst_QWebEnginePage to macOS 10.11Tony Sarajärvi2017-04-111-0/+1
| | | | | | Task-number: QTBUG-59808 Change-Id: I25b73f1a89fb9e19d04c5a4ccbadbe44acea039d Reviewed-by: Liang Qi <liang.qi@qt.io>
* Merge "Merge remote-tracking branch 'origin/5.8' into 5.9" into refs/staging/5.9Allan Sandfeld Jensen2017-04-094-0/+44744
|\
| * Merge remote-tracking branch 'origin/5.8' into 5.9Allan Sandfeld Jensen2017-04-054-0/+44744
| |\ | | | | | | | | | | | | | | | | | | Conflicts: src/core/gyp_run.pro Change-Id: I3e2d72769947e7abb0585e922e7517ecb0087331
| | * Binary compatibility files and global.cfg for QtWebEngine5.8Milla Pohjanheimo2017-04-054-0/+44744
| | | | | | | | | | | | | | | | | | | | | Add means to test binary compatibility for QtWebEngine too. Change-Id: I1bc39da3da1595b8ac39be6936ed47080a52c78b Reviewed-by: Sergio Ahumada <sahumada@texla.cl>
* | | Blacklist LinkHovered tests on Linuxes after fix did not workTony Sarajärvi2017-04-071-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6252f0231f85e5f4e6b887a6814d4968acae13bd tried fixing these autotests. As it evidently didn't work, we bring the blacklisting back. Task-number: QTBUG-55870 Change-Id: I12dc54a81cc25f743f1b37e321a6524ba6b5915c Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | | Yet another speculative fix of linkHovered QML testsPeter Varga2017-04-056-18/+19
|/ / | | | | | | | | | | | | | | | | | | | | | | | | When the test moves the mouse cursor out of the link area it positions the cursor above an iframe. We should not expect linkHovered signal above an iframe until its load is succeeded. Since we don't have API to test iframes' loading state, remove the iframe from the test. Moreover, increase signal timeout values to 12sec as it is used in other tests too since the 55-based chromium update. Task-number: QTBUG-55870 Change-Id: Id47494ac41a9d34f8a5bf4804fc5c157868cf923 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Blacklist tst_qmltests in macOS 10.11Tony Sarajärvi2017-04-041-0/+1
| | | | | | | | | | | | Task-number: QTBUG-58787 Change-Id: If0a658507c0caaa2d169da973109f801f9501914 Reviewed-by: Liang Qi <liang.qi@qt.io>
* | Fix broken inclusion of webenigne spellcheck testMichal Klocek2017-04-041-1/+1
| | | | | | | | | | | | | | | | | | Change 33e20b4 switched no_spellchecker into use_spellchecker, however change for tests directory was incorrect. Task-number: QTBUG-59687 Change-Id: Ie4d4dae863b90a3b35c9e92c88332096aad75325 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Blacklist tst_QWebEnginePage::mouseMovementProperties on macOS 10.12Tony Sarajärvi2017-03-301-0/+2
| | | | | | | | | | | | Task-number: QTBUG-59808 Change-Id: Id24f09a0502a3b48db2d3320d3c400bd349061e0 Reviewed-by: Liang Qi <liang.qi@qt.io>
* | Add back tst_QWebEngineView::horizontalScrollbarTest auto testPeter Varga2017-03-291-18/+19
| | | | | | | | | | Change-Id: Iebe5ed3e93b5b39866910ad9b63d02b88d64c3b2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix accessibility tests after 56 mergeAllan Sandfeld Jensen2017-03-271-3/+3
| | | | | | | | | | | | | | Editable fields are now one level less nested. Change-Id: If4ae9e7e35a30114976c5b8e29a42f99e50bfdb1 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Fix movementX and movementY properties of mouse eventsSzabolcs David2017-03-241-0/+32
| | | | | | | | | | | | | | | | | | | | Calculate movementX/movementY at every turn, not only when the mouse is in locked state. Task-number: QTBUG-59127 Change-Id: I362e055e6b5d6f831671604a093434373cedf19a Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add QML test for "Fix search restart after zero entries"Peter Varga2017-03-231-0/+31
| | | | | | | | | | | | | | | | | | | | The issue has been fixed in the qtwebengine-chromium 55-based branch: 2890c82cbd3a3e66d7062c9d9f4f065f5cc09d9e This test is based on the corresponding chromium test: https://codereview.chromium.org/2537773008/patch/1/10002 Change-Id: Ia930c42f2c3337f10fe133a35ffb5b596aa61d9f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Unblacklist changeLocale auto testsPeter Varga2017-03-154-12/+6
| | | | | | | | | | | | | | | | | | | | Do the error message comparison with utf-8 enconding since the localized error messages are stored in utf-8 format (error_page_strings.grdp). This also stabilizes the test because it doesn't depend on the encoding used by the Chromium. Change-Id: I24addc1c18d5b4325f4c0270e675e02c3f4e0812 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Rework form validation QML testsPeter Varga2017-03-081-50/+57
| | | | | | | | | | | | | | | | | | Use Custom Dialog API instead of Test Support API for testing form validation messages. Moreover, remove the form validation part from the Test Support API. Change-Id: I8ecc80745ddad26f90df413d9a1d04045512af6c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add SIGSEGV handler for the QML tests on LinuxPeter Varga2017-03-081-0/+74
| | | | | | | | | | | | | | | | | | The new handler prints stack trace if the browser process crashes due to segmentation fault while running QML tests. The solution is based on the QTestLib signal handler implementation. Change-Id: I5ccffc92043375fbf6fa5805a4592c61603efb3f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Cleanup QRegExp includesSamuel Gaist2017-03-071-0/+1
| | | | | | | | | | | | | | | | This patch adds the missing QRegExp includes in prevision of the qtbase include cleanup. Change-Id: Ic2cfddcd30207944c573096990032f7f7616a2b1 Reviewed-by: André Hartmann <aha_1980@gmx.de>
* | Merge "Merge remote-tracking branch 'origin/5.8' into 5.9" into refs/staging/5.9Allan Sandfeld Jensen2017-03-044-1/+59
|\ \
| * | Merge remote-tracking branch 'origin/5.8' into 5.9Allan Sandfeld Jensen2017-03-024-1/+59
| |\| | | | | | | | | | Change-Id: Iff6ab3c287c58d8ec84a1513460bfce5218e8a61
| | * Fix QWebEngineView::setFocus to properly set internal QQuickItem focusAlexandru Croitor2017-02-201-0/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The widgets object hierarchy related to focus goes like this: QWebEngineView's focus proxy is -> RenderWidgetHostViewQtDelegateWidget, which has an internal QQuickRootItem defined by QQuickWidget, and the child of the item is -> RenderWidgetHostViewQuickItem. Previously when QWebEngineView::setFocus was called, the focus was set on the RenderWidgetHostViewQtDelegateWidget and the QQuickRootItem, but not on the RenderWidgetHostViewQuickItem. This caused for e.g. an active HTML text input not receiving focus. Make sure the RenderWidgetHostViewQuickItem is marked to have focus within its root item, so that if the root item receives active focus, so will RenderWidgetHostViewQuickItem receive it. Task-number: QTBUG-58515 Change-Id: I175610e3dfebc03733aefe26c16f47096df8ff5b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * tests: blacklist tst_qwebengineview::changeLocale() on Windows and LinuxLiang Qi2017-02-171-0/+3
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-58022 Change-Id: I433c3b02a82494d6066338dab7a5991fab05040c Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| | * test: blacklist tst_QQuickWebEngineView::changeLocale() on WindowsLiang Qi2017-02-161-0/+3
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-58960 Change-Id: I14da592796dea0fbdda66a91ff58d4bc7941d84f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Add missing test files to qmltests.proPeter Varga2017-02-101-1/+3
| | | | | | | | | | | | | | | Change-Id: I1b4f10facdacde432a7b135419ae3c81acf6ce74 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Rework change locale tests for 55-based ChromiumPeter Varga2017-03-033-43/+69
|/ / | | | | | | | | | | | | | | | | Error pages no longer have useful titles in Chromium 55. Test the error page content instead. Tests have been also stabilized. Task-number: QTBUG-58022 Change-Id: If5c3e2b1df2cb3ee8b48d651e6f19360fa484f17 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Use off-the-record profiles in quick testsAllan Sandfeld Jensen2017-03-024-0/+7
| | | | | | | | | | | | | | | | Changes our automated tests to use off-the-record profiles so that we do not create profile directories on disk. Change-Id: Ide1fad7431e2bacd72c469f1c8ebdf473ecf25b6 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Rework unhandled key event propagation tests for 55-based ChromiumPeter Varga2017-03-012-31/+58
| | | | | | | | | | | | | | | | | | Since change https://codereview.chromium.org/2200833007 input elements are inappropriate for testing unconsumed key events. Test focus change on div elements instead. Change-Id: Ifa2f3e1bc9d6d9cb396fbad7caea907616d085b7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Update auto tests for Chromium 55Allan Sandfeld Jensen2017-03-018-16/+16
| | | | | | | | | | | | | | | | | | Load failures now have a Chromium side timeout of 10s so we need to wait longer than that. Additionally error-pages no longer have descriptive titles, so we can not rely on that in our tests any longer. Change-Id: I33ac8b9f1247403eb214f7260267edb887fe10d0 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Catch terminating render process in file picker testAllan Sandfeld Jensen2017-02-223-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | These tests have been broken for some time but we didn't catch that the web-process self-terminated. This change ensures we catch it and adds the failing tests to the black list. It also fixes BLACKLIST support by following what QUICK_TEST_MAIN does. Change-Id: I31cc123e1d653f37e33ccb3a754b9fae8cfe02d6 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Fix crashes in removeFromCanvasMichael Brüning2017-02-151-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | After reparenting the view, the compositor data may still be the same, but the node might be a different one. Check if the list of scene graph nodes is empty when making the decision on whether to build a new node tree or not. Also advance the node iterator for missing render passes. Task-number: QTBUG-58472 Change-Id: I28dfb40bda89470c7cdaec0aef8a976e307f5b6a Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge remote-tracking branch 'origin/5.8' into 5.9Allan Sandfeld Jensen2017-02-081-0/+7
|\| | | | | | | Change-Id: I0c3654ad097809fe10bcc6a15827a0af3006c4e6
| * Blacklist flaky linkHovered testMichal Klocek2017-02-071-0/+7
| | | | | | | | | | | | Task-number: QTBUG-55870 Change-Id: I3367889041614a5e7489909dd37c7af638edf16b Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>