summaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Add qtry prefix to webenginepage testMichal Klocek2020-01-171-2/+2
| | | | | | | We got one failure at previous integration. Change-Id: Ic229a66bde151ea6a6a1805e38eb8e2f6f337107 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge 5.14 into 5.14.1Kari Oikarinen2020-01-151-0/+172
|\ | | | | | | Change-Id: Ibc671c7a5ac4b070f3406c41598d071fd978e420
| * Fix crash when handling QEvent::TouchCancelRomain Pokrzywka2020-01-091-0/+172
| | | | | | | | | | | | | | | | | | | | | | | | TouchCancel events have an empty touchPoints() list, which first trips when accessing touchPoints[0], and later on crashes Chromium if we pass the empty list to m_touchSelectionController. Rework handleTouchEvent() to route TouchCancel events like other touch events, and make sure we pass a non-empty touchpoints list to Chromium. Task-number: QTBUG-80893 Change-Id: Ie8396a1191f72b5bbb2b047f131794b37cfded48 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Rework url changed logicMichal Klocek2020-01-142-6/+7
|/ | | | | | | | | | | | | | | | | | | | | | Due security changes to prevent url spoofing, our implementation is getting extra invalidate url requests. Unfortunately, this breaks our url handling, which now gets lots of new back and fort url changed signals and make several unit test failures. After tedious investigation of Chromium omnibox handing and trying out different approaches, it seems that only sensible solution is to follow Chromium logic and make NavigationStateChanged to update 'ui' in asynchronous matter. This change tries not break any tests and simplify url handling. The only side effect of this change is that WebEnginePage::setContent will get extra 'url' signal of initial 'urlData' and later 'baseUrl' change is emitted. Fix one of qml tests which did not expect to have url on LoadStartedStatus. Task-number: QTBUG-63388 Task-number: QTBUG-48995 Change-Id: Id347f4325c036e16bfae7bf2f694905e0f21f8d7 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Un-blacklist tst_qwebenginepage::fullScreenRequested() on WindowsTamas Zakor2019-12-182-151/+22
| | | | | | | | | | | | | | | The JavaScriptCallbackWatcher::wait() blocks the callback and it gets called after the wait() only. Replace JavaScriptCallbackWatcher() with QTRY_COMPARE() and QTRY_VERIFY(). These functions don't block the callback call. Remove JavaScriptCallback class from test. Also reimplement tst_qwebenginepage::runJavaScript auto test. Fixes: QTBUG-78015 Change-Id: I11e6f709c00a9121066c2554508c8312c1e33c12 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix Q(Quick)WebEngineDownloadItem::setDownloadDirectory()Tamas Zakor2019-12-183-7/+134
| | | | | | | | | | | | | | | | | | Keep the custom file name if the calling order of setDownloadDirectory() and setDownloadFileName() changes. Also do not emit patchChanged signal twice if setDownloadDirectory() changes the uniquifier of the file name. Add TempDir for qml auto tests what uses QTemporaryDir() to create temporary directory for downloads. See https://cgit.kde.org/messagelib.git/commit/?id=2c113dcb155b11bf2c0af3c85544962485784b26 for details. Fixes: QTBUG-80566 Change-Id: Ia76f263558eaf55cb297700407948523788c6229 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add binary compatibility files for qtwebengineMilla Pohjanheimo2019-12-173-0/+47964
| | | | | | | BC file built against 5.14.0 added. Change-Id: I6ca53448794081579c96effece4dbd870067d7bb Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* Merge remote-tracking branch 'origin/5.14.0' into 5.14Allan Sandfeld Jensen2019-12-043-10/+59
|\ | | | | | | Change-Id: I4f73d4b11bee795185d4eaae718d4cfdb3112100
| * Fix 'setDownloadDirectory' for download item on 'SavePage' actionKirill Burtsev2019-11-291-8/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromium's DownloadManager doesn't create its download items before path for saving page is confirmed. So assert inside updateDownloadPath was not correct. Moreover, the name is confusing because it's not really updating anything. Remove it and use ProfileAdapterClient::DownloadInfo timestamp to determine updated filename after directory change. Ammends recent new api for changing download directory 0884fab3b1. Fixes: QTBUG-80372 Change-Id: If9efb52979deb3cf21fc4e12989173c85e04e090 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * Favicon touchIconWithSameURL test: fix waiting on wrong spyKirill Burtsev2019-11-281-2/+2
| | | | | | | | | | | | | | Amends fc0dbde734 timeouts adjust for slower CI Change-Id: I77bacfb973cfe8e2c259a31d58f439ffcae7b87f Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * Update find request id when a new search interrupts an ongoing searchPeter Varga2019-11-281-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the new test became flaky it might happen because the first text search finished before the second findText() call. This is very unlikely, but in this case the test should be modified to not to check if the first find failed. The point is to check we get the correct amount of signals and the second search doesn't assert. If the callbacks will be removed in Qt6, it should be re-considered to remove the "unfinished find" workaround and trigger the first successful findTextFinished() signal even if it happens in the middle of another search. Fixes: QTBUG-80086 Change-Id: I9c1ce20fc43fd81e8af784385a00ac2e7f7603b7 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
| * Fix renderProcessTerminated signalJüri Valdmann2019-11-281-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the adaptations for Chromium 76, RenderWidgetHostViewQt was changed to become a RenderProcessHostObserver with the renderProcessTerminated signal being emitted from the override of RenderProcessHostObserver::RenderProcessExited. The problem with this can be seen by setting a breakpoint on the RenderProcessGone override in RenderWidgetHostViewQt. We then get the trace: QtWebEngineCore::RenderWidgetHostViewQt::RenderProcessGone content::RenderWidgetHostImpl::RendererExited() content::RenderViewHostImpl::RenderProcessExited content::RenderProcessHostImpl::ProcessDied ProcessDied iterates over all the observers and calls RenderProcessExited. Both the RenderViewHostImpl and our RWHVQt are observers, but the RVHImpl comes first. The RVHImpl then calls RendererExited, which calls our RenderProcessGone, which does a 'delete this'. Now our RenderProcessExited override can never be called because we have already deleted our observer. Fix by moving the RenderProcessGone code to WebContentsDelegateQt and getting the exit code from WebContents::GetCrashedErrorCode. Also add test. Task-number: QTBUG-80085 Change-Id: I434744286df97a37b64722d7c15a1d4ee11c8af6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Stop using loadVisuallyCommitted in tst_qquickwebengineviewgraphicsJüri Valdmann2019-11-292-84/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The loadVisuallyCommitted signal is not emitted until the grabWindow call, but the grabWindow call is not made until the loadVisuallyCommitted signal is emitted. This could maybe work in Prolog but in C++ it's not a good idea. Additionally, support not only images in RGB32 format, but also ARGB32, since that's what we get with software compositing. Fixes: QTBUG-58449 Task-number: QTBUG-79626 Change-Id: Iddae69764855febbc3a985ef7009227bc94634a5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Support accept attribute of file inputSzabolcs David2019-11-295-0/+54
|/ | | | | | | | | Set name filters of QFileDialog and QML FileDialog to avoid presenting all file types. Task-number: QTBUG-76564 Change-Id: I321214a30bc7e875ad132b015c63282f4eb482bf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Store favicon URL when serializing QWebEngineHistoryDmitriy Kuminov2019-11-082-0/+9
| | | | | | | | | | | | | | This is to make QWebEngineHistoryItem::iconUrl of the deserialized QWebEngineHistory object return the same URL it had when serializing. Otherwise it's impossible to have favicons for URLs from the navigation history of a restored browser session until these URLs are visited again (so that Chromium refetches their favicons). These icons are usually needed much earlier - e.g. when showing a popup with the navigation history and having an icon URL allows to load it from a disk cache before visiting the page. Fixes: QTBUG-78998 Change-Id: Ief2d089d52f301826e5c131d401cafd08952a8b5 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Add tst_QWebEnginePage::setHtmlWithModuleImportJüri Valdmann2019-11-081-0/+36
| | | | | | | | Try importing JS modules from a setHtml page. Fixes: QTBUG-77282 Change-Id: I925bd3239688117c380ed3ae404dcb9547d99cac Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Handle MSVC CI slowness in tst_originsAllan Sandfeld Jensen2019-11-071-1/+1
| | | | | | | | | | | | The test now reports it would succeed with a longer timeout on loading. This should be investigated later as the timeout is really out of line, or what should be acceptable. Task-number: QTBUG-79852 Fixes: QTBUG-79719 Change-Id: I60c1e6e0f7026b5ad61db2e22512dd45e1162e1c Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* More speculative fixes for MSVC 2019 CIv5.14.0-beta3Allan Sandfeld Jensen2019-11-064-23/+24
| | | | | | | | | Expand many more timeouts as loading basic test cases can now take many seconds. Task-number: QTBUG-79290 Change-Id: I749fe50525919b24a4a3fcba905745b6d6648121 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Deprecate QWebEngineDownloadItem path API properlyTamas Zakor2019-11-051-0/+4
| | | | | | | | Implements suggestion from 5.14 API review: - Replace QT_DEPRECATED with QT_DEPRECATED_SINCE and QT_DEPRECATED_VERSION_X Change-Id: I4d0bf8a2b535c44b5749cbd3bbab7e305bd137c6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Speculative fix of tst_OriginsAllan Sandfeld Jensen2019-11-041-65/+72
| | | | | | | | | Cleanup page between tests, increase load timeout and switch to QVERIFY_TRY to be told of timeout overruns. Fixes: QTBUG-79719 Change-Id: Ic246a5b0926c3e8b6c0f90f5ff21a33fa262c046 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Merge branch '5.13' into 5.14Allan Sandfeld Jensen2019-10-301-14/+27
|\ | | | | | | Change-Id: I6ab2e949cb2fa3b2db55a1654d42667db6257eab
| * Fix getDisplayMedia crashJüri Valdmann2019-10-171-14/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MEDIA_DISPLAY_VIDEO_CAPTURE stream type is handled incorrectly by MediaCaptureDevicesDispatcher causing a crash when an unexpected type of media device is returned to Chromium. This patch only fixes the crash, screen sharing is nonetheless not properly supported by WebEngine due to limitations of the public API which does not allow selecting between screens, not to mention windows or tabs. On Linux WebRTC's ScreenCapturer is not even built since it depends on use_x11 being set in GN. Fixes: QTBUG-78016 Change-Id: I7fa49febaba1be94bdb6c31265dfc24ee809d635 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
| * Stabilize tst_QWebEnginePage::comboBoxPopupPositionAfterMove auto testPeter Varga2019-10-091-0/+6
| | | | | | | | | | | | | | | | Fixes a flaky fail when jsViewPosition is called too early to query the view position. Change-Id: Ib2e9c1e95a6363a8e45e8bcc44e1878fd9a6914f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Unify shared context initializationMichal Klocek2019-09-262-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting shared context on core application object should be done before core application is initialised. This is handled correctly in widgets part but not in qml part. Unify our shared context creation and call WebEngine::initialize() before QCoreaApplication is created. Context has to be set shared before first window's QPlatformOpenGLContext is created and not before window itself is created as documentation claimed. Keep the older code running, but print the warning. Update one test to test new initialization order, but keep the others to check if they still works. [ChangeLog] WebEngine::initialize() has to be called before QCoreApplication is created. Task-number: QTBUG-76391 Change-Id: Iff938493a4d21f360110136192daedb6199584c1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix XMLHttpRequest status with custom schemesJüri Valdmann2019-09-251-0/+110
| | | | | | | | | | | | | | | | | | | | | | | | Emulate a HTTP 200 OK response when QWebEngineUrlRequestJob::reply is called so that an XMLHttpRequest to a custom scheme gets a proper 'status' property. Note that calling QWebEngineUrlRequestJob::fail on the other hand emulates a network error, meaning it triggers the 'error' event in XMLHttpRequest. Fixes: QTBUG-78316 Change-Id: Ia7249a5b72533aa7e2ed4ef8f62d8b6b89820cc1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix all GCC and Clang warningsJüri Valdmann2019-10-303-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix all warnings save for -Wdeprecated-declarations in tests. Warnings from GCC 9.2.0: src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23: warning: variable 'resource_root_relative_path' set but not used [-Wunused-but-set-variable] src/core/chromium_overrides.cpp:121:21: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] src/core/render_widget_host_view_qt.cpp:540:12: warning: enumeration value 'kNull' not handled in switch [-Wswitch] warning: enumeration value 'kMiddlePanningVertical' not handled in switch [-Wswitch] warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch [-Wswitch] warning: enumeration value 'kDndNone' not handled in switch [-Wswitch] warning: enumeration value 'kDndMove' not handled in switch [-Wswitch] warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch] warning: enumeration value 'kDndLink' not handled in switch [-Wswitch] warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch] src/core/type_conversion.cpp:57:12: warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch [-Wswitch] src/core/api/qtbug-60565.cpp:83:6: warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)' alias between functions of incompatible types 'void(void*, const std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=] src/core/api/qtbug-60565.cpp:79:6: warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias between functions of incompatible types 'void(void*, const std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=] src/core/api/qtbug-60565.cpp:75:6: warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)' alias between functions of incompatible types 'void(size_t, const std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=] src/core/api/qtbug-60565.cpp:71:6: warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias between functions of incompatible types 'void(size_t, const std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=] Warnings from Clang 9.0.1: src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29: warning: private field 'm_dispatcher' is not used [-Wunused-private-field] src/core/web_event_factory.cpp:1296:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] src/core/compositor/compositor_resource_fence.h:55:81: warning: extra ';' after member function definition [-Wextra-semi] src/core/renderer/render_frame_observer_qt.h:81:10: warning: 'ReadyToCommitNavigation' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27: warning: private field 'guest_' is not used [-Wunused-private-field] src/core/chromium_overrides.cpp:121:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] src/core/chromium_overrides.cpp:145:64: warning: missing field 'set_up_command_line' initializer [-Wmissing-field-initializers] src/core/chromium_overrides.cpp:146:55: warning: missing field 'set_up_command_line' initializer [-Wmissing-field-initializers] src/core/render_widget_host_view_qt.cpp:540:13: warning: 7 enumeration values not handled in switch: 'kNull', 'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch] src/core/compositor/stream_video_node.cpp:50:18: warning: 'updateState' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] src/core/compositor/stream_video_node.cpp:103:18: warning: 'initialize' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] src/core/type_conversion.cpp:57:13: warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in switch [-Wswitch] src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi] tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62: warning: lambda capture 'item' is not used [-Wunused-lambda-capture] tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Test XMLHttpRequests to CorsEnabled custom schemesJüri Valdmann2019-10-231-1/+17
| | | | | | | | | | | | | | | | | | | | Previously cross-origin XMLHttpRequests could only be made to the builtin CORS-enabled schemes, http, https, data, and chrome. Now we also support extending this set with new custom schemes using the CorsEnabled flag. Fixes: QTBUG-79322 Change-Id: I8628aad2be62013e32708308797712de82ff185b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Speculatively prepare for even slower CIAllan Sandfeld Jensen2019-10-237-38/+36
| | | | | | | | | | | | | | | | | | Bumb up timeouts to even more higher levels to accommodate even slower CI instances. Task-number: QTBUG-79290 Change-Id: I33a4660165f72837273c3089092687a8962c83ba Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Add HTTP content-typeAllan Sandfeld Jensen2019-10-231-0/+30
| | | | | | | | | | | | | | | | Some code only checks the http content type and not the job mimetype. Change-Id: I7a2b2f5d30c2f349f2570f0422ce415eebd0f644 Fixes: QTBUG-79319 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Merge remote-tracking branch 'origin/5.13' into 5.14Allan Sandfeld Jensen2019-10-223-2/+124
| | | | | | | | | | | | | | | | | | | | | | Conflicts: examples/webengine/minimal/main.cpp src/3rdparty src/core/net/url_request_custom_job.cpp tests/auto/widgets/qwebengineprofile/tst_qwebengineprofile.cpp Change-Id: I33994024a4be5ed787800c5718a0a443b970c36d Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Improve QWebEngineFindTextResult APIv5.14.0-beta2Peter Varga2019-10-193-25/+25
| | | | | | | | | | | | | | | | | | | | | | | | Implements suggestions from 5.14 API review: - Rename activeMatchOrdinal to activeMatch - Extend documentation - Change QML import version number to 1.10 Task-number: QTBUG-77839 Change-Id: I5eae659cfb5355af8d0c878d3b5f00654c9d6d13 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Rename certificate error's chain API methodKirill Burtsev2019-10-171-1/+1
| | | | | | | | | | | | | | | | Address API review and make the name to be consistent with other methods like localCertificateChain and peerCertificateChain of QSslCertificate Change-Id: I4f115846965d31ea9a20df3b7a27c6c041c52768 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Fix tst_qwebenginepage::comboBoxPopupPositionAfterMove() auto testTamas Zakor2019-10-171-0/+2
| | | | | | | | | | | | | | | | | | | | | | Assertion fail occurs when the destruction order of the windows is not correct. This happens only in this test and can not be reproduced manually. Destroy popup window before destroying the main window. Change-Id: Iea00df25c200e1b8aff9ce08ef73a411e549fcab Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Do not build certificateerror tests if Qt is configured with -no-sslPeter Varga2019-10-081-1/+4
| | | | | | | | | | Change-Id: Ic5d80b968b92a4edbf25a3d6e8cb9c07cbcf98f1 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* | Support qrc protocol in @match rules of user scriptsSzabolcs David2019-09-301-0/+28
| | | | | | | | | | | | | | | | | | | | | | Pulls in the following Chromium changes: 7ac85fb4cc6 Fix building with pulseaudio 13 7956dfb8d20 Support qrc protocol in UrlPattern 9af3b1bf632 Fix pressure of tablet events Task-number: QTBUG-76173 Change-Id: Iffc21ed6eb0a99e2b96780ce4f11629d38f8b47e Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | Blacklist visibilityState3 on windowsAllan Sandfeld Jensen2019-09-251-0/+3
| | | | | | | | | | | | | | Being flaky Change-Id: Ic9286b66296e58ce16dde63443c7e83e54c56682 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Merge remote-tracking branch 'origin/5.13' into 5.14Allan Sandfeld Jensen2019-09-246-39/+143
|\| | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: config.tests/glibc/glibc.cpp src/3rdparty src/core/configure.json src/core/profile_io_data_qt.cpp src/webengine/configure.json src/webenginewidgets/api/qwebenginepage.cpp tests/auto/widgets/qwebenginepage/BLACKLIST Change-Id: I3e1781048c3cb09bfbf7427dfc5dd1fec11a2b97
| * Fix flaky tst_QWebEnginePage::runJavaScriptFromSlotJüri Valdmann2019-09-142-9/+4
| | | | | | | | | | | | | | | | Unfortunately, "load finished" doesn't mean "ready to execute JavaScript". Fixes: QTBUG-74718 Change-Id: I611e35cfbb530ff68745d86124679d60ab0b113e Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| * Add environment variable check for tst_ProxyPac::proxypac()Tamas Zakor2019-09-121-0/+4
| | | | | | | | | | | | | | Yield error message if --proxy-pac-url argument is not passed. Change-Id: I9a5685982c0a9d8decc65ad9c728357c038ef0a0 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * Fix invalid url on profile changeMichal Klocek2019-09-041-0/+14
| | | | | | | | | | | | | | | | If adapter is initialized use always active url. Fixes: QTBUG-77977 Change-Id: Ie8d4ec7d7c703322cef50d26931cce2b130dcf34 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix QWebEnginePage visibility stateJüri Valdmann2019-08-201-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling view.show(); view.load(...); view.hide(); results in a WebContents in visible state because the first call to show() is delayed via a timer and never canceled so it takes effect after the hide(). Also, the page's visibility state is not updated when changing views, so that a visible QWebEngineView can be set to display a hidden QWebEnginePage. Fixes: QTBUG-77209 Change-Id: I0243c659f4039a35c36e04ea55c5972666170fd0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Fix file URI checks for FilePickerController::accepted() on WindowsTamas Zakor2019-07-311-12/+76
| | | | | | | | | | | | | | Extend auto tests with windows specific cases. Change-Id: I731cd520c12a38636a5df4829a79d7bd1d85a314 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Clean-up handling of selected filesAllan Sandfeld Jensen2019-07-271-29/+23
| | | | | | | | | | | | | | | | | | | | Simplifies the code and makes sure both the two QML implementations of the file-selector are source compatible. Note, this does not address issues with test on Windows. Change-Id: Ieee84866c456d600a812683cae389d6a6980366f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Fix Q(Quick)WebEngineDownloadItem::setPath() path conversionTamas Zakor2019-09-161-3/+32
| | | | | | | | | | | | | | | | | | Also extend auto test with path checking Task-number: QTBUG-78213 Change-Id: Icb5d4ec831d8a665894d5890f983752c3af60ce8 Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Remove usages of deprecated APIsSona Kurazyan2019-09-094-10/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Replaced the following deprecated APIs: QWebEngineProfile::setRequestInterceptor -> QWebEngineProfile::setUrlRequestInterceptor QWebEngineSettings::globalSettings -> WebEngineSettings::defaultSettings QLayout::setMargin -> QLayout::setContentsMargins QWheelEvent::{x, y} -> QWheelEvent::position QWheelEvent::{globalX, globalY} -> QWheelEvent::globalPosition QSysInfo::windowsVersion -> QOperatingSystemVersion::current Qt::InputMethodQuery::ImMicroFocus -> Qt::InputMethodQuery::ImCursorRectangle QDesktopWidget::screenGeometry -> QGuiApplication::primaryScreen::geometry QTime -> QElapsedTimer - Fixed the tests to compile when deprecated APIs are disabled. - Replaced the doc references to deprecated APIs with the new ones. Made the docs for deprecated APIs compile conditionally, based on deprecation version. Task-number: QTBUG-76491 Change-Id: I5c6b7c628957deb9163f0bd2b6bc31bde1c7daec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Blacklist several Qt WebEngine quick dialog tests on macOS 10.13Michael Brüning2019-09-091-0/+6
| | | | | | | | | | | | | | | | | | These tests are causing frequent failures on macOS 10.13 in the CI, but are not reproducible / debuggable when not running as part of CI. Task-number: QTBUG-76549 Change-Id: I1b105748c9fad8a6104beeccb10632518893d06b Reviewed-by: Liang Qi <liang.qi@qt.io>
* | Add webengine-core featureMichal Klocek2019-09-072-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create/split main configure for submodules. Now configure system knows when webenginecore module is not going to be built and the user gets the feedback after the configure step with the message: The following modules are not being compiled in this configuration: webenginecore webengine webenginewidgets If a module is not built also features are not populated, therefore some tests have to be moved to main configuration. This improves error reporting and prepares landing for QtPdf modules. Remove configure.prf and fix issues after config split. Add makefile call to report errors. Now calling make also reports issues. Task-number: QTBUG-75840 Task-number: QTBUG-76606 Change-Id: I76944df4c5db6f4954c464e3741a8054cb10b40e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Blacklist tst_QWebEnginePage::fullScreenRequested on WindowsAllan Sandfeld Jensen2019-09-061-0/+3
| | | | | | | | | | | | Task-number: QTBUG-78015 Change-Id: I9d1e2409897df6d5a36ab9a12d42224c2163df6b Reviewed-by: Liang Qi <liang.qi@qt.io>
* | Api to get certificate's chain on errorKirill Burtsev2019-09-054-85/+94
| | | | | | | | | | | | | | | | | | | | | | | | Expose certificate's chain on validation error starting with the immediate certificate and ending with the CA's certificate. [ChangeLog][QtWebEngineWidgets][QWebEngineCertificateError] New method to get the peer's chain of digital certificates. Fixes: QTBUG-51176 Change-Id: I799dfe9e44f9f2517f4691d175beee256114af79 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | Allow deferring QWebEngineCertificateError handlingKirill Burtsev2019-09-0510-16/+331
| | | | | | | | | | | | | | | | | | | | | | | | | | Introduce defer() method for halting URL load on certificate errors, and methods for rejecting and ignoring these errors subsequently in async manner. [ChangeLog][QtWebEngineWidgets][QWebEngineCertificateError] New methods for asynchronous decision on certificate error during load. Fixes: QTBUG-55110 Change-Id: Ib23eb568862ccc360208922a6a581f8e7edc4a7e Reviewed-by: Michael Brüning <michael.bruning@qt.io>