| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Also fix the mapping of Ctrl and Meta keys on Mac OSX.
On this platform Qt automatically maps Meta to Control
and vice versa. Chromium however does not expect such
behavior.
Change-Id: Ia9913322ae8ae6ffd99feb6edfc91b9ea752c5cb
Reviewed-by: Pierre Rossi <pierre.rossi@theqtcompany.com>
|
|
|
|
|
|
|
|
|
| |
The check for platform support is now taken care of on the top
level pro file, and skips the entire build, so this is not needed
anymore.
Change-Id: I5c7e572ec4055c2274eebfe2288f28811f77f048
Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
|
|
|
|
|
|
|
| |
Also revert the experimental version number to 1.0 in the import.
Change-Id: I7641110f296c432801808a4217c94a6d9cc2a540
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|\ |
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
.qmake.conf
src/3rdparty
src/core/content_browser_client_qt.h
src/core/core_module.pro
Change-Id: Ia05a6564a4d17ca14ff9b76ae018c3f4ef33d535
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As QtWebEngine now uses 5.x as its version number, we can just
provide cmake tests and let qmake scripts do the rest.
Task-number: QTBUG-42073
Change-Id: I28ccddbd1849980074dfbeefb5cb5a70c9209ab1
Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch exposes downloadStarted and downloadFinished
signals on the WebEngineProfile to notify about downloads.
The WebEngineDownloadItem exposes a subset of Chromium's
content::DownloadItem functionality.
For now we expose minimal requirements to be able to control
downloads in QML but this can be extended in the future.
This patch also adds a DownloadView to quicktestbrowser
to demonstrate the usage of the new API.
[ChangeLog][QtWebEngineQML] Add QtQuick download API
Change-Id: I8d8f0daf02c4e0151000427fc2a4b37d28b9db52
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In order to stay in line with the behavior expected by Chromium, we
focus the view on load. This is problematic when relying on the
editingFinished signal of text inputs in QML, as it is fired both when
pressing enter and when losing focus.
In our case, this would lead to reentering into load and in turn
QQuickWindowPrivate::setFocusInScope, and when returning from the outer
call, QQuickWindow would try to access the RWHVQtDelegateQuick from the
first load through a now dangling pointer.
It seems preferable to guard WebContentsAdapter::load against recursion.
Adds a simple autotest that covers the crash scenario.
Task-number: QTBUG-42929
Change-Id: Ib3bf9f421b1a91645b3e0e9aa658f2a3646d9caf
Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
| |
| |
| |
| |
| | |
Change-Id: I0b9a35c59d6eadb426143c041538ebb9c9d6d800
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Introduces the QML API for the WebEngineProfiles already implemented
for QtWebEngineWidgets.
[ChangeLog][QtWebEngineQML][QQuickWebEngineProfile] New API for profiles
applying to groups of QQuickWebEnginePages.
Change-Id: Ideccddb9f1fb19628297592fe0cec504c9890e46
Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/core/access_token_store_qt.cpp
src/core/access_token_store_qt.h
src/core/content_browser_client_qt.cpp
Change-Id: Id319ad0d87ce071e63d9c6c22b4fc35523ddfa74
|
| |\
| | |
| | |
| | | |
Change-Id: I3b7df1ada08a8985734d804208b50cd5e0403903
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I01615a492c958bf123deeef5d2ddf9fb01b1a9d0
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Error page should be disabled while testing loadFail signal since
testing signals of the internal error page is not possible yet.
Change-Id: I07f0bb6378fcbf5d18634197808801c94606803c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In the same way it was done for widgets.
Change-Id: I03ff6ed587346b00c76cf7314483263fd4f90a2d
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Change-Id: I1a5fedc4167dd780655b004811211e49631663c5
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|\ \ \ \
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/core/browser_context_qt.cpp
src/webengine/api/qquickwebengineview_p.h
Change-Id: I73bdec03b627b282851d7dda12006d4ab631072c
|
| | |/
| |/|
| | |
| | |
| | | |
Change-Id: I7cb497ce0f67eaf948caa88930fa1a3040ff4c39
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |/
| |
| |
| |
| | |
Change-Id: Id2e62af31f1dc5268fe6b163d2fc0b671f5e491a
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |
| |
| |
| |
| |
| |
| | |
Adds a test to check the return types of runJavaScript.
Change-Id: Ifd0cb4adf57c972e8a8ad240d51f11f0cc17aa3d
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Use explicit url in quick API too and use GetLastCommittedURL instead of
GetVisibleURL for getting the expected urls in tests.
Change-Id: If3251323645979643f3dc0e16491fe35b584f51c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adapt test results to the chromium behavior and remove expected
failures.
Change-Id: I277462125822e50f84c0d0ae795846a71c9a2b10
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is required so that embedders can implement custom error pages,
and is also needed for tests, where error-page loading has side-effects
on subsequent page loads.
Change-Id: I5ae276a58864a2fa9d7b608bea3340b482a92f4e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| | |
Change-Id: Ie27e4af5f4517bb1e1eea1262ab32140b3dff816
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Add crash tests for the Quick API and mark the unimplemented features
in the test logs.
Change-Id: I8e6b322fb1bb5ed75fed8b9556e2e975c9227f0a
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A tab's disposition can be foreground (e.g. target="_blank") or background
(Ctrl+Click, or middle-click). API consumers should be able to discern between
the two intents, so they can decide whether or not to focus their new view.
Change-Id: Iab3ccb9e9f0b85256892f4f74204515bdeefa695
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the equivalent API for navigationRequested in QtQuick.
This patch also enables and updates tests that depended on this
API, and removes the ones that we will not support.
Change-Id: I28970c11225420a9680fbd767880130492664179
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is a quick fix that only works because dialogs shouldn't outlive
the page that opened them. We still have a problem for the new window
case.
Change-Id: I652e545f7eac394a915f7f173795dc0f187fc6ea
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
| |
| |
| |
| |
| |
| |
| | |
and add shortcuts in the examples (with a basic UI in the test browser)
Change-Id: I237a04cf0b1fce2e0c6f8a19891ff3cb51727a40
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|/
|
|
|
|
|
|
| |
so that we can open local files on the command line for quick testing.
Change-Id: Ica0fd2242d90e5499c2f1550bc87362f20bf7938
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The requestedUrl function didn't return empty URL even if
the empty URL was really requested. It was assumed if
GetOriginalRequestURL returned empty string that means the requested url was
not set in the navigation entry.
This fix handles that case when empty url is set in the navigation
entry as requested url. If the navigation entry is in pending state that means the
request url has not been set yet thus the actual URL should be returned.
Change-Id: Ic2eff5c487686f7c0e349a7a34a86b80551a002f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
If the error page loading is interrupted by loading of another page the
signals of the second page should not be suppressed.
Change-Id: I537daabf80ffed005acaaf2a6019e52a3250c523
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Reviewed-by: Adam Kallai <kadam@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
| |
Add the missing default_encoding to the web preferences.
Use a 0ms timer instead of the 100ms in order to apply the settings
as soon as possible and avoid waiting mechanisms in the test.
Change-Id: I12f1a6dd68b29c2b287b160eea1ad5a5fb169c14
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
| |
Change-Id: I9db9bbfd106e8cf939108dbcadf27b7a43923662
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Window.showModalDialog() is not supported since Chromium 37, so we can
remove the showModalDialog test case.
If the view is not visible, the width and the height of the requested
geometry is always 0 in tst_QWebEnginePage::openWindowDefaultSize.
Change-Id: I420828815bc9528070ca58a9e42dea44517aeafc
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I66b6cb593ed6fe7cc2e74737829991631606709f
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
When the PATH is properly set up, this should not be necessary
and it overrode the explicitly set QTWEBENGINEPROCESS_PATH.
Change-Id: Ie83a9f4f15f2203329c44fd9653adbb19c62672c
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
If we get a replacement content, we can see a DidFinishLoad event for a frame.
This error page should be ignored based on the frame.
Change-Id: I3e1cd1773e8c5fc608605197c957011ddf258123
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
| |
That is the role that is returned from the WebView.
Change-Id: I9ab817e259c8fe69d756ffa576082066cf6b4ea8
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fact that the error pages are HTML and get loaded through the
same mechanism should be kept an implementation detail and not be
considered as a new load in the API sense.
Also implement HasErrorPage for good measure and remove an anoying
warning from the demo browser.
The issue of the url not being changed remains in the QML test (but
it doesn't affect a typical browser-like UI since the user input is
still there untouched in the address bar), just make sure that failure
does not affect the later checks. It also seems like we have a focus
problem somehow, but the test should probably use a click for that
matter.
Change-Id: Ib5e363981a11287fdf4bfe84b93c999d96ed8087
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
| |
Expose some "testable" settings as well as test the integration with
the QML Settings API.
Change-Id: I7ec6a7e695f60338b2c16a648e9a93b64ea29a94
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
Always check if there is another accessible set as title for the one
queried. For text fields also return the placeholder property if nothing
else is set.
Change-Id: I3f10ff04338a405ad8de00e75e15dded4aaeed3b
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
To have a more "discoverable" UX, and cleaner UI (requiring private
QML API for now).
Change-Id: Ic275287d429149a1c353a1cbdc5b7f9b19e57410
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@digia.com>
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
| |
Change-Id: I5e2ab9f9119491f61033d8dd93059d0a54f3bc5b
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calling findText successively might prevent the previous pending
FindReply to be sent, which would leak the callback on the
application side.
This would cause a crash in qupzilla since we empty all pending
callbacks in the QWebEnginePage's destructor to catch this kind
of issue.
This also renames lastRequestId to nextRequestId to make it clear
that this is the ID generator for everything, including findText,
and that lastFindRequestId is only a tracker.
Change-Id: Ia78d553a58ed31af7237aad8772fa9828560c6d4
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
QJSValue is not a built-in QMetaType (it's ID is over 1024
[QMetaType::User]) and we can't get the QML type names from
the QML engine, so I hardcoded it in this test.
The check of the "void" is unnecessary, because that is
built-in: QMetaType::Void
Change-Id: I0d7668abedc8830b4bba39ff60bce644fe97888b
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
To allow the qt5.git integration, allow the build to succeed if the
repository is checked out on a platform that we don't maintain.
This is the initial list of platforms that we want the integration
to succeed and we can add new ones once we start maintaining them.
Change-Id: Idce2a84eb8d5b1ef7f14d399fe013f666b479108
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
Also update all the examples to use 1.0 as 0.9 shouldn't be
publically recommended.
Change-Id: Ic58e35bdfd3a0f3d5201fc069b7103027ba84574
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: Ic0de45c1fe2a5537d61ad446c96fe8fda7c30966
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
This is essential API that should be public.
Change-Id: Ifbd86171933936112e2495ebed074faa2e52464d
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|