summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSona Kurazyan <sona.kurazyan@qt.io>2022-05-02 10:58:48 +0200
committerSona Kurazyan <sona.kurazyan@qt.io>2022-05-02 19:13:47 +0200
commit02f4919c7fc11ad5c60e89404542c6a95a10d3e9 (patch)
treea62c05ae774083709dec2e62aeee7e13dd74fb4c
parent761ab6f3a27569562ae0d2708cd0819f7bdd1ce5 (diff)
Avoid extra copy in a ranged loop
This avoids: warning: loop variable ‘node’ creates a copy from type ‘const QPatternist::TargetNode’ [-Wrange-loop-construct] Task-number: QTBUG-102867 Change-Id: I46df9f502782991fe74b5260f86bead829c67cf6 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
-rw-r--r--src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp
index 22e6dd9b..c7abbfe5 100644
--- a/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp
+++ b/src/xmlpatterns/schema/qxsdvalidatinginstancereader.cpp
@@ -998,7 +998,7 @@ bool XsdValidatingInstanceReader::validateKeyIdentityConstraint(const XsdElement
return false;
// 4.2.3
- for (const TargetNode node : qualifiedNodeSet) {
+ for (const TargetNode &node : qualifiedNodeSet) {
const QVector<QXmlItem> fieldItems = node.fieldItems();
for (int i = 0; i < fieldItems.count(); ++i) {
const QXmlNodeModelIndex index = fieldItems.at(i).toNodeModelIndex();