summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederik Gladhorn <frederik.gladhorn@qt.io>2019-07-12 14:23:35 +0200
committerFrederik Gladhorn <frederik.gladhorn@qt.io>2019-07-12 14:30:27 +0200
commit07181e06b62134473a7b4086499ee5d02c4e50e1 (patch)
tree94cbf9519c57fa7a3dc18e98974187701e6deda8
parentb1d1393a090aeb0f2141a20fa320a163ce4c7239 (diff)
Fix state handling: integrating, staged and deferred must be closedv3.0-based
This is currently how we prevent making changes to them. Change-Id: I7ea146b66eb9f10a2936be89ffa943b71f1ef6c5
-rw-r--r--java/com/google/gerrit/reviewdb/client/Change.java12
1 files changed, 11 insertions, 1 deletions
diff --git a/java/com/google/gerrit/reviewdb/client/Change.java b/java/com/google/gerrit/reviewdb/client/Change.java
index b521fbc033..524478bbc6 100644
--- a/java/com/google/gerrit/reviewdb/client/Change.java
+++ b/java/com/google/gerrit/reviewdb/client/Change.java
@@ -703,8 +703,18 @@ public final class Change {
return getStatus().equals(Status.ABANDONED);
}
+ public boolean isIntegrating() {
+ return getStatus().equals(Status.INTEGRATING);
+ }
+ public boolean isStaged() {
+ return getStatus().equals(Status.STAGED);
+ }
+ public boolean isDeferred() {
+ return getStatus().equals(Status.DEFERRED);
+ }
+
public boolean isClosed() {
- return isAbandoned() || isMerged();
+ return isAbandoned() || isMerged() || isStaged() || isIntegrating() || isDeferred();
}
public String getTopic() {