summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJukka Jokiniva <jukka.jokiniva@qt.io>2022-06-06 11:45:49 +0300
committerJukka Jokiniva <jukka.jokiniva@qt.io>2022-06-08 09:54:13 +0000
commit86bdbbc48133b6ab07a44bef47a4785d504d7f09 (patch)
tree552c9745bd63b66e3c1740c717ca75966d7cae62
parent976bc2693d5e5ed83e9bd3745cc5614c18a296a4 (diff)
Fix issue of some changes not loadingv3.5.2-based
After v3.5.2 version update the changes that had once failed an integration were not loading. This was because qt gerrit plugin has been using TAG_REVERTED when adding comment messages to failed builds, and the new Gerrit version is expecting a certain message structure on the comment. Change-Id: I752c323d6de8be4bdd99d8408804091895e8aebb Reviewed-by: Toni Saario <toni.saario@qt.io>
-rw-r--r--polygerrit-ui/app/utils/message-util.ts11
1 files changed, 8 insertions, 3 deletions
diff --git a/polygerrit-ui/app/utils/message-util.ts b/polygerrit-ui/app/utils/message-util.ts
index 70dd286a71..7c236afed9 100644
--- a/polygerrit-ui/app/utils/message-util.ts
+++ b/polygerrit-ui/app/utils/message-util.ts
@@ -26,7 +26,12 @@ function getRevertChangeIdFromMessage(msg: ChangeMessageInfo): ChangeId {
}
export function getRevertCreatedChangeIds(messages: ChangeMessageInfo[]) {
- return messages
- .filter(m => m.tag === MessageTag.TAG_REVERT)
- .map(m => getRevertChangeIdFromMessage(m));
+ try {
+ return messages
+ .filter(m => m.tag === MessageTag.TAG_REVERT)
+ .map(m => getRevertChangeIdFromMessage(m));
+ }
+ catch(err) {
+ return [];
+ }
}