diff options
| author | Ben Rohlfs <brohlfs@google.com> | 2020-11-09 13:43:49 +0100 |
|---|---|---|
| committer | Luca Milanesio <luca.milanesio@gmail.com> | 2020-11-12 00:23:40 +0000 |
| commit | 00a62ba7fb668bbc3a23575eb1b6e0fcf3af43ee (patch) | |
| tree | eae40877bbdd88fe192b240d5a2a45e403c2e2da | |
| parent | 0f0749164a3f06ad73494da53b90b9ed24b80ae4 (diff) | |
Fix showing "Add Patchset Description" for users that are not logged in
This was detected by screenshot testing and is a small bug that was
introduced by TypeScript migration. file-list-header was converted in
change 279621, but the bug probably only surfaced when gr-change-view
changed the account from {} to undefined.
Change-Id: Iad9167810c8cbf9e95b858a4225b9ee5343b3946
(cherry picked from commit 2f19f1f0c10fe3acc565d1f1e273261b7c461030)
| -rw-r--r-- | polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.ts | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.ts b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.ts index e37dc6b7b1..b86dd90271 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.ts +++ b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.ts @@ -171,13 +171,12 @@ export class GrFileListHeader extends KeyboardShortcutMixin( @computed('loggedIn', 'change', 'account') get _descriptionReadOnly(): boolean { - // Polymer 2: check for undefined if ( this.loggedIn === undefined || this.change === undefined || this.account === undefined ) { - return false; + return true; } return !( |