summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMilutin Kristofic <milutin@google.com>2021-10-21 20:55:05 +0200
committerMilutin Kristofic <milutin@google.com>2021-10-21 20:55:05 +0200
commit7e65e999b90bb5b5493979bff6205501b18986dd (patch)
tree52f837f4a2000375f70c1bccb6b37cf63243f69d
parent7e4d3ff70430a8582b3dabe605f387f5168029fe (diff)
Submit Requirements - show only non legacy requirements
when there is at least one non legacy requirement. Change-Id: I1eeadf839087a9e01f246d0e53005d9f5b96aa21
-rw-r--r--polygerrit-ui/app/api/rest-api.ts1
-rw-r--r--polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts11
2 files changed, 11 insertions, 1 deletions
diff --git a/polygerrit-ui/app/api/rest-api.ts b/polygerrit-ui/app/api/rest-api.ts
index f86e8250d6..39b40b61d8 100644
--- a/polygerrit-ui/app/api/rest-api.ts
+++ b/polygerrit-ui/app/api/rest-api.ts
@@ -1081,6 +1081,7 @@ export declare interface SubmitRequirementResultInfo {
applicability_expression_result?: SubmitRequirementExpressionInfo;
submittability_expression_result: SubmitRequirementExpressionInfo;
override_expression_result?: SubmitRequirementExpressionInfo;
+ is_legacy?: boolean;
}
/**
diff --git a/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts b/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts
index c493be48c0..e8859fd2f9 100644
--- a/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts
+++ b/polygerrit-ui/app/elements/change/gr-submit-requirements/gr-submit-requirements.ts
@@ -132,10 +132,19 @@ export class GrSubmitRequirements extends LitElement {
}
override render() {
- const submit_requirements = orderSubmitRequirements(
+ let submit_requirements = orderSubmitRequirements(
this.change?.submit_requirements ?? []
).filter(req => req.status !== SubmitRequirementStatus.NOT_APPLICABLE);
+ const hasNonLegacyRequirements = submit_requirements.some(
+ req => req.is_legacy === false
+ );
+ if (hasNonLegacyRequirements) {
+ submit_requirements = submit_requirements.filter(
+ req => req.is_legacy === false
+ );
+ }
+
return html` <h3
class="metadata-title heading-3"
id="submit-requirements-caption"