summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Wicking <paul.wicking@qt.io>2018-12-18 17:32:42 +0100
committerJukka Jokiniva <jukka.jokiniva@qt.io>2019-03-20 12:31:29 +0200
commit8a4fcd2c3ecce27ec970f2c318aef20a1425dae1 (patch)
tree97027b514b75e0d342387764dc67168f487867ec
parent5546ab5048a7a805dd4a4fc25afde843a163ca4a (diff)
Fix warnings when compiling with error_prone_warnings_toolchain
bazel build --java_toolchain //tools:error_prone_warnings_toolchain gerrit Produces warnings that not all enum values are handled in these functions. While these are not critical, we might as well be low on warnings. Change-Id: I08a06bf3c4dd3558c6fc95b23cc7ab58b9682480 Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
-rw-r--r--java/com/google/gerrit/common/PageLinks.java10
1 files changed, 10 insertions, 0 deletions
diff --git a/java/com/google/gerrit/common/PageLinks.java b/java/com/google/gerrit/common/PageLinks.java
index 97e7ff3312..4a213bc88f 100644
--- a/java/com/google/gerrit/common/PageLinks.java
+++ b/java/com/google/gerrit/common/PageLinks.java
@@ -141,11 +141,15 @@ public class PageLinks {
public static String topicQuery(Status status, String topic) {
switch (status) {
case ABANDONED:
+ case DEFERRED:
return toChangeQuery(status(status) + " " + op("topic", topic));
case MERGED:
case NEW:
return toChangeQuery(
op("topic", topic) + " (" + status(Status.NEW) + " OR " + status(Status.MERGED) + ")");
+ case INTEGRATING:
+ case STAGED:
+ return toChangeQuery(status(status) + " " + op("topic", topic));
}
return toChangeQuery(status(status) + " " + op("topic", topic));
}
@@ -168,6 +172,12 @@ public class PageLinks {
return "status:abandoned";
case MERGED:
return "status:merged";
+ case INTEGRATING:
+ return "status:integrating";
+ case DEFERRED:
+ return "status:deferred";
+ case STAGED:
+ return "status:staged";
case NEW:
default:
return "status:open";