summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomas Ljunggren <tomas.ljunggren@tieto.com>2011-12-05 12:49:24 +0100
committerTomas Ljunggren <tomas.ljunggren@tieto.com>2011-12-05 12:49:36 +0100
commited22fedfa0d6b6a6ecfcb32e1f4968a21ea17d85 (patch)
tree2275e08512b53d0ed7b0f53387086210fc01d29e
parent844898789e93361a3bcaf966a783bd80b601248d (diff)
parent8ad9feb199bc3ae808438422734fa2da96b2731e (diff)
Merged correction into integration
Merged 'origin/corrections/qtqainfra-389' into integration/v2.2.1 Change-Id: I78b3bd9af2c68adc4bb2acc6f764e2da3025470a
-rw-r--r--gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java7
-rw-r--r--gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java3
2 files changed, 6 insertions, 4 deletions
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
index 65c1e88146..f1e2b08454 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
@@ -683,7 +683,12 @@ public class ChangeUtil {
final Change.Id changeId = patchSetId.getParentKey();
AtomicUpdate<Change> atomicUpdate =
getUpdateToState(Change.Status.INTEGRATING, Change.Status.MERGED);
- db.changes().atomicUpdate(changeId, atomicUpdate);
+ Change change = db.changes().atomicUpdate(changeId, atomicUpdate);
+ List<PatchSetApproval> approvals = db.patchSetApprovals().byChange(changeId).toList();
+ for (PatchSetApproval a : approvals) {
+ a.cache(change);
+ }
+ db.patchSetApprovals().update(approvals);
}
/**
diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java
index e3d984601b..8167d713bc 100644
--- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java
+++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/StagingApprove.java
@@ -232,9 +232,6 @@ public class StagingApprove extends BaseCommand {
throw e;
}
- for (PatchSet patch : toApprove) {
- ChangeUtil.submit(patch.getId(), currentUser, db, opFactory, merger);
- }
// Rebuild staging branch.
ChangeUtil.rebuildStaging(destination, currentUser, db, git, opFactory,
merger, hooks);