summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomas Daarstad <tomas.daarstad@tieto.com>2012-03-28 09:20:46 +0200
committerTomas Daarstad <tomas.daarstad@tieto.com>2012-03-28 09:21:25 +0200
commitfc1d35bc50f20d7bd0be5bd58e8e329b8451b197 (patch)
treea699c82bc538b76d6fd73cbe4adc16fa87e5b78a
parentc8d26cd439c9e917109f683a8792541c78e1deaa (diff)
parent07d98aee2b9f61cdd34d9cc340e3fb4e2e90aed6 (diff)
Integration release of NQt GerritRC-V2.2.1-INT-015
Fixed JIRA issues: 167 Fixed gerrit email verification link requires insecure login 195 Added support for European style dates 220 Added a check to prevent NumberFormatException 270 Fixed review database update from StagingApprove 335 Fixed automatic update of reviewer list 340 Don't send mail for publishing comments for stage approved 347 Fixed late removal of review approvals 348 Fixed cherry pick footer settings 350 Consider sanity review column 352 Fix typo in project config's topic review checkbox label 355 Hide review panel also on diff and topic pages 366 Disable stage and submit button for changes included in topics 372 Validate topic current change set 375 Topic permalink copy to clipboard corrected 381 Do not permit trailing slash when pushing 382 Integration release of NQt Gerrit 382 Added a check to prevent NullPointerException Added a check to prevent ArrayIndexOutOfBoundsException 385 Keep highlight on review request 389 Set patch approval changeOpen to false 411 Updated to use current patch id in loadFileList method. 456 Remove leading and trailing whitespace in username when creating a request 462 Updated for eclipse 3.7, m2e and fixed the full name of the MAVEN2_CLASSPATH_CONTAINER 468 Fixed the Review score put on wrong change Change-Id: Id4b45a40e587e32ad3a6abfc0256d9759c9f1661
-rw-r--r--gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java12
1 files changed, 12 insertions, 0 deletions
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java
index 6906cea16d..d1249e9c97 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/PatchSetComplexDisclosurePanel.java
@@ -199,6 +199,12 @@ class PatchSetComplexDisclosurePanel extends CommonComplexDisclosurePanel {
if (isNew && changeDetail.canStage()) {
// Create button new button and add click handler.
final Button stagingButton = new Button(Util.M.mergeToStagingPatchSet(detail.getPatchSet().getPatchSetId()));
+
+ // If the change is included in a topic, the button should be disabled
+ if(changeDetail.getChange().getTopicId() != null){
+ stagingButton.setEnabled(false);
+ }
+
stagingButton.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {
@@ -227,6 +233,12 @@ class PatchSetComplexDisclosurePanel extends CommonComplexDisclosurePanel {
final Button b =
new Button(Util.M
.submitPatchSet(detail.getPatchSet().getPatchSetId()));
+
+ // If the change is included in a topic, the button should be disabled
+ if(changeDetail.getChange().getTopicId() != null ){
+ b.setEnabled(false);
+ }
+
b.addClickHandler(new ClickHandler() {
@Override
public void onClick(final ClickEvent event) {