summaryrefslogtreecommitdiffstats
path: root/gerrit-prettify
diff options
context:
space:
mode:
authorShawn O. Pearce <sop@google.com>2010-02-13 10:37:16 -0800
committerShawn O. Pearce <sop@google.com>2010-02-13 10:37:16 -0800
commit45442f8782b66d187a03bb5aae37d27086e51bcb (patch)
treed50524b2d6839db594cc508c1a04241885347a8b /gerrit-prettify
parent6f7f748231a1fbcbe4f04c085bee5443758d6c48 (diff)
Disable syntax highlighting on unified views
Because we can't use background colors to denote added or removed lines in the unified patch view, turn off syntax highlighting so we can color the text of added lines green and deleted lines red. Bug: issue 448 Change-Id: I994758b93e4f8b5633cd61c13911280c0bd7aafa Signed-off-by: Shawn O. Pearce <sop@google.com>
Diffstat (limited to 'gerrit-prettify')
-rw-r--r--gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettyFormatter.java8
-rw-r--r--gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettySettings.java11
2 files changed, 18 insertions, 1 deletions
diff --git a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettyFormatter.java b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettyFormatter.java
index 6b726fb0c3..27273a3298 100644
--- a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettyFormatter.java
+++ b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettyFormatter.java
@@ -114,7 +114,13 @@ public abstract class PrettyFormatter {
settings = how;
lines = new ArrayList<String>();
- String html = prettify(toHTML(srcText));
+ String html = toHTML(srcText);
+ if (settings.isSyntaxHighlighting()) {
+ html = prettify(html);
+ } else {
+ html = html.replaceAll("\n", "<br />");
+ }
+
int pos = 0;
int textChunkStart = 0;
diff --git a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettySettings.java b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettySettings.java
index 1608e0ec10..657021c16d 100644
--- a/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettySettings.java
+++ b/gerrit-prettify/src/main/java/com/google/gerrit/prettify/common/PrettySettings.java
@@ -21,12 +21,14 @@ public class PrettySettings {
protected int lineLength;
protected int tabSize;
protected boolean showTabs;
+ protected boolean syntaxHighlighting;
public PrettySettings() {
showWhiteSpaceErrors = true;
lineLength = 100;
tabSize = 2;
showTabs = true;
+ syntaxHighlighting = true;
}
public PrettySettings(PrettySettings pretty) {
@@ -35,6 +37,7 @@ public class PrettySettings {
lineLength = pretty.lineLength;
tabSize = pretty.tabSize;
showTabs = pretty.showTabs;
+ syntaxHighlighting = pretty.syntaxHighlighting;
}
public String getFilename() {
@@ -81,4 +84,12 @@ public class PrettySettings {
showTabs = show;
return this;
}
+
+ public boolean isSyntaxHighlighting() {
+ return syntaxHighlighting;
+ }
+
+ public void setSyntaxHighlighting(final boolean on) {
+ syntaxHighlighting = on;
+ }
}