diff options
| author | Edwin Kempin <ekempin@google.com> | 2023-04-03 12:50:59 +0000 |
|---|---|---|
| committer | Edwin Kempin <ekempin@google.com> | 2023-04-03 14:05:40 +0000 |
| commit | 6a32efa0598400631d1ba0a2cf8160b987db79f7 (patch) | |
| tree | ff6a0f72c7fbf61c2e8f68e9750e9319c321ada9 /version.bzl | |
| parent | f857e2cd9da9fd31da12a920965eab903ddecdbe (diff) | |
Fix rebasing chain when a checks refs exists for one of the changes
PatchSetUtil#getCurrentRevCommitIncludingPending had the wrong
assumption that a change only has:
* a change meta ref (ref/changes/<sharded-change-id>/meta)
* patch set refs (ref/changes/<sharded-change-id>/<patch-set-num>)
from which it's possible to parse a patch set number
If there are other change refs, e.g. a checks ref
(ref/changes/<sharded-change-id>/checks),
PatchSetUtil#getCurrentRevCommitIncludingPending failed with a
NullPointerException. That's because for all non-meta change refs it
tries to parse a patch set number from the ref, but it didn't expect
that the patch set number can be null if it's not a patch set ref (see
PatchSet.Id#fromRef).
Fix this by filtering out null patch set numbers.
Bug: Google b/276709753
Release-Notes: Fixed rebasing chain when a checks refs exists for one of the changes
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I47287d898112e9e2680c8738040ef1f05e173b8e
Diffstat (limited to 'version.bzl')
0 files changed, 0 insertions, 0 deletions