| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: I49a7fc97fd6d4f199c25774faa50ec4a826ae64a
|
|
|
|
| |
Change-Id: I08dc590bb1f62af67d88eb11313d5d4cfe2423c4
|
|
|
|
|
|
|
|
|
| |
It is wrong to include the servlet API in a WAR's WEB-INF/lib
directory. This confuses some servlet containers who refuse to
load the Gerrit WAR. Instead package the Jetty runtime and the
servlet API in a new WEB-INF/pgm-lib directory.
Change-Id: Ic5fe14c735e781b2d78d2fa8d0d403a08b7ee21f
|
|
|
|
|
| |
Bug: issue 1619
Change-Id: Ica04d0c19306da9afcadf3919581632f7df93483
|
|
|
|
|
| |
Change-Id: I4fb8cb41250c5b640a8d9e47caf97dc4670ff428
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eclipse overwrites these files when we import projects using m2e.
Eclipse 3 writes a timestamp at the top of these files making the Git
working tree dirty. Eclipse 4 (Juno) still overwrites these files but
doesn't write the timestamp. This should help keeping the working tree
clean. However, since the timestamp is currently present in these
files, Eclispe 4 would still make them dirty by overwriting and
effectively removing the timestamp.
This change removes the timestamp from these files. This help those
using Eclipse 4 and doesn't make it worse for those still using Eclispe
3.
Change-Id: Ic23299a12ac80f7294bcc602c8565889069a0d10
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unless a plugin declares "Gerrit-ApiType: plugin" in its manifest,
assume it is an extension and only make the gerrit-extension-api
available to it through the ClassLoader.
For non-plugins, do not make any Guice bindings available from the
server. This further restricts what an extension can see and do with
the system internals.
Change-Id: Ia38336c42786afb1419d64c06b0d908ae92a64d1
|
|
|
|
|
|
|
|
|
| |
Instead of unpacking a running server into ~/.gerritcodereview/tmp
only use that location for commands like init where there is no active
site. From gerrit.sh always use $site_path/tmp for the JARs to isolate
servers that run on the same host under the same UNIX user account.
Change-Id: I688490ffbbf70312767bb766dc7ccbea52401ad1
|
|
|
|
| |
Change-Id: Ie948a1b3c9df95e79fc09ef343d0d49ff3b267c2
|
|
|
|
|
| |
Change-Id: I3b2f0f532fc10b98657de117c80113fe0eac3bc4
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
|
|
|
|
|
|
|
|
| |
The 2.3 was released and what we have in the master branch
is targeted for 2.4.
Change-Id: Idca8a12aaef1dc5ea5f628b3640881e66f04dc9c
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
|
|
|
|
| |
Change-Id: I6f54a783959c58fb75114251e07a6871bc889904
|
|
|
|
| |
Change-Id: Ie70c285440b6200ad7f4dd8dea8a97317e1e62fc
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the order they are inserted onto the classpath depends on
directory iteration order of the WEB-INF directory at war-file
building time. On some filesystems that is alphabetical, and on some
filesystems, it is completely arbitrary. On the second kind of
filesystem, gerrit-patch-jgit can randomly end up on the classpath
*after* jgit itself, thus causing it to not be loaded.
Change-Id: I4ee9b22cbb93405e033f6f6bda9da1dd87b3419f
|
|
|
|
| |
Change-Id: Ic0f134719769e3d8b8cfb6f70703f9a61fcd2538
|
|
|
|
|
|
|
|
|
|
| |
Since Prolog isn't the most popular language, define a small
interactive interpreter that users or site administartors can play
around with by downloading the Gerrit WAR file and executing:
java -jar gerrit.war prolog-shell
Change-Id: I0474b59e6ace24e6e6bfda58f574add3b2bf79e0
|
|
|
|
|
| |
Change-Id: I1d3e6c42bc678536162a81d2b13372659a1c3dec
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
|
|
|
|
|
| |
I meant to keep reusing the 2.1 version number for the entire
2.1 series during development, but botched it during the 2.1.4
development cycle and set it to 2.1.4-SNAPSHOT by mistake. Put
it back to 2.1-SNAPSHOT since 2.1.4 is released.
Change-Id: I37e206c0609bf3fd94a5aab8ea301c98b7fb013e
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
| |
Change-Id: I71719c85b0d50707333517b8ef956853b04efa14
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
| |
Change-Id: I93386d5b71e8361219c03d95ab7476dc46e7d6b0
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
|
|
|
|
| |
Since some systems have a /tmp autocleaner, we don't want to trust
our gitweb configuration file to stay there. Instead keep it with
the extracted WARs inside of our own private temporary location.
Change-Id: I5f4dea46a755bf3296f15ae38361452fe8df6655
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On case insensitive filesystems like Mac OS X's HFS+ or Windows NTFS
if Gerrit is started out of the classes directory through an IDE
debugger we would find "daemon.class" on disk and try to load it,
but the JVM refuses because "daemon" is not the actual class name,
its "Daemon". Meanwhile running out of a JAR or on Linux always
works, because the JAR and ext2/3/4 are case sensitive.
Flip the order of operations around and try the Titlecase form of
the command name first. Its more likely going to be a match for
a Java classname, since developers name classes in CamelCaseFormat.
Bug: issue 490
Change-Id: I43a487eb0d5d528ac370e1794a4542e412236307
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
|
|
|
|
| |
This class used to be in the default package (and thus had no
package statement), but then we moved it into a package and Eclipse
inserted the package statement before our standard copyright header.
Change-Id: I342e8d6466a7a9b1b466f8f971df7598448038c8
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
| |
Change-Id: I5a69e2b7a3e64664f0ca32649d153cb8cde27b27
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
|
|
|
| |
Change-Id: Ic864f71b0899af24334c76b8558c2757a2f79750
Signed-off-by: Shawn O. Pearce <sop@google.com>
|
|
To run Gerrit Code Review we require Java 6, because our class
files are compiled against the Java 6 SDK, use methods from it,
and are in the Java 6 bytecode file format. We cannot run on a
JRE that predates the Java 6 specification.
Rather than giving users who are trying to run us on an outdated
virutal machine an obtuse stack trace like the following:
Exception in thread "main" java.lang.UnsupportedClassVersionError:
Bad version number in .class file
at java.lang.ClassLoader.defineClass1(Native Method)
...
we should give them a specific message describing the problem,
and our minimum version requirement.
To get a custom error message we compile our Main springboard class
in Java 1.2 format, against only APIs that are available since Java
1.2, and we check the specification of our runtime to verify it can
support us. This allows us to execute on a really old JRE and at
least report a descriptive error message.
In order to use Java 6 APIs in GerritLauncher we had to move it
to its own Maven component, where the runtime environment is still
described as Java 6.
Change-Id: I47bfcfb5076427d491c896a2815dd091ca205bfc
Signed-off-by: Shawn O. Pearce <sop@google.com>
|