aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Jenssen <tim.jenssen@qt.io>2023-01-25 15:38:18 +0100
committerTim Jenssen <tim.jenssen@qt.io>2023-01-25 14:51:04 +0000
commit239e94aff8de7e53bae5fceded40514f043db239 (patch)
treefd953dddb2ec39f98e996adb477b408bc84d6956
parenta486e2c0e26e77cad4f49c6db62eef045eb170c6 (diff)
dum_debug_infos.py: improve error output
Change-Id: I30bc1675f66b3f11c2291c705cb48ef98f5c9271 Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
-rw-r--r--packaging-tools/dump_debug_infos.py15
1 files changed, 12 insertions, 3 deletions
diff --git a/packaging-tools/dump_debug_infos.py b/packaging-tools/dump_debug_infos.py
index 6b40df3a0..0c1b635ee 100644
--- a/packaging-tools/dump_debug_infos.py
+++ b/packaging-tools/dump_debug_infos.py
@@ -76,10 +76,19 @@ def dump_sym(dump_syms_path: str, architecture: str, absolute_path: str, sym_pat
dump_syms_command = f'{dump_syms_path} {architecture} "{absolute_path}" > "{sym_path}"'
if verbose:
log.info("call: %s", dump_syms_command)
- dump_syms_return = subprocess.call(dump_syms_command, shell=True)
- if os.path.exists(sym_path) and os.stat(sym_path).st_size > 0 and dump_syms_return == 0:
+ dump_syms_result = subprocess.run(dump_syms_command,
+ shell=True,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT,
+ text=True)
+ if os.path.exists(sym_path) and os.stat(sym_path).st_size > 0 and dump_syms_result.returncode == 0:
return True
- raise Exception(f"dump_syms can not be called: \n{dump_syms_command}\n{dump_syms_return}")
+ raise Exception(
+ f"dump_syms can not be called:"
+ f"\n{dump_syms_command}"
+ f"\nreturncode: {dump_syms_result.returncode}"
+ f"\noutput: {dump_syms_result.stdout}"
+ )
def dump_syms(