release_task_reader.py: fix offline task validation issue

Offline tasks settings do not include 'repo_path'.

Change-Id: Icb8154cbc16ac5f254f1d2fbb4389baed920da2c
Reviewed-by: Patrik Teivonen <patrik.teivonen@qt.io>
Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>

2 files changed, 12 insertions, 2 deletions

diff --git a/packaging-tools/release_task_reader.py b/packaging-tools/release_task_reader.py
index 66768bcc0..de7d3a196 100755
--- a/packaging-tools/release_task_reader.py
+++ b/packaging-tools/release_task_reader.py
@@ -193,7 +193,10 @@ class IFWReleaseTask(ReleaseTask):
         self._source_online_repository_path = value
 
     def validate(self) -> None:
-        for item in ["repo_path", "config_file"]:
+        validate_list = ["config_file", "repo_path"]
+        if "ifw.offline" in self.name:
+            validate_list.remove("repo_path")
+        for item in validate_list:
             if not self._key_exists(item):
                 raise ReleaseTaskError(f"Value invalid or missing: {item}")
 
diff --git a/packaging-tools/tests/test_release_task_reader.py b/packaging-tools/tests/test_release_task_reader.py
index 8ad039945..ba9ba12f4 100755
--- a/packaging-tools/tests/test_release_task_reader.py
+++ b/packaging-tools/tests/test_release_task_reader.py
@@ -81,7 +81,14 @@ class TestReleaseTaskReader(unittest.TestCase):
         """, ["deb,linux"], TaskType.DEB_TASK_TYPE, True),
         ("""
             [task.deb.repository.linux.x64]
-        """, ["deb"], TaskType.DEB_TASK_TYPE, False)
+        """, ["deb"], TaskType.DEB_TASK_TYPE, False),
+        ("""
+            [task.ifw.offline.linux.x64.no_config_file]
+        """, ["ifw,offline"], TaskType.IFW_TASK_TYPE, False),
+        ("""
+            [task.ifw.offline.linux.x64]
+            config_file:  foobar-file-repository
+        """, ["ifw,offline"], TaskType.IFW_TASK_TYPE, True)
     )
     @unpack  # type: ignore
     def test_release_task_validity(