pylint: Remove unnecessary bits of code

Enable pylint checks, and fix the following anti-patterns:
- superfluous-parens
- no-else-return, no-else-raise, no-else-break, no-else-continue
- unnecessary-comprehension
- pointless-statement, pointless-string-statement
- unnecessary-pass, useless-return
- unused-variable, unused-argument
- useless-object-inheritance
- condition-evals-to-constant
- simplifiable-if-expression
- redundant-unittest-assert
Requires to be submitted with the following change in tqtc-qtsdk:
251649c633eb7acc417cf88fd1c7f885e2bccd7b

Change-Id: I3dd50a7030e06565ae6c04d0a0e3aa07bc68218f
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>

1 files changed, 2 insertions, 3 deletions

diff --git a/packaging-tools/bld_module.py b/packaging-tools/bld_module.py
index 8638583fc..b2197875a 100755
--- a/packaging-tools/bld_module.py
+++ b/packaging-tools/bld_module.py
@@ -80,7 +80,7 @@ def patch_archive(base_dir, search_strings, qt_install_prefix):
 ###############################
 def get_qt_install_prefix(qt_path):
     cmd_args = [os.path.join(qt_path, 'bin', 'qmake'), '-query', 'QT_INSTALL_PREFIX']
-    ret, qt_install_prefix = do_execute_sub_process(cmd_args, qt_path, get_output=True)
+    _, qt_install_prefix = do_execute_sub_process(cmd_args, qt_path, get_output=True)
     return qt_install_prefix.strip()
 
 
@@ -308,8 +308,7 @@ else:  # --> qmake
         generateCommand.append(os.environ["EXTRA_QMAKE_ARGS"])
     generateCommand.append(qtModuleProFile)
 
-runCommand(generateCommand, currentWorkingDirectory=qtModuleBuildDirectory,
-           callerArguments=callerArguments, extra_environment=environment)
+runCommand(generateCommand, currentWorkingDirectory=qtModuleBuildDirectory, extra_environment=environment)
 
 ret = runBuildCommand(currentWorkingDirectory=qtModuleBuildDirectory, callerArguments=callerArguments)
 if ret: