aboutsummaryrefslogtreecommitdiffstats
path: root/packaging-tools/send_header_diff_kmail.py
Commit message (Collapse)AuthorAgeFilesLines
* Refactor runner.py functionsPatrik Teivonen2022-11-011-2/+2
| | | | | | | | | Rewrite runner.py Follow up patch: run_command from bld_utils.py Requires following patch in 6cc08ee72a7eb1860bb2f982879ff71c6dda2e10 Change-Id: I984046f56d4faac8ac58f12d0dad07d7bae4b0a2 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* Revert "Revert "Use logging functions from logging_util.py""Antti Kokko2022-10-261-3/+7
| | | | | | | | | | This reverts commit 64b709d4b422e6d59f9e703fbc1124dd3f77d556. Reason for revert: required dependent changes are done, we can bring this change back Change-Id: I1692b433eda3fd2a1e5aa541785dae942cbd1665 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
* Revert "Use logging functions from logging_util.py"Antti Kokko2022-10-191-7/+3
| | | | | | | | | This reverts commit bd38f3c2897c3f82f8c10464f70ed301c618dae7. Reason for revert: temporarily revert due to colorlog import issues Change-Id: I8e47743780c8998580ca40de56cbe0d0b5f49504 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* Use logging functions from logging_util.pyPatrik Teivonen2022-10-181-3/+7
| | | | | | | | | | | | | -Remove inconsistent print function/logging module usage across scripts -Initialize logger from logging_util.py -Use CI friendly format in logging to stdout -Log file format with extra debug information (script, line, process) -Remove rainbow_logging_handler in favor of colorlog -Remove unnecessary print/log functions from unit tests -Remove unnecessary whitespace in logging messages Change-Id: Ib913cf2f6a2b02e06628f94dceeeaf845191b96b Reviewed-by: Antti Kokko <antti.kokko@qt.io>
* Add missing type hints, enable strict mypy checkingPatrik Teivonen2022-09-221-1/+1
| | | | | | | | Enable --strict parameter in mypy. Add missing type hints and resolve remaining type errors. Change-Id: Id9547cc3351b88729930c577d4ed628780c1447b Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* pylint: Add checking for PEP8 naming style conventions (C0103)Patrik Teivonen2022-09-081-4/+4
| | | | | | | | | | Enable checking for invalid-name C0103 in pylint. Change all remaining names to be PEP8 compliant. Ignore false positive constants. Note: patch renames some python modules Change-Id: I6ddd338e3ed260280e5fd9b356406603b8cc3ccc Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* Reduce use of module globals by wrapping code outside functions in mainPatrik Teivonen2022-09-061-1/+6
| | | | | | | | | | | -Move code from module scope to main() functions where it makes sense -Pass module variables as arguments to functions that used them Linters will complain about naming clashes in outer scope if same name is used in a function. Change-Id: I1319cf1632f94907ee918e6f7593c79b0909e48b Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* pylint: Add string formatting checks, use f-string and lazy % formattingPatrik Teivonen2022-08-161-2/+2
| | | | | | | | | | | Enable following checks in pylint: - C0209: Formatting a regular string which could be a f-string - W1202: Use lazy % formatting in logging functions - W1203: Use lazy % formatting in logging functions Use f-string for string formatting where recommended and lazy % formatting in logging. Change-Id: I14924d27e0f800c47af1ec903be4c51f24191d26 Reviewed-by: Antti Kokko <antti.kokko@qt.io>
* Make imports consistent across Python scripts, isort hookv6.4.0-beta3-packagingPatrik Teivonen2022-08-051-2/+2
| | | | | | | | | | | | | | | | | | -Add isort to Pipfile, isort hook with blackformatter profile -Fix imports in unittest hook -Group and sort imports by their category (PEP8) -Blank line between import groups (PEP8) -Move all imports to toplevel (PEP8) -Don't unnecessarily append to sys.path (PEP8) -Import only required functions (this also helps reduce line length) -Update deprecated imports such as builtins.WindowsError, ConfigParser.readfp -Remove Python 2, cyclic and unused imports -Fix platform dependent imports and remove unnecessaty try-excepts -Remove unnecessary comments before imports, use in-line comments when needed -Rename conflicting functions in imports, variables as absolute imports are recommended (PEP8) Change-Id: I5ac7a3499ea47a6bdc9a9a2b5211841f65c011ea Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
* PEP8: Blank lines in function and class definitions, file endPatrik Teivonen2022-07-111-0/+1
| | | | | | | | | | | | | | Correct the amount of lines in function and class definitions as well as at the end of the file. Enable following flake8 checks: - E301 Expected 1 blank line, found 0 - E302 Expected 2 blank lines, found 0 - E303 Too many blank lines - E305 Expected 2 blank lines after end of function or class - E306 Expected 1 blank line before a nested definition - W391 Blank line at end of file Change-Id: Ia9bb511ded47df1f43bfffa4be00abfdbda60cae Reviewed-by: Akseli Salovaara <akseli.salovaara@qt.io>
* PEP8 compliant copyright headers in Python scriptsv6.4.0-beta2-packagingPatrik Teivonen2022-07-071-49/+49
| | | | | | | | | | | | | -Update year and license header -Update header formatting to match others in send_header_diff_kmail.py -Change "## " to "# " in license headers to make them PEP8 compliant. -Reference: https://peps.python.org/pep-0008/#block-comments -flake8 rule descriptions and codes: -Block comment should start with '# ' (E265) -Too many leading '#' for block comment (E266) Change-Id: Ife039694462e9908bc22ab253ba3202c7245a7a3 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* Update shebang, year in copyright noticePatrik Teivonen2022-04-111-1/+2
| | | | | | | | Change current year for copyright statement and use Python 3 shebang in Python 3 scripts with consistent style. Change-Id: I61983c80cd09d0a8a4b458ac1ae5a72ccd2d1ce2 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
* Add script to send the header diffs using kmailFrederik Gladhorn2016-02-121-0/+87
The main point is to use the message id so that all mails will end up in the same thread. Change-Id: Ia84724948ac2ce11e97e1eed53576bf577b0cbcf Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@theqtcompany.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-25 00:23:34 +0000