diff options
author | Tobias Hunger <tobias.hunger@qt.io> | 2018-05-07 14:58:16 +0200 |
---|---|---|
committer | Tobias Hunger <tobias.hunger@qt.io> | 2018-05-07 13:38:34 +0000 |
commit | dee02070349682286d385cb5c00ca61478cc44ca (patch) | |
tree | 1aed16163b25415affbafd512d23b03a1cc8437c | |
parent | 91c19ab19d17a332cb5c880bede5ed4462085978 (diff) |
ProjectExplorer: Use override consistently
clang-tidy fixes from modernize-use-override check.
Change-Id: I216701aec0b4134321e220f9e599e053a8e22945
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
-rw-r--r-- | src/plugins/projectexplorer/buildconfiguration.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/buildstep.h | 8 | ||||
-rw-r--r-- | src/plugins/projectexplorer/buildsteplist.h | 4 | ||||
-rw-r--r-- | src/plugins/projectexplorer/clangparser.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/customwizard/customwizard.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/devicesupport/idevicefactory.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/extracompiler.h | 4 | ||||
-rw-r--r-- | src/plugins/projectexplorer/gcctoolchain.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/kitinformation.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/projectconfiguration.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/projectimporter.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/projecttree.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/projectwindow.h | 2 | ||||
-rw-r--r-- | src/plugins/projectexplorer/toolchain.h | 2 |
14 files changed, 19 insertions, 19 deletions
diff --git a/src/plugins/projectexplorer/buildconfiguration.h b/src/plugins/projectexplorer/buildconfiguration.h index 46cc6f35ec..b720e204ed 100644 --- a/src/plugins/projectexplorer/buildconfiguration.h +++ b/src/plugins/projectexplorer/buildconfiguration.h @@ -122,7 +122,7 @@ class PROJECTEXPLORER_EXPORT IBuildConfigurationFactory : public QObject protected: IBuildConfigurationFactory(); - ~IBuildConfigurationFactory(); + ~IBuildConfigurationFactory() override; public: // The priority is negative if this factory can not create anything for the target. diff --git a/src/plugins/projectexplorer/buildstep.h b/src/plugins/projectexplorer/buildstep.h index 7a0f6db92a..840e31ee21 100644 --- a/src/plugins/projectexplorer/buildstep.h +++ b/src/plugins/projectexplorer/buildstep.h @@ -124,7 +124,7 @@ class PROJECTEXPLORER_EXPORT BuildStepFactory : public QObject public: BuildStepFactory(); - ~BuildStepFactory(); + ~BuildStepFactory() override; static const QList<BuildStepFactory *> allBuildStepFactories(); @@ -191,9 +191,9 @@ public: this, &BuildStepConfigWidget::updateSummary); } - QString summaryText() const { return QLatin1String("<b>") + displayName() + QLatin1String("</b>"); } - QString displayName() const { return m_step->displayName(); } - bool showWidget() const { return false; } + QString summaryText() const override { return QLatin1String("<b>") + displayName() + QLatin1String("</b>"); } + QString displayName() const override { return m_step->displayName(); } + bool showWidget() const override { return false; } BuildStep *step() const { return m_step; } private: diff --git a/src/plugins/projectexplorer/buildsteplist.h b/src/plugins/projectexplorer/buildsteplist.h index 80ef5e5310..9100051577 100644 --- a/src/plugins/projectexplorer/buildsteplist.h +++ b/src/plugins/projectexplorer/buildsteplist.h @@ -81,8 +81,8 @@ public: Target *target() const; Project *project() const override; - virtual QVariantMap toMap() const override; - virtual bool fromMap(const QVariantMap &map) override; + QVariantMap toMap() const override; + bool fromMap(const QVariantMap &map) override; bool isActive() const override; diff --git a/src/plugins/projectexplorer/clangparser.h b/src/plugins/projectexplorer/clangparser.h index b3c559714b..0c7adaba8d 100644 --- a/src/plugins/projectexplorer/clangparser.h +++ b/src/plugins/projectexplorer/clangparser.h @@ -38,7 +38,7 @@ class PROJECTEXPLORER_EXPORT ClangParser : public ProjectExplorer::GccParser public: ClangParser(); - void stdError(const QString &line); + void stdError(const QString &line) override; static Core::Id id(); diff --git a/src/plugins/projectexplorer/customwizard/customwizard.h b/src/plugins/projectexplorer/customwizard/customwizard.h index d9fec08044..315b4ae5b0 100644 --- a/src/plugins/projectexplorer/customwizard/customwizard.h +++ b/src/plugins/projectexplorer/customwizard/customwizard.h @@ -56,7 +56,7 @@ class PROJECTEXPLORER_EXPORT ICustomWizardMetaFactory : public QObject public: ICustomWizardMetaFactory(const QString &klass, Core::IWizardFactory::WizardKind kind); - ~ICustomWizardMetaFactory(); + ~ICustomWizardMetaFactory() override; virtual CustomWizard *create() const = 0; QString klass() const { return m_klass; } diff --git a/src/plugins/projectexplorer/devicesupport/idevicefactory.h b/src/plugins/projectexplorer/devicesupport/idevicefactory.h index 42929ff2d7..a66d77b2e5 100644 --- a/src/plugins/projectexplorer/devicesupport/idevicefactory.h +++ b/src/plugins/projectexplorer/devicesupport/idevicefactory.h @@ -44,7 +44,7 @@ class PROJECTEXPLORER_EXPORT IDeviceFactory : public QObject Q_OBJECT public: - ~IDeviceFactory(); + ~IDeviceFactory() override; static const QList<IDeviceFactory *> allDeviceFactories(); virtual QString displayNameForId(Core::Id type) const = 0; diff --git a/src/plugins/projectexplorer/extracompiler.h b/src/plugins/projectexplorer/extracompiler.h index e69d4b3ca8..d4ef5326ac 100644 --- a/src/plugins/projectexplorer/extracompiler.h +++ b/src/plugins/projectexplorer/extracompiler.h @@ -99,7 +99,7 @@ public: ProcessExtraCompiler(const Project *project, const Utils::FileName &source, const Utils::FileNameList &targets, QObject *parent = nullptr); - ~ProcessExtraCompiler(); + ~ProcessExtraCompiler() override; protected: // This will run a process in a thread, if @@ -141,7 +141,7 @@ class PROJECTEXPLORER_EXPORT ExtraCompilerFactory : public QObject Q_OBJECT public: explicit ExtraCompilerFactory(QObject *parent = nullptr); - ~ExtraCompilerFactory(); + ~ExtraCompilerFactory() override; virtual FileType sourceType() const = 0; virtual QString sourceTag() const = 0; diff --git a/src/plugins/projectexplorer/gcctoolchain.h b/src/plugins/projectexplorer/gcctoolchain.h index 44f9b91b96..2a0ca0e17d 100644 --- a/src/plugins/projectexplorer/gcctoolchain.h +++ b/src/plugins/projectexplorer/gcctoolchain.h @@ -283,7 +283,7 @@ public: void addToEnvironment(Utils::Environment &env) const override; protected: - virtual CompilerFlags defaultCompilerFlags() const override; + CompilerFlags defaultCompilerFlags() const override; private: friend class Internal::ClangToolChainFactory; diff --git a/src/plugins/projectexplorer/kitinformation.h b/src/plugins/projectexplorer/kitinformation.h index 874d2fd130..2c1b55d288 100644 --- a/src/plugins/projectexplorer/kitinformation.h +++ b/src/plugins/projectexplorer/kitinformation.h @@ -163,7 +163,7 @@ public: ItemList toUserOutput(const Kit *k) const override; - virtual void addToMacroExpander(ProjectExplorer::Kit *kit, Utils::MacroExpander *expander) const override; + void addToMacroExpander(ProjectExplorer::Kit *kit, Utils::MacroExpander *expander) const override; static Core::Id id(); static IDevice::ConstPtr device(const Kit *k); diff --git a/src/plugins/projectexplorer/projectconfiguration.h b/src/plugins/projectexplorer/projectconfiguration.h index 27078d649e..f42e987093 100644 --- a/src/plugins/projectexplorer/projectconfiguration.h +++ b/src/plugins/projectexplorer/projectconfiguration.h @@ -46,7 +46,7 @@ protected: explicit ProjectConfiguration(QObject *parent, Core::Id id); public: - ~ProjectConfiguration() = default; + ~ProjectConfiguration() override = default; Core::Id id() const; diff --git a/src/plugins/projectexplorer/projectimporter.h b/src/plugins/projectexplorer/projectimporter.h index e676430b6b..66f6d77831 100644 --- a/src/plugins/projectexplorer/projectimporter.h +++ b/src/plugins/projectexplorer/projectimporter.h @@ -51,7 +51,7 @@ public: }; ProjectImporter(const Utils::FileName &path); - virtual ~ProjectImporter(); + ~ProjectImporter() override; const Utils::FileName projectFilePath() const { return m_projectPath; } const Utils::FileName projectDirectory() const { return m_projectPath.parentDir(); } diff --git a/src/plugins/projectexplorer/projecttree.h b/src/plugins/projectexplorer/projecttree.h index 67b8db99c6..75f4384a16 100644 --- a/src/plugins/projectexplorer/projecttree.h +++ b/src/plugins/projectexplorer/projecttree.h @@ -48,7 +48,7 @@ class PROJECTEXPLORER_EXPORT ProjectTree : public QObject Q_OBJECT public: explicit ProjectTree(QObject *parent = nullptr); - ~ProjectTree(); + ~ProjectTree() override; static ProjectTree *instance(); diff --git a/src/plugins/projectexplorer/projectwindow.h b/src/plugins/projectexplorer/projectwindow.h index 1ff2e461b2..c50e018620 100644 --- a/src/plugins/projectexplorer/projectwindow.h +++ b/src/plugins/projectexplorer/projectwindow.h @@ -56,7 +56,7 @@ class ProjectWindow : public Utils::FancyMainWindow public: ProjectWindow(); - ~ProjectWindow(); + ~ProjectWindow() override; private: ProjectWindowPrivate *d; diff --git a/src/plugins/projectexplorer/toolchain.h b/src/plugins/projectexplorer/toolchain.h index 2b5e4bec97..59f3b7a402 100644 --- a/src/plugins/projectexplorer/toolchain.h +++ b/src/plugins/projectexplorer/toolchain.h @@ -180,7 +180,7 @@ class PROJECTEXPLORER_EXPORT ToolChainFactory : public QObject public: ToolChainFactory(); - ~ToolChainFactory(); + ~ToolChainFactory() override; static const QList<ToolChainFactory *> allToolChainFactories(); |