diff options
| author | Tobias Hunger <tobias.hunger@digia.com> | 2013-02-12 12:56:02 +0100 |
|---|---|---|
| committer | Tobias Hunger <tobias.hunger@digia.com> | 2013-02-12 18:31:28 +0100 |
| commit | 962ba86d0fdc884231bf3ffa0ccf834fee64dd61 (patch) | |
| tree | c260b75440b273a159ff62656e8a2095691bbb70 /src/plugins/autotoolsprojectmanager/makestep.cpp | |
| parent | 6a7cefbd97cddd0258c394623932723c53472b82 (diff) | |
AbstractProcessStep: Do not run a qprocess in a thread
This avoids sending signals for new tasks and process output
via the gui thread's event loop. When finding lots of issues in
the output we generate so many events that any attempt to
compress events takes a long time (max. events waiting to be
processed were > 1200000 when doing a clang -Weverything build!),
and thus the UI freezes.
Change-Id: I9668d2537b1a268e788cd0ea5c756ebaab4462a9
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager/makestep.cpp')
| -rw-r--r-- | src/plugins/autotoolsprojectmanager/makestep.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/plugins/autotoolsprojectmanager/makestep.cpp b/src/plugins/autotoolsprojectmanager/makestep.cpp index f8cc20d669..2485779999 100644 --- a/src/plugins/autotoolsprojectmanager/makestep.cpp +++ b/src/plugins/autotoolsprojectmanager/makestep.cpp @@ -211,6 +211,7 @@ void MakeStep::run(QFutureInterface<bool> &interface) if (!canContinue) { emit addOutput(tr("Configuration is faulty. Check the Issues view for details."), BuildStep::MessageOutput); interface.reportResult(false); + emit finished(); return; } |