diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2024-02-01 17:04:09 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2024-02-01 16:07:51 +0000 |
| commit | c22d6b501b5f09da05a7c05373ba4afbfbed5c73 (patch) | |
| tree | 6c737f0fd7bc69aae5fa823424faa12a073ec335 /src/plugins/classview/classviewmanager.cpp | |
| parent | 8f2d0dbcc919db995b036a4ba90dd9550f2c9f18 (diff) | |
ClassView: Replace QSharedPointer with std::shared_ptr
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.
Change-Id: I46a556c6ab558b4b86c7f9d767cac5b16302f326
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/classview/classviewmanager.cpp')
| -rw-r--r-- | src/plugins/classview/classviewmanager.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/plugins/classview/classviewmanager.cpp b/src/plugins/classview/classviewmanager.cpp index 522b039a5b..9f62de9e09 100644 --- a/src/plugins/classview/classviewmanager.cpp +++ b/src/plugins/classview/classviewmanager.cpp @@ -47,7 +47,7 @@ static Manager *managerInstance = nullptr; */ /*! - \fn void ClassView::Internal::Manager::treeDataUpdate(QSharedPointer<QStandardItem> result) + \fn void ClassView::Internal::Manager::treeDataUpdate(std::shared_ptr<QStandardItem> result) Emits a signal about a tree data update (to tree view). \a result holds the item with the current tree. @@ -128,7 +128,7 @@ ParserTreeItem::ConstPtr ManagerPrivate::findItemByRoot(const QStandardItem *ite uiList.removeLast(); const SymbolInformation &inf = Internal::symbolInformationFromItem(cur); internal = internal->child(inf); - if (internal.isNull()) + if (!internal) break; } @@ -147,7 +147,7 @@ Manager::Manager(QObject *parent) managerInstance = this; // register - to be able send between signal/slots - qRegisterMetaType<QSharedPointer<QStandardItem> >("QSharedPointer<QStandardItem>"); + qRegisterMetaType<std::shared_ptr<QStandardItem>>("std::shared_ptr<QStandardItem>"); initialize(); @@ -174,7 +174,7 @@ Manager *Manager::instance() bool Manager::canFetchMore(QStandardItem *item, bool skipRoot) const { ParserTreeItem::ConstPtr ptr = d->findItemByRoot(item, skipRoot); - if (ptr.isNull()) + if (!ptr) return false; return ptr->canFetchMore(item); } @@ -186,7 +186,7 @@ bool Manager::canFetchMore(QStandardItem *item, bool skipRoot) const void Manager::fetchMore(QStandardItem *item, bool skipRoot) { ParserTreeItem::ConstPtr ptr = d->findItemByRoot(item, skipRoot); - if (ptr.isNull()) + if (!ptr) return; ptr->fetchMore(item); } @@ -194,7 +194,7 @@ void Manager::fetchMore(QStandardItem *item, bool skipRoot) bool Manager::hasChildren(QStandardItem *item) const { ParserTreeItem::ConstPtr ptr = d->findItemByRoot(item); - if (ptr.isNull()) + if (!ptr) return false; return ptr->childCount(); } @@ -255,8 +255,8 @@ void Manager::initialize() if (!state()) return; - QSharedPointer<QStandardItem> rootItem(new QStandardItem()); - d->m_root->fetchMore(rootItem.data()); + std::shared_ptr<QStandardItem> rootItem(new QStandardItem()); + d->m_root->fetchMore(rootItem.get()); emit treeDataUpdate(rootItem); }, Qt::QueuedConnection); |