aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/breakhandler.h
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2018-08-22 17:35:12 +0200
committerhjk <hjk@qt.io>2018-09-04 13:33:29 +0000
commitc7f0285c4c1d39572b99dfee3f92eccf6893dda6 (patch)
treec69a5876cc4c98b551528b3cd14a37f9ee0a7d79 /src/plugins/debugger/breakhandler.h
parent4192d7d62fe65b70b9f00f540425ea52bcb68c81 (diff)
Debugger: Consolidate breakpoint search
We already have a concept of Context when action on editor events, use that directly when searching an (almost) matching breakpoint instead of translating it into breakpoint manager's interface language. This also centralizes the guesswork for non-exact matches in one place, making it easier to fix currently wrong matches later. Change-Id: I5579e7e01792d425cad4ccf1dbcbbd1bd56c84ec Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/debugger/breakhandler.h')
-rw-r--r--src/plugins/debugger/breakhandler.h9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/plugins/debugger/breakhandler.h b/src/plugins/debugger/breakhandler.h
index 118e8ca022..048e2f996a 100644
--- a/src/plugins/debugger/breakhandler.h
+++ b/src/plugins/debugger/breakhandler.h
@@ -78,8 +78,6 @@ public:
void updateLineNumber(int lineNumber);
void updateFileName(const Utils::FileName &fileName);
- bool isLocatedAt(const QString &fileName, int lineNumber, bool useMarkerPosition) const;
-
QString displayName() const;
QString markerFileName() const;
QString toolTip() const;
@@ -296,12 +294,7 @@ public:
static const GlobalBreakpoints globalBreakpoints();
static GlobalBreakpoint createBreakpoint(const BreakpointParameters &data);
-
- static GlobalBreakpoint findBreakpointByLocation(const ContextData &location);
- // Find a breakpoint matching approximately the data in needle.
- static GlobalBreakpoint findSimilarBreakpoint(const BreakpointParameters &needle);
- static GlobalBreakpoint findWatchpoint(const BreakpointParameters &data);
- static GlobalBreakpoint findBreakpointByFunction(const QString &functionName);
+ static GlobalBreakpoint findBreakpointFromContext(const ContextData &location);
static void claimBreakpointsForEngine(DebuggerEngine *engine);
static void toggleBreakpoint(const ContextData &location, const QString &tracePointMessage = QString());